Re: gadgetfs & endpoints

2018-09-05 Thread Alan Stern
On Wed, 5 Sep 2018, Ranran wrote: > I have one more question please on this topic, juto to verify: > Seems that gadget hid (hidg) doesn't supports getfeature/setfeature ? > https://github.com/torvalds/linux/blob/master/Documentation/usb/gadget_hid.txt What part of that document makes you think

Re: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Wolfram Sang
On Wed, Sep 05, 2018 at 10:17:26PM +, Ajay Gupta wrote: > Hi Greg, > > > > +static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 len) > > > +{ > > > + struct device *dev = uc->dev; > > > + struct i2c_client *client = uc->client; > > > + unsigned char buf[2]; > > > + struct i2c_msg

[PATCH v6 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Ajay Gupta
Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C interface. This UCSI I2C driver uses I2C bus driver interface for communicating with Type-C controller. Signed-off-by: Ajay Gupta --- Changes from v1 -> v2 Fixed identation in drivers/usb/typec/ucsi/Kconfig Changes

[PATCH v6 1/2] i2c: buses: add i2c bus driver for NVIDIA GPU

2018-09-05 Thread Ajay Gupta
Latest NVIDIA GPU card has USB Type-C interface. There is a Type-C controller which can be accessed over I2C. This driver adds I2C bus driver to communicate with Type-C controller. I2C client driver will be part of USB Type-C UCSI driver. Signed-off-by: Ajay Gupta --- Changes from v1 -> v2

RE: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Ajay Gupta
Hi Greg, > > +static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 len) > > +{ > > + struct device *dev = uc->dev; > > + struct i2c_client *client = uc->client; > > + unsigned char buf[2]; > > + struct i2c_msg msgs[] = { > > + { > > + .addr =

RE: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Ajay Gupta
Hi Greg, > On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote: > > + dev_info(dev, "Silicon id %2ph", data + > CCGX_I2C_RAB_READ_SILICON_ID); > > + dev_info(dev, "FW1 version %8ph\n", data + > CCGX_I2C_RAB_FW1_VERSION); > > + dev_info(dev, "FW2 version %8ph\n", data + > >

[PATCH v2] Revert "cdc-acm: implement put_char() and flush_chars()"

2018-09-05 Thread Mariusz Bialonczyk
From: Oliver Neukum This reverts commit a81cf9799ad7299b03a4dff020d9685f9ac5f3e0. The patch causes a regression, which I cannot find the reason for. So let's revert for now, as a revert hurts only performance. Original report: I was trying to resolve the problem with Oliver but we don't get

Re: [GIT PULL] USB-serial fixes for v4.19-rc3

2018-09-05 Thread Greg Kroah-Hartman
On Wed, Sep 05, 2018 at 04:02:23PM +0200, Johan Hovold wrote: > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) > > are available in the Git repository at: > >

[GIT PULL] USB-serial fixes for v4.19-rc3

2018-09-05 Thread Johan Hovold
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.19-rc3 for you to fetch changes up to

Re: [PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 03:02:48PM +0200, Oliver Neukum wrote: > On Mi, 2018-09-05 at 14:19 +0200, Greg KH wrote: > > On Wed, Sep 05, 2018 at 12:07:03PM +0200, Oliver Neukum wrote: > > > If we filter flags before they reach the core we need to generate our > > > own warnings. > > > > > >

Re: [PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-05 Thread Oliver Neukum
On Mi, 2018-09-05 at 14:19 +0200, Greg KH wrote: > On Wed, Sep 05, 2018 at 12:07:03PM +0200, Oliver Neukum wrote: > > If we filter flags before they reach the core we need to generate our > > own warnings. > > > > Signed-off-by: Oliver Neukum > > Fixes: 0cb54a3e47cb ("USB: debugging code

Re: [PATCH] Revert "cdc-acm: implement put_char() and flush_chars()"

2018-09-05 Thread Greg KH
On Thu, Aug 30, 2018 at 11:18:36AM +0200, Oliver Neukum wrote: > This reverts commit a81cf9799ad7299b03a4dff020d9685f9ac5f3e0. > > The patch causes a regression, which I cannot find the reason for. > So let's revert for now, as a revert hurts only performance. > > I was trying to resolve the

Re: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Greg KH
On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta > --- > Changes from

Re: [PATCH v5 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-05 Thread Greg KH
On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote: > + dev_info(dev, "Silicon id %2ph", data + CCGX_I2C_RAB_READ_SILICON_ID); > + dev_info(dev, "FW1 version %8ph\n", data + CCGX_I2C_RAB_FW1_VERSION); > + dev_info(dev, "FW2 version %8ph\n", data + CCGX_I2C_RAB_FW2_VERSION);

Re: [PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 12:07:03PM +0200, Oliver Neukum wrote: > If we filter flags before they reach the core we need to generate our > own warnings. > > Signed-off-by: Oliver Neukum > Fixes: 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow") > --- > drivers/usb/core/devio.c | 5

[hid:for-4.20/microsoft 2/3] ERROR: "input_ff_create_memless" [drivers/hid/hid-microsoft.ko] undefined!

2018-09-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft head: 830e82aa48f32518dfa5335c0134f611d4bab4b2 commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/3] HID: microsoft: Add rumble support for Xbox One S controller config: m68k-sun3_defconfig (attached as

Re: [PATCH v5 00/22] usb: usbtmc: Changes needed for compatible IVI/VISA library

2018-09-05 Thread guido
Greg, Thank you for reviewing our usbtmc kernel patches. People are asking me about the progress of the last patches and I'm not sure whether new patches can be merged now or not. So this is just a reminder to our last patch series (four weeks ago):

Re: [hid:for-4.20/microsoft 2/2] hid-microsoft.c:undefined reference to `input_ff_create_memless'

2018-09-05 Thread Jiri Kosina
On Wed, 5 Sep 2018, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git > for-4.20/microsoft > head: 73c5b254c36529c84c9d19e07905f7103bb32e79 > commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add > rumble support for Xbox One

[hid:for-4.20/microsoft 2/2] undefined reference to `input_ff_create_memless'

2018-09-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft head: 73c5b254c36529c84c9d19e07905f7103bb32e79 commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add rumble support for Xbox One S controller config: parisc-b180_defconfig (attached as

Re: Question about a patch for Worlde controller

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 08:58:38AM +, Maxence Duprès wrote: > Sorry to ask you again but nothing appear in rc2 or in testing branch > for Worlde/Prodipe keyboard in drivers/usb/core/quirks.c > > USB: add quirk for WORLDE Controller KS49 or Prodipe MIDI 49C USB Sorry for the delay, it's been

Re: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-09-05 Thread 'g...@kroah.com' (g...@kroah.com)
On Wed, Sep 05, 2018 at 10:51:52AM +, Yeh.Charles [葉榮鑫] wrote: > Hi Greg, > Because the VENDOR_WRITE_REQUEST & VENDOR_READ_REQUEST is different > between old and new chip. > > VENDOR_WRITE_REQUESTVENDOR_READ_REQUEST > PL2303 (old chip) 0x01

Re: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-09-05 Thread 'g...@kroah.com' (g...@kroah.com)
On Wed, Sep 05, 2018 at 10:54:00AM +, Yeh.Charles [葉榮鑫] wrote: > Hi All, > > The "confidential" message is auto add by email server, please ignore it Sorry, but I can not just "ignore it". Talk to your corporate lawyers for why that is the case. greg k-h

RE: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-09-05 Thread Yeh . Charles [葉榮鑫]
Hi All, The "confidential" message is auto add by email server, please ignore it Charles Yeh TeL: +886-2-26546363 ext.522 Prolific Technology Inc. -Original Message- From: Yeh.Charles [葉榮鑫] Sent: Wednesday, September 5, 2018 6:52 PM To: ''g...@kroah.com' (g...@kroah.com)' Cc: Johan

RE: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-09-05 Thread Yeh . Charles [葉榮鑫]
Hi Greg, Because the VENDOR_WRITE_REQUEST & VENDOR_READ_REQUEST is different between old and new chip. VENDOR_WRITE_REQUESTVENDOR_READ_REQUEST PL2303 (old chip) 0x01 0x01 PL2303G(new chip) 0x80 0x81 We

[hid:for-4.20/microsoft 2/2] hid-microsoft.c:undefined reference to `input_ff_create_memless'

2018-09-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft head: 73c5b254c36529c84c9d19e07905f7103bb32e79 commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add rumble support for Xbox One S controller config: i386-alldefconfig (attached as

[PATCH 2/2] USB: usbdevfs: restore warning for nonsensical flags

2018-09-05 Thread Oliver Neukum
If we filter flags before they reach the core we need to generate our own warnings. Signed-off-by: Oliver Neukum Fixes: 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow") --- drivers/usb/core/devio.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 1/2] USB: usbdevfs: sanitize flags more

2018-09-05 Thread Oliver Neukum
Requesting a ZERO_PACKET or not is sensible only for output. In the input direction the device decides. Likewise accepting short packets makes sense only for input. This allows operation with panic_on_warn without opening up a local DOS. Signed-off-by: Oliver Neukum Reported-by:

Re: Question about a patch for Worlde controller

2018-09-05 Thread Maxence Duprès
Sorry to ask you again but nothing appear in rc2 or in testing branch for Worlde/Prodipe keyboard in drivers/usb/core/quirks.c USB: add quirk for WORLDE Controller KS49 or Prodipe MIDI 49C USB Thanks you. Le 20/08/2018 à 19:12, Greg KH a écrit : > On Mon, Aug 20, 2018 at 12:03:47PM +,

Re: [PATCH v3] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-09-05 Thread Johan Hovold
On Wed, Sep 05, 2018 at 08:44:12AM +0200, Loic Poulain wrote: > Thanks for review, I'm fine with that and I'll review the other patch. > Karoly can use chunks of my patch if useful. Thanks a lot. And if chunks can be reused, that would be great. Johan

Re: Prolific: PL2303G Linux driver ( new USB to UART chip)

2018-09-05 Thread 'g...@kroah.com' (g...@kroah.com)
On Wed, Sep 05, 2018 at 08:11:41AM +, Yeh.Charles [葉榮鑫] wrote: > Hi all, > I am a software engineer from Prolific. > Do you have received the following email? > Prolific has new USB to UART chip, we need to update new driver to > Linux kernel. Yes, we did, but you sent the

Re: [PATCH] USB: change dev_WARN to dev_err triggerable from user space

2018-09-05 Thread Oliver Neukum
On Di, 2018-09-04 at 15:18 -0400, Alan Stern wrote: > On Tue, 4 Sep 2018, Johan Hovold wrote: > > > On Tue, Sep 04, 2018 at 12:21:09PM +0200, Oliver Neukum wrote: > > > On Di, 2018-09-04 at 11:31 +0200, Johan Hovold wrote: > > > > On Tue, Sep 04, 2018 at 10:44:41AM +0200, Oliver Neukum wrote: > >

Re: [PATCH v3] USB: serial: ftdi_sio: Add support for CBUS GPIO

2018-09-05 Thread Loic Poulain
Hi Johan, On 4 September 2018 at 14:47, Johan Hovold wrote: > On Sat, Aug 04, 2018 at 12:17:15PM +0200, Loic Poulain wrote: >> Some FTDI devices like FTX or FT232R support CBUS Bit Bang mode on CBUS >> pins, allowing host to control them via simple USB control transfers. >> To make use of a CBUS