Re: [PATCH] usb: udc: add gadget state kobject uevent

2013-07-18 Thread Alan Stern
it's wise to add a transition from NOTATTACHED to CONFIGURED. Another good point. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: gadget: udc-core: move sysfs_notify() to a workqueue

2013-07-18 Thread Alan Stern
the gadget is unregistered. Also, what happens if two state transitions occur before the work queue gets around to executing the work routine? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: How should we handle isochronous underruns?

2013-07-18 Thread Alan Stern
On Thu, 18 Jul 2013, Ming Lei wrote: On Thu, Jul 18, 2013 at 3:24 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 4 Jul 2013, Alan Stern wrote: On Thu, 4 Jul 2013, Ming Lei wrote: If so, your coming change may break ABI because as you described that the flag should be set

Re: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-18 Thread Alan Stern
may be seldom triggered, do you know under which condition the stopped is triggered in your problem?(stall, short read or others) I was going to ask the same question. This particular piece of code gets executed _only_ when an URB is unlinked. Not during any other kind of error. Alan Stern

Re: Help r/e gadgetfs bulk xfer problem on Overo gumstix

2013-07-18 Thread Alan Stern
? Not as far as I know. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 2/6] USB: OHCI: make ohci-omap a separate driver

2013-07-18 Thread Alan Stern
) otg_set_host(hcd-phy-otg, 0); omap_ohci_clock_power() should be called after usb_remove_hcd(), not before. This reason is simple: Until usb_remove_hcd() is called, the controller is still running and therefore needs to have a valid clock signal. Alan Stern -- To unsubscribe from this list: send the line

Re: question about bus_suspend and bus_resume

2013-07-18 Thread Alan Stern
it by calling usb_hcd_resume_root_hub(). For system suspend, you have to make the appropriate platform-specific arrangements so that wakeup events will actually cause the system to wake up. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH V3 6/6] USB: OHCI: make ohci-s3c2410 a separate driver

2013-07-18 Thread Alan Stern
; - orig = ohci_hub_status_data(hcd, buf); + orig = orig_ohci_hub_status_data(hcd, buf); Since you're changing the line anyway, you should get rid of the extra space before the '='. After you make those two changes, you can add my Acked-by. Alan Stern -- To unsubscribe from

Re: [PATCH V3 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-07-18 Thread Alan Stern
MODULE_ALIAS line down here with these lines. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: How should we handle isochronous underruns?

2013-07-18 Thread Alan Stern
that only a few HCDs other than ehci currently implement the endpoint_reset method: xhci, whci, dwc2, and ozwpan. It would not be hard to fix them up to ignore calls for isochronous endpoints. Any objections to this approach? Alan Stern -- To unsubscribe from this list: send the line unsubscribe

Re: xhci driver problem

2013-07-19 Thread Alan Stern
with -EINVAL. Yes, it is the right command. You may need to do a little debugging to find out where in usb_set_configuration() the error occurs. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Alan Stern
-- drivers were using the drvdata value even after their remove function returned. Several commits have been applied to fix those bugs. Finding and backporting them and their dependencies will not be easy. I suggest this patch not be applied. Alan Stern -- To unsubscribe from this list: send

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-19 Thread Alan Stern
with USB-3 devices when the sequence numbers get out of alignment. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Audio I/O parameters

2013-07-19 Thread Alan Stern
. I don't know -- it's up to Clemens. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: How should we handle isochronous underruns?

2013-07-19 Thread Alan Stern
usb_host_endpoint *); Does that look okay? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] [RFC] EHCI: add to memory barrier to updating hw_next

2013-07-19 Thread Alan Stern
not cause any errors. IMHO, if the qTD list is broken the HC think there is no qTD to send. So I added mb() at hw_next update code. At the time when the hw_next update gets executed, what is the value of state? It should be QH_STATE_IDLE. Alan Stern -- To unsubscribe from this list: send

Re: [PATCH] backports: backport drvdata = NULL core driver fixes

2013-07-19 Thread Alan Stern
, and a1028f0abfb3. Admittedly, these are all related problems in a single subsystem, but it gives you a little idea of how far this goes. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: Sound Blaster USB X-Fi configuration problem

2013-07-19 Thread Alan Stern
suggest allocating and deallocating a buffer in the function that calls the quirk routines, and have it pass the buffer as an extra argument. Many thanks for your help. That was exactly what I was looking for. You're welcome. Alan Stern -- To unsubscribe from this list: send the line unsubscribe

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-19 Thread Alan Stern
in to an OHCI controller and when it is plugged in to an EHCI controller? Instructions are in Documentation/usb/usbmon.txt. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: How should we handle isochronous underruns?

2013-07-19 Thread Alan Stern
drivers. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Sound Blaster USB X-Fi configuration problem

2013-07-20 Thread Alan Stern
On Sat, 20 Jul 2013, Clemens Ladisch wrote: Alan Stern wrote: On Sat, 20 Jul 2013, Mariusz Grecki wrote: + u16 buf = 1; + + snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 0x2a, + USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_OTHER, + 0, 0, buf, 2

Re: How should we handle isochronous underruns?

2013-07-20 Thread Alan Stern
that it could easily be made hcd-specific. I haven't done that because the regions it protects are all very short, so there probably isn't very much contention. fixed by changing drivers. If only very less drivers need the change, I agree with you. Okay, good. Alan Stern -- To unsubscribe from

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-20 Thread Alan Stern
On Fri, 19 Jul 2013 sgtcapsl...@lavabit.com wrote: Can you provide usbmon traces showing what happens when the mouse is plugged in to an OHCI controller and when it is plugged in to an EHCI controller? Instructions are in Documentation/usb/usbmon.txt. Alan Stern Absolutely. Ahh

Re: Sound Blaster USB X-Fi configuration problem

2013-07-20 Thread Alan Stern
the circumstances, I guess we have to err on the safe side and keep the two functions separate. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Alan Stern
the name string. Have the consumer pass the data structure's address when it calls phy_create, instead of passing the name. Then you don't have to worry about two PHYs accidentally ending up with the same name or any other similar problems. Alan Stern -- To unsubscribe from this list: send

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-20 Thread Alan Stern
On Sat, 20 Jul 2013, sgtcapslock wrote: This could be considered a bug in the usbhid driver. As far as I can see, the only way to fix it is to use two interrupts URBs rather than one. Alan Stern Thanks a lot for taking time to diagnose this, I appreciate it! I think I

Re: How should we handle isochronous underruns?

2013-07-21 Thread Alan Stern
On Sun, 21 Jul 2013, Ming Lei wrote: On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 20 Jul 2013, Ming Lei wrote: No, we don't have to change every driver using isochronous URBs. Many of them set URB_ISO_ASAP on every URB -- in fact, AFAIK snd-usb

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Alan Stern
does phy_create() fit into this picture? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kernel panic in sg_complete

2013-07-21 Thread Alan Stern
be a bug in the logic of sg_complete() or usb_sg_wait(). _That_ logic bug is what needs to be fixed. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-22 Thread Alan Stern
(). Reported-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/ep0.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 007651c..7fa93f4 100644 --- a/drivers/usb

Re: [PATCH] usb: gadget: udc-core: move sysfs_notify() to a workqueue

2013-07-22 Thread Alan Stern
); device_unregister(gadget-dev); + flush_work(gadget-work); Shouldn't the flush_work() call come before device_unregister()? You don't want to call sysfs_notify() on an unregistered device. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v3 1/1] Intel xhci: refactor EHCI/xHCI port switching

2013-07-22 Thread Alan Stern
, but it's enough to do it in xHCI only because the hub driver doesn't start running again until after both hosts are resumed. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com Acked-by: Alan Stern st...@rowland.harvard.edu It is noticeable that this code: diff --git a/drivers/usb

Re: How should we handle isochronous underruns?

2013-07-22 Thread Alan Stern
and then continues on a different CPU?) But I think it would still have higher overhead than calling usb_new_iso_stream once, whenever a new stream is started. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

2013-07-22 Thread Alan Stern
); + pm_runtime_set_active(dev); + pm_runtime_enable(dev); + } + + return ret; +} All good. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-22 Thread Alan Stern
? phy_create is the API by which the PHY's driver (the supplier) hook into the PHY framework. It's like the controller driver will always interact with the PHY driver through the PHY framework. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [PATCH v2] USB: host: Use usb_hcd_platform_shutdown() wherever possible

2013-07-22 Thread Alan Stern
/ohci-omap3.c | 10 +- drivers/usb/host/ohci-ppc-of.c| 11 +-- 8 files changed, 8 insertions(+), 82 deletions(-) Acked-by: Alan Stern st...@rowland.harvard.edu -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-22 Thread Alan Stern
really provide a pointer to ML archives). Ah, ok. I wasn't aware of that. I'll assume then that the necessary people have the complete picture. It might help to get a usbmon trace and dmesg log from Linus, if he still has this problem. Alan Stern -- To unsubscribe from this list: send

Re: How should we handle isochronous underruns?

2013-07-22 Thread Alan Stern
On Tue, 23 Jul 2013, Ming Lei wrote: On Mon, Jul 22, 2013 at 11:09 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 22 Jul 2013, Ming Lei wrote: Not exactly. The HCD has to keep track of the next available time slot for the endpoint. Some special value, like -1

Re: isochronous URB and packet calculations for USB audio

2013-07-22 Thread Alan Stern
On Thu, 10 May 2012, Clemens Ladisch wrote: Alan Stern wrote: Can you explain briefly how the snd-usb-audio driver decides how many URBs to submit and how many isochronous packets to use in each URB? The default is to have 8 ms per URB (which can be adjusted with the nrpacks module

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-23 Thread Alan Stern
; | | direction = !dwc-ep0_expect_in; | dwc-delayed_status = false; | usb_gadget_set_state(dwc-gadget, USB_STATE_CONFIGURED); I see. Doesn't the mass-storage gadget also use delayed status when going into the _un_configured state? Alan Stern -- To unsubscribe from this list

Re: [PATCH] usb: gadget: udc-core: move sysfs_notify() to a workqueue

2013-07-23 Thread Alan Stern
, void *data) { dev_set_drvdata(gadget-dev, data); } Acked-by: Alan Stern st...@rowland.harvard.edu -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

2013-07-23 Thread Alan Stern
. As the OMAP IO pad wakeup management code [1] is still in transition, I'll wait till that gets settled and then resend this series. Okay. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: Weird Serial number with Fitbit Base Station dongle

2013-07-23 Thread Alan Stern
, it is actually correct. Can you post a usbmon trace showing what happens when the dongle is first plugged? Instructions are in the kernel source file Documentation/usb/usbmon.txt. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v4 1/1] Intel xhci: refactor EHCI/xHCI port switching

2013-07-23 Thread Alan Stern
and + * xHCI host controllers) have been resumed. */ - if (usb_is_intel_switchable_xhci(pdev)) - usb_enable_xhci_ports(pdev); + + if (pdev-vendor == PCI_VENDOR_ID_INTEL) + usb_enable_intel_xhci_ports(pdev); Short and sweet; I like it! Alan Stern

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
would use phy1 or phy2, and the PHY consumers would use host1 or host2. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-23 Thread Alan Stern
resources get deallocated? When the gadget disconnects from the host? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] USB: OHCI: make ohci-omap a separate driver

2013-07-23 Thread Alan Stern
-by: Manjunath Goudar manjunath.gou...@linaro.org Cc: Felipe Balbi ba...@ti.com Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: linux-usb@vger.kernel.org V2: -omap_ohci_clock_power(0) called in usb_hcd_omap_remove(). -Removed ohci_setup

Re: [PATCH 3/6] USB: OHCI: make ohci-omap3 a separate driver

2013-07-23 Thread Alan Stern
-by: Manjunath Goudar manjunath.gou...@linaro.org Cc: Anand Gadiyar gadi...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: linux-usb@vger.kernel.org V2: -ohci_setup() removed because it is called in .reset

Re: [PATCH 5/6] USB: OHCI: make ohci-at91 a separate driver

2013-07-23 Thread Alan Stern
-by: Manjunath Goudar manjunath.gou...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Alan Stern st...@rowland.harvard.edu Cc: Greg KH g...@kroah.com Cc: linux-usb@vger.kernel.org V2: -Set non-standard fields in ohci_at91_hc_driver manually, rather than relying on an expanded struct

Re: [PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver

2013-07-23 Thread Alan Stern
before W90X900(W90P910) can be booted with a multi-platform kernel and an ehci driver that only works on one of them. With the infrastructure added by Alan Stern in patch 3e0232039 USB: EHCI: prepare to make ehci-hcd a library module, we can avoid this problem by turning a bus glue

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
not a layering violation for one region of the kernel to store private data in a structure defined by another part of the kernel. This happens all the time (e.g., dev_set_drvdata). Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: Audio I/O parameters

2013-07-23 Thread Alan Stern
find plenty of references for how to do it on Google, but it is time consuming and needs plenty of disk space as well as a reasonably fast machine. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
, this was simply meant to be a suggestion to show that it is relatively easy to do what you need without using name or ID strings. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Buffer size for ALSA USB PCM audio

2013-07-24 Thread Alan Stern
. Is this really the intended behavior? It doesn't seem right at all. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Buffer size for ALSA USB PCM audio

2013-07-24 Thread Alan Stern
On Wed, 24 Jul 2013, Takashi Iwai wrote: At Wed, 24 Jul 2013 10:41:43 -0400 (EDT), Alan Stern wrote: I have been studying the data_ep_set_params() function in sound/usb/endpoint.c. This is the routine that calculates the number of samples and I/O requests to keep on the USB hardware

Re: Audio I/O parameters

2013-07-24 Thread Alan Stern
of the one Clemens sent earlier.) Alan Stern Index: usb-3.10/sound/usb/endpoint.c === --- usb-3.10.orig/sound/usb/endpoint.c +++ usb-3.10/sound/usb/endpoint.c @@ -575,6 +575,7 @@ static int data_ep_set_params(struct snd

Re: Buffer size for ALSA USB PCM audio

2013-07-24 Thread Alan Stern
); } In this case, I'm particularly considering what happens when snd_usb_endpoint_implicit_feedback_sink(ep) is false. Besides, what's the reason for allocating 10 URBs if you're not going to submit more than 2 of them at a time? Alan Stern -- To unsubscribe from this list: send the line

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-24 Thread Alan Stern
, you should make sure that neither URB is running. Probably the best way is to call usb_unlink_urb() for the other URB whenever one gets an error. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: Weird Serial number with Fitbit Base Station dongle

2013-07-24 Thread Alan Stern
On Wed, 24 Jul 2013, Laurent Bigonville wrote: Le Tue, 23 Jul 2013 10:16:00 -0400 (EDT), Alan Stern st...@rowland.harvard.edu a écrit : On Tue, 23 Jul 2013, Laurent Bigonville wrote: Hi, This is probably a minor issue, but when plugin the Fitbit base station dongle, I'm

Re: [PATCH 1/5] usb: xhci: add the suspend/resume functionality

2013-07-24 Thread Alan Stern
into account? Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-24 Thread Alan Stern
On Wed, 24 Jul 2013, Felipe Balbi wrote: Hi, On Tue, Jul 23, 2013 at 12:53:53PM -0400, Alan Stern wrote: I see. Doesn't the mass-storage gadget also use delayed status when going into the _un_configured state? no it doesn't, we bail out early if config number is zero, look

Re: [PATCH V2 1/2] USB: OHCI: make ohci-ep93xx a separate driver

2013-07-24 Thread Alan Stern
Cc: Arnd Bergmann a...@arndb.de Cc: Alan Stern st...@rowland.harvard.edu Cc: Greg KH g...@kroah.com Cc: linux-usb@vger.kernel.org V2: -ohci_hcd_init() statements are removed, because by default it is called in ohci_setup(). @@ -45,6 +58,7 @@ static int usb_hcd_ep93xx_probe(const struct

Re: [PATCH V2 2/2] USB: OHCI: make ohci-pxa27x a separate driver

2013-07-24 Thread Alan Stern
...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: linux-usb@vger.kernel.org V2: -Changed ohci_hcd and pxa27x_ohci struct variable names. 1 ohci_hcd struct variable name is ohci. 2 pxa27x_ohci struct variable name

Re: External HDD does not work with 3.11-rc2

2013-07-24 Thread Alan Stern
program on your computer sending a command to the drive that it can't handle (SCSI INQUIRY command with a transfer length of 512). It is not a kernel problem. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: External HDD does not work with 3.11-rc2

2013-07-25 Thread Alan Stern
reveal why this was not triggered on 3.9 and 3.10 as bad as on 3.11... Do you know which program is the culprit? From the timing, it is likely to be something that udev runs. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: Buffer size for ALSA USB PCM audio

2013-07-25 Thread Alan Stern
in practice. The patch below fixes this problem and drastically simplifies the calculation. How does it look? Alan Stern Index: usb-3.10/sound/usb/endpoint.c === --- usb-3.10.orig/sound/usb/endpoint.c +++ usb-3.10/sound/usb

Re: [PATCH 2/2] usb: dwc3: ep0: don't change to configured state too early

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Felipe Balbi wrote: On Wed, Jul 24, 2013 at 02:01:27PM -0400, Alan Stern wrote: On Wed, 24 Jul 2013, Felipe Balbi wrote: Hi, On Tue, Jul 23, 2013 at 12:53:53PM -0400, Alan Stern wrote: I see. Doesn't the mass-storage gadget also use delayed status when

Re: Audio I/O parameters

2013-07-25 Thread Alan Stern
yesterday. I think it will fix this problem. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Patch queue status?

2013-07-25 Thread Alan Stern
Greg: What's the status of your USB patch queue? I've seen a bunch of notices about patches being applied -- is the queue empty yet? I ask because of this: http://marc.info/?l=linux-usbm=137356910824266w=2 which hasn't been merged yet. Alan Stern -- To unsubscribe from this list

Re: Patch queue status?

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Greg KH wrote: On Thu, Jul 25, 2013 at 11:34:22AM -0400, Alan Stern wrote: Greg: What's the status of your USB patch queue? I've seen a bunch of notices about patches being applied -- is the queue empty yet? No it isn't empty yet, I tried to pick out most

Re: Audio I/O parameters

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, James Stone wrote: Please try the patch from here: http://marc.info/?l=linux-usbm=137476385206265w=2 instead of the one I sent to you yesterday. I think it will fix this problem. Alan Stern Perfect! All fixed! Can you provide a usbmon trace

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
. On the other hand, there's no real reason to reject it, and it could end up helping people who want to test new USB devices. So... Acked-by: Alan Stern st...@rowland.harvard.edu -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Alan Stern
. I really don't like adding stuff like this to the kernel if at all possible. Up to you. Still, I think bringing situations like this to people's attention is a large part of what WARN_ON is intended for. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: Audio I/O parameters

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, James Stone wrote: On Thu, Jul 25, 2013 at 7:26 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 25 Jul 2013, James Stone wrote: Please try the patch from here: http://marc.info/?l=linux-usbm=137476385206265w=2 instead of the one I sent

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Felipe Balbi wrote: On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: On Thu, 25 Jul 2013, Greg KH wrote: On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host

Re: [PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-26 Thread Alan Stern
); +MODULE_LICENSE(GPL); Would it be a good idea to combine all the little do-nothing modules like this into one single source file? Then adding a new device would require only two things: Change the help message for the Kconfig entry; Add a line to the id_table. Alan Stern -- To unsubscribe

Re: [PATCH] USB: ohci_usb warn irq nobody cared on shutdown

2013-07-26 Thread Alan Stern
)) flush_work(ohci-nec_work); - ohci_usb_reset (ohci); ohci_writel (ohci, OHCI_INTR_MIE, ohci-regs-intrdisable); + ohci_usb_reset(ohci); free_irq(hcd-irq, hcd); hcd-irq = 0; Reviewed-by: Alan Stern st...@rowland.harvard.edu -- To unsubscribe from this list: send

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-26 Thread Alan Stern
if no media is present. Or at least, it shouldn't treat medium not present responses as errors. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Audio I/O parameters

2013-07-26 Thread Alan Stern
On Fri, 26 Jul 2013, Clemens Ladisch wrote: Alan Stern wrote: On Thu, 25 Jul 2013, James Stone wrote: The only slight difference I can see is that maybe the 3.10 uses slightly higher CPU load than 3.5 at the ridiculously low latency of 64 frames/period duplex. With the new patch

Re: [PATCH V3 2/2] USB: OHCI: make ohci-pxa27x a separate driver

2013-07-26 Thread Alan Stern
...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: linux-usb@vger.kernel.org V2: -Changed ohci_hcd and pxa27x_ohci struct variable names. 1 ohci_hcd struct variable name is ohci. 2 pxa27x_ohci struct variable name

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-26 Thread Alan Stern
[50138.525315] pci_pm_runtime_suspend(): hcd_pci_runtime_suspend+0x0/0x50 returns -16 [50138.536357] PM: Finishing wakeup. In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way. Alan Stern Index: usb-3.10/drivers/scsi

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-27 Thread Alan Stern
with 3.10.3. Dmesg filtered with 'hci'. Each of you, please post a usbmon trace showing what happens when the drive is plugged in. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Audio I/O parameters

2013-07-27 Thread Alan Stern
underruns. Alan Stern Index: usb-3.10/drivers/usb/host/ehci-sched.c === --- usb-3.10.orig/drivers/usb/host/ehci-sched.c +++ usb-3.10/drivers/usb/host/ehci-sched.c @@ -1388,7 +1388,7 @@ iso_stream_schedule ( struct

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-27 Thread Alan Stern
On Sat, 27 Jul 2013, Stuart Foster wrote: On 07/27/13 15:58, Alan Stern wrote: On Sat, 27 Jul 2013, Stuart Foster wrote: Hi, I have started having problems with an external USB 3 diskdrive, the problems started when I moved from the 3.10.2 kernel to 3.10.3. The machine is a ASUS

Re: Audio I/O parameters

2013-07-27 Thread Alan Stern
. The optimal number of URBs is actually quite tricky to calculate. I'll send out another patch in a few days. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-28 Thread Alan Stern
On Sat, 27 Jul 2013, Stuart Foster wrote: On 07/27/13 20:34, Alan Stern wrote: On Sat, 27 Jul 2013, Stuart Foster wrote: On 07/27/13 15:58, Alan Stern wrote: On Sat, 27 Jul 2013, Stuart Foster wrote: Hi, I have started having problems with an external USB 3 diskdrive

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Oliver Neukum wrote: On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way. Alan, I think your diagnosis is correct

Re: Buffer size for ALSA USB PCM audio

2013-07-29 Thread Alan Stern
understand why not; doesn't queue_pending_output_urbs() make the packet sizes match the sizes from the corresponding feedback endpoint? I'd appreciate any advice you can offer. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Martin K. Petersen wrote: Alan == Alan Stern st...@rowland.harvard.edu writes: Alan, Alan It was introduced by commit 98dcc2946adb (SCSI: sd: Update WRITE Alan SAME heuristics). This commit adds a call to scsi_get_vpd_page() Alan in sd_read_write_same() without

Re: Panasonic DMC-ZS3 mass storage USB regression in 3.10.3

2013-07-29 Thread Alan Stern
[ 290.192146] usb 6-1.7: reset high-speed USB device number 3 using ehci-pci [ 321.167769] usb 6-1.7: reset high-speed USB device number 3 using ehci-pci See this email thread: http://marc.info/?l=linux-usbm=137503976012984w=2 Alan Stern -- To unsubscribe from this list: send

Re: Audio I/O parameters

2013-07-29 Thread Alan Stern
On Sun, 28 Jul 2013, James Stone wrote: On Sat, Jul 27, 2013 at 6:45 PM, Alan Stern st...@rowland.harvard.edu wrote: On Sat, 27 Jul 2013, James Stone wrote: OK. So this seems to have solved the starting jack at low latencies problem, but I am still getting sporadic cannot submit urb (err

Re: Panasonic DMC-ZS3 mass storage USB regression in 3.10.3

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Marc Meledandri wrote: On Mon, Jul 29, 2013 at 11:24 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sun, 28 Jul 2013, Marc Meledandri wrote: I've hit a USB regression from 3.10.2 (working) - 3.10.3 (busted) with my Panasonic DMC-ZS3 camera. I can no longer

Re: Buffer size for ALSA USB PCM audio

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Clemens Ladisch wrote: Alan Stern wrote: Clemens remarked some time ago that keeping the queue full would be trivial, if only he knew how full it needed to be. The answer to that is given above. I have been trying to make the appropriate changes, but I'm

Re: Buffer size for ALSA USB PCM audio

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Daniel Mack wrote: On 29.07.2013 20:20, Alan Stern wrote: data_ep_set_params() checks snd_usb_endpoint_implicit_feedback_sink() in three places. It looks like only the second place is correct. Can you verify whether the other two are right, and explain to me

Re: USB Interrupt Transaction Scheduling

2013-07-29 Thread Alan Stern
, it wouldn't be violating the high speed limitation of 63 endpoints per micro-frame. The limitation you are referring to (Table 5-8 in the spec) is for interrupt transfers to high-speed devices. It does not apply to interrupt transfers to full-speed devices. Alan Stern -- To unsubscribe from

RE: USB Interrupt Transaction Scheduling

2013-07-30 Thread Alan Stern
EHCI controllers, and you can get more by adding PCI cards. Thank you for your help. I'm trying to get a better understanding of the USB limitations, so our design does not fail as the system expands. You're welcome. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux

Re: Audio I/O parameters

2013-07-30 Thread Alan Stern
this. It may take a few days. Alan Stern -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: External HDD does not work with 3.11-rc2

2013-07-30 Thread Alan Stern
On Tue, 30 Jul 2013, Philipp Dreimann wrote: On Mon, Jul 29, 2013 at 7:04 PM, Alan Stern st...@rowland.harvard.edu wrote: It turns out I was probably wrong. Take a look at this message: http://marc.info/?l=linux-scsim=137511040432420w=2 The patch in that email may fix your

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Alan Stern
On Tue, 30 Jul 2013, Oliver Neukum wrote: On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: On Mon, 29 Jul 2013, Oliver Neukum wrote: On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix

  1   2   3   4   5   6   7   8   9   10   >