Re: [PATCH v17 2/3] usb: USB Type-C connector class

Hi Mats, On Fri, Mar 03, 2017 at 08:27:08PM +0100, Mats Karrman wrote: > On 2017-03-03 13:59, Heikki Krogerus wrote: > > > On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: > > > > > How would something like that sound to you guys? > >

Re: query on UCSI

Hi, On Mon, Mar 06, 2017 at 02:41:17PM +0530, Shah, Nehal-bakulchandra wrote: > Hi Greg and Heikki, > > > I can see that ucsi acpi interface driver is available in kernel tree. I have > following queries on the same. Kindly pardon my ignorance as i am a novice to > this. > > - Is there any

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Tue, Mar 07, 2017 at 01:36:29AM +, Peter Chen wrote: > >On Mon, Mar 06, 2017 at 09:15:51AM +0800, Peter Chen wrote: > >> > > What interface you use when you receive this event to handle > >> > > dual-role switch? I am wonder if a common dual-role class is > >> > > needed, then we can have a

Re: query on UCSI

Hi, On Tue, Mar 07, 2017 at 12:39:39AM +0530, Shah, Nehal-bakulchandra wrote: > Hi Heikki , > > > Thanks for the prompt reply. > If i understood correctly the current driver(drivers/usb/misc/ucsi.c) supports > the OPM and rest all is taken care by EC FW with BIOS . > In ucsi.c file i did not

Re: [PATCH v17 2/3] usb: USB Type-C connector class

Hi, On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: > On 2017-03-03 04:13, Guenter Roeck wrote: > > > On 03/02/2017 07:22 AM, Mats Karrman wrote: > > > > > > Looking forward, one thing I have run into is how to connect the typec > > > driver with a > > > driver for an

Re: [PATCH v17 2/3] usb: USB Type-C connector class

Hi Peter, On Fri, Mar 03, 2017 at 11:35:29AM +0800, Peter Chen wrote: > On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > > +/* --- */ > > +/* Driver callbacks to report role updates */ > > + > > +/** > > + *

Re: Sometimes supports_usb_power_delivery reports incorrect value.

On Tue, Aug 15, 2017 at 04:26:07PM -0700, Badhri Jagan Sridharan wrote: > Submitted couple of patches for the missing pieces in TCPM. > Those patches along with "usb: typec: update partner power delivery > support with opmode" > seems to address the issue of reporting the right value for >

Re: Sometimes supports_usb_power_delivery reports incorrect value.

Hi, On Mon, Aug 14, 2017 at 11:57:15AM -0700, Badhri Jagan Sridharan wrote: > Hi Heikki, > > While testing with different type-c phones available in the market, > With some phones, I noticed that supports_usb_power_delivery > reports "no" eventhough an explicit pd contract has been >

Re: [PATCH] usb: typec: include linux/device.h in ucsi.h

rface") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > --- > drivers/usb/typec/ucsi/ucsi.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/u

Re: [PATCH v4] usb: typec: Don't prevent using constant typec_mode_desc initializers

r_altmode() > et.al. to using const pointers. > > Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> > Reviewed-by: Guenter Roeck <gro...@chromium.org> This is OK by me. FWIW: Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> FYI, in case you guys are i

Re: [RFC PATCH v5 1/2] usb: typec: USB Type-C Port Manager (tcpm)

Hi Guenter, On Fri, Apr 21, 2017 at 03:15:52PM -0700, Guenter Roeck wrote: > +/* > + * Logging > + */ > + > +#ifdef CONFIG_DEBUG_FS > + > +static bool tcpm_log_full(struct tcpm_port *port) > +{ > + return port->logbuffer_tail == > + (port->logbuffer_head + 1) % LOG_BUFFER_ENTRIES;

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On Thu, Apr 27, 2017 at 11:10:55AM -0700, Guenter Roeck wrote: > On Thu, Apr 27, 2017 at 11:50:12AM +0530, Rajaram R wrote: > > On Tue, Apr 25, 2017 at 7:40 PM, Guenter Roeck wrote: > > > On 04/25/2017 01:26 AM, Rajaram R wrote: > > >> > > >> On Mon, Apr 24, 2017 at 11:20 PM,

Re: [PATCH v4] usb: typec: Don't prevent using constant typec_mode_desc initializers

On Fri, Apr 28, 2017 at 11:25:34AM +0200, Greg KH wrote: > On Wed, Apr 26, 2017 at 01:08:02PM +0300, Heikki Krogerus wrote: > > Hi Mats, > > > > On Tue, Apr 25, 2017 at 11:49:47PM +0200, Mats Karrman wrote: > > > In some situations, e.g. when registering a

Re: [PATCH v5 2/3] phy: Move ULPI phy header out of drivers to include path

t; > Cc: Stephen Boyd <stephen.b...@linaro.org> > Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > Cc: linux-o...@vger.kernel.org > Cc

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

Hi guys, On Wed, May 17, 2017 at 02:36:44AM -0700, Guenter Roeck wrote: > On 05/17/2017 12:34 AM, Oliver Neukum wrote: > > Am Mittwoch, den 17.05.2017, 00:32 -0700 schrieb Badhri Jagan > > Sridharan: > > > > Hi, > > > > > "Two independent set of mechanisms are defined to allow a USB Type-C > >

Re: [PATCH] doc-rst: fixed kernel-doc directives in usb/typec.rst

On Sat, May 13, 2017 at 03:49:17PM +0200, Markus Heiser wrote: > Even if this file is not yet included in any toctree, it is parsed by > Sphinx since it is named '.rst'. This patch fixes the following two > ERRORs from Sphinx build: > > Documentation/usb/typec.rst:116: ERROR: Error in

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

On Wed, May 17, 2017 at 06:02:47AM -0700, Guenter Roeck wrote: > On 05/17/2017 05:38 AM, Heikki Krogerus wrote: > > Hi guys, > > > > On Wed, May 17, 2017 at 02:36:44AM -0700, Guenter Roeck wrote: > > > On 05/17/2017 12:34 AM, Oliver Neukum wrote: > > > >

[PATCH 3/3] usb: typec: ucsi: Add ACPI driver

Driver for ACPI UCSI interface method. This driver replaces the previous UCSI driver drivers/usb/misc/ucsi.c. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/misc/Kconfig | 26 -- drivers/usb/misc/Makefile | 1 - drivers/usb/misc/

[PATCH 0/3] usb: typec: Add proper UCSI support

for other interface methods later. Heikki Krogerus (3): usb: typec: update partner power delivery support with opmode usb: typec: Add support for UCSI interface usb: typec: ucsi: Add ACPI driver drivers/usb/misc/Kconfig| 26 -- drivers/usb/misc/Makefile | 1

[PATCH 2/3] usb: typec: Add support for UCSI interface

of the optional UCSI features (alternate modes, power source capabilities, and cable capabilities). Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 2 + drivers/usb/typec/Makefile | 1 + drivers/usb/typec/ucsi/Kconfig | 22 ++ drive

[PATCH 1/3] usb: typec: update partner power delivery support with opmode

If USB PD contract is established after creation of the partner, the power delivery support attribute of the partner needs to be updated separately. This can be done in typec_set_pwr_opmode() by checking if the port has already partner and updating the value if it does. Signed-off-by: Heikki

Re: [PATCH v2 1/2] usb: typec: Add support for UCSI interface

Hi Guenter, On Mon, Jun 12, 2017 at 02:55:49PM +0300, Heikki Krogerus wrote: > > > +/* Command Status and Connector Change Indication (CCI) data structure */ > > > +struct ucsi_cci { > > > + u8:1; /* reserved */ > > > + u8 connector_change:7; > > >

[PATCH v3 1/2] usb: typec: Add support for UCSI interface

of the optional UCSI features (alternate modes, power source capabilities, and cable capabilities). Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 2 + drivers/usb/typec/Makefile | 1 + drivers/usb/typec/ucsi/Kconfig | 23 ++ drive

[PATCH v3 0/2] New driver for UCSI (USB Type-C)

imeouts are in milliseconds by using _MS ending with the definition (UCSI_TIMEOUT_MS and UCSI_SWAP_TIMEOUT_MS) as suggested by Guenter. - Including also in ucsi.h as suggested by Guenter. - In ucsi_acpi.c, explicitly pointing out in the comment that we can not use devm_ioremap_resource() as

[PATCH v3 2/2] usb: typec: ucsi: Add ACPI driver

Driver for ACPI UCSI interface method. This driver replaces the previous UCSI driver drivers/usb/misc/ucsi.c. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- drivers/usb/misc/Kconfig | 26 -- driv

Re: [PATCH v4 1/2] usb: typec: Add support for UCSI interface

On Fri, Jun 16, 2017 at 03:14:37PM -0700, Guenter Roeck wrote: > On Fri, Jun 16, 2017 at 11:21:24AM +0300, Heikki Krogerus wrote: > > UCSI - USB Type-C Connector System Software Interface - is a > > specification that defines set of registers and data > > structures for contr

Re: [PATCH] usb: typec: Defer checking of valid power role swap to low level drivers

On Thu, May 18, 2017 at 02:08:53PM -0700, Badhri Jagan Sridharan wrote: > On Thu, May 18, 2017 at 9:51 AM, Guenter Roeck wrote: > > On Thu, May 18, 2017 at 11:13:51AM +0200, Oliver Neukum wrote: > >> Am Mittwoch, den 17.05.2017, 02:36 -0700 schrieb Guenter Roeck: > >> > On

Re: [PATCH] usb: typec: Add a sysfs node to manage port type

n has finished. > + > + Valid values: > + - DRP > + - DFP > + - UFP > > What: /sys/class/typec//supported_accessory_modes > Date:April 2017 > Contact: Heikki Krogerus <heikki.kroge.

Re: [PATCH] usb: typec: Add a sysfs node to manage port type

On Tue, May 23, 2017 at 06:16:28AM -0700, Guenter Roeck wrote: > On 05/23/2017 03:46 AM, Heikki Krogerus wrote: > > Hi, > > > > On Mon, May 22, 2017 at 01:05:42PM -0700, Badhri Jagan Sridharan wrote: > > > User space applications in some cases have the need to enfo

[RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

Driver for USB Type-C PHY on Intel WhiskeyCove PMIC that works with Type-C Port Controller Manager to provide USB Power Delivery and USB Type-C functionalities Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/staging/typec/Kconfig | 11 + drivers/staging

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

On Wed, May 24, 2017 at 06:11:20AM -0700, Guenter Roeck wrote: > Hello Heikki, > > On 05/24/2017 05:54 AM, Heikki Krogerus wrote: > > Driver for USB Type-C PHY on Intel WhiskeyCove PMIC that > > works with Type-C Port Controller Manager to provide USB > > Po

Re: [PATCH 3/3] usb: typec: ucsi: Add ACPI driver

Hi, On Thu, May 25, 2017 at 06:23:30AM -0700, Guenter Roeck wrote: > > + /* > > +* NOTE: The memory region for the data structures is used also in an > > +* operation region, which means ACPI has already reserved it. Therefore > > +* it can not be requested here. > > +*/ > > +

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

Hi, On Thu, May 25, 2017 at 06:20:16AM -0700, Guenter Roeck wrote: > On 05/16/2017 05:26 AM, Heikki Krogerus wrote: > > UCSI - USB Type-C Connector System Software Interface - is a > > specification that defines set of registers and data > > structures for controlling the U

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

Hi, My two cents. On Thu, May 25, 2017 at 10:12:27AM -0700, Guenter Roeck wrote: > > What is keeping this code in staging at the moment? Who isn't agreeing > > on the existing apis we have there? > > > > I don't think the APIs are at issue; I would not expect any substantial > (if any)

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

On Wed, May 24, 2017 at 05:08:10PM +0200, Greg Kroah-Hartman wrote: > On Wed, May 24, 2017 at 03:54:23PM +0300, Heikki Krogerus wrote: > > Driver for USB Type-C PHY on Intel WhiskeyCove PMIC that > > works with Type-C Port Controller Manager to provide USB > > Power De

Re: [RFC PATCH] staging: typec: Intel WhiskeyCove PMIC USB Type-C PHY driver

On Wed, May 24, 2017 at 08:22:35AM -0700, Guenter Roeck wrote: > On Wed, May 24, 2017 at 05:08:10PM +0200, Greg Kroah-Hartman wrote: > > On Wed, May 24, 2017 at 03:54:23PM +0300, Heikki Krogerus wrote: > > > Driver for USB Type-C PHY on Intel WhiskeyCove PMIC that > >

Re: [PATCH 2/3] usb: typec: Add support for UCSI interface

On Fri, May 26, 2017 at 06:26:01AM -0700, Guenter Roeck wrote: > > > What happens if trace is not enabled ? If I recall discussions around > > > CLANG > > > correctly, it complains about unused static inline functions. > > > > Nothing happens if trace is not enable. Everything continues to > >

Re: [PATCH 3/3] usb: typec: ucsi: Add ACPI driver

On Fri, May 26, 2017 at 06:30:38AM -0700, Guenter Roeck wrote: > On 05/26/2017 04:08 AM, Heikki Krogerus wrote: > > Hi, > > > > On Thu, May 25, 2017 at 06:23:30AM -0700, Guenter Roeck wrote: > > > > + /* > > > > +* NOTE: The memor

Re: [PATCH v6] usb: typec: Add a sysfs node to manage port type

g has not yet picked this: Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] usb: typec: Add support for UCSI interface

of the optional UCSI features (alternate modes, power source capabilities, and cable capabilities). Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 2 + drivers/usb/typec/Makefile | 1 + drivers/usb/typec/ucsi/Kconfig | 22 ++ drive

[PATCH v2 0/3] New driver for UCSI (USB Type-C)

also in ucsi.h as suggested by Guenter. - In ucsi_acpi.c, explicitly pointing out in the comment that we can not use devm_ioremap_resource() as suggested by Guenter. Heikki Krogerus (2): usb: typec: Add support for UCSI interface usb: typec: ucsi: Add ACPI driver drivers/usb/misc/Kconfig

[PATCH v2 2/2] usb: typec: ucsi: Add ACPI driver

Driver for ACPI UCSI interface method. This driver replaces the previous UCSI driver drivers/usb/misc/ucsi.c. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/misc/Kconfig | 26 -- drivers/usb/misc/Makefile | 1 - drivers/usb/misc/

Re: [PATCH v6 5/6] mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips

anan > <sathyanarayanan.kuppusw...@linux.intel.com> > Acked-for-MFD-by: Lee Jones <lee.jo...@linaro.org> For the typec_wcove.c part: Revieved-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] New driver for UCSI (USB Type-C)

Hi Guenter, On Mon, Jun 05, 2017 at 05:30:22PM +0300, Heikki Krogerus wrote: > Hi, > > This moves the current ucsi driver from drivers/usb/misc/ucsi.c to the > new USB Type-C class (drivers/usb/typec/). That allows us to finally do > role swapping. > > The driver is now sp

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

Hi Guenter, Gentle ping. I'm sorry to bother you with this, I know you are busy. On Mon, Jun 12, 2017 at 05:40:08PM +0300, Heikki Krogerus wrote: > UCSI - USB Type-C Connector System Software Interface - is a > specification that defines set of registers and data > structures for co

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

On Thu, Jun 15, 2017 at 08:08:19AM -0700, Guenter Roeck wrote: > On Mon, Jun 12, 2017 at 05:40:08PM +0300, Heikki Krogerus wrote: > > UCSI - USB Type-C Connector System Software Interface - is a > > specification that defines set of registers and data > > structures for contr

[PATCH v4 2/2] usb: typec: ucsi: Add ACPI driver

Driver for ACPI UCSI interface method. This driver replaces the previous UCSI driver drivers/usb/misc/ucsi.c. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Guenter Roeck <li...@roeck-us.net> --- drivers/usb/misc/Kconfig | 26 -- driv

[PATCH v4 0/2] usb: typec: New driver for UCSI

y using _MS ending with the definition (UCSI_TIMEOUT_MS and UCSI_SWAP_TIMEOUT_MS) as suggested by Guenter. - Including also in ucsi.h as suggested by Guenter. - In ucsi_acpi.c, explicitly pointing out in the comment that we can not use devm_ioremap_resource() as suggested by Guenter. Heikki

[PATCH v4 1/2] usb: typec: Add support for UCSI interface

of the optional UCSI features (alternate modes, power source capabilities, and cable capabilities). Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 2 + drivers/usb/typec/Makefile | 1 + drivers/usb/typec/ucsi/Kconfig | 23 ++ drive

Re: [PATCH v2 1/2] usb: typec: Add support for UCSI interface

Hi, On Fri, Jun 09, 2017 at 07:52:56PM -0700, Guenter Roeck wrote: > > diff --git a/drivers/usb/typec/ucsi/debug.h b/drivers/usb/typec/ucsi/debug.h > > new file mode 100644 > > index ..87d0cd20597a > > --- /dev/null > > +++ b/drivers/usb/typec/ucsi/debug.h > > @@ -0,0 +1,64 @@ > >

Re: [PATCH v2 0/3] New driver for UCSI (USB Type-C)

On Fri, Jun 09, 2017 at 06:30:30AM -0700, Guenter Roeck wrote: > On 06/09/2017 04:03 AM, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, Jun 05, 2017 at 05:30:22PM +0300, Heikki Krogerus wrote: > > > Hi, > > > > > > This moves the

Re: [PATCH v3 1/2] usb: typec: Add support for UCSI interface

On Wed, Jun 14, 2017 at 12:50:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 14, 2017 at 09:45:46AM +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > Gentle ping. > > After less than 2 days? Relax please... OK, Sorry for the noise. -- heikki -- To unsub

Re: [PATCH v1] ACPI: Switch to use generic UUID API

;bske...@redhat.com> > Cc: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Cc: Joerg Roedel <j...@8bytes.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: Yisen Zhuang <yisen.zhu...@huawei.com> > Cc: Bjorn Helgaas <bhelg...@google.com&

Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack

Hi Maksim, Sorry for commenting this so late but.. On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote: > @@ -806,7 +814,7 @@ static int tower_probe (struct usb_interface *interface, > const struct usb_device > struct device *idev = >dev; > struct usb_device *udev =

Re: [PATCH] usb: misc: legousbtower: Fix memory leak

;Fixes" tag: Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack") Please check Documentation/process/submitting-patches.rst for more information. > Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> You are signing the patch for me which y

[PATCH] usb: typec: wcove: start using tcpm for USB PD support

This patch makes the driver work with USB Type-C Port Manager (tcpm.c) to provide USB PD functionality. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 4 +- drivers/usb/typec/typec_wcove.c | 594 ++---

Re: [PATCH 1/2 v2] typec: tcpm: Validate source and sink caps

Hi, On Mon, Oct 09, 2017 at 03:13:43PM -0700, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates whether the src_caps/snk_caps adheres > to it. > > 6.4.1 Capabilities Message > A Capabilities message (Source Capabilities message or

[PATCH] usb: typec: tcpm: reset the port on removal

If a port is unregistered, all the devices attached to it must be unregistered as well. This will also make sure VBUS and VCONN are disabled. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/tcpm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

Re: [PATCH] usb: typec: wcove: fix uninitialized usbc_irq1 and usbc_irq2

calar variable") > > Fixes: 3c4fb9f16921 ("usb: typec: wcove: start using tcpm for USB PD support") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Thanks, -- heikki -- To unsubscribe f

Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code

vers/staging/typec/tcpm.c | 37 + > 1 file changed, 1 insertion(+), 36 deletions(-) Nice! Just to be sure: The idea is to leave tcpci.c in staging, right? In any case, FWIW, for all of these: Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> -- heikki

Re: [RFC PATCH 2/2] usb: typec: dummy alternate mode driver

On Thu, Sep 28, 2017 at 03:22:35PM +0300, Felipe Balbi wrote: > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > +MODULE_DESCRIPTION("DisplayPort Alternate Mode"); > > huh? Copy paste :-) Cheers, -- heikki -- To unsubscribe from this list: send

[RFC PATCH 2/2] usb: typec: dummy alternate mode driver

Example alternate mode driver. Meant only to give an idea how a real alternate mode driver *could* look like! Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 2 + drivers/usb/typec/Makefile | 1 + drivers/usb/typec/al

[RFC PATCH 1/2] usb: typec: Simple bus for alternate modes

Bus for binding SVID specific drivers to the altnernate mode devices. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Makefile | 2 + drivers/usb/typec/altmode.c| 249 + drivers/usb/typec/alt

[RFC PATCH 0/2] usb: typec: alternate mode bus

by using the remote endpoint concept [1][2] on ACPI and DT platforms, but I have no solution for the "platform data" case where we have neither DT nor ACPI to describe the connections for us. [1] Documentation/devicetree/bindings/graph.txt [2] Documentation/acpi/dsd/graph.txt Heikki K

Re: [PATCH v3 05/14] mux: core: Add usb.h header with MUX_USB_* and and MUX_TYPEC_* state constants

Hi Hans, Sorry about the late response. On Fri, Sep 22, 2017 at 08:37:54PM +0200, Hans de Goede wrote: > Add MUX_USB_* and MUX_TYPEC_* state constant defines, which can be used by > USB device/host, resp. Type-C polarity/role/altmode mux drivers and > consumers to ensure that they agree on the

Re: [PATCH 01/12] usb: typec: add API to get port type and preferred role

Hi, On Tue, Sep 26, 2017 at 08:45:16AM +0800, Li Jun wrote: > This patch add 2 APIs to get port type and preferred role from firmware > description. > > Signed-off-by: Li Jun > --- > drivers/usb/typec/typec.c | 45 + >

Re: [PATCH 02/12] usb: typec: add basic typec properties

On Tue, Sep 26, 2017 at 08:45:17AM +0800, Li Jun wrote: > port-type is required for any typec port; default-role is only required > for drp; power source capable needs src-pdos; power sink capable needs > snk-pdos, max-snk-mv, max-snk-ma, op-snk-mw. > > Signed-off-by: Li Jun >

[PATCH] usb: typec: driver for TI TPS6598x USB Power Delivery controllers

-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig| 11 + drivers/usb/typec/Makefile | 1 + drivers/usb/typec/tps6598x.c | 475 +++ 3 files changed, 487 insertions(+) create mode 100644 drivers/usb/typec/tps6

Re: [PATCH 15/15] usb: make device_type const

On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> Acked-by: Heikki K

Re: [PATCH 04/11] usb: xhci: Add Intel cherrytrail extended cap / otg phy mux handling

Hi, On Fri, Sep 01, 2017 at 11:48:38PM +0200, Hans de Goede wrote: > The Intel cherrytrail xhci controller has an extended cap mmio-range > which contains registers to control the muxing to the xhci (host mode) > or the dwc3 (device mode) and vbus-detection for the otg usb-phy. > > Having a mux

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

Hi Adam, On Fri, Nov 24, 2017 at 02:05:27PM +, Adam Thomson wrote: > On 24 November 2017 12:19, Heikki Krogerus wrote: > > Is it OK to everybody that the type of the psy is changed like that? > > Hans?! > > > > We do have drivers that already change the type, fo

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

On Sat, Nov 25, 2017 at 03:03:02PM +0100, Hans de Goede wrote: > > Is it OK to everybody that the type of the psy is changed like that? > > Hans?! > > > > We do have drivers that already change the type, for example > > drivers/power/supply/isp1704_charger.c, but what does the user space > >

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

On Mon, Nov 27, 2017 at 04:54:08PM +, Adam Thomson wrote: > On 27 November 2017 14:12, Heikki Krogerus wrote: > > > Hi Adam, > > > > On Fri, Nov 24, 2017 at 02:05:27PM +, Adam Thomson wrote: > > > On 24 November 2017 12:19, Heikki Krogerus wro

Re: [PATCH v3] typec: tcpm: fusb302: Resolve out of order messaging events

> > Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> FWIW: Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > --- > > Changes in v3: > - Always read from FIFO on TX_SUCCES and GCRCSENT events, but decision on how >to report to TCPM is no lon

Re: [PATCH v2] typec: fusb302: Use dev_err during probe

On Fri, Nov 24, 2017 at 12:03:16AM +0100, Mats Karrman wrote: > If probe fails, fusb302_debugfs_exit is called making it impossible > to view any logs so use normal dev_err for any error messages during > probe. > > Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> Acke

Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

Hi, On Tue, Nov 14, 2017 at 11:44:47AM +, Adam Thomson wrote: > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 78983e1..7c26c3d 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -12,6 +12,7 @@ > #include > #include > #include >

Re: [RFC PATCH 0/2] usb: typec: alternate mode bus

Hi, Thanks for taking a look at this.. On Sun, Nov 26, 2017 at 12:23:31PM +0100, Hans de Goede wrote: > Hi Heiko, > > On 28-09-17 13:35, Heikki Krogerus wrote: > > Hi guys, > > > > The bus allows SVID specific communication with the partners to be > > han

Re: [PATCH 21/45] usb: typec: remove duplicate includes

On Tue, Dec 05, 2017 at 07:34:55AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge <pravin.shedge4li...@gmail.com>

Re: Dual-role behavior with USB-C?

Hi guys, On Wed, Dec 13, 2017 at 10:43:50AM +0800, Peter Chen wrote: > On Wed, Dec 13, 2017 at 01:17:23AM +, Takashi Matsuzawa wrote: > > Hello. > > > > >If you have a Type-C connector on your board, then you also should > > >have a USB Type-C PHY that takes care of CC logic. The

[PATCH] usb: pd: fix the offset for SVID specific commands

The SVID specific commands in the Command field of the Structured VDM Header start from 16, not 10. Changing the value used in VDO_CMD_VENDOR() macro from 10 to 0x10. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- include/linux/usb/pd_vdo.h | 2 +- 1 file chan

Re: [PATCH] usb: pd: fix the offset for SVID specific commands

On Mon, Dec 18, 2017 at 03:08:35PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 18, 2017 at 05:03:03PM +0300, Heikki Krogerus wrote: > > The SVID specific commands in the Command field of the > > Structured VDM Header start from 16, not 10. Changing the > > value used in V

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

Controller Manager, which of course is not the case any more. Would the attached patch be sufficient? Thanks, -- heikki >From 3bbd624a67df91c23db996db5f2f931fde77fcc1 Mon Sep 17 00:00:00 2001 From: Heikki Krogerus <heikki.kroge...@linux.intel.com> Date: Tue, 14 Nov 2017 14:45:27 +03

Re: [GIT PULL] USB/PHY driver changes for 4.15-rc1

Hi Guenter, On Tue, Nov 14, 2017 at 06:48:21AM -0800, Guenter Roeck wrote: > On 11/14/2017 05:17 AM, Greg KH wrote: > > On Mon, Nov 13, 2017 at 09:29:36PM -0800, Linus Torvalds wrote: > > > On Mon, Nov 13, 2017 at 8:19 AM, Greg KH > > > wrote: > > > > > > > > Other

Re: [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

Hi Adam, On Tue, Nov 14, 2017 at 11:44:41AM +, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. > > The source PPS supply is represented using the Power Supply framework to > provide > access and control APIs for

Re: [RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

On Tue, Nov 21, 2017 at 01:51:41PM +, Adam Thomson wrote: > > These don't apply on top of Badhri's series: > > http://www.spinics.net/lists/kernel/msg2649921.html > > Hi Heikki, > > When I submitted these I was aware of Badhri's patch set but at the time they > hadn't been approved or

Re: State of USB-C PD on the linux kernel

On Tue, Oct 31, 2017 at 04:19:58PM +0100, L. Rose wrote: > Hi, thanks for your reply! > > > On 31.10.2017 10:17, Heikki Krogerus wrote: > > Hi, > > > > It is likely that your system handles USB PD in firmware, and the OS > > has no say in that. Which board i

Re: State of USB-C PD on the linux kernel

On Wed, Nov 01, 2017 at 11:38:13PM +0100, L. Rose wrote: > Hi, thanks for replying! > > > Could you send acpidump to me? > Sorry, but can you point me a URL where to get acpidump? I'm running > arch, but any x86_64-binary or source code should be fine. Couldn't find > it anywhere on the net. It

Re: [PATCH 5/6] USB: typec: add SPDX identifiers to some files

se text in the file > itself. > > The SPDX identifier is a legally binding shorthand, which can be used > instead of the full boiler plate text. > > Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Cc: Guenter Roeck <li...@roeck-us.net> > Cc: Hans de Goede <h

Re: [PATCH 6/6] USB: typec: Remove remaining redundant license text

done on a quest to remove the 700+ different ways that files in > the kernel describe the GPL license text. And there's unneeded stuff > like the address (sometimes incorrect) for the FSF which is never > needed. > > No copyright headers or other non-license-description text was rem

Re: [PATCH 2/2 v5] typec: tcpm: Only request matching pdos

> - Rebase I'm fine with this, but in case you'll prepare one more version, I'll put a few really minor nits below. I would prefer though that Guenter gave his ACK to any patches touching tcpm.c or tcpci.c. But FWIW: Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Than

Re: [PATCH 1/6] USB: add SPDX identifiers to all remaining Makefiles

inuxfoundation.org> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Cc: Peter Korsgaard <jac...@sunsite.dk> > Cc: Thomas Winischhofer <tho...@winischhofer.net> > Cc: Johan Hovold <jo...@kernel.org> > Cc: Heikki Krogerus <heikki.kroge...@linux.int

Re: [PATCH 1/2 v5] typec: tcpm: Validate source and sink caps

f partner > device would only log them. > > Signed-off-by: Badhri Jagan Sridharan <bad...@google.com> It would have been nice to have enum for the return values used in tcpm_cap_err() IMHO, but never mind. Is Guenter OK with these? FWIW: Acked-by: Heikki Krogerus <heikki.kroge.

Re: [PATCH 2/2] typec: tcpm: Only request matching pdos

Hi, +Dan and Guenter I'm sorry for the late reply. These slipped under my radar. I do have a one more proposal below, and a few nits.. On Wed, Oct 18, 2017 at 01:22:48PM -0700, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and

Re: [PATCH 1/2 v3] typec: tcpm: Validate source and sink caps

+Dan and Guenter, I don't have any problems with this, but since I had those few comments for the 2/2 of this series, few nitpics below.. On Wed, Oct 18, 2017 at 01:22:47PM -0700, Badhri Jagan Sridharan wrote: > The source and sink caps should follow the following rules. > This patch validates

Re: [PATCH 05/24] USB: typec: Remove redundant license text

done on a quest to remove the 700+ different ways that files in > the kernel describe the GPL license text. And there's unneeded stuff > like the address (sometimes incorrect) for the FSF which is never > needed. > > No copyright headers or other non-license-description text was rem

Re: [RFC PATCH 0/2] usb: typec: alternate mode bus

On Thu, Dec 07, 2017 at 05:40:40PM +0100, Hans de Goede wrote: > Hi, > > On 07-12-17 16:00, Heikki Krogerus wrote: > > Hi Hans, > > > > On Tue, Dec 05, 2017 at 03:56:05PM +0100, Hans de Goede wrote: > > > Hi, > > > > > >

Re: [RFC PATCH 0/2] usb: typec: alternate mode bus

Hi Hans, On Tue, Dec 05, 2017 at 03:56:05PM +0100, Hans de Goede wrote: > Hi, > > On 01-12-17 09:38, Heikki Krogerus wrote: > > Hi, > > > > Thanks for taking a look at this.. > > > > On Sun, Nov 26, 2017 at 12:23:31PM +0100, Hans de Goede wrote: > &g

[PATCH] usb: typec: wcove: fix the sink capabilities

he Battery and Variable Supply objects, as there is no need for them. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/typec_wcove.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/typec/typec_wcove.c b/drivers/usb/typec/typ

Re: Dual-role behavior with USB-C?

Hi Takashi, On Tue, Dec 12, 2017 at 07:01:34AM +, Takashi Matsuzawa wrote: > Hello. > Thank you very much for your comment. > > > Since USB OTG FSM has not been accepted by industry during last ten years, > > we decide > > to give up maintaining OTG FSM at Linux kernel. For role switch use

Re: [PATCH] usb: typec: tps6598x: mark expected switch fall-through

On Fri, Oct 27, 2017 at 04:01:13PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Heikki Krog

<    1   2   3   4   5   6   7   8   9   10   >