Re: [PATCH 1/2] net: asix: init ASIX AX88772B MAC from EEPROM

2012-12-18 Thread Oliver Neukum
On Tuesday 18 December 2012 14:38:32 Lucas Stach wrote: > Am Dienstag, den 18.12.2012, 14:33 +0100 schrieb Oliver Neukum: > > On Tuesday 18 December 2012 14:24:32 Lucas Stach wrote: > > > Am Dienstag, den 18.12.2012, 14:11 +0100 schrieb Oliver Neukum: > > > > On Tue

Re: Remove CONFIG_USB_SUSPEND?

2012-12-18 Thread Oliver Neukum
On Tuesday 18 December 2012 11:11:15 Alan Stern wrote: > I suggest that we remove the CONFIG_USB_SUSPEND option, starting in > 3.9. Practically everyone enables it, and the amount of code it > protects is fairly small (just portions of usbcore, nothing in the > drivers). That works both ways. Wh

Re: Remove CONFIG_USB_SUSPEND?

2012-12-18 Thread Oliver Neukum
On Tuesday 18 December 2012 11:38:46 Alan Stern wrote: > On Tue, 18 Dec 2012, Oliver Neukum wrote: > > > On Tuesday 18 December 2012 11:11:15 Alan Stern wrote: > > > I suggest that we remove the CONFIG_USB_SUSPEND option, starting in > > > 3.9. Practically everyone

Re: Fwd: [PATCH 001/001] Adding support "PSC Scanning, Magellan 800i" in cdc-acm

2012-12-26 Thread Oliver Neukum
On Wednesday 26 December 2012 18:29:44 Den Ladin wrote: > From: Denis N Ladin > > Adding support "PSC Scanning, Magellan 800i" in cdc-acm > Signed-off-by: Denis N Ladin Acked-by: Oliver Neukum > --- > Very simple, but very necessary. > Suitable for all ver

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-04 Thread Oliver Neukum
On Friday 04 January 2013 10:48:16 Dan Williams wrote: > Some drivers (ex sierra_net) need the status interrupt URB > active even when the device is closed, because they receive > custom indications from firmware. Allow sub-drivers to set > a flag that submits the status interrupt URB on probe and

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-05 Thread Oliver Neukum
On Friday 04 January 2013 19:26:33 Dan Williams wrote: > On Fri, 2013-01-04 at 23:16 +0100, Oliver Neukum wrote: > > On Friday 04 January 2013 10:48:16 Dan Williams wrote: > > > Some drivers (ex sierra_net) need the status interrupt URB > > > active even when the dev

Re: [PATCH v2 Resend 9/9] usb: add usb_device_allow_power_off() function.

2013-01-07 Thread Oliver Neukum
On Saturday 05 January 2013 13:58:27 Alan Stern wrote: > > static int inline usb_device_prevent_power_off(struct usb_device *udev) > > { > > struct device *dev = usb_get_port_dev(udev); > > > > if(!dev) > > return -ENODEV; > > > > return pm_runtime_get_sync(dev); >

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-07 Thread Oliver Neukum
On Saturday 05 January 2013 11:59:16 Bjørn Mork wrote: Hi, > You can still use a trick similar to what qmi_wwan and cdc_mbim does to > take over the status endpoint from usbnet: By not implementing .status, > and possibly setting dev->status to NULL in .bind, you are free to > handle the status e

Re: [PATCH v2 Resend 9/9] usb: add usb_device_allow_power_off() function.

2013-01-07 Thread Oliver Neukum
On Tuesday 08 January 2013 14:38:27 Lan Tianyu wrote: > On 2013年01月07日 15:43, Oliver Neukum wrote: > > Please change the name. It looks like a contradiction in itself and would > > thereby almost beg for misuse. > > > Hi Oliver: > how about "usb_device_con

Re: [PATCH 1/1]linux-usb:optimize to match the Huawei USB storage devices and support new switch command

2013-01-08 Thread Oliver Neukum
On Tuesday 08 January 2013 11:57:30 Sebastian Andrzej Siewior wrote: > > +static int usb_stor_huawei_scsi_init(struct us_data *us) > > +{ > > + int result = 0; > > + int act_len = 0; > > + struct bulk_cb_wrap *bcbw = (struct bulk_cb_wrap *) us->iobuf; > > + char rewind_cmd[] = {0x11

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: > I've had a quick look at the trace posted at > https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs > that are successfully submitted. I'm not sure what useful information I could > get from the trace. The

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 13:13:58 Ming Lei wrote: > IMO, there is a minor fault in the error handling path of > uvc_status_start() inside uvc_v4l2_open(), and the 'users' count > should have been decreased before usb_autopm_put_interface(). > In theory, the warning can be triggered when the devi

[PATCH] uvc: fix race of open and suspend in error case

2013-01-10 Thread Oliver Neukum
Ming Lei reported: IMO, there is a minor fault in the error handling path of uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should have been decreased before usb_autopm_put_interface(). In theory, the warning can be triggered when the device is opened just between usb_autopm_put_i

Re: [PATCH] CDC_NCM adding support IFF_NOARP for buggy device

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 21:59:28 Wei Shuai wrote: Hi, I am afraid this is done in an unclean manner. > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 71b6e92..9903f79 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -545,6 +545,7 @@

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 10:20:42 Alan Stern wrote: > On Thu, 10 Jan 2013, Oliver Neukum wrote: > > In the long run it is probably a good idea to pass duplicated URBs to > > usbmon by > > a special code path. > > I'd prefer to add extra information to the WA

Re: Linux 3.8-rc1 - another regression on USB :-(

2013-01-12 Thread Oliver Neukum
On Saturday 12 January 2013 14:16:02 Andreas Mohr wrote: > > Greg, Linus, > > It sounds insane, but after banging on the issue I have found out that > > USB problem is caused (also in vanilla kernel) with a config change: > > USB-all built as modules - bad USB > > USB core built in, UHCI/EHCI modu

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-13 Thread Oliver Neukum
On Sunday 13 January 2013 18:42:49 Alex Riesen wrote: > On Sun, Jan 13, 2013 at 5:56 PM, Alan Stern wrote: > > On Sun, 13 Jan 2013, Alex Riesen wrote: > >> > >> Yes, almost. What about khubd hanging when machine is shutdown? > > > > What about it? I have trouble understanding all the descriptions

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Oliver Neukum
On Monday 14 January 2013 11:47:57 Ming Lei wrote: > [ 181.175323] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables this message. > [ 181.183624] modprobeD c04f1920 0 2462 2461 0x > [ 181.183685] [] (__schedule+0x5fc/0x6d4) from [] > (async_synchronize_cookie_

Re: Linux 3.8-rc1 - another regression on USB :-(

2013-01-16 Thread Oliver Neukum
On Tuesday 15 January 2013 23:26:20 Woody Suwalski wrote: > The modules are insmoded in a fixed order: > usb-common, usbcore, xhci-hcd, ehci-hcd, uhci-hcd, ohci-hcd, usbhid, > usb_storage,... > > If all USB is built as modules - I get read errors from USB drives when > accessing squash image, b

Re: [PATCH v7 0/6] solve deadlock caused by memory allocation with I/O

2013-01-17 Thread Oliver Neukum
On Thursday 17 January 2013 09:28:14 Ming Lei wrote: > - we still need some synchronization to avoid accessing the storage >between sys_sync and device suspend, just like system sleep case, >pm_restrict_gfp_mask is needed even sys_sync has been done >inside enter_state(

Re: usb3.0 device recognized as usb2.1

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 16:36:29 kishon wrote: > > Bus 001 Device 004: ID 152d:2509 JMicron Technology Corp. / JMicron > > USA Technology Corp. JMS539 SuperSpeed SATA II 3.0G Bridge > > Device Descriptor: > > You are connecting to the wrong port. > > Try connecting to bus2 which seems to have u

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 15:25:47 Bjørn Mork wrote: > Adding support for the MBIM mode in some Sierra Wireless devices. > > Some Sierra Wireless firmwares support CDC MBIM but have no CDC > Union funtional descriptor. This violates the MBIM specification, > but we can easily work around the bug b

Re: [usb-storage] Re: USB storage suspend

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 14:09:26 Alan Stern wrote: > The autosuspend delay at the USB level probably should be set to 0; > then the autosuspend delay at the SCSI disk level will control the > actual power changes. What about things like lsusb? Should we better not go down quite to zero? > No

Re: [usb-storage] Re: USB storage suspend

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 11:58:28 Sarah Sharp wrote: > Isn't there a sysfs file to control the polling rate for removable > media? I don't remember where is it though. (I seem to ask about mass /sys/block/$DEVICE/events_poll_msecs HTH Oliver -- To unsubscribe from thi

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-21 Thread Oliver Neukum
On Monday 21 January 2013 15:47:13 Bjørn Mork wrote: > But I wonder if this isn't really a generic problem in usbnet. The > FLAG_MULTI_PACKET test here seems completely bogus: > > if (length % dev->maxpacket == 0) { > if (!(info->flags & FLAG_SEND_ZLP)) { >

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 16:28:48 Bjørn Mork wrote: > Agreed. But I believe the condition should be > > if (!(info->flags & FLAG_SEND_ZLP) && !(info->flags & FLAG_MULTI_PACKET)) { > .. > } else { > urb->transfer_flags |= URB_ZERO_PACKET; > } > > to ensure that we send the ZLP in

Re: [PATCH net 3/3] net: cdc_ncm: fix error path for single interface probing

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 16:50:40 Bjørn Mork wrote: > commit bbc8d92 (net: cdc_ncm: add Huawei devices) implemented > support for devices with a single combined control and data > interface. Fix up the error path so that we do not double > release such interfaces in case of probing failures. Hi B

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote: > Specification says: > NCM/MBIM shall not send ZLP if buffer size is dwNtbOutMaxSize. > > The problem is: > dwNtbOutMaxSize value is negotiated between host and device NCM/MBIM > entities and usbnet has no knowledge about it. > > Adding

Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-22 Thread Oliver Neukum
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote: > > > Either the FLAG_MULTI_PACKET minidriver will have already padded the > > > buffer so that we do not hit (length % dev->maxpacket == 0), or we > > > should choose one of the alternatives: ZLP or padding. > > > > But we cannot simply ca

Re: [RFC] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Oliver Neukum
On Thursday 24 January 2013 11:25:52 Bjørn Mork wrote: > The MBIM firmware for the Sierra Wireless MC7710 is a nice source > of "interesting" device issues. One of the uglier ones is that > it under certain conditions will start flooding us with frames > having length 0 as fast as it can. And tha

Re: [RFC] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Oliver Neukum
On Thursday 24 January 2013 11:52:22 Bjørn Mork wrote: > Oliver Neukum writes: > > > On Thursday 24 January 2013 11:25:52 Bjørn Mork wrote: > >> The MBIM firmware for the Sierra Wireless MC7710 is a nice source > >> of "interesting" device issues. One

Re: [RFC] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Oliver Neukum
On Thursday 24 January 2013 12:22:54 Bjørn Mork wrote: > Oliver Neukum writes: > > > On Thursday 24 January 2013 11:52:22 Bjørn Mork wrote: > >> Oliver Neukum writes: > >> > >> > On Thursday 24 January 2013 11:25:52 Bjørn Mork wrote: > >> >

Re: [RFC] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Oliver Neukum
On Thursday 24 January 2013 13:47:40 Bjørn Mork wrote: > Oliver Neukum writes: > > On Thursday 24 January 2013 12:22:54 Bjørn Mork wrote: > > > >> Sorry for being daft, but how do I code the "20 among the last 30" part > >> there? > > > >

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-24 Thread Oliver Neukum
On Thursday 24 January 2013 20:16:56 Bjørn Mork wrote: > A device sending 0 length frames as fast as it can has been > observed killing the host system due to the resulting memory > pressure. > > Temporarily disable RX skb allocation and URB submission when > the current error ratio is high, preve

Re: [PATCH net] net: usbnet: prevent buggy devices from killing us

2013-01-25 Thread Oliver Neukum
On Friday 25 January 2013 08:13:15 Bjørn Mork wrote: > Oliver Neukum writes: > > On Thursday 24 January 2013 20:16:56 Bjørn Mork wrote: > >> A device sending 0 length frames as fast as it can has been > >> observed killing the host system due to the res

Re: [PATCH v2 1/5] cdc-acm: reindent log messages

2016-11-18 Thread Oliver Neukum
On Thu, 2016-11-17 at 23:56 +0100, Ladislav Michl wrote: > Use only one tab to indent dev_{(v)dbg,err} parameters. > > Signed-off-by: Ladislav Michl Acked-by: Oliver Neukum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH v2 1/5] cdc-acm: reindent log messages

2016-11-19 Thread Oliver Neukum
On Sat, 2016-11-19 at 17:06 +0100, Greg KH wrote: > On Fri, Nov 18, 2016 at 11:14:03AM +0100, Oliver Neukum wrote: > > On Thu, 2016-11-17 at 23:56 +0100, Ladislav Michl wrote: > > > Use only one tab to indent dev_{(v)dbg,err} parameters. > > > > > > Signed-

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-21 Thread Oliver Neukum
t; for your device. Regards Oliver From 51665f8ce6e13ba11b93b856290135bfe529d835 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Mon, 21 Nov 2016 14:08:31 +0100 Subject: [PATCH] CDC-ACM: debugging for parsed descriptors This is necessary to debug the parser on malformed he

Re: [PATCHv12 2/3] usb: USB Type-C connector class

2016-11-28 Thread Oliver Neukum
On Thu, 2016-11-24 at 11:57 +0200, Heikki Krogerus wrote: > On Wed, Nov 23, 2016 at 09:12:04PM -0800, Guenter Roeck wrote: > > In our implementation, the default preferred role is determined by the > > low level driver (as, in my understanding, is suggested by the standard). > > This means that th

Re: [PATCHv12 2/3] usb: USB Type-C connector class

2016-11-28 Thread Oliver Neukum
On Mon, 2016-11-28 at 12:11 -0800, Guenter Roeck wrote: > On Mon, Nov 28, 2016 at 04:23:23PM +0200, Heikki Krogerus wrote: > > On Mon, Nov 28, 2016 at 11:19:32AM +0100, Oliver Neukum wrote: > The Type-C specification states (in 4.5.2.2.11): > > "Note: if both Try.SRC and

Re: [PATCHv12 2/3] usb: USB Type-C connector class

2016-11-29 Thread Oliver Neukum
On Tue, 2016-11-29 at 14:20 +0100, Greg KH wrote: > On Tue, Nov 29, 2016 at 02:59:58PM +0200, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote: > > > Personally I don't really care about a module parameter; as mentioned > > > above, > >

Re: cdc_ether flooding kernel logs since bfe9b9d2d

2016-11-30 Thread Oliver Neukum
On Tue, 2016-11-29 at 14:41 +0100, Kristian Evensen wrote: > I don't know which of the two behaviors (if any) are "correct" or what > the best way to solve this problem is. One options is to remove the > code from the generic usbnet_cdc_status() function and move it to a > ZTE-specific status funct

Re: [PATCH 1/1] input: usbhid: fix improper check

2016-12-05 Thread Oliver Neukum
On Sun, 2016-12-04 at 13:10 +0800, Pan Bian wrote: > From: Pan Bian > > Function hid_post_reset() returns 0 on success, or 1 on failures. It seems like hid_post_reset() is buggy in not returning a proper error code in the failure case. So your diagnosis is right, but the fix is at the wrong plac

Re: [PATCH 0/2] USB: resume time optimization by using spec minimums

2016-12-05 Thread Oliver Neukum
On Sat, 2016-12-03 at 10:05 +0100, Greg KH wrote: > I think these values have grown over the years due to bad devices > being > reported. Look at the kernel logs for details. So we can not reduce > them by default. > > That being said, this is a nice change, but I really hate module > parameters

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-125

2016-12-05 Thread Oliver Neukum
On Mon, 2016-12-05 at 06:53 -0800, Nathaniel Quillin wrote: > Add device-id entry for GW Instek AFG-125, which has a byte swapped > bInterfaceSubClass (0x20). > > Signed-off-by: Nathaniel Quillin Acked-by: Oliver Neukum -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-12-07 Thread Oliver Neukum
On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote: Hi, > At least for my part I very much concentrated on making sure that > the user space ABI as well as the port driver API are sane and usable. Rightly so, as this part cannot be changed once included in a kernel release. So, can we agree

Re: [PATCH] usb: misc: rio500: fix result type for error message

2016-12-07 Thread Oliver Neukum
On Wed, 2016-12-07 at 15:50 +0100, Greg KH wrote: > On Wed, Dec 07, 2016 at 08:12:10PM +0900, Kim Jae Joong wrote: > > Fix variable type for dev_err about usb_bulk_msg() > > What was wrong with it before this change? What warning are you > "changing"? It was subtle. The error message printed a s

Re: add URB_ZERO_PACKET in transfer_flags for usb-skeleton.c

2016-12-12 Thread Oliver Neukum
On Thu, 2016-12-08 at 16:16 +0100, Greg KH wrote: > On Fri, Dec 09, 2016 at 12:09:46AM +0900, Jae Joong Kim wrote: > > > Do you have a driver that was based on this skeleton that needed this > > > flag to be added to work properly? Has it been updated in the kernel > > > source tree properly for i

Re: Fwd: UAS erorrs

2016-12-12 Thread Oliver Neukum
On Mon, 2016-12-12 at 09:37 +0100, Hans de Goede wrote: > Hi, I keep having the below errors and I think it is related to UAS? hi, it definitely is a UAS issue. Do you happen to know what command causes the error? Some more background, please. Regards Oliver -- To unsub

Re: Fwd: UAS erorrs

2016-12-13 Thread Oliver Neukum
On Mon, 2016-12-12 at 10:55 -0800, Alex Ruiz wrote: > I noticed it as being an issue when trying to run "rsync" local to > local. But it effected everything including long times to mount, > partitioning, ddrescue, and etc. > > > This is the hardware: http://www.iguanamicro.com/mousb30sahad.html

Re: [PATCHv13 2/3] usb: USB Type-C connector class

2016-12-15 Thread Oliver Neukum
On Thu, 2016-12-15 at 13:50 +0200, Heikki Krogerus wrote: > 1) Should we use "source" and "sink" instead of "device" and "host" > with the prefer_role attribute after all? I was uncomfortable with > that when we talked about it last time because the terms kept changing > with every new Type-C spec

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > Hi Oliver, > > I was working with this JMicron device and using the uas driver. > I am seeing the following 2 issues. > > 1) On connect I see the following messages. Thanks. Do you want to submit it to Greg? The patch is fine. > 2) On d

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 12:54 +0100, Hans de Goede wrote: > Hi, > > On 21-12-16 12:42, Oliver Neukum wrote: > > On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > >> Hi Oliver, > >> > >> I was working with this JMicron device and using the uas drive

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
On Wed, 2016-12-21 at 17:37 +0530, George Cherian wrote: > > On 12/21/2016 05:12 PM, Oliver Neukum wrote: > > On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote: > >> Hi Oliver, > >> > >> I was working with this JMicron device and using the uas driver.

Re: JMS56x not working reliably with uas driver

2016-12-21 Thread Oliver Neukum
ed patch and do a SCSI log of the enumeration? Regards Oliver From d4ddac88bbf9cb15e7d8638582f96d31e245f15b Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Wed, 21 Dec 2016 15:34:54 +0100 Subject: [PATCH] uas: device crashes on reset We avoid resetting it. Signed-of

Re: JMS56x not working reliably with uas driver

2016-12-22 Thread Oliver Neukum
On Thu, 2016-12-22 at 15:43 +0530, George Cherian wrote: > dmesg with the patch applied Hi, did you apply both patches, yours and the one I posted? And did you physically disconnect your device? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread Oliver Neukum
On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: > I don't see how this patch fixes anything. Unless I'm mistaken, it > just avoids the problem by preventing the system from issuing the > command that provokes the error, rather than really fixing the > underlying error. Please clarify. If a r

Re: JMS56x not working reliably with uas driver

2016-12-27 Thread Oliver Neukum
On Tue, 2016-12-27 at 10:20 -0500, Alan Stern wrote: > On Tue, 27 Dec 2016, Oliver Neukum wrote: > > > On Thu, 2016-12-22 at 17:44 -0500, Alan Stern wrote: > > > I don't see how this patch fixes anything. Unless I'm mistaken, it > > > just avoids the probl

Re: JMS56x not working reliably with uas driver

2016-12-29 Thread Oliver Neukum
On Tue, 2016-12-27 at 21:19 -0500, Alan Stern wrote: > On Tue, 27 Dec 2016, George Cherian wrote: > > True. I am afraid that there necessarily is a window for resetting a > > disconnected device. But the check you proposed is better. > > however, I'd like to encapsulate that together with a test f

[PATCH] Hi Oliver,

2017-01-02 Thread Oliver Neukum
ror is not seen when it is added to unusual_device list with US_FL_NO_REPORT_OPCODES passed. Signed-off-by: George Cherian Signed-off-by: Oliver Neukum CC: sta...@vger.kernel.org --- drivers/usb/storage/unusual_devs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/stor

[PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device

2017-01-02 Thread Oliver Neukum
: Oliver Neukum CC: sta...@vger.kernel.org --- drivers/usb/storage/unusual_devs.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index af3c7ee..16cc183 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb

Re: Thunderbolt adapter fails to instantiate USB and device enumeration if already connected at boot time

2017-01-03 Thread Oliver Neukum
On Mon, 2017-01-02 at 14:45 -0700, Chris Murphy wrote: > I see these lines in the problem case, which don't occur in the > working case. > > [0.561046] pci_bus :37: busn_res: [bus 37-ff] end is updated > to 37 > [0.561047] pci_bus :37: busn_res: can not insert [bus 37] > under doma

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

2017-01-09 Thread Oliver Neukum
On Fri, 2017-01-06 at 16:45 -0800, Todd Brandt wrote: > Add a kernel parameter that replaces the USB_RESUME_TIMEOUT > and other hardcoded delay numbers with the USB spec minimums. Hi, the problem with that is that distros cannot use it. It is obviously better than nothing but it seems to me that

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-10 Thread Oliver Neukum
On Fri, 2017-01-06 at 12:54 +0200, Heikki Krogerus wrote: > Hi guys, > > On Thu, Jan 05, 2017 at 05:54:02PM +0200, Mika Westerberg wrote: > > I wonder if "source sink" instead is better? Along the lines of > > /sys/power/state. > > > > Then you can print "[source] sink" when source is selected

Re: [PATCHv14 2/3] usb: USB Type-C connector class

2017-01-11 Thread Oliver Neukum
On Wed, 2017-01-11 at 09:57 +0200, Heikki Krogerus wrote: > On Tue, Jan 10, 2017 at 11:08:51AM +0100, Oliver Neukum wrote: > > > And since we are talking about the ABI, can we also change the listing > > > of the accessory mode back to just "audio" and "debu

Re: [PATCH v5 1/2] USB: add switch to turn off padding of resume time delays

2017-01-12 Thread Oliver Neukum
Am Mittwoch, den 11.01.2017, 21:06 +0200 schrieb Felipe Balbi: > Hi, > > Todd Brandt writes: > > > > On Mon, 2017-01-09 at 09:44 +0100, Oliver Neukum wrote: > > Well my main purpose in getting this out there is to get the seed > > planted for further optimiza

Re: [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard

2017-01-23 Thread Oliver Neukum
Am Montag, den 23.01.2017, 19:36 +0100 schrieb Lukáš Lalinský: > On Sat, Jan 21, 2017 at 10:08 AM, Greg Kroah-Hartman > wrote: > > > > Always use scripts/get_maintainer.pl to determine who to send > > patches > > to, and what mailing list.  You forgot linux-usb@vger, which I've > > now > > added.

Re: [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard

2017-01-24 Thread Oliver Neukum
Am Dienstag, den 24.01.2017, 08:37 +0100 schrieb Lukáš Lalinský: > On Tue, Jan 24, 2017 at 8:32 AM, Oliver Neukum > wrote: > > > > Am Montag, den 23.01.2017, 19:36 +0100 schrieb Lukáš Lalinský: > > > > > > I have uploaded both captures here - &g

NAPI on USB network drivers

2017-01-25 Thread Oliver Neukum
Hi, looking at r8152 I noticed that it uses NAPI. I never considered this for the generic USB networking code as you cannot disable interrupts for USB. Is it still worth it? What are the benefits? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-08 Thread Oliver Neukum
On Thu, 2016-09-08 at 13:58 +0200, Wim Osterholt wrote: > L.S. > > up to vanilla kernel 4.7.3 I've seen no problems. > On two different dekstops running vanilla kernel-4.8 I can force a > crash by > inserting an USB-modem that requires module cdc_acm.ko . > (Strangely enough that doesn't happen on

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-08 Thread Oliver Neukum
On Thu, 2016-09-08 at 14:58 +0200, Wim Osterholt wrote: > On Thu, Sep 08, 2016 at 02:20:38PM +0200, Oliver Neukum wrote: > > > > > > The oops tells things that I didn't all write down, but it says > > > null pointer dereference at 0246 > > > &

Re: [PATCH net-next 0/3] r8152: configuration setting

2016-09-08 Thread Oliver Neukum
On Thu, 2016-09-08 at 13:02 +, Hayes Wang wrote: > I tested above method before. And I found that the cdc_ether > was loaded before switching the configuration. The behavior > of loading one driver and changing to another driver has > opportunity to let our some previous chips become abnorma

Re: [uas] ORICO 2588US3 USB HDD enclosure goes offline after idle

2016-09-12 Thread Oliver Neukum
On Fri, 2016-09-09 at 04:03 +0300, Dmitry Gutov wrote: > On 06.09.2016 12:56, Oliver Neukum wrote: > > > Could you apply the attached patch, > > Thanks, will do as soon as I have a chance to reboot. > > > enable SCSI logging (with > > scsi_logging_level) a

[PATCH] scsi: introduce a quirk for false cache reporting

2016-09-12 Thread Oliver Neukum
Some SATA to USB bridges fail to cooperate with some drives resulting in no cache being present being reported to the host. That causes the host to skip sending a command to synchronize caches. That causes data loss when the drive is powered down. Signed-off-by: Oliver Neukum Reviewed-by: Martin

Re: [PATCH 2/3] cdc-acm: cleanup debugging in submission path

2016-09-12 Thread Oliver Neukum
On Fri, 2016-09-09 at 14:15 +0200, Greg KH wrote: > On Wed, Sep 07, 2016 at 02:30:02PM +0200, Oliver Neukum wrote: > > Actually make it retutn useful information. > > > > Signed-off-by: Oliver Neukum > > --- > > drivers/usb/class/cdc-acm.c | 8 > &

[PATCH 2/2] cdc-acm: cleaning up debug in data submission path

2016-09-13 Thread Oliver Neukum
Further cleanup making the debug messages more precise, useful and removing mere trace points. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc

[PATCH 1/2] cdc-acm: cleanup debugging in submission path

2016-09-13 Thread Oliver Neukum
Actually make it retutn useful information. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index fef0d8f..faab151 100644 --- a/drivers/usb/class

Re: VL805 USB 3.0 does not see connected devices (only on x86_64) (x86 is ok)

2016-09-14 Thread Oliver Neukum
On Wed, 2016-09-14 at 15:22 +0300, c400 wrote: > may be i can help to test something else? I am ready and have enough free time You may need to mount debugfs at /sys/kernel/debug HTH Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the bo

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-19 Thread Oliver Neukum
On Sun, 2016-09-18 at 19:48 +1200, Pierre de Villemereuil wrote: > Dear kernel devs, > > I'm using openSUSE Tumbleweed (kernel 4.7.2-2-default) on an ASUS Vivobook > Flip TP301UA-C4028T, see here for specs: > https://www.asus.com/Notebooks/ASUS-VivoBook-Flip-TP301UA/specifications/ > > Since my

Re: [PATCH] usb: misc: legousbtower: Fix NULL pointer deference

2016-09-20 Thread Oliver Neukum
On Tue, 2016-09-20 at 08:22 +0200, Greg KH wrote: > When you sent this the last time (back on Sept 2), I sent you a > "simpler" patch, the same one below, and asked you if that worked > instead. I never heard back, could you test this patch and see if it > resolves the issue for you? As far as I

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-20 Thread Oliver Neukum
On Tue, 2016-09-20 at 11:11 +1200, Pierre de Villemereuil wrote: > Dear Oliver, > > Sorry about my last message, the bug is actually still going on. I found > something interesting though: when AC is plugged, USB is working totally OK, > but when on battery, then here comes trouble... Could this

Re: cdc_acm bug? read buffer bytes shifted

2016-09-20 Thread Oliver Neukum
On Fri, 2016-09-16 at 18:24 +0200, Julio Guerra wrote: > > On Sat, 2016-08-20 at 14:14 +0200, Julio Guerra wrote: > Another example: > > 00 00 00 00 00 00 00 01 > ... > > 01 00 00 00 00 00 00 00 > ... > > 00 01 00 00 00 00 00 00 > ... > > 00 00 01 00 00 00 00 00

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-09-20 Thread Oliver Neukum
On Tue, 2016-09-20 at 20:58 +1200, Pierre de Villemereuil wrote: > Hi Oliver! > > Here you are. > > dmesg signals when plugging AC in: > http://paste.opensuse.org/57485b34 > > dmesg signals when unplugging AC: > http://paste.opensuse.org/5a8e9910 > > And just in case, dmesg signals when pluggin

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-20 Thread Oliver Neukum
On Mon, 2016-09-19 at 14:02 -0400, Alan Stern wrote: > > We can for sure enable autosuspend for the sdmmc device, although as > > soon as an SD card will be detected the rtsx driver will increase > the > > runtime PM usage count. The count is decreased when the card is > > removed (or failed to be

Re: 4.8-rc: runtime PM trying to activate child device host6 but parent (2-1.2:1.0) is not active

2016-09-20 Thread Oliver Neukum
On Tue, 2016-09-20 at 14:11 +0200, Carsten Mattner wrote: > 4.8-rc5 was fine, but 4.8-rc6 and 4.8-rc7 on a Lenovo Thinkpad x220 report > this > warning or error (cannot tell) anytime a USB mass storage device is inserted > into a usb port (2.0 or 3.0): > > runtime PM trying to activate child devi

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-20 Thread Oliver Neukum
On Mon, 2016-09-12 at 04:43 +0200, Wim Osterholt wrote: > > A laptop, more broken than the rest, does not output anything after > inserting. Later on it crashes. No system.map file in /boot. > After booting with the dongle inserted it spits out: I cannot replicate it. Could you please provide "ls

[PATCH] cdc-acm: hardening against malicious devices

2016-09-20 Thread Oliver Neukum
This should fix the last holes against malicious devices still open in cdc-acm. It cannot go into stable due to the introduction of the common parser. The fix for stable already merged also covers the problems this patch fixes. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 5

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-21 Thread Oliver Neukum
On Tue, 2016-09-20 at 10:12 -0400, Alan Stern wrote: > On Tue, 20 Sep 2016, Oliver Neukum wrote: > That shouldn't be an issue in this case, at least, not with the current > code. The sdmmc and memstick drivers block autosuspend if media is > present. Good. > &g

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-21 Thread Oliver Neukum
On Tue, 2016-09-20 at 17:45 +0200, Wim Osterholt wrote: > On Tue, Sep 20, 2016 at 03:05:14PM +0200, Oliver Neukum wrote: > > > > I cannot replicate it. Could you please provide "lsusb -v"? > > > > Regards > > Oliver > > It concer

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-21 Thread Oliver Neukum
On Thu, 2016-08-18 at 13:50 +0300, Binyamin Sharet wrote: > On 08/18/2016 01:31 PM, Oliver Neukum wrote: > > On Wed, 2016-08-17 at 14:34 +0300, Binyamin Sharet wrote: > >>> After connecting such a device, NULL pointer dereference in the > >> kernel. > >>>

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
On Thu, 2016-09-22 at 09:53 +0300, Binyamin Sharet wrote: > On Wed, Sep 21, 2016 at 11:09 PM, Malcolm Priestley > wrote: > > > Malcolm, just to make it clear, this bug was not found with an > actual device, but with emulation. It was quite peculiar a bug, though. Could you prepare a test kernel

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
On Thu, 2016-09-22 at 10:50 +0300, Binyamin Sharet wrote: > On Thu, Sep 22, 2016 at 10:35 AM, Oliver Neukum wrote: > > On Thu, 2016-09-22 at 09:53 +0300, Binyamin Sharet wrote: > >> On Wed, Sep 21, 2016 at 11:09 PM, Malcolm Priestley > >> wrote: > >> > &g

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
On Thu, 2016-09-22 at 14:46 +0300, Binyamin Sharet wrote: > On Thu, Sep 22, 2016 at 11:18 AM, Binyamin Sharet > wrote: > > On Thu, Sep 22, 2016 at 11:02 AM, Oliver Neukum wrote: > >> On Thu, 2016-09-22 at 10:50 +0300, Binyamin Sharet wrote: > >>> On Thu, Sep 22

Re: [PATCH] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing led

2016-09-22 Thread Oliver Neukum
On Wed, 2016-09-21 at 10:35 -0400, Alan Stern wrote: > On Wed, 21 Sep 2016, Oliver Neukum wrote: > > Yes, but this is not the point. A heuristic with a timeout makes > > sense only if the uses are unpredictable. If you know with a high > > degree of probability when the nex

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-22 Thread Oliver Neukum
tch? Regards Oliver From e0f6d09babd9f30d952389ff98a2a25df9a158a5 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Thu, 22 Sep 2016 16:22:06 +0200 Subject: [PATCH] vt6656: avoid double free This data structure is fred in disconnect(). It must not be freed earlier. Signed-off-by: Oliver

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-22 Thread Oliver Neukum
On Wed, 2016-09-21 at 18:41 +0200, Wim Osterholt wrote: > On Wed, Sep 21, 2016 at 02:21:17PM +0200, Oliver Neukum wrote: > > in sysfs. > > Google pointed me to /sys/bus/usb/drivers/usb/* > where I find all kinds of 'bConfigurationValue'. > Now is the problem t

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Oliver Neukum
On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: > > On 22/09/16 20:50, Malcolm Priestley wrote: > > > > > > On 22/09/16 15:25, Oliver Neukum wrote: > >> On Thu, 2016-09-22 at 14:46 +0300, Binyamin Sharet wrote: > >> > >>>> -- B

Re: [umap2] status of issues

2016-09-26 Thread Oliver Neukum
On Fri, 2016-09-02 at 12:41 +, Binyamin Sharet (bsharet) wrote: > Hi, > Here are the sources of the issues that were reproduced: so it seems to me that the current state is: > [02/11][10cf:5500] drivers/staging/comedi/drivers/vmk80xx.c open > [04/11][0557:2002] drivers/net/usb/kaweth.c fi

Re: [Umap2][7/11][160a:3184] NULL pointer dereference

2016-09-26 Thread Oliver Neukum
On Mon, 2016-09-26 at 18:57 +0100, Malcolm Priestley wrote: > > On 26/09/16 09:48, Oliver Neukum wrote: > > On Sat, 2016-09-24 at 01:21 +0100, Malcolm Priestley wrote: > >> > >> On 22/09/16 20:50, Malcolm Priestley wrote: > >>> > >>> >

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-09-28 Thread Oliver Neukum
On Tue, 2016-09-27 at 18:34 +0200, Wim Osterholt wrote: > On Thu, Sep 22, 2016 at 04:40:50PM +0200, Oliver Neukum wrote: > > > > dmesg -c > > echo 9 > /proc/sysrq-trigger > > modprobe cdc_acm > > echo "module cdc_acm +mpf" > /sys/kernel/debug/dy

<    1   2   3   4   5   6   7   8   9   10   >