Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the deferred modules will try to probe again. This is to check back if the

[PATCH] USB: musb: Correct Kconfig in order to avoid non compilable selection

Currently it is possible to have: USB_MUSB_OMAP2PLUS=m TWL4030_USB=y which would result compile time error due to missing symbols. With this change USB_MUSB_OMAP2PLUS and TWL4030_USB will be in sync. Reported-by: Vincent Stehle v-ste...@ti.com Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com

Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data

On 03/12/2013 04:20 PM, Roger Quadros wrote: Adding Peter to the loop. I faintly remember him mentioning this issue before for beagle. We really need the deferred probe mechanism or we need to resort to device registering order. Yes, BeagleBoard is a good example. Long story short: we have

[PATCH] usb: otg: twl4030: Change TWL4030_MODULE_* ids to TWL_MODULE_*

To facilitate upcoming cleanup in twl stack. No functional changes. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/usb/otg/twl4030-usb.c | 46 --- 1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/drivers/usb/otg/twl4030

Re: [PATCH] usb: otg: twl4030: Change TWL4030_MODULE_* ids to TWL_MODULE_*

Hi Felipe, On 11/13/2012 10:47 AM, Felipe Balbi wrote: On Tue, Nov 13, 2012 at 10:43:38AM +0100, Peter Ujfalusi wrote: To facilitate upcoming cleanup in twl stack. No functional changes. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com I guess this one must go together with the rest

Re: [PATCH] usb: otg: twl4030: Change TWL4030_MODULE_* ids to TWL_MODULE_*

On 11/13/2012 11:37 AM, Felipe Balbi wrote: ok good. Unfortunately I have already sent this merge window's pull request to Greg so I'd have to delay this until v3.9. If that's ok with you, I can take it through my tree. I hoped that this can go with 3.8 since in 3.9 I'm planning to remove all

Re: [PATCH v5 5/6] usb: musb: cppi_dma: Clean up tusb_omap_dma structure

On 01/25/2017 12:17 PM, Alexandre Bailon wrote: > A pointer to musb is now present in the dma_controller structure. > Remove the one present in tusb_omap_dma structure. the subject line should be: usb: musb: tusb6010_omap: ... > Signed-off-by: Alexandre Bailon > --- >

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

On 2017-04-05 10:13, Peter Ujfalusi wrote: I had similar hunch first, but did not worked. I have tested this patch and did not helped. To be precise this is what I have tried: - boot w/o cable connected - boot w/ board connected to PC (device mode) - boot w/ OTG-A cable with USB keyboard - boot

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

Tony, On 2017-04-05 03:36, Tony Lindgren wrote: * Tony Lindgren <t...@atomide.com> [170404 07:06]: * Bin Liu <b-...@ti.com> [170404 05:30]: On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: Tony, since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb

usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

Tony, since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb is compiled in. The kernel will stuck printing: ** 206 printk messages dropped ** [8.926727] musb_bus_suspend 2584: trying to suspend as a_idle while active The bisect (log is [1]) points to: d8e5f0eca1e8 usb:

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

Tony, On 04/05/2017 06:29 PM, Tony Lindgren wrote: * Tony Lindgren <t...@atomide.com> [170405 06:53]: * Peter Ujfalusi <peter.ujfal...@ti.com> [170405 00:15]: To be precise this is what I have tried: - boot w/o cable connected - boot w/ board connected to PC (device mode) -

Re: [PATCH] usb: musb: Fix trying to suspend while active for OTG configurations

this case just seems to completely confuse the musb state machine. Let's fix the issue by making musb_host_setup() attempt to force the mode only if port_mode is configured for host mode. Tested-by: Peter Ujfalusi <peter.ujfal...@ti.com> Fixes: d8e5f0eca1e8 ("usb: musb: Fix hardirq-safe hardi

Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

Bin, On 2017-05-11 17:12, Bin Liu wrote: which is valid. So will you update the patch to move the declaration to the beginning of the function to avoid this WARNING. I would just fix it locally if you prefer. I was waiting for Vinod or someone from the DMAengine guys to say something for

[PATCH v2 00/10] usb: musb: tusb6010_omap: Convert to DMAengine

e" size=1 fi done echo "Test ran up to $size" Regards, Peter CC: dmaeng...@vger.kernel.org I only send the cover letter and the DMAengine patch for the dmaengine list, the rest can be checked - if there is interest - via lkml --- Peter Ujfalusi (10): dmaengine:

[PATCH v2 08/10] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well

Handle the DMA TX in a similar way as we do for the RX: in the DMA completion callback. Since we are no longer using DMA completion interrupt for the TX we can as wall keep these interrupts disabled, but keep the handler for debug purposes. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.

[PATCH v2 10/10] usb: musb: tusb6010_omap: Convert to DMAengine API

With the port_window support in DMAengine and the sDMA driver we can convert the driver to DMAengine. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/tusb6010_omap.c | 201 --- 1 file changed, 80 insertions(+), 121 deletions(-)

[PATCH v2 06/10] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi <peter.uj

[PATCH v2 01/10] dmaengine: omap-dma: port_window support correction for both direction

are settings for the slave port while the omap_sg members apply to the memory side of the sDMA setup. Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support") Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Cc: Russell King <li...@armlinux.org.uk> Cc: dma

[PATCH v2 09/10] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines

is not yet supports DT boot. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- arch/arm/mach-omap2/dma.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index e58c13a9bea5..0b77a0176018 100644 --- a/arch/ar

[PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

We have one register for each EP to set the maximum packet size for both TX and RX. If for example an RX programming would happen before the previous TX transfer finishes we would reset the TX packet side. To fix this issue, only modify the TX or RX part of the register. Signed-off-by: Peter

[PATCH v2 02/10] usb: musb: Add quirk to avoid skb reserve in gadget mode

buffer. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/musb_core.c | 3 +++ drivers/usb/musb/musb_core.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 870da18f5077..87cbd56cc761

[PATCH v2 03/10] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks

When using the g_ncm for networking this flag will make sure that the buffer is alligned to 32bit so the DMA can be used to offload the data movement. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/tusb6010.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[PATCH v2 07/10] usb: musb: tusb6010_omap: Allocate DMA channels upfront

to lock within the DMAengine API when requesting channel. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/tusb6010_omap.c | 184 +++ 1 file changed, 92 insertions(+), 92 deletions(-) diff --git a/drivers/usb/musb/tusb6010_om

[PATCH v2 04/10] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program

Having one musb_ep_select() instead the two calls in if/else is the same thing, but makes the code a bit simpler to follow. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/tusb6010_omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drive

Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

On 2017-05-11 02:16, Joe Perches wrote: On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote: On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote: We have one register for each EP to set the maximum packet size for both TX and RX. If for example an RX programming would happen before

[PATCH] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

("USB: Add MUSB and TUSB support") Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- Bin, I have separated the patch from the tusb DMAengine conversion series and that will depend on this patch. Regards, Peter drivers/usb/mus

[PATCH v3 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi <peter.uj

[PATCH v3 1/9] dmaengine: omap-dma: port_window support correction for both direction

are settings for the slave port while the omap_sg members apply to the memory side of the sDMA setup. Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support") Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Cc: Russell King <li...@armlinux.org.uk> Cc: dma

[PATCH v3 7/9] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well

Handle the DMA TX in a similar way as we do for the RX: in the DMA completion callback. Since we are no longer using DMA completion interrupt for the TX we can as wall keep these interrupts disabled, but keep the handler for debug purposes. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.

[PATCH v3 9/9] usb: musb: tusb6010_omap: Convert to DMAengine API

With the port_window support in DMAengine and the sDMA driver we can convert the driver to DMAengine. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010_omap.c | 201 ---

[PATCH v3 8/9] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines

is not yet supports DT boot. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Acked-by: Tony Lindgren <t...@atomide.com> --- arch/arm/mach-omap2/dma.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index

[PATCH v3 2/9] usb: musb: Add quirk to avoid skb reserve in gadget mode

buffer. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_core.c | 3 +++ drivers/usb/musb/musb_core.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_

[PATCH v3 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program

Having one musb_ep_select() instead the two calls in if/else is the same thing, but makes the code a bit simpler to follow. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010_omap.c | 3 +-- 1 file changed,

[PATCH v3 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks

When using the g_ncm for networking this flag will make sure that the buffer is alligned to 32bit so the DMA can be used to offload the data movement. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010.c | 3

[PATCH v3 6/9] usb: musb: tusb6010_omap: Allocate DMA channels upfront

to lock within the DMAengine API when requesting channel. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010_omap.c | 184 +++ 1 file changed, 92 insertions(+), 92 deleti

[PATCH v3 0/9] usb: musb: tusb6010_omap: Convert to DMAengine

send the cover letter and the DMAengine patch for the dmaengine list, the rest can be checked - if there is interest - via lkml --- Peter Ujfalusi (9): dmaengine: omap-dma: port_window support correction for both direction usb: musb: Add quirk to avoid skb reserve in gadget mode usb: m

[PATCH v4 6/9] usb: musb: tusb6010_omap: Allocate DMA channels upfront

to lock within the DMAengine API when requesting channel. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010_omap.c | 185 +++ 1 file changed, 92 insertions(+), 93 deleti

[PATCH v4 5/9] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.

[PATCH v4 8/9] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines

is not yet supports DT boot. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Acked-by: Tony Lindgren <t...@atomide.com> --- arch/arm/mach-omap2/dma.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index

[PATCH v4 1/9] dmaengine: omap-dma: port_window support correction for both direction

are settings for the slave port while the omap_sg members apply to the memory side of the sDMA setup. Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support") Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Cc: Russell King <li...@armlinux.org.uk> Cc: dma

[PATCH v4 9/9] usb: musb: tusb6010_omap: Convert to DMAengine API

With the port_window support in DMAengine and the sDMA driver we can convert the driver to DMAengine. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010_omap.c | 201 ---

[PATCH v4 7/9] usb: musb: tusb6010: Handle DMA TX completion in DMA callback as well

Handle the DMA TX in a similar way as we do for the RX: in the DMA completion callback. Since we are no longer using DMA completion interrupt for the TX we can as wall keep these interrupts disabled, but keep the handler for debug purposes. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.

[PATCH v4 0/9] usb: musb: tusb6010_omap: Convert to DMAengine

be checked - if there is interest - via lkml --- Peter Ujfalusi (9): dmaengine: omap-dma: port_window support correction for both direction usb: musb: Add quirk to avoid skb reserve in gadget mode usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks usb: musb: tu

[PATCH v4 2/9] usb: musb: Add quirk to avoid skb reserve in gadget mode

buffer. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_core.c | 3 +++ drivers/usb/musb/musb_core.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_

[PATCH v4 4/9] usb: musb: tusb6010_omap: Use one musb_ep_select call in tusb_omap_dma_program

Having one musb_ep_select() instead the two calls in if/else is the same thing, but makes the code a bit simpler to follow. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010_omap.c | 3 +-- 1 file changed,

[PATCH v4 3/9] usb: musb: tusb6010: Add MUSB_G_NO_SKB_RESERVE to quirks

When using the g_ncm for networking this flag will make sure that the buffer is aligned to 32bit so the DMA can be used to offload the data movement. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/tusb6010.c | 3

[PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine

alse; +// if (dma_addr & 0x2) +// return false; /* * Because of HW issue #10, it seems like mixing sync DMA and async Since this condition will almost all the time was true - effectively disabling the DMA use. Regards. Peter --- Peter Ujfalusi (4): u

[PATCH 2/4] usb: musb: tusb6010_omap: Allocate DMA channels upfront

to lock within the DMAengine API when requesting channel. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/tusb6010_omap.c | 184 +++ 1 file changed, 92 insertions(+), 92 deletions(-) diff --git a/drivers/usb/musb/tusb6010_om

[PATCH 1/4] usb: musb: tusb6010_omap: Create new struct for DMA data/parameters

For the DMA we have ch (channel), dmareq and sync_dev parameters both within the tusb_omap_dma_ch and tusb_omap_dma_ch struct. By creating a common struct the code can be simplified when selecting between the shared or multichannel DMA parameters. Signed-off-by: Peter Ujfalusi <peter.uj

[PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

With the port_window support in DMAengine and the sDMA driver we can convert the driver to DMAengine. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- drivers/usb/musb/tusb6010_omap.c | 201 --- 1 file changed, 80 insertions(+), 121 deletions(-)

[PATCH 3/4] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines

is not yet supports DT boot. Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> --- arch/arm/mach-omap2/dma.c | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index e58c13a9bea5..0b77a0176018 100644 --- a/arch/ar

Re: [PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine

Sorry, I have forgot to update the commit message for the last patch. On 2017-05-03 13:54, Peter Ujfalusi wrote: Hi, With port_window support implemented in DMAengine and the sDMA DMAengine driver, the tusb6010_omap driver can be converted away from the custom legacy omap-dma API to generic

[PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine

alse; +// if (dma_addr & 0x2) +// return false; /* * Because of HW issue #10, it seems like mixing sync DMA and async Since this condition will almost all the time was true - effectively disabling the DMA use. Regards. Peter --- Peter Ujfalusi (4): u

Re: [PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine

On 2017-05-04 17:31, Tony Lindgren wrote: * Peter Ujfalusi <peter.ujfal...@ti.com> [170503 04:00]: Hi, With port_window support implemented in DMAengine and the sDMA DMAengine driver, the tusb6010_omap driver can be converted away from the custom legacy omap-dma API to generic DMA

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

On 2017-05-05 16:37, Peter Ujfalusi wrote: Tony, On 2017-05-05 00:05, Tony Lindgren wrote: * Tony Lindgren <t...@atomide.com> [170504 12:43]: Hi, * Peter Ujfalusi <peter.ujfal...@ti.com> [170503 04:00]: With the port_window support in DMAengine and the sDMA driver we

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

Tony, On 2017-05-05 00:05, Tony Lindgren wrote: * Tony Lindgren <t...@atomide.com> [170504 12:43]: Hi, * Peter Ujfalusi <peter.ujfal...@ti.com> [170503 04:00]: With the port_window support in DMAengine and the sDMA driver we can convert the driver to DMAengine. Actuall

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

Tony, On 2017-05-06 01:55, Tony Lindgren wrote: OK I verified that with the current mainline kernel using dma and g_ether and your patches 1 to 3 I can run the variable size ping test loop for few minutes before it just stops working and I can see the legacy DMA interrupt increase depending on

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

;>> through all of these files in order to see what does it mean: >> >> Yeah, 644 is "clear", but _RW() is even more clear. Ideally I want to >> get rid of all of the "non-standard" users that set random modes of >> sysfs files, as we get it wr

Re: [PATCH] dma: cppi41: delete channel from pending list when stop channel

Hi, On 28/11/2018 13.15, Peter Ujfalusi wrote: forgot to fix up Vinod's email address. > > > On 12/11/2018 17.40, Bin Liu wrote: > > Can you fix up the subject line to: > dmaengine: ti: cppi4: delete channel from pending list when stop channel > >> The driver defi

Re: [PATCH] dma: cppi41: delete channel from pending list when stop channel

on the channel, so clearing the pending list is the correct thing to do. With the fixed subject: Reviewed-by: Peter Ujfalusi I have one question: > Fixes: 975faaeb9985 ("dma: cppi41: start tear down only if channel is busy") > Cc: sta...@vger.kernel.org # v3.15+ > Signed-of