Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

* Bin Liu [170404 05:30]: > On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: > > Tony, > > > > since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the musb > > is compiled in. The kernel will stuck printing: > > > > ** 206 printk messages dropped ** [

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

Hi, * Kishon Vijay Abraham I <kis...@ti.com> [170330 04:51]: > On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > > Seems this can be also done when implementing PM runtime handling. > > If you want some of these changes done for the initial patch, > > please let

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Moreno Bartalucci [170327 23:12]: > > Il giorno 27 mar 2017, alle ore 19:15, Bin Liu ha scritto: > > > > […] > > > > The MUSB otg state machine has been changed in many place since the last > > time I looked at it, and I am not sure how exactly

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Bin Liu <b-...@ti.com> [170327 10:17]: > On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote: > > * Moreno Bartalucci <moreno.bartalu...@tecnorama.it> [170327 09:23]: > > > If I understood your patch, however, if the device (anyone, not just my > >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Moreno Bartalucci [170327 09:23]: > If I understood your patch, however, if the device (anyone, not just my one) > takes longer to switch, VBUS is deasserted anyway. Yeah some of them can take at least 10 seconds even to enumerate. So probably we need to have

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

* Kishon Vijay Abraham I <kis...@ti.com> [170326 23:27]: > On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote: > > +static const struct phy_ops ops = { > > + .owner = THIS_MODULE, > > +}; > > Given that this phy doesn't have any phy_ops, Is

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Bin Liu [170327 06:22]: > On Mon, Mar 27, 2017 at 02:53:27PM +0200, Moreno Bartalucci wrote: > > > Il giorno 25 mar 2017, alle ore 08:21, Lars Melin ha > > > scritto: > > > > > >> > > >> The usb device has been disconnected, why it still cares about VBUS > >

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

url: > https://github.com/0day-ci/linux/commits/Tony-Lindgren/phy-cpcap-usb-Add-CPCAP-PMIC-USB-support/20170324-061112 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git > next > config: x86_64-randconfig-a0-03260238 (attached as .config) > compile

[PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

are done using cpcap-adc IIO ADC driver. Cc: devicet...@vger.kernel.org Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Tested-by: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Changes since v1: - Use ii

Re: [PATCH] phy: cpcap-usb: Add CPCAP PMIC USB support

* Sebastian Reichel <s...@kernel.org> [170321 19:20]: > Hi, > > On Thu, Mar 16, 2017 at 08:51:52PM -0700, Tony Lindgren wrote: > > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > > multiplexing USB PHY. > > > > This USB PHY can o

[PATCH] phy: cpcap-usb: Add CPCAP PMIC USB support

are done using cpcap-adc IIO ADC driver. Cc: devicet...@vger.kernel.org Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Cc: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t...@atomide.com> --- .../devicetree/bindings/phy/phy-

Re: [PATCH] usb: musb: fix possible spinlock deadlock

26.609407]SyS_delete_module+0x11c/0x1e4 > [ 126.614252]__sys_trace_return+0x0/0x10 > > Fixes: ea2f35c01d5ea ("usb: musb: Fix sleeping function called from invalid > context for hdrc glue") > Cc: <sta...@vger.kernel.org> #4.9+ > Signed-off-by: Bin Liu

Re: v4.9 to v4.10 regression: oops when USB cable is plugged in.

* Pavel Machek [170203 00:00]: > Hi! > > > On Fri, Jan 27, 2017 at 10:55:12PM +0100, Pavel Machek wrote: > > > Ok, I can try. But so far even -rc1 is a lot of fun. But... I consider > > > phone calls core feature of a phone. I'd very much like to get that to > > > work.

Re: [PATCH 6/8] ARM: dts: dra7x-evm: Enable dual-role mode for USB1

* Roger Quadros [170123 03:21]: > USB1 port is micro-AB type and can function as peripheral > as well as host. Enable dual-role mode for USB1. Good to see this happening :) Can you please send the dts changes separately after the driver changes have gotten merged? Meanwhile I'll

Re: v4.9 to v4.10 regression: oops when USB cable is plugged in.

* Pali Rohár <pali.ro...@gmail.com> [170124 02:02]: > On Tuesday 24 January 2017 10:18:17 Pavel Machek wrote: > > Hi! > > On Mon 2017-01-23 14:44:54, Tony Lindgren wrote: > > > * Pavel Machek <pa...@ucw.cz> [170123 14:26]: > > > > [25392.239837]

Re: v4.9 to v4.10 regression: oops when USB cable is plugged in.

* Pavel Machek [170123 14:26]: > [25392.239837] Unhandled fault: external abort on non-linefetch (0x1028) at > 0xfa0ab060 > [25392.239868] pgd = c0004000 > [25392.239898] [fa0ab060] *pgd=48011452(bad) > [25392.239929] Internal error: : 1028 [#1] ARM > [25392.239929] Modules linked

Re: [PATCHv4 3/2] dmaengine: cppi41: Clean up pointless warnings

* Bin Liu <b-...@ti.com> [170120 13:08]: > On Fri, Jan 20, 2017 at 12:07:53PM -0800, Tony Lindgren wrote: > > With patches "dmaengine: cppi41: Fix runtime PM timeouts with USB mass > > storage", and "dmaengine: cppi41: Fix oops in cppi41_runtime_resume", &

Re: [PATCH] usb: phy: Implement am335x advisory 1.0.34

* Bin Liu <b-...@ti.com> [170120 12:32]: > On Fri, Jan 20, 2017 at 12:01:04PM -0800, Tony Lindgren wrote: > > I noticed in sprz360i.pdf there's "Advisory 1.0.34 USB2PHY: Register > > Accesses After a USB Subsystem Soft Reset May Lock Up the Entire System" > >

[PATCHv4 3/2] dmaengine: cppi41: Clean up pointless warnings

get pointless error -115 when musb is configured as a usb peripheral. That's because we should now check for the state of is_suspended instead. Let's just remove the now useless code and replace it with a WARN(). Signed-off-by: Tony Lindgren <t...@atomide.com> --- Found one more cosmetic iss

[PATCH] usb: phy: Implement am335x advisory 1.0.34

e PM, let's also add runtime PM to the phy driver. This way we have have them all behave the same way. Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/phy/phy-am335x.c | 61 +--- 1 file changed, 58 insertions(+), 3 deletions(-) diff -

[PATCH] usb: musb: Fix external abort on non-linefetch for musb_irq_work()

[] (process_one_work+0x2b4/0x808) [] (process_one_work) from [] (worker_thread+0x3c/0x550) [] (worker_thread) from [] (kthread+0x104/0x148) [] (kthread) from [] (ret_from_fork+0x14/0x24) Signed-off-by: Tony Lindgren <t...@atomide.com> --- I found one more corner case issue in my usb cable plugfest yes

Re: [PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

* Bin Liu <b-...@ti.com> [170120 09:24]: > On Thu, Jan 19, 2017 at 08:56:46AM -0800, Tony Lindgren wrote: > > * Alexandre Bailon <abai...@baylibre.com> [170119 06:09]: > > > The DMA may hung up if a teardown is initiated while an endpoint is still > > >

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

* Bin Liu <b-...@ti.com> [170119 09:16]: > On Thu, Jan 19, 2017 at 08:15:45AM -0800, Tony Lindgren wrote: > > * Tony Lindgren <t...@atomide.com> [170119 07:57]: > > > * Bin Liu <b-...@ti.com> [170119 07:14]: > > > > On Thu, Jan 19, 2017 at 07:04:57AM

[PATCH 2/2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

vchenko <andy.shevche...@gmail.com> Cc: Bin Liu <b-...@ti.com> Cc: Grygorii Strashko <grygorii.stras...@ti.com> Cc: Kevin Hilman <khil...@baylibre.com> Cc: Patrick Titiano <ptiti...@baylibre.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reported-by:

Re: [PATCH v3 0/4] dmaengine: cppi41: Make CPPI 4.1 driver more generic

* Alexandre Bailon [170119 02:38]: > - Make CPPI 4.1 driver compatible with old and new binddings. Thanks for fixing that, that removes a dependency with the dts changes. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

[PATCHv4 0/2] cppi41 dma fixes for v4.10-rc cycle

, and fixed with the second patch in this series. That's minimal v4 version of the "dmaengine: cppi41: Fix oops in cppi41_runtime_resume" patch. Regards, Tony Tony Lindgren (2): dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage dmaengine: cppi41: Fix oops in cp

Re: [PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

* Alexandre Bailon [170119 06:09]: > The DMA may hung up if a teardown is initiated while an endpoint is still > active (Advisory 2.3.27 of DA8xx errata). > To workaround this issue, add a delay before to initiate the teardown. > > Signed-off-by: Alexandre Bailon

[PATCH 1/2] dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage

lt;khil...@baylibre.com> Cc: Patrick Titiano <ptiti...@baylibre.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/dma/cppi41.c | 16 1 file changed, 16 insertions(+) diff --git a/drive

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

* Tony Lindgren <t...@atomide.com> [170119 07:57]: > * Bin Liu <b-...@ti.com> [170119 07:14]: > > On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > > > * Bin Liu <b-...@ti.com> [170118 19:42]: > > > > On Wed, Jan 18, 2017 at 06:29:59P

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

* Bin Liu <b-...@ti.com> [170119 07:14]: > On Thu, Jan 19, 2017 at 07:04:57AM -0800, Tony Lindgren wrote: > > * Bin Liu <b-...@ti.com> [170118 19:42]: > > > On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote: > > > > At least with the cppi41 d

Re: [PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

* Bin Liu <b-...@ti.com> [170118 19:42]: > On Wed, Jan 18, 2017 at 06:29:59PM -0800, Tony Lindgren wrote: > > At least with the cppi41 dma, size 1 in dma transfers will just wait > > In which case do you see the size 1 transfer? using testusb? > > > until the devic

[PATCH 1/2] usb: musb: Fix host mode error -71 regression

code that no longer is needed. Fixes: 467d5c980709 ("usb: musb: Implement session bit based runtime PM for musb-core") Reported-by: Bin Liu <b-...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_core.c | 15 ++- drivers/usb/m

[PATCH 2/2] usb: musb: Size 1 dma in transfers won't complete with cpp41

Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_cppi41.c | 1 + drivers/usb/musb/musb_dma.h| 3 +++ drivers/usb/musb/musb_host.c | 16 +++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/mu

[PATCHv2 0/2] Two musb fixes for v4.10-rc cycle

separately with a cpp41 flag and don't trash the TX registers in RX dma quirk - Limit quirk to cpp41 in dma sizes 0 - 1 only - Update description accordingly Tony Lindgren (2): usb: musb: Fix host mode error -71 regression usb: musb: Size 1 dma in transfers won't complete with cpp41

Re: [PATCH 2/2] usb: musb: Tiny dma in transfers won't complete with cpp41

* Tony Lindgren <t...@atomide.com> [170118 16:50]: > At least with the cppi41 dma, size 1 in dma transfers will just wait > until the device is disconnected. And it also seems that enumerating > a USB stick with a hub can take a USB reset with smallish size in > transfers

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170118 13:14]: > On Wed, Jan 18, 2017 at 12:48:59PM -0800, Tony Lindgren wrote: > > And here's a fix for the error -71 regression. > > > > Bin, can you review and test your earlier case mentioned in > > commit 9298b4aad37e ("us

[PATCH 2/2] usb: musb: Tiny dma in transfers won't complete with cpp41

size of 16 which is based on my obeservations on BeagleBone to make enumerating more reliable. Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_host.c | 9 - 1 file changed, 8

[PATCH 0/2] Two musb fixes for v4.10-rc cycle

Hi all, Here are two fixes for v4.10-rc cycle to deal with error -75 and -115 issues when plugging in USB mass storage device to a hub. Note that I will also post two cppi41 dma related patches, but those can be applied separately. Regards, Tony Tony Lindgren (2): usb: musb: Fix host mode

[PATCH 1/2] usb: musb: Fix host mode error -71 regression

code that no longer is needed. Fixes: 467d5c980709 ("usb: musb: Implement session bit based runtime PM for musb-core") Reported-by: Bin Liu <b-...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_core.c | 15 ++- drivers/usb/m

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170118 10:49]: > On Wed, Jan 18, 2017 at 10:44:32AM -0800, Tony Lindgren wrote: > > * Tony Lindgren <t...@atomide.com> [170118 10:15]: > > > * Grygorii Strashko <grygorii.stras...@ti.com> [170118 10:05]: > > > > > &

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko [170118 11:18]: > Just thinking, may be cppi41 should not be platform device at all > and it might be reasonable to have it as lib with > cppi41_init()/cppi41_remove(), > so musb SoC glue layer will initialize it, because it provides services to >

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko <grygorii.stras...@ti.com> [170118 10:05]: > > > On 01/18/2017 10:53 AM, Tony Lindgren wrote: > > Hi, > > > > * Bin Liu <b-...@ti.com> [170118 06:26]: > >> With this v3, I still get -71 error when a device is plugged

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170118 10:43]: > On Wed, Jan 18, 2017 at 08:53:09AM -0800, Tony Lindgren wrote: > > Hi, > > > > * Bin Liu <b-...@ti.com> [170118 06:26]: > > > With this v3, I still get -71 error when a device is plugged to a hub to > >

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren <t...@atomide.com> [170118 10:15]: > * Grygorii Strashko <grygorii.stras...@ti.com> [170118 10:05]: > > > > > > On 01/18/2017 10:53 AM, Tony Lindgren wrote: > > > Hi, > > > > > > * Bin Liu <b-...@ti.com> [17011

Re: [PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

and don't have dma requests lingering. Care to try the updated patch below? It won't help with the -71 issue but the $subject issue should be fixed. And you should not see the WARN() trigger with your tests presumably. Regards, Tony 8< ---- >From tony Mon Sep 17 00:00:00 2001

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170117 11:47]: > On Tue, Jan 17, 2017 at 09:39:23AM -0800, Tony Lindgren wrote: > > * Bin Liu <b-...@ti.com> [170117 08:49]: > > > On Tue, Jan 17, 2017 at 08:31:03AM -0800, Tony Lindgren wrote: > > > > * Bin Liu <b-...@ti.

[PATCHv3] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

lt;khil...@baylibre.com> Cc: Patrick Titiano <ptiti...@baylibre.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reported-by: Alexandre Bailon <abai...@baylibre.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Here's what I think we should merge as a

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170117 08:49]: > On Tue, Jan 17, 2017 at 08:31:03AM -0800, Tony Lindgren wrote: > > * Bin Liu <b-...@ti.com> [170117 08:22]: > > > On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > > > > * Bin Liu <b-...@ti.

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170117 08:22]: > On Tue, Jan 17, 2017 at 08:11:39AM -0800, Tony Lindgren wrote: > > * Bin Liu <b-...@ti.com> [170117 05:00]: > > > On Mon, Jan 16, 2017 at 03:54:29PM -0800, Tony Lindgren wrote: > > > > Anyways, for the -rc seri

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Bin Liu <b-...@ti.com> [170117 05:00]: > On Mon, Jan 16, 2017 at 03:54:29PM -0800, Tony Lindgren wrote: > > Anyways, for the -rc series oops, we can just leave out the WARN_ON > > parts for now until drivers/usb/musb/musb_cppi41.c is fixed too. > > Giving that cppi is

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren <t...@atomide.com> [170116 15:36]: > * Tony Lindgren <t...@atomide.com> [170113 14:00]: > > * Grygorii Strashko <grygorii.stras...@ti.com> [170113 13:37]: > > > > Simplified diff with fix on top of your patch: > > > > > > &

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren <t...@atomide.com> [170113 14:00]: > * Grygorii Strashko <grygorii.stras...@ti.com> [170113 13:37]: > > > Simplified diff with fix on top of your patch: > > > > > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > > > in

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko [170113 13:37]: > > Simplified diff with fix on top of your patch: > > > > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c > > index ce37a1a..9e9403a 100644 > > --- a/drivers/dma/cppi41.c > > +++ b/drivers/dma/cppi41.c > > @@ -319,12 +319,6

Re: [PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko <grygorii.stras...@ti.com> [170113 10:37]: > > > On 01/13/2017 12:01 PM, Tony Lindgren wrote: > > Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") > > together with recent MUSB changes allowed USB and DMA on

[PATCHv2] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

vchenko <andy.shevche...@gmail.com> Cc: Bin Liu <b-...@ti.com> Cc: Grygorii Strashko <grygorii.stras...@ti.com> Cc: Kevin Hilman <khil...@baylibre.com> Cc: Patrick Titiano <ptiti...@baylibre.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reported-by:

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko <grygorii.stras...@ti.com> [170113 09:37]: > On 01/13/2017 10:17 AM, Tony Lindgren wrote: > > But anyways here's your basic idea plugged into my recent patch and > > it seems to work. I maybe have missed something though while readin

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren <t...@atomide.com> [170113 08:27]: > @@ -316,11 +318,12 @@ static irqreturn_t cppi41_irq(int irq, void *data) > __iormb(); > > while (val) { > + unsigned long flags; >

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Tony Lindgren <t...@atomide.com> [170112 16:04]: > * Grygorii Strashko <grygorii.stras...@ti.com> [170112 15:43]: > > @@ -457,38 +449,36 @@ static void push_desc_queue(struct cppi41_channel *c) > > cppi_writel(reg, cdd->qmgr_mem + QMGR_QUEUE_D(c->q_num

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Sergei Shtylyov [170113 01:25]: > > @@ -320,7 +323,8 @@ static irqreturn_t cppi41_irq(int irq, void *data) > > int error; > > > > error = pm_runtime_get(cdd->ddev.dev); > > - if (error < 0) > > +

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko [170112 15:43]: > @@ -457,38 +449,36 @@ static void push_desc_queue(struct cppi41_channel *c) > cppi_writel(reg, cdd->qmgr_mem + QMGR_QUEUE_D(c->q_num)); > } > > -static void pending_desc(struct cppi41_channel *c) > +static void

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko <grygorii.stras...@ti.com> [170112 14:53]: > > > On 01/12/2017 04:19 PM, Tony Lindgren wrote: > > * Grygorii Strashko <grygorii.stras...@ti.com> [170112 13:54]: > >> On 01/12/2017 03:30 PM, Tony Lindgren wrote: > >> > >>

Re: [PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

* Grygorii Strashko <grygorii.stras...@ti.com> [170112 13:54]: > On 01/12/2017 03:30 PM, Tony Lindgren wrote: > > Sry, but even if it looks better it might still race with PM runtime :( > > > - if (likely(pm_runtime_active(cdd->ddev.dev))) > > +

[PATCHv2] usb: musb: Add support for optional VBUS irq to dsps glue layer

when the am335x internal PM coprocessor provides us with an IRQ chip. For now, we still need to poll for the host mode status. Signed-off-by: Tony Lindgren <t...@atomide.com> --- Changes since v1: - Updated based on comments from Bin mostly to limit to peripheral mode only --- drivers/us

[PATCH] dmaengine: cppi41: Fix oops in cppi41_runtime_resume

Cc: Grygorii Strashko <grygorii.stras...@ti.com> Cc: Kevin Hilman <khil...@baylibre.com> Cc: Patrick Titiano <ptiti...@baylibre.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reported-by: Alexandre Bailon <abai...@baylibre.com> S

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

* Alexandre Bailon [170112 09:42]: > This solves the issue but I still have a bad playback quality. > I don't remember if I have spoken about it so I will describe it. > When I play audio (with your patch or mine), the music cut a lot. > The issue go away when the MUSB

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

* Grygorii Strashko <grygorii.stras...@ti.com> [170112 09:24]: > On 01/12/2017 11:09 AM, Tony Lindgren wrote: > > Below is what seems to fix issues for me, not seeing any more warnings > > either. > > > > Care to give it a try with your USB headset? > > Th

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

* Tony Lindgren <t...@atomide.com> [170109 10:35]: > Hi, > > * Alexandre Bailon <abai...@baylibre.com> [170109 09:04]: > > Sometime, a transfer may not be queued due to a race between runtime pm > > and cppi41_dma_issue_pending(). > > Sometime, cppi41_ru

Re: [PATCH] usb: musb: Add support for optional VBUS irq to dsps glue layer

* Bin Liu <b-...@ti.com> [170111 05:42]: > On Tue, Jan 10, 2017 at 01:53:53PM -0600, Bin Liu wrote: > > On Thu, Jan 05, 2017 at 11:12:59AM -0800, Tony Lindgren wrote: > > > We can now configure the PMIC interrupt to provide us VBUS > > > events. In that case

Re: [PATCH 08/11] dmaengine: cppi41: Implement the glue for da8xx

* Alexandre Bailon [170110 07:23]: > On 01/10/2017 11:05 AM, Sekhar Nori wrote: > > On DA8xx, CPPI 4.1 DMAengine is not an independent system resource, but > > embedded within the USB 2.0 controller. So, I think all that is needed > > is for MUSB DA8xx glue to trigger probe

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

* Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> [170109 10:55]: > On 01/09/2017 09:43 PM, Tony Lindgren wrote: > > > > > da8xx driver is registering and using the cppi dma controller but > > > > actually, > > > > the da8xx has a cppi41 dma c

Re: [PATCH 1/4] usb: musb: da8xx: Use the right dma controller

* Sergei Shtylyov [170109 10:30]: > Hello! > > On 01/09/2017 07:38 PM, Alexandre Bailon wrote: > > > da8xx driver is registering and using the cppi dma controller but actually, > > the da8xx has a cppi41 dma controller. > > Update the driver to register and

Re: [PATCH v2 2/2] dmaengine: cppi41: Ignore EINPROGRESS for PM runtime in interrupt handler

* Alexandre Bailon [170109 09:04]: > We can occasionally get -EINPROGRESS for pm_runtime_get. > This is happening when an interrupt is fired before PM runtime had time > to update the PM state to RESUMED. > In that case, don't print any error. Hmm if the cppi41 interrupt

Re: [PATCH v2 1/2] dmaengine: cppi41: Fix list not empty warning on runtime suspend

Hi, * Alexandre Bailon [170109 09:04]: > Sometime, a transfer may not be queued due to a race between runtime pm > and cppi41_dma_issue_pending(). > Sometime, cppi41_runtime_resume() may be interrupted right before to > update device PM state to RESUMED. > When it happens,

Re: [PATCH] usb: musb: Add support for optional VBUS irq to dsps glue layer

* Tony Lindgren <t...@atomide.com> [170105 11:14]: > We can now configure the PMIC interrupt to provide us VBUS > events. In that case we don't need to constantly poll the > status and can make it optional. This is only wired up > for the mini-B interface on beaglebone. > &

[PATCH] usb: musb: Add support for optional VBUS irq to dsps glue layer

when the am335x internal PM coprocessor provides us with an IRQ chip. For now, we still need to poll for the host mode status. Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_dsps.c | 114 ++- 1 file changed, 90 insertions(

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

* Aaro Koskinen [170103 12:13]: > On Tue, Jan 03, 2017 at 08:05:04PM +0100, Greg Kroah-Hartman wrote: > > I'm not objecting to this patch, just really curious why no one else has > > ever hit it. > > Maybe I'm the only user... I still have 770 in my test rack :) I don't

Re: [PATCH 03/16] usb: musb: Fix trying to free already-free IRQ 4

* Bin Liu <b-...@ti.com> [170103 10:35]: > Tony, > > On Tue, Jan 03, 2017 at 04:36:14PM +0100, Greg KH wrote: > > On Tue, Jan 03, 2017 at 09:15:08AM -0600, Bin Liu wrote: > > > From: Tony Lindgren <t...@atomide.com> > > > > > > W

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

* Ladislav Michl [161220 10:41]: > Hi Laurent, > > On Sat, Nov 12, 2016 at 03:21:24AM +0200, Laurent Pinchart wrote: > > Hi Bin, > > > > http://pandaboard.org/sites/default/files/board_reference/ES/750-2170-002-sch_revb.pdf > > > > It would seem that the voltage is

Re: [PATCH] usb: musb: fix runtime PM in debugfs

* Bin Liu <b-...@ti.com> [161219 12:46]: > MUSB driver now has runtime PM support, but the debugfs driver misses > the PM _get/_put() calls, which could cause MUSB register access > failure. Acked-by: Tony Lindgren <t...@atomide.com> -- To unsubscribe from this list: send

Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode

* Pali Rohár <pali.ro...@gmail.com> [161214 07:40]: > On Wednesday 14 December 2016 16:34:31 Tony Lindgren wrote: > > * Pali Rohár <pali.ro...@gmail.com> [161214 06:48]: > > > > We need this because and this allows debugging problems related > > to .

Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode

* Pali Rohár [161214 06:48]: We need this because and this allows debugging problems related to ...? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2] usb: dwc3: omap: fix race of pm runtime with irq handler in probe

; > ^^ IRQs are disabled in HW, but handler may still run > of_platform_depopulate(omap->dev); > pm_runtime_put_sync(>dev); > ^^ PM runtime can race with IRQ handler > pm_runtime_disable(>dev); > > return 0; > > So, OMAP DWC3 IRQ need to be disabled befo

Re: [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq

* Grygorii Strashko <grygorii.stras...@ti.com> [161209 15:32]: > > > On 12/09/2016 05:04 PM, Tony Lindgren wrote: > > * Grygorii Strashko <grygorii.stras...@ti.com> [161209 14:46]: > >> > >> > >> On 12/09/2016 03:59 PM, Tony Lindgren wrot

Re: [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq

* Grygorii Strashko <grygorii.stras...@ti.com> [161209 14:46]: > > > On 12/09/2016 03:59 PM, Tony Lindgren wrote: > > * Grygorii Strashko <grygorii.stras...@ti.com> [161209 12:55]: > > > Switch back from devm_request_threaded_irq() to request_threaded_irq() to

Re: [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq

* Grygorii Strashko [161209 12:55]: > Switch back from devm_request_threaded_irq() to request_threaded_irq() to > avoid races between interrupt handler execution and PM runtime in error > handling code path in probe and in dwc3_omap_remove(): Can't you just call

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Roger Quadros <rog...@ti.com> [161209 08:09]: > Hi Tony, > > On 08/12/16 05:21, Tony Lindgren wrote: > > Somehow starting with v4.9-rc7 there have been imprecise > > external aborts on omap5-uevm dwc3 controller. I have not been > > able to bisect what

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Grygorii Strashko <grygorii.stras...@ti.com> [161208 15:38]: > On 12/08/2016 04:57 PM, Tony Lindgren wrote: > > Seems to work based on few boot tests. Probably both should be applied, > > my original patch to prevent spurious interrupts before things are > > initializ

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Grygorii Strashko <grygorii.stras...@ti.com> [161208 13:54]: > Hi Tony, > > On 12/08/2016 09:37 AM, Tony Lindgren wrote: > > * Felipe Balbi <ba...@kernel.org> [161208 01:45]: > >> Tony Lindgren <t...@atomide.com> writes: > >>> So

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Felipe Balbi <ba...@kernel.org> [161208 12:10]: > > Hi, > > Tony Lindgren <t...@atomide.com> writes: > >> nothing against it. Would be nice if TI could confirm this is needed and > >> check if other families might also need it. > > > &g

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Felipe Balbi <ba...@kernel.org> [161208 12:12]: > > Hi, > > Tony Lindgren <t...@atomide.com> writes: > > * Felipe Balbi <ba...@kernel.org> [161208 11:17]: > >> Tony Lindgren <t...@atomide.com> writes: > >> > The call to pm_runtim

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Felipe Balbi <ba...@kernel.org> [161208 11:17]: > Tony Lindgren <t...@atomide.com> writes: > > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it. > > right, but there's no runtime suspend until ->remove(). IOW, after > pm_runtime_get_sync(), al

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Felipe Balbi <ba...@kernel.org> [161208 11:19]: > > Hi, > > Tony Lindgren <t...@atomide.com> writes: > >> Is there also some dwc3 internal clock? If we assume the usb_otg_ss > >> module is properly enabled it could be some dwc3 internal clo

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Tony Lindgren <t...@atomide.com> [161208 10:45]: > * Tony Lindgren <t...@atomide.com> [161208 10:25]: > > * Felipe Balbi <ba...@kernel.org> [161208 09:52]: > > > > > > Hi, > > > > > > Tony Lindgren <t...@atomide.co

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

* Laurent Pinchart <laurent.pinch...@ideasonboard.com> [161208 04:03]: > Hi Tony, > > On Wednesday 07 Dec 2016 21:51:23 Tony Lindgren wrote: > > * Laurent Pinchart <laurent.pinch...@ideasonboard.com> [161123 08:44]: > > > On Wednesday 23 Nov 2016 18:40:09 Tomi

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Tony Lindgren <t...@atomide.com> [161208 10:25]: > * Felipe Balbi <ba...@kernel.org> [161208 09:52]: > > > > Hi, > > > > Tony Lindgren <t...@atomide.com> writes: > > > * Felipe Balbi <ba...@kernel.org> [161208 01:45]: > > >

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Felipe Balbi <ba...@kernel.org> [161208 09:52]: > > Hi, > > Tony Lindgren <t...@atomide.com> writes: > > * Felipe Balbi <ba...@kernel.org> [161208 01:45]: > >> > >> Hi, > >> > >> Tony Lindgren <t...@atomide.c

Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

* Felipe Balbi <ba...@kernel.org> [161208 01:45]: > > Hi, > > Tony Lindgren <t...@atomide.com> writes: > > Somehow starting with v4.9-rc7 there have been imprecise > > There's nothing touching dwc3 since v4.9-rc5. Right, nothing obvious has changed. I th

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

* Laurent Pinchart <laurent.pinch...@ideasonboard.com> [161123 08:44]: > Hello, > > On Wednesday 23 Nov 2016 18:40:09 Tomi Valkeinen wrote: > > On 23/11/16 18:34, Tony Lindgren wrote: > > > OK. And what changes to your current .config make the musb_bus_

[PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

Cc: Roger Quadros <rog...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/dwc3/dwc3-omap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/

[PATCH] usb: musb: Fix trying to free already-free IRQ 4

[] (musb_remove+0xf0/0x12c [musb_hdrc]) [] (musb_remove [musb_hdrc]) from [] (platform_drv_remove+0x24/0x3c) ... This is because the irq number in use is 260 nowadays, and the dma controller is using u8 instead of int. Signed-off-by: Tony Lindgren <t...@atomide.com> --- Found one more

<    1   2   3   4   5   6   7   >