Re: [PATCH] MIPS: OCTEON: Platform support for DWC3 USB controller.

2017-01-06 Thread Aaro Koskinen
Hi, On Fri, Jan 06, 2017 at 05:42:24PM -0600, Steven J. Hill wrote: > Add all the necessary platform code to initialize the dwc3 > USB host controller found on OCTEON III processors. This > code initializes the clocks and resets the USB core with > PHYs. It is then passed off to the platform

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

2017-01-03 Thread Aaro Koskinen
Hi, On Tue, Jan 03, 2017 at 08:05:04PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote: > > On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: &

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

2017-01-03 Thread Aaro Koskinen
Hi, On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs > > to be loaded to get the PHY going and ohci-omap should

[PATCH] USB: ohci-omap: defer probe if PHY is missing

2017-01-02 Thread Aaro Koskinen
Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs to be loaded to get the PHY going and ohci-omap should wait for those. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/usb/host/ohci-omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [PATCH] usb: phy-omap-otg: Space required after that ','.

2016-05-31 Thread Aaro Koskinen
Hi, On Tue, May 31, 2016 at 08:59:44AM -0400, Sandhya Bankar wrote: > Space required after that ','. > > Signed-off-by: Sandhya Bankar <bankarsandhya...@gmail.com> Reviewed-by: Aaro Koskinen <aaro.koski...@iki.fi> A. > --- > drivers/usb/phy/phy-omap-otg.c

[PATCH] USB: MUSB: fail with error when no DMA controller set

2015-11-23 Thread Aaro Koskinen
Fail with error when no DMA controller is set. Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 18cfc0a..f8d3b40 100644 --- a/drivers/us

[PATCH] usb: phy: omap-otg: fix uninitialized pointer

2015-10-27 Thread Aaro Koskinen
otg_dev->extcon was referenced before otg_dev was initialized. Fix. Cc: sta...@vger.kernel.org Fixes: a2fd2423240f ("usb: phy: omap-otg: Replace deprecated API of extcon") Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> --- drivers/usb/phy/phy-omap-otg.c | 2 +- 1 file c

Re: tools: usbip: detach: avoid calling strlen() at each iteration

2015-09-15 Thread Aaro Koskinen
Hi, On Tue, Sep 15, 2015 at 09:27:20PM +0100, Eric Curtin wrote: > Instead of calling strlen on every iteration of the for loop, just call it > once and cache the result in a temporary local variable which will be used > in the for loop instead. > > Signed-off-by: Eric Curtin

Re: [PATCH, RESEND] usb: musb: fix Kconfig regression

2015-02-27 Thread Aaro Koskinen
: start using the control module driver) Acked-by: Acked-by: Pavel Machek pa...@ucw.cz Cc: sta...@vger.kernel.org # v3.9+ This patch allows me to disable redundant CONFIG_OMAP_CONTROL_PHY from 4.0-rc1 .config and still get a working USB on Nokia N9. So: Tested-by: Aaro Koskinen aaro.koski...@iki.fi

Re: [PATCH 0/3] USB: host: Misc patches to remove hard-coded octeon platform information

2014-11-14 Thread Aaro Koskinen
caviumnetworks account] I've tested it only on an EdgeRouterPro (Octeon II system, which I have on-site). I have also tested them on EdgeRouter Pro. Thanks, this is great improvement. Tested-by: Aaro Koskinen aaro.koski...@iki.fi A. -- To unsubscribe from this list: send the line unsubscribe

Re: RCU bug with v3.17-rc3 ?

2014-10-10 Thread Aaro Koskinen
On Fri, Oct 10, 2014 at 05:18:35PM +0100, Russell King - ARM Linux wrote: On Fri, Oct 10, 2014 at 12:47:06AM +0300, Aaro Koskinen wrote: On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: What GCC version are you using? 4.8.1 and 4.8.2 are known to miscompile the ARM

Re: RCU bug with v3.17-rc3 ?

2014-10-09 Thread Aaro Koskinen
Hi, On Thu, Oct 09, 2014 at 10:41:01PM +0200, Rabin Vincent wrote: What GCC version are you using? 4.8.1 and 4.8.2 are known to miscompile the ARM kernel and these find_get_entry() crashes with 0x involved smell a lot like the earlier reports from kernels build with those

Re: [PATCH] staging: octeon-usb: prevent memory corruption

2014-05-26 Thread Aaro Koskinen
On Fri, May 23, 2014 at 11:17:18AM +0400, Sergey Popov wrote: On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote: scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 ANSI: 5 sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB) usb 1-1: reset

Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API

2014-04-22 Thread Aaro Koskinen
Hi, On Tue, Apr 22, 2014 at 08:21:35AM +0200, Robert Baldyga wrote: On 04/19/2014 12:52 PM, Aaro Koskinen wrote: On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote: dev_info(pdev-dev, - OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n, - (rev 4

Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API

2014-04-19 Thread Aaro Koskinen
Hi, On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote: dev_info(pdev-dev, - OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n, - (rev 4) 0xf, rev 0xf, config-extcon, otg_dev-id, + OMAP USB OTG controller rev %d.%d (id=%d,

Re: [PATCH 05/13] extcon: extcon-class: improve extcon client API

2014-04-10 Thread Aaro Koskinen
Hi, On Thu, Apr 10, 2014 at 03:16:43PM +0200, Robert Baldyga wrote: +struct extcon_cable *extcon_get_cable_by_name(struct device *dev, + const char *name) +{ + return of_extcon_get_cable_by_name(dev-of_node, name); +}

Re: [PATCH] staging: octeon-usb: prevent memory corruption

2014-03-23 Thread Aaro Koskinen
Hi, On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote: scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 ANSI: 5 sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB) usb 1-1: reset high-speed USB device number 2 using OcteonUSB usb 1-1: reset

[PATCH] staging: octeon-usb: prevent memory corruption

2014-03-19 Thread Aaro Koskinen
and SLUB kernels. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=72121 Reported-by: Sergey Popov pinkb...@gentoo.org Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/staging/octeon-usb/octeon-hcd.c | 108 1 file changed, 108 insertions(+) diff --git

Re: Panic during booting Octeon-based router

2014-03-16 Thread Aaro Koskinen
attach my kernel config as well. Apropriate bugreport on - https://bugzilla.kernel.org/show_bug.cgi?id=72121 You should report this to the person responsible for the OcteonUSB driver, Aaro Koskinen (CC'ed). I'm looking into this. As a quick workaround, try switching CONFIG_SLOB - SLUB

Re: [PATCH 23/28] Remove MACH_OMAP_H4_OTG

2014-02-09 Thread Aaro Koskinen
On Sun, Feb 09, 2014 at 07:48:01PM +0100, Richard Weinberger wrote: The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger rich...@nod.at Acked-by: Aaro Koskinen aaro.koski...@iki.fi A. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

[PATCH 3/3] usb: phy: fix some Kconfig descriptions

2013-12-21 Thread Aaro Koskinen
Some module names are not up to date in Kconfig help texts. Fix that. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 54bebba39e91

[PATCH 1/3] usb: phy-tahvo: fix smatch warnings

2013-12-21 Thread Aaro Koskinen
by deleting bogus NULL pointer checks. The USB framework will always call us with a valid OTG pointer. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/phy-tahvo.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 2/3] usb: phy-isp1301-omap: fix smatch warnings

2013-12-21 Thread Aaro Koskinen
checks. The USB framework will always call us with a valid OTG pointer. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/phy-isp1301-omap.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy

[PATCH 0/3] usb: minor phy fixes

2013-12-21 Thread Aaro Koskinen
Hi, Here's some minor fixes for next/3.14. Aaro Koskinen (3): usb: phy-tahvo: fix smatch warnings usb: phy-isp1301-omap: fix smatch warnings usb: phy: fix some Kconfig descriptions drivers/usb/phy/Kconfig| 6 +++--- drivers/usb/phy/phy-isp1301-omap.c | 9 - drivers

Re: [PATCH v4 4/4] USB: OMAP1: Tahvo USB transceiver driver

2013-12-07 Thread Aaro Koskinen
Hi, On Fri, Dec 06, 2013 at 02:46:29PM -0600, Felipe Balbi wrote: On Fri, Dec 06, 2013 at 04:13:07PM +0200, Aaro Koskinen wrote: Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs

[PATCH v4 1/4] ARM: OMAP1: USB: move omap_usb_config to platform data

2013-12-06 Thread Aaro Koskinen
Move omap_usb_config to platform data, so that OTG driver can include it. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap1/include/mach/usb.h | 38 +--- include/linux/platform_data/usb-omap1.h | 51

[PATCH v4 0/4] USB: OMAP1: Tahvo USB support for 770

2013-12-06 Thread Aaro Koskinen
=137081763029385w=2 Earlier RFC versions: http://marc.info/?l=linux-omapm=13655371679w=2 http://marc.info/?l=linux-omapm=136266725827698w=2 Aaro Koskinen (4): ARM: OMAP1: USB: move omap_usb_config to platform data USB: OMAP1: add extcon to platform data USB: OMAP1: OTG

[PATCH v4 2/4] USB: OMAP1: add extcon to platform data

2013-12-06 Thread Aaro Koskinen
Add extcon field to platform data. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- include/linux/platform_data/usb-omap1.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/platform_data/usb-omap1.h b/include/linux/platform_data/usb-omap1.h index 8c7764ddd284

[PATCH v4 4/4] USB: OMAP1: Tahvo USB transceiver driver

2013-12-06 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- Documentation/ABI/testing/sysfs-platform-tahvo-usb | 16 + drivers/usb/phy/Kconfig

Re: ARM: v3.13-rc1: USB regression

2013-11-25 Thread Aaro Koskinen
Hi, On Sun, Nov 24, 2013 at 10:43:59PM +, Russell King - ARM Linux wrote: On Mon, Nov 25, 2013 at 12:22:47AM +0200, Aaro Koskinen wrote: [ 33.967324] ohci ohci: Coherent DMA mask 0x (pfn 0xe-0xe) covers a smaller range of system memory than the DMA zone pfn 0x0

Re: ARM: v3.13-rc1: USB regression

2013-11-25 Thread Aaro Koskinen
Hi, On Mon, Nov 25, 2013 at 05:18:53PM +, Russell King - ARM Linux wrote: On Mon, Nov 25, 2013 at 06:33:02PM +0200, Aaro Koskinen wrote: Hi, On Sun, Nov 24, 2013 at 10:43:59PM +, Russell King - ARM Linux wrote: On Mon, Nov 25, 2013 at 12:22:47AM +0200, Aaro Koskinen wrote

ARM: v3.13-rc1: USB regression

2013-11-24 Thread Aaro Koskinen
Hi, With 3.13-rc1, the USB OHCI probe fails on Amstrad E3 (ARM/OMAP1) as follows: [ 33.814705] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [ 33.821482] ohci-omap: OHCI OMAP driver [ 33.925153] ohci ohci: OMAP OHCI [ 33.929087] ohci ohci: new USB bus registered, assigned bus

[PATCH] USB: phy-generic: fix nop xceiv probe

2013-11-15 Thread Aaro Koskinen
-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/phy-generic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index fce3a9e..834dc98 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -252,6

USB regression in v3.12-rc4

2013-10-12 Thread Aaro Koskinen
Hi, With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB (peripheral, g_ether). According to git bisect this is caused by: 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 Author: Bin Liu b-...@ti.com Date: Tue Sep 17

Re: USB regression in v3.12-rc4

2013-10-12 Thread Aaro Koskinen
Hi, On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote: With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB (peripheral, g_ether). To clarify, I was running v3.12-rc4 on N800/peripheral side and that's where the problem is; on host side I'm running some old Debian kernel

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-18 Thread Aaro Koskinen
Hi, On Sat, Aug 17, 2013 at 08:44:18PM +, Paul Zimmerman wrote: It doesn't get very far: External DMA Mode not supported dwc2_hcd_init() FAILED, returning -22 Hi Greg, all, After taking a look at the Octeon driver, it looks like that controller uses a customized

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-17 Thread Aaro Koskinen
On Fri, Aug 16, 2013 at 08:02:27PM -0700, Greg KH wrote: dcw2 already supports different boards/systems, so perhaps there's a way to tie your board into that? It doesn't get very far: External DMA Mode not supported dwc2_hcd_init() FAILED, returning -22 A. -- To unsubscribe

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2013 at 06:01:50AM -0700, Greg KH wrote: It was just pointed out to me by Sebastian that it looks like both the octeon-usb and dwc2 drivers in drivers/staging/ are for the same exact hardware core. Were you two aware of this? It was mentioned here:

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
On Fri, Aug 16, 2013 at 08:51:57PM +, Paul Zimmerman wrote: From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] Sent: Friday, August 16, 2013 1:45 PM On Fri, Aug 16, 2013 at 06:35:10PM +, Paul Zimmerman wrote: Aaro, I would ask you the same question. Is the Octeon driver fully

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2013 at 06:35:10PM +, Paul Zimmerman wrote: Aaro, I would ask you the same question. Is the Octeon driver fully functional? Are there any shortcomings with it that you know about? I sent this driver when mainlining the support for EdgeRouter Lite

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2013 at 10:39:39AM -0700, Greg KH wrote: As the dwc2 code seems to be the more mature codebase, any objection to me deleting the octeon-usb driver? If it's possible to get it working on Octeon HW, then having a single driver is of course the best solution. Is dwc2

Re: [PATCH 0/2] ARM: OMAP: fix USB regression on Nokia boards

2013-08-15 Thread Aaro Koskinen
Hi, On Tue, Aug 06, 2013 at 08:06:14PM +0300, Aaro Koskinen wrote: USB subsystem changes broke the USB peripheral/gadget on N800, N810 and RX-51/N900 during the merge window. We need to fix this in board files. I tested all these with 3.11-rc4 + g_ether + ssh. Ping? A. Aaro Koskinen (1

[PATCH 1/2] ARM: omap2: fix musb usage for n8x0

2013-08-06 Thread Aaro Koskinen
just pass MUSB_OTG as mode from board files. Signed-off-by: Daniel Mack zon...@gmail.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap2/board-n8x0.c | 4 arch/arm/mach-omap2/usb-musb.c | 5 + 2 files changed, 1

[PATCH 0/2] ARM: OMAP: fix USB regression on Nokia boards

2013-08-06 Thread Aaro Koskinen
Hi, USB subsystem changes broke the USB peripheral/gadget on N800, N810 and RX-51/N900 during the merge window. We need to fix this in board files. I tested all these with 3.11-rc4 + g_ether + ssh. Aaro Koskinen (1): ARM: OMAP: rx51: change musb mode to OTG Daniel Mack (1): ARM: omap2: fix

[PATCH 2/2] ARM: OMAP: rx51: change musb mode to OTG

2013-08-06 Thread Aaro Koskinen
Peripheral-only mode got broken in v3.11-rc1 because of unknown reasons. Change the mode to OTG, in practice that should work equally well even when/if the regression gets fixed. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap2/board-rx51.c | 2 +- 1 file changed, 1

Re: v3.11-rc1 USB regressions

2013-07-24 Thread Aaro Koskinen
Hi, On Tue, Jul 16, 2013 at 08:57:10PM +0300, Aaro Koskinen wrote: On Tue, Jul 16, 2013 at 08:33:06AM +0200, Daniel Mack wrote: fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 usb: musb: gadget: remove hcd initialization (Reverting this fixes error cdc_ether: probe of 4-1:1.0 failed

Re: v3.11-rc1 USB regressions

2013-07-24 Thread Aaro Koskinen
Hi, On Wed, Jul 24, 2013 at 09:04:28PM +0200, Daniel Mack wrote: On 24.07.2013 20:51, Aaro Koskinen wrote: When I revert fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 and 8b125df5b24cfb0ec7fa1971e343cc0badc1827d, it works like before (3.10): I'm now running -rc2 with above fixes and reverts

Re: v3.11-rc1 USB regressions

2013-07-16 Thread Aaro Koskinen
Hi, On Tue, Jul 16, 2013 at 08:33:06AM +0200, Daniel Mack wrote: fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 usb: musb: gadget: remove hcd initialization (Reverting this fixes error cdc_ether: probe of 4-1:1.0 failed with error -110 seen on the host side.) Which role does

Re: v3.11-rc1 USB regressions

2013-07-16 Thread Aaro Koskinen
Hi, On Tue, Jul 16, 2013 at 11:22:47AM +0300, Felipe Balbi wrote: On Tue, Jul 16, 2013 at 12:30:00PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 16 July 2013 12:03 PM, Daniel Mack wrote: Hi Aaro, On 16.07.2013 00:56, Aaro Koskinen wrote: Hi, I think USB tree

Re: v3.11-rc1 USB regressions

2013-07-16 Thread Aaro Koskinen
On Tue, Jul 16, 2013 at 08:30:21PM +0200, Daniel Mack wrote: On 16.07.2013 20:26, Aaro Koskinen wrote: Hi, On Tue, Jul 16, 2013 at 11:22:47AM +0300, Felipe Balbi wrote: On Tue, Jul 16, 2013 at 12:30:00PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 16 July 2013 12:03 PM, Daniel Mack

v3.11-rc1 USB regressions

2013-07-15 Thread Aaro Koskinen
Hi, I think USB tree introduced regressions in v3.11-rc1, at least for some OMAP devices using legacy boot. I have only bisected these; I have no idea what the real fixes are but the following reverts make Nokia OMAP2+ boards again usable for kernel development work (they need working USB

Re: [PATCH v3 4/4] USB: OMAP1: Tahvo USB transceiver driver

2013-07-08 Thread Aaro Koskinen
Hi, On Mon, Jul 08, 2013 at 10:21:09AM +0300, Felipe Balbi wrote: On Tue, Jun 18, 2013 at 08:07:01PM +0300, Aaro Koskinen wrote: +static ssize_t vbus_state_show(struct device *device, + struct device_attribute *attr, char *buf) +{ + struct tahvo_usb *tu

Re: [PATCH v2 3/5] USB: OMAP1: OTG controller driver

2013-06-18 Thread Aaro Koskinen
Hi, On Tue, Jun 18, 2013 at 11:21:43AM +0300, Felipe Balbi wrote: On Sun, Jun 16, 2013 at 04:35:10PM +0300, Aaro Koskinen wrote: +#include mach/usb.h no mach/* includes under drivers/usb, sorry. It's a pain to fix those up later. Sorry, that was left there by a mistake. I will fix

[PATCH v3 2/4] USB: OMAP1: add extcon to platform data

2013-06-18 Thread Aaro Koskinen
Add extcon field to platform data. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- include/linux/platform_data/usb-omap1.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/platform_data/usb-omap1.h b/include/linux/platform_data/usb-omap1.h index 8c7764d..43b5ce1 100644

[PATCH v3 3/4] USB: OMAP1: OTG controller driver

2013-06-18 Thread Aaro Koskinen
Transceivers need to manage OTG controller state on OMAP1 to enable switching between peripheral and host modes. Provide a driver for that. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig| 10 +++ drivers/usb/phy/Makefile | 1 + drivers/usb/phy/phy

[PATCH v3 1/4] ARM: OMAP1: USB: move omap_usb_config to platform data

2013-06-18 Thread Aaro Koskinen
Move omap_usb_config to platform data, so that OTG driver can include it. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap1/include/mach/usb.h | 38 +--- include/linux/platform_data/usb-omap1.h | 51

[PATCH v3 0/4] USB: OMAP1: Tahvo USB support for 770

2013-06-18 Thread Aaro Koskinen
=13655371679w=2 http://marc.info/?l=linux-omapm=136266725827698w=2 Aaro Koskinen (4): ARM: OMAP1: USB: move omap_usb_config to platform data USB: OMAP1: add extcon to platform data USB: OMAP1: OTG controller driver USB: OMAP1: Tahvo USB transceiver driver arch/arm/mach-omap1/include/mach

[PATCH v3 4/4] USB: OMAP1: Tahvo USB transceiver driver

2013-06-18 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig | 14 ++ drivers/usb/phy/Makefile| 1 + drivers/usb

[PATCH v2 2/5] USB: OMAP1: add extcon to platform data

2013-06-16 Thread Aaro Koskinen
Add extcon field to platform data. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- include/linux/platform_data/usb-omap1.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/platform_data/usb-omap1.h b/include/linux/platform_data/usb-omap1.h index 8c7764d..43b5ce1 100644

[PATCH v2 4/5] USB: OMAP1: Tahvo USB transceiver driver

2013-06-16 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig | 14 ++ drivers/usb/phy/Makefile| 1 + drivers/usb

[PATCH v2 5/5] ARM: OMAP1: nokia770: enable Tahvo

2013-06-16 Thread Aaro Koskinen
Add platform data for Tahvo. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap1/board-nokia770.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-omap1/board-nokia770.c b/arch/arm/mach-omap1/board-nokia770.c index 62a15e2..85089d8 100644

[PATCH v2 0/5] USB: OMAP1: Tahvo USB support for 770

2013-06-16 Thread Aaro Koskinen
=linux-omapm=137081763029385w=2 Earlier RFC versions: http://marc.info/?l=linux-omapm=13655371679w=2 http://marc.info/?l=linux-omapm=136266725827698w=2 Aaro Koskinen (5): ARM: OMAP1: USB: move omap_usb_config to platform data USB: OMAP1: add extcon to platform data USB

[PATCH v2 1/5] ARM: OMAP1: USB: move omap_usb_config to platform data

2013-06-16 Thread Aaro Koskinen
Move omap_usb_config to platform data, so that OTG driver can include it. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap1/include/mach/usb.h | 38 +--- include/linux/platform_data/usb-omap1.h | 51 + 2 files changed

[PATCH v2 3/5] USB: OMAP1: OTG controller driver

2013-06-16 Thread Aaro Koskinen
Transceivers need to manage OTG controller state on OMAP1 to enable switching between peripheral and host modes. Provide a driver for that. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig| 10 +++ drivers/usb/phy/Makefile | 1 + drivers/usb/phy/phy

Re: [PATCH 2/3] USB: OMAP: add omap-otg

2013-06-13 Thread Aaro Koskinen
Hi, On Wed, Jun 12, 2013 at 06:13:26PM +0300, Felipe Balbi wrote: On Mon, Jun 10, 2013 at 01:40:05AM +0300, Aaro Koskinen wrote: +void omap_otg_set_mode(enum omap_otg_mode mode) +{ + if (!otg_dev) { + WARN(1, %s: controller not present\n, __func__); + return

[PATCH 0/3] USB: OMAP: Tahvo USB support for 770

2013-06-09 Thread Aaro Koskinen
Hi, These patches add support for Tahvo USB transceiver and allow using both host and peripheral modes on Nokia 770. Tested (peripheral mode, host mode, vbus detection) with 3.10-rc4. Aaro Koskinen (3): ARM: OMAP1: nokia770: enable Tahvo USB: OMAP: add omap-otg USB: OMAP: Tahvo USB

[PATCH 2/3] USB: OMAP: add omap-otg

2013-06-09 Thread Aaro Koskinen
Transceivers need to manage OTG controller state on OMAP1 to enable switching between peripheral and host modes. Provide a driver for that. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig| 10 drivers/usb/phy/Makefile |1 + drivers/usb/phy

[PATCH 1/3] ARM: OMAP1: nokia770: enable Tahvo

2013-06-09 Thread Aaro Koskinen
Add platform data for Tahvo. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap1/board-nokia770.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-omap1/board-nokia770.c b/arch/arm/mach-omap1/board-nokia770.c index 62a15e2..91449c5 100644

[PATCH 3/3] USB: OMAP: Tahvo USB transceiver driver

2013-06-09 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig | 14 ++ drivers/usb/phy/Makefile|1 + drivers/usb

Re: [PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-05 Thread Aaro Koskinen
Hi, On Wed, Jun 05, 2013 at 11:36:46AM +0300, Dan Carpenter wrote: On Wed, Jun 05, 2013 at 12:31:32AM +0300, Aaro Koskinen wrote: -#define CVMX_USBCX_DAINT(block_id) (CVMX_ADD_IO_SEG(0x00016F001818ull) + ((block_id) 1) * 0x1000ull) There should be a few helper macros. OK

[PATCH 0/6] staging: octeon-usb: cvmx-usbcx-defs.h cleanup

2013-06-04 Thread Aaro Koskinen
patches. A. Aaro Koskinen (6): staging: octeon-usb: run cvmx-usbcx-defs.h through Lindent staging: octeon-usb: cvmx-usbcx-defs.h: fix comment style staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines

[PATCH 5/6] staging: octeon-usb: cvmx-usbcx-defs.h: delete CVS keyword marker

2013-06-04 Thread Aaro Koskinen
Delete CVS keyword marker and a comment that the file is autogenerated. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/staging/octeon-usb/cvmx-usbcx-defs.h |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usbcx-defs.h b/drivers/staging

[PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-04 Thread Aaro Koskinen
Avoid long lines in CVMX_USBCX macros. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 208 +++--- 1 file changed, 156 insertions(+), 52 deletions(-) diff --git a/drivers/staging/octeon-usb/cvmx-usbcx-defs.h b/drivers

[PATCH 6/6] staging: octeon-usb: cvmx-usbcx-defs.h: reformat license text to fit 80 cols

2013-06-04 Thread Aaro Koskinen
Reformat the original license text to fit in 80-column terminal. No change in wording. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/octeon-usb

Re: [PATCH] MIPS: OCTEON: Rename Kconfig CAVIUM_OCTEON_REFERENCE_BOARD to CAVIUM_OCTEON_SOC

2013-05-21 Thread Aaro Koskinen
Hi, What about OCTEON_WDT, should it be changed too: tristate Cavium OCTEON SOC family Watchdog Timer depends on CPU_CAVIUM_OCTEON On Mon, May 20, 2013 at 03:19:38PM -0700, David Daney wrote: config OCTEON_MGMT_ETHERNET tristate Octeon Management port ethernet driver

[RFC PATCH v2 0/4] USB: OMAP: Tahvo USB support for 770

2013-04-09 Thread Aaro Koskinen
, not needed - don't write to OTG_SYSCON_1/2, this is handled by board code - move OTG CTRL handling to omap-otg Please review and comment. Thanks, A. Aaro Koskinen (4): retu-mfd: support also Tahvo ARM: OMAP1: nokia770: enable Tahvo USB: OMAP: add omap-otg USB

[RFC PATCH v2 1/4] retu-mfd: support also Tahvo

2013-04-09 Thread Aaro Koskinen
Tahvo is a multi-function device on Nokia 770, implementing USB transceiver and charge/battery control. It's so close to Retu that a single driver can support both. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/Kconfig |6

[RFC PATCH v2 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-04-09 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig | 14 ++ drivers/usb/phy/Makefile|1 + drivers/usb

[RFC PATCH v2 3/4] USB: OMAP: add omap-otg

2013-04-09 Thread Aaro Koskinen
Transceivers need to manage OTG controller state on OMAP1 to enable switching between peripheral and host modes. Provide a driver for that. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/phy/Kconfig| 10 drivers/usb/phy/Makefile |1 + drivers/usb/phy

[RFC PATCH 2/4] ARM: OMAP1: nokia770: enable Tahvo

2013-03-07 Thread Aaro Koskinen
Add platform data for Tahvo. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap1/board-nokia770.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-omap1/board-nokia770.c b/arch/arm/mach-omap1/board-nokia770.c index 62a15e2..91449c5 100644

[RFC PATCH 4/4] USB: OMAP: Tahvo USB transceiver driver

2013-03-07 Thread Aaro Koskinen
Add Tahvo USB transceiver driver. Based on old code from linux-omap tree. The original driver was written by Juha Yrjölä, Tony Lindgren, and Timo Teräs. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/otg/Kconfig | 16 ++ drivers/usb/otg/Makefile|1 + drivers/usb

[RFC PATCH 3/4] USB: OMAP: move omap-otg out from isp1301_omap

2013-03-07 Thread Aaro Koskinen
in isp1301 is tightly coupled with isp1301 and cannot be trivially moved out, but still this provides a way for other drivers to register to OTG interrupt. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/otg/Kconfig|5 ++ drivers/usb/otg/Makefile |1 + drivers

[RFC PATCH 0/4] USB: OMAP: Tahvo USB support for 770

2013-03-07 Thread Aaro Koskinen
) Please review and comment. Thanks, A. Aaro Koskinen (4): retu-mfd: support also Tahvo ARM: OMAP1: nokia770: enable Tahvo USB: OMAP: move omap-otg out from isp1301_omap USB: OMAP: Tahvo USB transceiver driver arch/arm/mach-omap1/board-nokia770.c | 10 + drivers/mfd/Kconfig

[RFC PATCH 1/4] retu-mfd: support also Tahvo

2013-03-07 Thread Aaro Koskinen
Tahvo is a multi-function device on Nokia 770, implementing USB transceiver and charge/battery control. It's so close to Retu that a single driver can support both. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/Kconfig |6

Re: [RFC PATCH 3/4] USB: OMAP: move omap-otg out from isp1301_omap

2013-03-07 Thread Aaro Koskinen
Hi, On Thu, Mar 07, 2013 at 04:51:59PM +0200, Felipe Balbi wrote: why is this otg_dev even needed ? Can you refresh my memory ? If you want to handle OTG controller interrupt you need it... Though looks like tahvo does not really need it, and it can be disabled. A. -- To unsubscribe from this

[PATCH 1/2] usb: musb: omap2430: fix omap_musb_mailbox glue check again

2013-03-05 Thread Aaro Koskinen
if the musb core is ready. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/musb/omap2430.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 1762354..2a39c11 100644 --- a/drivers/usb/musb

[PATCH 2/2] usb: musb: omap2430: fix sparse warning

2013-03-05 Thread Aaro Koskinen
Fix the following sparse warning: drivers/usb/musb/omap2430.c:54:33: warning: symbol '_glue' was not declared. Should it be static? Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/musb/omap2430.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2012-12-27 Thread Aaro Koskinen
Hi, On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: This patch series adds dt data to get MUSB working in omap4 and omap3 Changes from v2: * Changes the subject of all the patches to include ARM: dts: * Added reg

[PATCH] musb: omap2430: fix the readiness check in omap_musb_mailbox

2012-12-22 Thread Aaro Koskinen
e1a05000 e593401c (e5940004) [ 14.448944] ---[ end trace dbf47e5bc5ba03c2 ]--- [ 14.453826] Kernel panic - not syncing: Fatal exception Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/usb/musb/omap2430.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git