Re: [PATCH] usb: hide usb_of_get_companion_dev for CONFIG_USB=n

On Mon, Aug 20, 2018 at 5:22 AM Yoshihiro Shimoda wrote: > > From: Arnd Bergmann, Sent: Tuesday, August 14, 2018 11:27 PM > > > > On Tue, Aug 14, 2018 at 3:58 PM Alan Stern > > wrote: > > > On Mon, 13 Aug 2018, Arnd Bergmann wrote: > > > > diff --gi

[PATCH] usb: musb: remove an unused variable

emove references to default_a of struct usb_otg") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/musb/da8xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c index 0e5929e81d26..1c023c0091c4 100644 --- a/drivers/usb/musb/da8xx

[PATCH] usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency

Without that option, we run into a link failure: drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") Signed-of

[PATCH] usb: dwc3: qcom: mark PM functions as __maybe_unused

t;usb: dwc3: Add Qualcomm DWC3 glue driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/dwc3/dwc3-qcom.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 8abb6f31389d..d7a

Re: [RFC 00/10] ARM: Remove support for Exynos5440

On Tue, Apr 24, 2018 at 10:56 PM, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Tue, Apr 24, 2018 at 10:50:58PM +0200, Arnd Bergmann wrote: >> On Tue, Apr 24, 2018 at 10:32 PM, Krzysztof Kozlowski <k...@kernel.org> >> wrote: > The only dependency is through

Re: [RFC 00/10] ARM: Remove support for Exynos5440

On Tue, Apr 24, 2018 at 10:32 PM, Krzysztof Kozlowski wrote: > Hi, > > > Overview > > Let's continue the removal of old platforms. We already get rid of Exynos4212. > Now it's time for Exynos5440. > > The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting >

[PATCH] usb: select USB_COMMON for usb role switch config

the same problem for other helpers like USB_LED_TRIG or PHY drivers. Fixes: d54f063cdbe4 ("extcon: axp288: Set USB role where necessary") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/Kconfig b/dri

Re: Multiple generic PHY instances for DWC3 USB IP

On Wed, Apr 4, 2018 at 10:00 AM, Felipe Balbi wrote: > > Hi, > > Masahiro Yamada writes: Each DWC3 instance is connected with multiple HS PHYs and multiple SS PHYs, depending on the number of ports. >>> >>> in that case,

Re: [PATCH 38/47] usb: musb: remove blackfin port

On Wed, Mar 14, 2018 at 6:12 PM, Bin Liu <b-...@ti.com> wrote: > On Wed, Mar 14, 2018 at 04:35:51PM +0100, Arnd Bergmann wrote: >> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >> index 5506a9c03c1f..490990e8b015 100644 >> --- a/drivers/usb/musb/K

Re: [PATCH 00/16] remove eight obsolete architectures

On Thu, Mar 15, 2018 at 10:59 AM, Hannes Reinecke wrote: > On 03/15/2018 10:42 AM, David Howells wrote: >> Do we have anything left that still implements NOMMU? >> > RISC-V ? > (evil grin :-) Is anyone producing a chip that includes enough of the Privileged ISA spec to have things

Re: [PATCH 00/16] remove eight obsolete architectures

On Thu, Mar 15, 2018 at 10:42 AM, David Howells wrote: > Do we have anything left that still implements NOMMU? Yes, plenty. I was wondering the same thing, but it seems that the architectures we remove are almost completely representative of what we support overall, except

[PATCH 38/47] usb: musb: remove blackfin port

The blackfin architecture is getting removed, so we can clean up all the special cases in the musb driver. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/musb/Kconfig| 10 +- drivers/usb/musb/Makefile | 1 - drivers/usb/musb/blackfin.c

[PATCH 37/47] usb: host: remove tilegx platform glue

The tile architecture is getting removed, so the ehci and ohci platform glue drivers are no longer needed. In case of ohci, this is the last one to define a PLATFORM_DRIVER macro, so we can remove even more. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/host/ehci-hcd.c

[PATCH 00/47] arch-removal: device drivers

. For anything else, I'd keep the removal patches in my asm-generic tree and will send a pull request for 4.17 along with the actual arch removal. Arnd Arnd Bergmann edac: remove tile driver net: tile: remove ethernet drivers net: adi: remove blackfin ethernet drivers net: 8390: remove m32r

[PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

A lot of Kconfig symbols have architecture specific dependencies. In those cases that depend on architectures we have already removed, they can be omitted. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- block/bounce.c | 2 +- drivers/ide/Kconfig

[PATCH 00/16] remove eight obsolete architectures

architectures for several years at this point. Arnd Arnd Bergmann (14): arch: remove frv port arch: remove m32r port arch: remove score port arch: remove blackfin port arch: remove tile port procfs: remove CONFIG_HARDWALL dependency mm: remove blackfin MPU support mm: remove

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

On Tue, Feb 27, 2018 at 11:22 AM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-27 18:03 GMT+09:00 Arnd Bergmann <a...@arndb.de>: >> On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >>> But,

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-26 21:43 GMT+09:00 Arnd Bergmann <a...@arndb.de>: >> On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >>>

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-26 17:43 GMT+09:00 Arnd Bergmann <a...@arndb.de>: >> On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >>> As Docum

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

On Sat, Feb 24, 2018 at 3:50 PM, Masahiro Yamada wrote: > As Documentation/kbuild/kconfig-language.txt notes, 'select' should be > used with care - it forces a lower limit of another symbol, ignoring > the dependency. > > MFD_SYSCON depends on HAS_IOMEM, but several

[4.4-stable 09/22] ARM: tegra: select USB_ULPI from EHCI rather than platform

the 'select' statements from mach-tegra and drivers/soc/tegra and adds them with the device driver that actually needs them. Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Thierry Reding <tred...@nvidia.com> [arnd: rebased to 4.4-stable] Signed-off-by: Arnd Bergmann &l

[4.4-stable 07/22] usb: phy: msm add regulator dependency

e kernels. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 22e8ecb6bfbd..7a72bef35acf 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @

[4.9-stable 8/9] usb: phy: msm add regulator dependency

e kernels. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index b9c409a18faa..125cea1c3c8d 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

On Tue, Feb 6, 2018 at 2:05 PM, Robin Murphy wrote: > > It looks like we have only one real arch (score) without IOMEM, and two > (s390 and tile) where it is possible to configure out, so it does seem like > a reasonable feature to assume. Maybe we could have something like

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

On Tue, Feb 6, 2018 at 11:14 AM, Geert Uytterhoeven wrote: > Hi all, > > If NO_DMA=y, get_dma_ops() returns a reference to the non-existing > symbol bad_dma_ops, thus causing a link failure if it is ever used. > > The intention of this is twofold: > 1. To catch

Re: [PATCH] usb: dwc2: Fix endless deferral probe

On Fri, Jan 12, 2018 at 6:51 PM, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > Em Fri, 12 Jan 2018 10:18:59 +0100 > Arnd Bergmann <a...@arndb.de> escreveu: > >> On Fri, Jan 12, 2018 at 9:06 AM, Stefan Wahren <stefan.wah...@i2se.com> >> wrote: &

Re: [PATCH] usb: dwc2: Fix endless deferral probe

On Fri, Jan 12, 2018 at 9:06 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Am 12.01.2018 um 00:32 schrieb Arnd Bergmann: >> On Wed, Jan 10, 2018 at 1:15 PM, Stefan Wahren <stefan.wah...@i2se.com> >> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-c

Re: [PATCH] usb: dwc2: Fix endless deferral probe

On Wed, Jan 10, 2018 at 1:15 PM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Hi Arnd, > > > Am 09.01.2018 um 22:33 schrieb Arnd Bergmann: >> >> On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren <stefan.wah...@i2se.com> >> wrote: >>> >&g

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

On Thu, Jan 11, 2018 at 2:30 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: > On Thursday 11 January 2018 02:27 AM, Arnd Bergmann wrote: >> On Mon, Jan 8, 2018 at 7:32 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: >>> On Monday 08 January 2018 06:31 PM, Ar

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

On Mon, Jan 8, 2018 at 7:32 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: > Hi Arnd, > > On Monday 08 January 2018 06:31 PM, Arnd Bergmann wrote: >> Stefan Wahren reports a problem with a warning fix that was merged >> for v4.15: we had lots of device nodes with

[PATCH] usb: mtu3: fix ssusb_wakeup_set dummy

'ssusb_wakeup_set'; did you mean 'ssusb_wakeup_disable'? [-Werror=implicit-function-declaration] This adapts the dummy helpers the same way that the extern declarations were. Fixes: f0ede2c6282b ("usb: mtu3: supports remote wakeup for mt2712 with two SSUSB IPs") Signed-off-by: Arn

Re: [PATCH] usb: dwc2: Fix endless deferral probe

On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren wrote: > The dwc2 USB driver tries to find a generic PHY first and then look > for an old style USB PHY. In case of a valid generic PHY node without > a PHY driver, the PHY layer will return -EPROBE_DEFER forever. So dwc2 >

[PATCH] phy: work around 'phys' references to usb-phy devices

to generic-phy. Fixes: 014d6da6cb25 ("ARM: dts: bcm283x: Fix DTC warnings about missing phy-cells") Link: https://marc.info/?l=linux-usb=151518314314753=2 Cc: sta...@vger.kernel.org Cc: Stefan Wahren <stefan.wah...@i2se.com> Cc: Felipe Balbi <ba...@kernel.org> Signed

Re: [PATCH] Revert "ARM: dts: bcm283x: Fix DTC warnings about missing phy-cells"

On Mon, Jan 8, 2018 at 10:36 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: > Am 08.01.2018 um 10:27 schrieb Arnd Bergmann: >> >> On Mon, Jan 8, 2018 at 10:15 AM, Stefan Wahren <stefan.wah...@i2se.com> >> wrote: >>> >>> Hi Eric, >>>

Re: [GIT PULL] Qualcomm ARM64 Defconfig updates for 4.16

On Mon, Jan 1, 2018 at 7:53 AM, Andy Gross wrote: > The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: > > Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) > > are available in the git repository at: > >

Re: [PATCH] usb: xhci: fix incorrect memset()

On Mon, Dec 11, 2017 at 6:01 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote: >> On 11.12.2017 13:27, Arnd Bergmann wrote: >> > gcc-8 warnings about the new driver using a memset with a bogus lengt

Re: [PATCH] Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"

one legacy driver can be bound to an USB device > controller at a time. > > Hence revert commit 7a9618a22aad. > > Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> > Cc: Romain Izard <romain.izard@gmail.com> > Cc: Arnd Bergmann <a...@arndb.de> &g

Re: [PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

On Mon, Dec 11, 2017 at 5:09 PM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Mon, 2017-12-11 at 12:30 +0100, Arnd Bergmann wrote: >> One patch that was meant as a cleanup apparently did more than it intended, >> allowing all combinations of legacy gadge

[PATCH 2/2] usb: gadget: webcam: fix V4L2 Kconfig dependency

of randconfig builds. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/legacy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/Kconfig b/drivers/usb/gadget/legacy/Kconfig index 2d80a9d1d5d9..fbd974965399 100644 --- a/drive

[PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

out USB_ETH") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/Kconfig| 28 drivers/usb/gadget/legacy/Kconfig | 28 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/usb/gadget/

[PATCH] usb: xhci: fix incorrect memset()

-size] It looks like the author meant to use sizeof() rather than ARRAY_SIZE() here, so use that. Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/host/xhci-dbgcap.c | 2 +- 1 file changed, 1 insertio

[PATCH 1/2] usbip: fix off-by-one frame number calculation

changing the % modulo operator into a cheaper bitmask that the other drivers use, to make it wrap after 0x7ff rather than before it. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/usbip/vudc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 2/2] usbip: use monotonic timestamps

-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/usbip/vudc.h | 2 +- drivers/usb/usbip/vudc_dev.c | 7 +++ drivers/usb/usbip/vudc_sysfs.c | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/usb/usbip/vudc.h b/drivers/usb/usbip/vudc.h index 44fb24

[PATCH] usb: xhci: tegra: use time64_t for printing timestamp

interfaces and works until 2106, when the firmware-defined data structure overflows. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/host/xhci-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-t

[PATCH] usb: mtu3: fix dma_addr_t printk output again

: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] This fixes the printk argument accordingly. Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address") Signed-off-by: Arnd Bergmann <a...@arndb.de&

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

On Sat, Oct 28, 2017 at 3:33 PM, Martin Blumenstingl wrote: > On Fri, Oct 27, 2017 at 9:55 PM, Alan Stern wrote: >> On Fri, 27 Oct 2017, Martin Blumenstingl wrote: >>> >> diff --git

[PATCH] usb: xhci: tegra: use time64_t for printing timestamp

interfaces and works until 2106, when the firmware-defined data structure overflows. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/host/xhci-tegra.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-t

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

On Thu, Oct 19, 2017 at 11:25 PM, Martin Blumenstingl wrote: >> Does dwc2 also use separate nodes for the roothub? From your >> description it sounds like it would not be affected by your patch. > currently it doesn't use separate notes for the roothub -

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

On Tue, Oct 17, 2017 at 11:19 PM, Martin Blumenstingl wrote: >> Ok, very good! >> >>> is there anything else you want me to test? >> >> What about the same dtb when run on a kernel without your >> patch series? Does that work as well, or are your patches >>

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

On Tue, Oct 17, 2017 at 11:00 PM, Martin Blumenstingl <martin.blumensti...@googlemail.com> wrote: > On Fri, Oct 13, 2017 at 9:37 AM, Arnd Bergmann <a...@arndb.de> wrote: >> On Thu, Oct 12, 2017 at 10:56 PM, Martin Blumenstingl >> <martin.blumensti...@googlemail.c

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

On Thu, Oct 12, 2017 at 10:56 PM, Martin Blumenstingl <martin.blumensti...@googlemail.com> wrote: > Hi Arnd, > > thank you for reviewing this patch! > > On Mon, Oct 9, 2017 at 12:24 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Sun, Oct 8, 2017

Re: [RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub

On Sun, Oct 8, 2017 at 11:17 PM, Martin Blumenstingl wrote: > A USB root-hub may have several PHYs which need to be configured before > the root-hub starts working. > This adds the documentation for such a USB root-hub as well as a hint > regarding the

[PATCH] [v2] usb: gadget: dummy: fix nonsensical comparisons

: Felipe Balbi <ba...@kernel.org> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v2: simplify the expression as suggested by Alan Stern --- drivers/usb/gadget/udc/dummy_hcd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c

[PATCH] usb: gadget: dummy: fix nonsensical comparisons

lipe Balbi <ba...@ti.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/udc/dummy_hcd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c index a030d7923d7d..54e8

[PATCH] usb: typec: include linux/device.h in ucsi.h

will not be visible outside of this definition or declaration [-Werror] This includes the required header file. Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/typec/ucsi/ucsi.h | 1 + 1 file chan

[PATCH] usb: musb: don't mark of_dev_auxdata as initdata

from the function da8xx_probe() to the (unknown reference) .init.data:(unknown) This removes the annotation. Reported-by: Olof's autobuilder <o...@lixom.net> Fixes: d6299b6efbf6 ("usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx") Signed-off-by: Arnd Bergman

Re: next build: 1 warnings 1 failures (next/next-20170424)

On Mon, Apr 24, 2017 at 11:58 AM, Olof's autobuilder wrote: > --- > > Errors: > > arm.allmodconfig: > ERROR: "__aeabi_uldivmod" [drivers/gpu/drm/arm/mali-dp.ko] undefined! patch sent. > >

Re: [RFC] usb: chipidea: set dma_ops for the created ci_hdrc platform_device

On Tue, Apr 25, 2017 at 12:01 PM, Jisheng Zhang wrote: > Hi all, > > After commit 1dccb598df549 ("arm64: simplify dma_get_ops"), the chipidea > driver can't work any more on Marvell Berlin arm64 platforms, the reason > is the created ci_hdrc platform_device's dma_ops is

[PATCH] usb: host: xhci: remove #ifdef around PM functions

) A simpler way to do this correctly is to use __maybe_unused annotations that let the compiler silently drop the functions when there is no reference. Fixes: b0c69b4bace3 ("usb: host: plat: Enable xHCI plat runtime PM") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/host/

[PATCH, 3.18-stable regression] gadgetfs: fix uninitialized variable in error handling

ory. Fixes: c81fc59be42c ("gadgetfs: use-after-free in ->aio_read()") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inod

Re: [PATCH] Partially revert "usb: Kconfig: using select for USB_COMMON dependency"

On Tue, Apr 18, 2017 at 4:36 AM, Ben Hutchings wrote: > This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for > USB_LED_TRIG. This config symbol has bool type and enables extra code > in usb_common itself, not a separate driver. Enabling it should not > force

[PATCH RESEND^2] usb: gadget: udc: atmel: fix debug output

] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Alexand

[PATCH, RESEND] usb: gadget: udc: atmel: fix debug output

] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Alexand

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

On Tue, Feb 14, 2017 at 1:26 PM, Roger Quadros <rog...@ti.com> wrote: > On 14/02/17 13:44, Arnd Bergmann wrote: >> On Tue, Feb 14, 2017 at 11:36 AM, Roger Quadros <rog...@ti.com> wrote: >>> Why are we using sysdev to read DT property? We should be using t

Re: [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration

On Tue, Feb 14, 2017 at 11:36 AM, Roger Quadros <rog...@ti.com> wrote: > On 11/02/17 03:27, Peter Chen wrote: >> From: Arnd Bergmann <a...@arndb.de> >> >> For xhci-hcd platform device, all the DMA parameters are not >> configured properly, notably dma o

Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing

On Friday, February 10, 2017 2:12:36 PM CET Linus Walleij wrote: > > > + /* Right now device-tree probed devices don't get dma_mask set. > > +* Since shared usb code relies on it, set it here for now. > > +* Once we have dma capability bindings this can go away. > > +

[PATCH] usb: gadget: udc: atmel: fix debug output

] DBG(DBG_ERR, "%s: EPT_CFG = 0x%lx (maxpacket = %lu)\n", This changes the debug output the same way as the other code. Fixes: 741d2558bf0a ("usb: gadget: udc: atmel: Update endpoint allocation scheme") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadge

[PATCH] usb: phy: ab8500: remove unused ab8500_eyediagram_workaroud()

from where. Fixes: 635f997a499b ("usb: phy: ab8500: Remove the set_power callback") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/phy/phy-ab8500-usb.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/

Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

On Friday, January 6, 2017 12:29:12 PM CET Raviteja Garimella wrote: > Hi Arnd, > > On Fri, Jan 6, 2017 at 3:33 AM, Arnd Bergmann <a...@arndb.de> wrote: > > On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: > >> The UDC is based on Synopsys De

Re: [RFC 0/1] Platform driver support for 'amd5536udc' driver

On Thursday, January 5, 2017 1:53:16 PM CET Raviteja Garimella wrote: > The UDC is based on Synopsys Designware core USB (2.0) Device controller > IP. ... > This is a request for comments from maintainers/others regarding approach > on whether to have 2 different drivers (one each for AMD and

Re: [PATCH] usb: musb: mark PM functions as __maybe_unused

On Monday, November 28, 2016 11:51:37 AM CET Geert Uytterhoeven wrote: > On Tue, Nov 22, 2016 at 3:30 PM, Arnd Bergmann <a...@arndb.de> wrote: > > Building without CONFIG_PM causes a harmless warning: > > > > drivers/usb/musb/musb_core.c:2041:12: error: ‘mu

[PATCH] usb: musb: mark PM functions as __maybe_unused

thing without warning. Fixes: ea2f35c01d5e ("usb: musb: Fix sleeping function called from invalid context for hdrc glue") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/musb/musb_core.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --g

Re: [PATCH] usb: dwc3: avoid empty-body warning

On Thursday, November 17, 2016 1:23:43 PM CET Felipe Balbi wrote: > Arnd Bergmann <a...@arndb.de> writes: > > Building with W=1, we get a warning about harmless empty statements: > > > > drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf': > > drivers/usb

Re: [PATCH] dwc3: make PM functions as __maybe_unused

On Wednesday, November 16, 2016 1:13:48 PM CET Felipe Balbi wrote: > Arnd Bergmann <a...@arndb.de> writes: > > A change to the suspend/resume handling in dwc3-pci introduced a > > harmless warning: > > > > drivers/usb/dwc3/dwc3-pci.c:169:12: error: ‘dwc3_pci_dsm’ d

Re: [PATCH] usb: dwc3: pci: avoid build warning

On Wednesday, November 16, 2016 1:17:51 PM CET Felipe Balbi wrote: > dwc3_pci_dsm() is only needed if (PM || PM_SLEEP), > we should make sure it's not defined if neither of > those is defined. > > This fixes a randconfig build warning. > > Reported-by: Arnd Bergmann <a..

[PATCH] usb: dwc3: avoid empty-body warning

that instead. Alternatively, the code could be removed entirely as it does nothing. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- This has been present in the driver for a while, but the code just moved around, so it showed up as a new warning for me. I hope to eventually address all W=1 wa

[PATCH] dwc3: make PM functions as __maybe_unused

.org/patch/9318887/ Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/dwc3/dwc3-pci.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 8c39ec6522fd..771b620b4878 100644 --- a/drivers/usb

Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote: > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc) > > void dwc3_host_exit(struct dwc3 *dwc) > > { > > phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy", > > - dev_name(>xhci->dev)); > > +

Re: [PATCH 2/3] usb: dwc3: host: Do not use dma_set_coherent_mask

On Tuesday, October 25, 2016 4:26:27 PM CEST Sriram Dash wrote: > Do not require dma_set_coherent_mask for hcd > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Aside from the comments I had for patch 3, you are doing two different things here: > diff --git a/drivers/usb/dwc3/d

Re: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent

On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote: > Do not use dma_coerce_mask_and_coherent for hcd. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> The patch is good, but please follow the usual rules for submitting someone else's patch: - As the first line, h

[PATCH] kalmia: avoid potential uninitialized variable use

here This warning is harmless, but for consistency, we should make the check for the return code match what the driver does everywhere else and just progate it, which then gets rid of the warning. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/usb/kalmia.c | 2 +- 1 file chan

Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static

On Friday, September 23, 2016 5:08:37 PM CEST Greg KH wrote: > On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for > > 'xhci_unmap_td_bounce_buffer'

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Wednesday, September 21, 2016 11:43:59 AM CEST Sriram Dash wrote: > >From: Arnd Bergmann [mailto:a...@arndb.de] > >On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: > > ===

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Wednesday, September 21, 2016 11:06:47 AM CEST Sriram Dash wrote: > > Hello Arnd, > > We tried this patch on NXP platforms (ls2085 and ls1043) which use dwc3 > controller without any glue layer. On first go, this did not work. But after > minimal reworks mention snippet below, we are able to

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On Monday, September 19, 2016 10:29:27 AM CEST Kishon Vijay Abraham I wrote: > On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote: > > On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I > > wrote: > >> This way the driver will be probed only once (the reset can

[PATCH] usb: musb: fix error handling message in probe

[-Werror=maybe-uninitialized] This modifies the function to assign the return code before checking it, and does uses the same method in the check for usb_phy_generic_register() as well. Fixes: 947c49afe41f ("usb: musb: da8xx: Remove mach code") Signed-off-by: Arnd Bergmann <

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

On Friday, September 16, 2016 1:49:59 PM CEST Kishon Vijay Abraham I wrote: > > I think the offset information can come from the devicetree too. The phy can > be > modeled something like below. > > usb-phys@c000 { > compatible =

Re: [PATCH] usb: use of_usb_get_dr_mode_by_phy() inline helper without USB

On Wednesday, September 14, 2016 3:51:01 PM CEST Arnd Bergmann wrote: > We have had two new PHY drivers call of_usb_get_dr_mode_by_phy() > recently without having a dependency on CONFIG_USB_COMMON, resulting > in a link error: > > ERROR: "of_usb_get_dr_mode_by_phy" [driv

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Wednesday, September 14, 2016 5:31:36 PM CEST Lorenzo Pieralisi wrote: > On Wed, Sep 07, 2016 at 01:47:22PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Robin Murphy writes: > > > On 07/09/16 10:55, Peter Chen wrote: > > > [...] > > >>> Regarding the DMA configuration

[PATCH] usb: use of_usb_get_dr_mode_by_phy() inline helper without USB

ot the one that already has a correct check for USB_SUPPORT rather than USB_COMMON. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: 5ed935458519 ("phy: meson: add USB2 PHY support for Meson8b and GXBB") --- include/linux/usb/of.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/1] usb: Kconfig: using select for USB_COMMON dependency

them. > > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Felipe Balbi <ba...@kernel.org> > Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Signed-off-by: Peter Chen <peter.c...@nxp.com> > Acked-by: Arnd Bergmann <a...@arndb.de> I've also put this o

Re: [PATCH v4] usb: core: setup dma_pfn_offset for USB devices and, interfaces

0xF within the scsi layer > (scsi_calculate_bounce_limit()). > This will result in bounce buffers being unnecessarily used. > > Hint: On 32-bit ARM platforms dma_max_pfn() = dma_mask_pfn + dma_pfn_offset > > Signed-off-by: Roger Quadros <rog...@ti.com> Acked-by: Arnd Bergman

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

On Tuesday, September 13, 2016 4:50:05 PM CEST Peter Chen wrote: > On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote: > > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > > > > > I just see below Kconfig entry at the same Kconfig

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > I just see below Kconfig entry at the same Kconfig > (drivers/usb/Kconfig), and forget your changes. > > config USB_LED_TRIG > bool "USB LED Triggers" > depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS >

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

On Tuesday, September 13, 2016 9:48:55 AM CEST Peter Chen wrote: > On Mon, Sep 12, 2016 at 05:36:23PM +0200, Arnd Bergmann wrote: > > Moving the CONFIG_USB_ULPI_BUS option to the top-level Kconfig file > > means that we can enable it without any of the other USB support, > &g

[PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

rs/phy/phy-tusb1210.ko] undefined! ERROR: "__ulpi_register_driver" [drivers/phy/phy-tusb1210.ko] undefined! ERROR: "ulpi_write" [drivers/phy/phy-tusb1210.ko] undefined! This adds a 'select USB_COMMON' for the symbol, similar to what we have for related options. Signed-off-by

[PATCH] usb: gadget: uvc: add V4L2 dependency

CONFIG_VIDEO_V4L2=m too, avoiding the link failure. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 2ea3fc3c41b9..8ad203296079 100644 --- a/drivers/usb/

Re: [PATCH v2] usb: core: setup dma_pfn_offset for USB devices and, interfaces

On Monday, September 12, 2016 9:09:16 AM CEST Alan Stern wrote: > > diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c > > index 0406a59..66364ea 100644 > > --- a/drivers/usb/core/message.c > > +++ b/drivers/usb/core/message.c > > @@ -1863,6 +1863,12 @@ free_interfaces: > >

[PATCH] usb: dwc3: avoid -Wmaybe-uninitialized warning

that it's safe and makes it easier to understand to me. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: 31162af447d7 ("usb: dwc3: gadget: avoid while (1) loop on completion") --- drivers/usb/dwc3/gadget.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) dif

Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

On Thursday, September 8, 2016 8:28:10 PM CEST Peter Chen wrote: > On Thu, Sep 08, 2016 at 12:17:21PM +0200, Arnd Bergmann wrote: > > On Thursday, September 8, 2016 12:43:06 PM CEST Felipe Balbi wrote: > > > Arnd Bergmann <a...@arndb.de> writes: > > > > On Thu

  1   2   3   4   5   6   >