Re: Race related to e04a0442d33b "HID: core: remove the absolute need of hid_have_special_driver[]"

Hi Heiner, On Fri, May 11, 2018 at 12:11 AM, Heiner Kallweit wrote: > Due to some other issue with one devices supported by hid-led I figured > out that it's no longer needed to list devices with own driver in > hid_have_special_driver[]. > > So I removed the entries for

Re: [PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

946] hid-generic 0003:03F0:094A.0003: input: USB HID v1.11 Mouse > [PixArt HP USB Optical Mouse] on usb-:00:14.0-2/input0 > > Signed-off-by: Dave Young <dyo...@redhat.com> > Cc: sta...@vger.kernel.org > --- Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

On Nov 27 2017 or thereabouts, Greg KH wrote: > On Mon, Nov 27, 2017 at 09:16:31AM +0100, Benjamin Tissoires wrote: > > On Nov 25 2017 or thereabouts, Dave Young wrote: > > > This mouse keep disconnecting in runleve 3 like below, add it needs the > > > quirk t

Re: [PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

On Nov 25 2017 or thereabouts, Dave Young wrote: > This mouse keep disconnecting in runleve 3 like below, add it needs the > quirk to mute the anoying messages. > > [ 111.230555] usb 2-2: USB disconnect, device number 6 > [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd >

Re: [PATCH] drivers/hid: Convert timers to use timer_setup()

le tested. Looks good enough for me: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > > drivers/hid/hid-appleir.c | 8 > drivers/hid/hid-prodikeys.c| 7 +++ > drivers/hid/hid-wiimote-core.c | 6 +++--- > drivers/h

Re: [PATCH] HID: usbhid: Convert timers to use timer_setup()

; multitouch. > > Cc: Jiri Kosina <ji...@kernel.org> > Cc: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Cc: linux-in...@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: Thomas Gleixner <t...@linutronix.de> > Signed-off-by: Kees Cook <keesc...@c

Re: [PATCH] HID: usbhid: fix "always poll" quirk

ported-by: Olof Johansson <o...@lixom.net> > Tested-by: Olof Johansson <o...@lixom.net> > Fixes: e399396a6b0 ("HID: usbhid: remove custom locking from usbhid_open...") > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> > --- slightly reviewed and

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 15 2017 or thereabouts, Jiri Kosina wrote: > On Tue, 13 Jun 2017, Benjamin Tissoires wrote: > > > BTW, the merge with your for-next branch is going to be tricky :( > > I've just pushed the for-next merge. Second/third pair of eyes (scripted > eyes even better :) )

[PATCH Resent 1/3] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- Resent with -

Re: [PATCH 1/3] HID: core: move the dynamic quirks handling in core

On Jun 14 2017 or thereabouts, Andy Shevchenko wrote: > On Wed, Jun 14, 2017 at 11:24 AM, Benjamin Tissoires > <benjamin.tissoi...@redhat.com> wrote: > > usbhid has a list of dynamic quirks in addition to a list of static quirks. > > There is not much USB specific in

Re: [PATCH 0/3] Proposal for making hid_have_special_driver obsolete

On Jun 14 2017 or thereabouts, Bastien Nocera wrote: > > > > On 14 Jun 2017, at 10:24, Benjamin Tissoires > > <benjamin.tissoi...@redhat.com> wrote: > > > > Hi, > > > > As mentioned by Jiri, I found a way to have this horrible

[PATCH 0/3] Proposal for making hid_have_special_driver obsolete

for-4.12/driver-matching-fix branch. I'll resubmit a proper patch that will apply properly to for-next as soon as for-4.12/driver-matching-fix gets merged. Cheers, Benjamin Benjamin Tissoires (3): HID: core: move the dynamic quirks handling in core HID: quirks: move the list of special

[PATCH 1/3] HID: core: move the dynamic quirks handling in core

usbhid has a list of dynamic quirks in addition to a list of static quirks. There is not much USB specific in that, so move this part of the module in core so we can have one central place for quirks. Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/Ma

[PATCH 3/3] HID: core: remove the absolute need of hid_have_special_driver[]

hid_have_special_driver[] useless. It still allows to not see a hid-generic driver bound and removed during boot, so we can keep it around. This will also help other people to have a special HID driver without the need of recompiling hid-core. Signed-off-by: Benjamin Tissoires <benjamin.tis

[PATCH 2/3] HID: quirks: move the list of special devices into a quirk

-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/hid/hid-core.c| 835 +--- drivers/hid/hid-quirks.c | 866 +- include/linux/hid.h | 1 + net/bluetooth/hidp/core.c | 2 +- 4

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 13 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 13 2017 or thereabouts, Jiri Kosina wrote: > > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of > > hid.git, and if no more issues are discovered, I'll push that to Linus > > this we

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 13 2017 or thereabouts, Jiri Kosina wrote: > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of > hid.git, and if no more issues are discovered, I'll push that to Linus > this week so that we finally get rid of this long-lasting PITA (while > still heading towards

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

and falling back to generic driver is > figured out. > > Signed-off-by: Jiri Kosina <jkos...@suse.cz> > --- Thanks for the quick band-aid. Same as Hans: I started checking the VID/PID with the drivers association, and got bored after a few. I _think_ you automated the thing

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Jun 09 2017 or thereabouts, Greg KH wrote: > On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: > > Greg KH writes: > > > > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > > >> Longer-term, we'd ideally make 'generic' driver special and let it > > >>

Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1

On Jun 08 2017 or thereabouts, Philipp Zabel wrote: > Hi Benjamin, > > On Wed, Jun 7, 2017 at 9:11 AM, Benjamin Tissoires > <benjamin.tissoi...@redhat.com> wrote: > > Hi Philip, > > > > On Jun 07 2017 or thereabouts, Philipp Zabel wrote: > [...] &

Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1

Hi Philip, On Jun 07 2017 or thereabouts, Philipp Zabel wrote: > When plugging in an Oculus Rift CV1 HMD, it takes a long time until the hidraw > devices appear, specifically two control transfers time out querying the HID > report descriptors: > > $ echo 1 > /sys/module/hid/parameters/debug

Re: [PATCH v1] ACPI: Switch to use generic UUID API

: Borislav Petkov <b...@suse.de> > Cc: Dan Williams <dan.j.willi...@intel.com> > Cc: Amir Goldstein <amir7...@gmail.com> > Cc: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: Ben Skeggs <

[PATCH v2] HID: remove initial reading of reports at connect

-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- changes in v2: - amended subject (was: HID: get rid of HID_QUIRK_NO_INIT_REPORTS) - kept around HID_QUIRK_NO_INIT_REPORTS - force retrieval of reports at HIDIOCGUSAGE(S) in hiddev --- drivers/hid/i2c-hid/i2c-hid.c

Re: [PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS

On Mar 06 2017 or thereabouts, Jiri Kosina wrote: > On Thu, 5 Jan 2017, Benjamin Tissoires wrote: > > > For case 1, the hiddev documentation provides an ioctl to do the > > init manually. A solution could be to retrieve the requested report > > when EVIOCGUSAGE is called

Re: [PATCH] HID: usbhid: Use pr_ and remove unnecessary OOM messages

nted if descendent above a printk > > Signed-off-by: Joe Perches <j...@perches.com> Looks good to me: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > --- > drivers/hid/usbhid/hid-core.c | 16 +++- > drivers/hid/usbhid/h

Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev

On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: > We need to store the minor number each drivers. In case of hidraw, it's > minor number stores in struct hidraw. But hiddev's minor is located in > struct hid_device. > > So reallocates for hiddev's minor number. > There is not a real need to

Re: [PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected

On Mar 02 2017 or thereabouts, Jaejoong Kim wrote: > The hid-core announces kernel message which driver is loaded if there is > a hiddev, but hiddev's minor number is always zero even though it's not > zero. > > So, we need to store the minor number asked from usb core and do some > refactoring

Re: [PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

Hi, well, not to undermine your work, I am not a big fan of this kind of patches. Yes, it's nice to follow checkpatch, but on some rare case, we just ignore the warning because the end result would be too ugly (I haven't read the patch, so I am not judging how you solved the issues raised here

Re: [PATCH v2] HID: hiddev: allocate minor number hiddev's USB interface is bound to

ev. hidraw does use a minor too, but stores it in struct hidraw directly, so IMO it would make sense to store this in struct hiddev. The problem is that this struct is not exported, and it's going to be some refactoring work to do so. So, in a way, I am tempted to give my: Acked-by: Benjam

Re: [PATCH] HID: usbhid: extend polling interval configuration to joysticks

2 with jspoll=2, > resulting in a polling rate of 500Hz (verified with evhz). > > Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> > --- Looks good to me. Acked-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Documentation/kernel-parameters.txt

Re: [PATCH] HID: remove use of DRIVER_LICENSE

Grant Grundler <grund...@google.com> > --- > Most of the kernel already uses hard coded strings. > The few places that don't are easy to fix. FWIW: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> -- To unsubscribe from this list: send the line &q

[PATCH] HID: get rid of HID_QUIRK_NO_INIT_REPORTS

the behavior and hope that we won't break any userspace tool. Note that I don't think hidraw would be affected and I checked that the FF drivers that need to interact with the report fields are all using output reports, which are not initialized by usbhid_init_reports(). Signed-off-by: Benjamin

Re: [hid:for-4.10/i2c-hid 7/8] drivers/hid/i2c-hid/i2c-hid.c:772:19: error: 'struct i2c_hid' has no member named 'irq'

i2c_hid_free_buffers(ihid); >774 >775ret = i2c_hid_alloc_buffers(ihid, bufsize); > > --- > 0-DAY kernel test infrastructureOpen Source Technology Center > https://lists.01.org/pipermail/kbuild-all

Re: [PATCH v2] hid: hid-led: fix issue with transfer buffer not being dma capable

userspace processes writing a different values at the same time). If so, then you'll need to add a locking mechanism (can't recall if the LED API provide one for us or not), or just alloc/free the buffers directly. If no, the patch is: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com>

Re: [PATCH 2/2] usb: misc: remove outdated USB LED driver

let's remove the old USB LED driver. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Acked-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > --- > drivers/usb/misc/Kconf

Re: [PATCH 1/2] hid: migrate USB LED driver from usb misc to hid

Hi Heiner, On Jun 17 2016 or thereabouts, Heiner Kallweit wrote: > This patch migrates the USB LED driver to the HID subsystem. > Supported are Dream Cheeky Webmail Notifier / Friends Alert > and Riso Kagaku Webmail Notifier. > > Benefits: > - Avoid using USB low-level calls and use the HID

Re: [PATCH v2] hid: migrate Riso Kagaku LED driver from USB misc to HID

On Jun 15 2016 or thereabouts, Heiner Kallweit wrote: > Am 14.06.2016 um 23:49 schrieb Benjamin Tissoires: > > On Jun 12 2016 or thereabouts, Heiner Kallweit wrote: > >> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of > >> usb/misc/usbled d

Re: [PATCH v2] hid: migrate Riso Kagaku LED driver from USB misc to HID

On Jun 12 2016 or thereabouts, Heiner Kallweit wrote: > The Riso Kagaku Webmail Notifier (and its clones) is supported as part of > usb/misc/usbled driver currently. This patch migrates the driver for this > device to the HID subsystem. > > Benefits: > - Avoid using USB low-level calls and use

Re: [PATCH] hid: migrate Riso Kagaku LED driver from USB misc to HID

On May 28 2016 or thereabouts, Heiner Kallweit wrote: > Am 27.05.2016 um 23:45 schrieb Benjamin Tissoires: > > On May 27 2016 or thereabouts, Heiner Kallweit wrote: > >> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of > >> usb/misc/usbled d

Re: [PATCH] hid: migrate Riso Kagaku LED driver from USB misc to HID

On May 27 2016 or thereabouts, Heiner Kallweit wrote: > The Riso Kagaku Webmail Notifier (and its clones) is supported as part of > usb/misc/usbled driver currently. This patch migrates the driver for this > device to the HID subsystem. > > Benefits: > - Avoid using USB low-level calls and use

Re: [PATCH] hid: Fix boot delay for Creative SB Omni Surround 5.1 with quirk

> > --- Looks good to me but your mailer might have mangled the lines. Jiri might be able to apply the patch, but next time, please make sure the mailer client does not break lines. Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > drivers/hid/hid-ids

Re: [PATCH v2] HID: quirks: Add no_init_reports for AKAI midi controller

; > Signed-off-by: Stafford Horne <sho...@gmail.com> Works for me: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > --- > Resending the same patch for the keyboard to simply disable init reports, > as discussed with Oliver there might

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

titouch driver instead of microsoft one for Microsoft >>>>> Surface Type Covers. >>>>> >>>>> By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as >>>>> well as the multitouch pads do. >>>> >>>> I've discussed

Re: [PATCH v4 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices

drien Vergé <adrienve...@gmail.com> > Signed-off-by: Adrien Vergé <adrienve...@gmail.com> > --- The HID part is: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > drivers/hid/hid-ids.h | 5 - > drivers/hid/usbhid/hid-quir

Re: [PATCH v3 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices

Hi Adrien, On Tue, Nov 24, 2015 at 2:49 PM, Adrien Vergé wrote: > All ELAN hid devices seem to require the ALWAYS_POLL quirk. Let's use > this quirk for all devices from this vendor, rather than maintaining a > list of all its known product IDs. > > To achieve that, this

Re: [PATCH] HID: usbhid: add Chicony/Pixart usb optical mouse that needs QUIRK_ALWAYS_POLL

. Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin #define USB_DEVICE_ID_CHICONY_TACTICAL_PAD 0x0418 #define USB_DEVICE_ID_CHICONY_MULTI_TOUCH 0xb19d #define USB_DEVICE_ID_CHICONY_WIRELESS 0x0618 diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid

Re: [PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

I have no clue what this code is doing (don't know much about the ff system). Quoting your initial 0001/0001, I thing the commit message should be the following. Jim, can you please validate it? The FF2 driver (usbhid/hid-pidff.c) does not set the effect ID when uploading an effect. The result

Re: [PATCH 1/2] Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

You are missing here (before the first '---' the commit message which should state why you want to have this patch merged. To rephrase and continue what you wrote in your very first submission of this series, this could be (including your Signed-of-by): The FF2 driver (usbhid/hid-pidff.c) sends

Re: [PATCHv2 001/002] usbhid: Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

kfree(pidff); return error; } --- On 20/01/2015 14:09, Benjamin Tissoires wrote: Hi, Jim, in addition to what Alan said, here are some comments that I would like to be fixed in the v2. On Sun, Jan 18, 2015 at 11:07 AM, Jim Keir jimk...@oracledbadirect.com wrote: From: Jim Keir jimk

Re: [PATCH 001/001] usbhid: Fix initialisation and force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

Hi, Jim, in addition to what Alan said, here are some comments that I would like to be fixed in the v2. On Sun, Jan 18, 2015 at 11:07 AM, Jim Keir jimk...@oracledbadirect.com wrote: From: Jim Keir jimk...@yahoo.co.uk Signed-off-by: Jim Keir jimk...@yahoo.co.uk The Signed-off-by line is

Re: test program to check usb hid devices

If I understood correctly, you just want to dump the hid output. You can just cat /sys/kernel/debug/hid/*/events if debugfs is mounted. Or you may want to have a look at these 2 projects: hid-recorder - http://bentiss.github.io/hid-replay-docs/ usbhid-dump-

Re: [PATCH] Add quirk HID_QUIRK_NO_INIT_REPORTS for RNDPLUS touchscreen

On Fri, Mar 21, 2014 at 3:39 PM, Yufeng Shen mile...@chromium.org wrote: There is timeout error during initialization: kernel: [ 14.167086] hid-multitouch 0003:2512:5003.0001: usb_submit_urb(ctrl) failed: -1 kernel: [ 14.167135] hid-multitouch 0003:2512:5003.0001: timeout initializing

Re: [PATCH] Add quirk HID_QUIRK_NO_INIT_REPORTS for RNDPLUS touchscreen

On Fri, Mar 21, 2014 at 6:08 PM, Yufeng Shen mile...@google.com wrote: On Fri, Mar 21, 2014 at 4:58 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Fri, Mar 21, 2014 at 3:39 PM, Yufeng Shen mile...@chromium.org wrote: There is timeout error during initialization: kernel

Re: [PATCH] HID: usbhid: quirk for CY-TM75 75 inch Touch Overlay

Hi, On Mon, Jan 27, 2014 at 6:02 PM, Yufeng Shen mile...@chromium.org wrote: There is timeout error during initialization: kernel: [ 11.733104] hid-multitouch 0003:1870:0110.0001: usb_submit_urb(ctrl) failed: -1 kernel: [ 11.734093] hid-multitouch 0003:1870:0110.0001: timeout

Re: kernel Oops: 0003 on usbhid_submit_report

On Fri, Aug 23, 2013 at 12:52 PM, Andreas Lillebø Holm andr...@sqhead.com wrote: Hi, I just wanna followup this issue a bit more. We have now tested on several hardware platform, and it is only on one platform it fails. The platform it fails on is Atom Intel e6xx CPU with EG20T PCH

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

Hi Peter, thanks for forwarding this to the appropriate people mailing list. Hi Sarah, thanks for starting investigating this :) On Fri, Jul 19, 2013 at 1:37 AM, Peter Hurley pe...@hurleysoftware.com wrote: Before we revert to using the workaround, I'd like to suggest that this new

Re: [PATCH] hid: put the case in the right switch statement

Adding Jiri to the recipient list of the patch, otherwise, the thread may fall in the depth of his mailbox :) Cheers, Benjamin On Thu, Oct 25, 2012 at 7:08 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Alan, Yes, I saw that too. Acked-by: Benjamin Tissoires benjamin.tissoi