Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Dan Williams
On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote: > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > > On 4/26/2018 23:12, Johan Hovold wrote: > > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > > > > On 4/26/2018 18:39, Lars Melin wrote: > > > > > On 4/26/2018

Re: [PATCH] usb:serial:optrion: fix dwm-158 3g modem interface

2018-04-23 Thread Dan Williams
On Tue, 2018-04-24 at 09:55 +0700, Lars Melin wrote: > On 4/23/2018 23:54, Dan Williams wrote: > > > > MI_00 D-Link Mobile Broadband Device (cdc_ether) > > > MI_02 D-Link HSPA+DataCard Diagnostics Interface (also ppp m > > > MI_03 D-Link HSPA+DataCard NMEA Device

Re: [PATCH] usb:serial:optrion: fix dwm-158 3g modem interface

2018-04-23 Thread Dan Williams
On Mon, 2018-04-23 at 14:14 +0700, Lars Melin wrote: > On 4/23/2018 14:03, Giuseppe Lippolis wrote: > > The dwm-158 interface 4 and 5 doesn't answer to the AT commands > > and doesn't appears a option interface. > > Tested on openwrt distribution (kernel 4.14 using the old blacklist > >

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-26 Thread Dan Williams
On Sun, 2018-03-25 at 13:52 -0700, Tony Lindgren wrote: > * Pavel Machek [180325 19:00]: > > Hi! > > > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it > > > > seems > > > > to react to AT commands, and in particular reacts to ADT123; (; > > > > is > > > >

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-24 Thread Dan Williams
On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > On Fri 2018-03-23 12:35:21, Sebastian Reichel wrote: > > Hi, > > > > On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > > > Hi! > > > > > > > > > Do you have the related dts patches picked from next? > > > > > > > > > > > >

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Dan Williams
On Thu, 2018-03-22 at 20:28 +0100, Pavel Machek wrote: > Hi! > > > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost > > > $ > > > sudo lsusb > > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > > Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Wed, 2018-01-31 at 16:32 -0600, Dan Williams wrote: > On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > > Hi Johan, > > > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan H

Re: [PATCH] option: Add support for Quectel EP06

2018-01-31 Thread Dan Williams
On Thu, 2018-02-01 at 09:17 +1100, Johan Hovold wrote: > On Wed, Jan 31, 2018 at 09:56:01AM +0100, Kristian Evensen wrote: > > Hi Johan, > > > > On Wed, Jan 31, 2018 at 7:38 AM, Johan Hovold > > wrote: > > > This will probably have to do for now, but we already have > > >

Re: [PATCH] USB: cdc-wdm: ignore -EPIPE from GetEncapsulatedResponse

2017-10-02 Thread Dan Williams
On Fri, 2017-09-22 at 22:18 +0200, Bjørn Mork wrote: > The driver will forward errors to userspace after turning most of > them > into -EIO. But all status codes are not equal. The -EPIPE (stall) in > particular can be seen more as a result of normal USB signaling than > an actual error. The state

Re: new usb LTE modem device

2017-08-09 Thread Dan Williams
On Wed, 2017-08-09 at 11:19 +0700, Lars Melin wrote: > On 8/9/2017 02:33, Bjørn Mork wrote: > > > > The qmi_wwan part looks fine to me. But you > > will need to split it in two patches since the two > > drivers are parts of different subsystems. > > > > The option driver use interface blacklists

Re: AW: new usb LTE modem device

2017-08-08 Thread Dan Williams
On Tue, 2017-08-08 at 22:22 +0200, Giuseppe Lippolis wrote: > > The option driver use interface blacklists instead of multiple > > match entries. > > You should probably follow the same style there. But this is up to > > Johan... > > Can I ask what ist he difference between .sendsetup and

Re: [PATCH v2] usb: serial: Add support for Qivicon USB ZigBee dongle

2017-07-03 Thread Dan Williams
On Mon, 2017-07-03 at 10:16 +0200, Frans Klaver wrote: > On Mon, Jul 3, 2017 at 10:13 AM, Johan Hovold > wrote: > > On Fri, Jun 30, 2017 at 02:49:55PM +0200, Frans Klaver wrote: > > > On Fri, Jun 30, 2017 at 2:44 PM, Stefan Triller > > ller.de> wrote: > > > >

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-05 Thread Dan Williams
esterb...@linux.intel.com> > Cc: Borislav Petkov <b...@suse.de> > Cc: Dan Williams <dan.j.willi...@intel.com> > Cc: Amir Goldstein <amir7...@gmail.com> > Cc: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> > Cc: Jani Nikula <jani.nik...@linux.intel.co

Re: [PATCH] option: add Quectel UC15, UC20, EC21, and EC25 modems

2017-03-09 Thread Dan Williams
On Thu, 2017-03-09 at 13:14 -0500, Balazs Harmath wrote: > So i can expect these to be added soon? Are you able to apply and test this patch, and see if it works for your device? That would help. Thanks! Dan > Thanks, > Bali > > > > On Mar 9, 2017, at 12:32 PM, Dan Will

[PATCH] option: add Quectel UC15, UC20, EC21, and EC25 modems

2017-03-09 Thread Dan Williams
Add Quectel UC15, UC20, EC21, and EC25. The EC20 is handled by qcserial due to a USB VID/PID conflict with an existing Acer device. Signed-off-by: Dan Williams <d...@redhat.com> --- NOTE: The UC20, EC21, and EC25 should also get a corresponding qmi_wwan patch but I don't have that lying

Re: Requeste to add Quectel EC21 in USB:serial:qcserial

2017-03-09 Thread Dan Williams
On Thu, 2017-03-09 at 10:28 +0100, Oliver Neukum wrote: > Am Mittwoch, den 08.03.2017, 17:30 -0500 schrieb Balazs Harmath: > > Hi guys, > > > > I’w working with a Quectel EC21 modem and i ran into an issue that > > the qcserial driver is not getting installed for it.  > > Previously i was working

Re: [PATCH net,stable] qmi_wwan/cdc_ether: add device ID for HP lt2523 (Novatel E371) WWAN card

2017-02-01 Thread Dan Williams
On Tue, 2017-01-24 at 10:36 +0100, Bjørn Mork wrote: > Bjørn Mork <bj...@mork.no> writes: > > > From: Dan Williams <d...@redhat.com> > > Woops! I didn't intend to blame this on you Dan.  Sorry. I reused > your > commit message, and obviously unin

Re: AW: add usb option device

2016-11-17 Thread Dan Williams
ices they actually should drive.  They should not claim interfaces they should not or cannot drive. Dan > Thanks, > Bye. > > > > > -Ursprüngliche Nachricht- > > Von: Oliver Neukum [mailto:oneu...@suse.com] > > Gesendet: Mittwoch, 16. November 2016 21:

Re: add usb option device

2016-11-17 Thread Dan Williams
On Thu, 2016-11-17 at 11:15 +0100, Johan Hovold wrote: > On Wed, Nov 16, 2016 at 10:03:52PM +0100, Giuseppe Lippolis wrote: > > > > Dear All, > > thanks for the very interesting discussion. > > > > > > > > > > > > > This will make option grab all the ports, as shown by your > > > > dmesg > > >

Re: add usb option device

2016-11-16 Thread Dan Williams
On Wed, 2016-11-16 at 11:49 -0600, Dan Williams wrote: > On Tue, 2016-11-15 at 20:13 +0100, Giuseppe Lippolis wrote: > > > > Dear all, > > I'm porting the Dlink DWR-512 device to LEDE (embedded linux). > > This device embed a 3G modem connected through the usb bus .

Re: add usb option device

2016-11-16 Thread Dan Williams
On Tue, 2016-11-15 at 20:13 +0100, Giuseppe Lippolis wrote: > Dear all, > I'm porting the Dlink DWR-512 device to LEDE (embedded linux). > This device embed a 3G modem connected through the usb bus . > The modem work properly with the option kernel module. > > I added these line in the  > >

Re: [patch] USB: serial: option: add WeTelecom WM-D200

2016-08-22 Thread Dan Williams
On Mon, 2016-08-22 at 20:07 +0300, Aleksandr Makarov wrote: > 22.08.2016 18:03, Dan Williams пишет: > > > > On Sat, 2016-08-20 at 14:50 +0300, Aleksandr Makarov wrote: > > > > > > USB: serial: option: add WeTelecom WM-D200 > > > > > > Add sup

Re: [patch] USB: serial: option: add WeTelecom WM-D200

2016-08-22 Thread Dan Williams
On Sat, 2016-08-20 at 14:50 +0300, Aleksandr Makarov wrote: > USB: serial: option: add WeTelecom WM-D200 > > Add support for WeTelecom WM-D200. > > T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  4 Spd=12  MxCh= 0 > D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1 > P:  Vendor=22de

Re: [PATCH] Support HP lt4114 LTE Module (Huawei ME206V-561)

2016-02-25 Thread Dan Williams
On Thu, 2016-02-25 at 18:15 +0100, Bjørn Mork wrote: > Dan Williams <d...@redhat.com> writes: > > On Mon, 2016-02-22 at 18:03 +0700, Lars Melin wrote: > > > On 2016-02-21 10:09, Daniel Johnson wrote: > > > > On Fri, Feb 19, 2016 at 12:27 AM, Bjørn Mork <bj..

Re: [PATCH] Support HP lt4114 LTE Module (Huawei ME206V-561)

2016-02-22 Thread Dan Williams
On Sun, 2016-02-21 at 12:44 +0700, Lars Melin wrote: > On 2016-02-20 03:34, Dan Williams wrote: > > On Fri, 2016-02-19 at 18:21 +0100, Bjørn Mork wrote: > > > Dan Williams <d...@redhat.com> writes: > > > > On Fri, 2016-02-19 at 21:20 +0700, Lars Me

Re: [PATCH] Support HP lt4114 LTE Module (Huawei ME206V-561)

2016-02-22 Thread Dan Williams
On Mon, 2016-02-22 at 18:03 +0700, Lars Melin wrote: > On 2016-02-21 10:09, Daniel Johnson wrote: > > On Fri, Feb 19, 2016 at 12:27 AM, Bjørn Mork wrote: > > > One of them is likely a QCDM port if this is really a Qualcomm > > > based > > > device.  The other might be an inactive

Re: [PATCH] Support HP lt4114 LTE Module (Huawei ME206V-561)

2016-02-19 Thread Dan Williams
On Fri, 2016-02-19 at 18:21 +0100, Bjørn Mork wrote: > Dan Williams <d...@redhat.com> writes: > > On Fri, 2016-02-19 at 21:20 +0700, Lars Melin wrote: > > > > > cfg #1 > > > MI_00 HP Mobile Connect - PC UI Interface > > > MI_01 HP Mobile Conne

Re: [PATCH] Support HP lt4114 LTE Module (Huawei ME206V-561)

2016-02-19 Thread Dan Williams
On Fri, 2016-02-19 at 21:20 +0700, Lars Melin wrote: > On 2016-02-19 17:31, Bjørn Mork wrote: > > Daniel Johnson writes: > > > > > > > Currently 4 ttyUSB devices are detected, but only the second > > > > > two respond to > > > > > AT commands. The first two serial ports may

Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

2016-01-04 Thread Dan Williams
On Mon, 2016-01-04 at 12:32 +0700, Lars Melin wrote: > On 2016-01-04 05:00, Jose Alonso wrote: > > > > The program Heimdall (http://glassechidna.com.au/heimdall) is used > > to flash a new firmware in Samsung Mobile Phones. It uses only the > > library libusb to access the device. > > > > The

Re: [PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-16 Thread Dan Williams
On Wed, 2015-12-16 at 10:39 +0100, Daniele Palmas wrote: > This patch series add support in the cdc_ncm driver for two devices > based on the same platform, that are different only for carrier > customization. > > The devices do not have ARP capabilities. > > Daniele Palmas (2): > net: usb:

Re: [PATCH 0/6] net: qmi_wwan: MDM9x30 support

2015-12-03 Thread Dan Williams
On Thu, 2015-12-03 at 19:24 +0100, Bjørn Mork wrote: > We add new device IDs all the time, often without any testing on > actual hardware. This is usually OK as long as the device is similar > to already supported devices, using the same chipset and firmware > basis. But the Sierra Wireless

Re: [PATCH v2] usb: Quiet down false peer failure messages

2015-12-03 Thread Dan Williams
ion and just turns the pr_warn into > pr_debug to quiet things down. > > Tested on my Intel box. > > Signed-off-by: Don Zickus <dzic...@redhat.com> Acked-by: Dan Williams <dan.j.willi...@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: Quiet down false peer failure messages

2015-11-30 Thread Dan Williams
On Tue, Nov 17, 2015 at 1:00 PM, Don Zickus wrote: > My recent Intel box is spewing these messages: > > xhci_hcd :00:14.0: xHCI Host Controller > xhci_hcd :00:14.0: new USB bus registered, assigned bus number 2 > usb usb2: New USB device found, idVendor=1d6b,

Re: Celot modem driver

2015-11-25 Thread Dan Williams
On Wed, 2015-11-25 at 13:13 +0100, M. Hrdlička wrote: > Hello, > log script told me, that I may to tell you about add this device to > propper linux driver. > > Device is combo USB modem Celot CTD-200, manufacturing date in > September 2010, it´s combinated GSM (GPRS/UMTS/HSPA) and CDMA modem. >

Re: Obtaining USB vendor/product ID in C language given a modem file path

2015-11-18 Thread Dan Williams
On Wed, 2015-11-18 at 18:56 -0800, ToddA wrote: > Hi, > > If this isn't the correct mailing list for this question, do let me > know > if there's a better one where I could ask. > > I have a C language program that talks to modems and these days it is > almost always a USB modem. For diagnostic

Re: [PATCH] USB: qcserial: Add support for Quectel EC20 Mini PCIe module

2015-11-04 Thread Dan Williams
On Wed, 2015-11-04 at 16:57 +0100, Bjørn Mork wrote: > Petr Štetiar writes: > > > Bjørn Mork [2015-11-04 13:15:10]: > > > >> Based on that, I wonder if it wouldn't be more appropriate to simply do > >> this as a device specific quirk in the qmi_wwan probe? > > > >

Re: Resetting USB modems and USB to serial converters increases ttyUSBXX counter

2015-10-22 Thread Dan Williams
On Thu, 2015-10-22 at 10:39 +0200, Erwin Van de Velde wrote: > Hi all, > > Thank you for your helpful answers! I have investigated it further, > stopping potential culprits in userspace and I have found the issue: > it is modemmanager that seems to keep the devices open somewhere and > thus

Re: Huawei E3131

2015-08-12 Thread Dan Williams
On Wed, 2015-08-12 at 23:17 +0200, Martin Mokrejs wrote: Hi Bjorn, my have a new USB 3G modem sold in Czech Republic by T-Mobile. So far it works for me only using the option driver and pppd. The 'qmi-network /dev/cdc-wdm0' does not work for me. Maybe it has no QMI interface ('modprobe

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Dan Williams
On Thu, 2015-07-02 at 15:43 +0200, Oliver Neukum wrote: On Thu, 2015-07-02 at 20:33 +0700, Lars Melin wrote: On 2015-07-02 20:01, Oliver Neukum wrote: On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: Then I would like to

Re: cdc_acm / cdc_wdm issue. Connection to device lost (Sony Ericsson w660)

2015-06-20 Thread Dan Williams
On Fri, 2015-06-19 at 19:43 +0200, Fab Stz wrote: Oh ! I just realized my mistake. Actually it is not the kernel that is faulty but my configuration (since I migrated from debian wheezy to jessie). I had connection/disconnection issues because of conflicts between gammu and ModemManager.

Re: usbserial option driver newid

2015-03-05 Thread Dan Williams
On Wed, 2015-03-04 at 22:00 -0500, Rick Farina wrote: On 03/04/15 13:01, Greg KH wrote: And again, a kernel patch is the real way to fix it for everyone. Okay, got a lot of things figured out and have everything working now. Glad I spent the extra time because I found some neat things on

Re: difference in option.ko and sierra.ko Linux drivers

2015-02-05 Thread Dan Williams
On Thu, 2015-02-05 at 07:33 -0800, Greg KH wrote: On Thu, Feb 05, 2015 at 07:36:40PM +0530, temp sha wrote: You mean to say only Sierra has its own proprietary commands and no one else ? What is so special about Sierra that requires a dedicated driver in Linux while rest of all vendors

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Dan Williams
that is incremented each time a new rfkill interface is added. Suggested-by: Dan Williams d...@redhat.com Signed-off-by: Olivier Sobrie oliv...@sobrie.be --- drivers/net/usb/hso.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

2015-01-30 Thread Dan Williams
On Fri, 2015-01-30 at 17:15 +0100, Olivier Sobrie wrote: Hello Dan, On Fri, Jan 30, 2015 at 09:47:59AM -0600, Dan Williams wrote: On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote: By using only the usb interface number for the rfkill name, we might have a name conflicts in case

Re: difference in option.ko and sierra.ko Linux drivers

2015-01-29 Thread Dan Williams
On Thu, 2015-01-29 at 06:23 -0800, Greg KH wrote: On Thu, Jan 29, 2015 at 02:50:13PM +0530, temp sha wrote: Can any one let me know the difference in option and sierra kernel modules ? looks like both drivers support GSM modem. And from the source code perspective both look similar. I am

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-26 Thread Dan Williams
On Mon, 2015-01-26 at 19:17 +0100, Johan Hovold wrote: On Mon, Jan 26, 2015 at 04:00:26PM +0100, Henri Manson wrote: Hello, I performed the test using VirtualBox and live cd iso images, so mixing different version of kernel and user-space programs does not happen. You'd probably

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-26 Thread Dan Williams
will then ignore it. What is the VID/PID again so that we can add it to the upstream blacklist? Dan On Mon, Jan 26, 2015 at 10:20 PM, Dan Williams d...@redhat.com wrote: On Mon, 2015-01-26 at 19:17 +0100, Johan Hovold wrote: On Mon, Jan 26, 2015 at 04:00:26PM +0100, Henri Manson wrote: Hello

Re: Fatal Exception on device when Hotsyncing Palm in linux

2015-01-26 Thread Dan Williams
On Mon, 2015-01-26 at 23:33 +0100, Henri Manson wrote: From lsusb: Bus 008 Device 013: ID 0830:0002 Palm, Inc. m505 I've blacklisted anything driven by 'visor' upstream in ModemManager, since most of those appear to be non-phone devices. Yes, 3 are phones (Samsung and Acer) but they are so

Re: [PATCH 04/11] hso: fix memory leak in hso_create_rfkill()

2015-01-20 Thread Dan Williams
On Tue, 2015-01-20 at 14:13 +0100, Oliver Neukum wrote: On Tue, 2015-01-20 at 13:29 +0100, Olivier Sobrie wrote: When the rfkill interface was created, a buffer containing the name of the rfkill node was allocated. This buffer was never freed when the device disappears. To fix the

Re: Understanding what's going on when using a Huawei E173 USB 3G web-stick (UMTS/HSPA)

2014-11-14 Thread Dan Williams
On Fri, 2014-11-14 at 11:56 +0100, Sedat Dilek wrote: On Wed, Nov 12, 2014 at 2:21 PM, Sedat Dilek sedat.di...@gmail.com wrote: On Tue, Nov 4, 2014 at 5:55 PM, Dan Williams d...@redhat.com wrote: On Tue, 2014-11-04 at 16:11 +0100, Sedat Dilek wrote: Hi, I wanted to understand what

Re: Understanding what's going on when using a Huawei E173 USB 3G web-stick (UMTS/HSPA)

2014-11-04 Thread Dan Williams
On Tue, 2014-11-04 at 16:11 +0100, Sedat Dilek wrote: Hi, I wanted to understand what is going on the kernel-side when connecting to the Internet via a Huawei E173 USB web-stick (3rd Generation: UMTS / HSPA). Especially the correlation between the diverse USB/NET kernel-drivers and how

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Dan Williams
On Mon, 2014-10-27 at 20:40 +0100, Oliver Neukum wrote: On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: I guess we could use that quirk, but I'm actually leaning towards just removing that quirk and reducing the log level of the message to info. Oliver, what do you say? Now

Re: [PATCH] option: add Haier CE81B CDMA modem

2014-10-22 Thread Dan Williams
On Wed, 2014-10-22 at 10:18 +0200, Johan Hovold wrote: On Tue, Oct 14, 2014 at 11:10:41AM -0500, Dan Williams wrote: Port layout: 0: QCDM/DIAG 1: NMEA 2: AT 3: AT/PPP Signed-off-by: Dan Williams d...@redhat.com --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2

[PATCH] option: add Haier CE81B CDMA modem

2014-10-14 Thread Dan Williams
Port layout: 0: QCDM/DIAG 1: NMEA 2: AT 3: AT/PPP Signed-off-by: Dan Williams d...@redhat.com --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d1a3f60..8d8764d 100644 --- a/drivers/usb/serial

Re: ax88179_178a hang over xhci

2014-09-07 Thread Dan Williams
On Sat, Sep 6, 2014 at 10:05 AM, Andrea Arcangeli aarca...@redhat.com wrote: On Sat, Sep 06, 2014 at 05:33:19PM +0200, Andrea Arcangeli wrote: without weaking any /sysfs pm runtime related file, and I'll let you know if it hangs again. No luck... it already hung again with the patches

Re: [xhci] BUG: unable to handle kernel NULL pointer dereference at (null)

2014-08-27 Thread Dan Williams
e65e21a542cab81d794db4e5fe919c4e1d624ea7 Author: Dan Williams dan.j.willi...@intel.com AuthorDate: Tue Jul 22 00:08:51 2014 -0700 Commit: Dan Williams dan.j.willi...@intel.com CommitDate: Fri Aug 22 10:06:50 2014 -0700 xhci: unit test ring enqueue/dequeue routines Given the complexity

Re: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 3:37 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams It's confusing (to me at least) to keep on remembering the differences between event rings (managed by the hardware) and non-event rings managed by the host. Replace if (ring-type == FOO) branches

Re: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 3:55 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams v1.0 hosts require that TD-fragments (portions of a TD that do not end on a MPB boundary) not cross a TRB segment boundary. This constraint is in addition to the constraint that a TRB may

Re: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 9:21 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams [mailto:dan.j.willi...@intel.com] On Tue, Aug 26, 2014 at 3:37 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams It's confusing (to me at least) to keep on remembering

[RFC PATCH 01/20] xhci: cleanup remaining cycle bit toggles via ternary conditional

2014-08-22 Thread Dan Williams
These can simply be toggled via xor. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 749fc68eb5c1

[RFC PATCH 02/20] xhci: remove invalid cast of xhci to a usb_device in xhci_log_ctx trace

2014-08-22 Thread Dan Williams
An xhci controller device is a pci or a platform device, never a usb_device. Cc: Xenia Ragiadakou burzalod...@gmail.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-trace.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/usb

[RFC PATCH 04/20] xhci: increase trb segment size, kill -segment_pool

2014-08-22 Thread Dan Williams
instance. In support of freeing segments from irq context struct xhci_segment grows a -dev and -ew field (exectue_work). As a result there is no longer a need to pass a 'xhci' parameter down to xhci_free_segment(). Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-mem.c

[RFC PATCH 05/20] xhci: prepare for mid-segment link-trbs

2014-08-22 Thread Dan Williams
coded link at the end assumption. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-mem.c | 17 +++-- drivers/usb/host/xhci-ring.c |7 ++- drivers/usb/host/xhci.c | 12 drivers/usb/host/xhci.h |1 + 4 files changed, 18

[RFC PATCH 03/20] xhci: introduce xhci_to_dev

2014-08-22 Thread Dan Williams
Replace many occurrences of xhci_to_hcd(xhci)-self.controller with a helper. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-mem.c | 29 - drivers/usb/host/xhci.c |6 +++--- drivers/usb/host/xhci.h | 13 + 3

[RFC PATCH 11/20] xhci: provide helpers for retrieving 'enqueue' and 'dequeue' pointers

2014-08-22 Thread Dan Williams
In prepartion for converting ring management from pointers to power-of-2 indexes, introduce xhci_ring_dequeue(), xhci_ring_enqueue(), xhci_ring_set_dequeue(), and xhci_ring_set_enqueue(). Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-dbg.c | 16 ++-- drivers

[RFC PATCH 06/20] xhci: drop 'xhci' argument to last_trb

2014-08-22 Thread Dan Williams
last_trb() can simply distinguish event rings by the ring -type. With this in place the 'xhci' parameter can be removed from last_trb_on_last_seg(), next_trb(), and inc_deq(). Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c | 75

[RFC PATCH 08/20] xhci: refactor inc_enq(), share a common advance_enq() with prepare_ring()

2014-08-22 Thread Dan Williams
endpoint rings into event_ring_inc_enq() and common_inc_enq(). Unfortunately this isn't a net win in the diffstat, but it does eliminate the liability of failing to update one of the instances especially in preparation for overhauling TD-fragment handling for xhci1.0+ hosts. Signed-off-by: Dan Williams

[RFC PATCH 12/20] xhci: introduce struct xhci_ring_pointer

2014-08-22 Thread Dan Williams
Consolidate ring pointer tracking variables into their own type. This simplifies the calling convention of some routines and allows for the later introduction of integer ring index variables. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-dbg.c |8 + drivers

[RFC PATCH 13/20] xhci: use %pad for printing dma_addr_t

2014-08-22 Thread Dan Williams
Clean up verbose (unsigned long long) casts. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-dbg.c | 70 - drivers/usb/host/xhci-mem.c | 46 --- drivers/usb/host/xhci-ring.c | 41

[RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-22 Thread Dan Williams
for xhci1.0+ ring handling which will have it's own ring ops. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-mem.c | 63 ++--- drivers/usb/host/xhci-ring.c | 306 +- drivers/usb/host/xhci.h | 28 +++- 3 files changed

[RFC PATCH 00/20] xhci: implement xhci-v1+ td-fragment rules, test

2014-08-22 Thread Dan Williams
those hosts. --- For testing convenience these patches are available via git at: git://git.kernel.org/pub/scm/linux/kernel/git/djbw/usb td-fragments-v1 Note that this branch may be rebased and/or abandoned (in favor of a td-fragments-v2+) as the set is revised. Dan Williams (20): xhci

[RFC PATCH 10/20] xhci: clarify ring valid checks

2014-08-22 Thread Dan Williams
All rings have -dequeue = -enqueue = first trb in first segment, so it is redundant to check if -dequeue is NULL when -ring is set. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-hub.c |5 ++--- drivers/usb/host/xhci-ring.c |2 +- 2 files changed, 3

[RFC PATCH 17/20] xhci: combine xhci_queue_bulk_tx() and queue_bulk_sg_tx()

2014-08-22 Thread Dan Williams
The only difference between these two routines is that the latter handles a scatterlist of more than one entry. Fake a single entry scatterlist for the non-sg case, and delete the duplicate code. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c | 158

[RFC PATCH 16/20] xhci: refactor prepare_transfer()

2014-08-22 Thread Dan Williams
boundary. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c | 122 -- 1 files changed, 70 insertions(+), 52 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 27d271e26445

[RFC PATCH 18/20] xhci: add xhci_ring_reap_td() helper

2014-08-22 Thread Dan Williams
TDs from endpoint rings are open-coded cleaned up in a duplicate fashion in two places. Provide common helper. This is later used to as a place to inject ring-type-specific post-reap operations. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c | 17

[RFC PATCH 14/20] xhci: power-of-2 ring sizes

2014-08-22 Thread Dan Williams
as the dequeue pointer? The open coded num_trbs alignment statement in xhci_ring_expansion() is replaced with the standard ALIGN macro. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-mem.c | 45 ++- drivers/usb/host/xhci.c

[RFC PATCH 15/20] xhci: kill -num_trbs_free_temp in struct xhci_ring

2014-08-22 Thread Dan Williams
This can simply be done inline in xhci_queue_isoc_tx(). Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c |6 +++--- drivers/usb/host/xhci.h |1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b

[RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-22 Thread Dan Williams
. MBP: Max Burst Packet, is the minimum amount of data hardware expects to transfer before the end of a segment (assuming the TD spans a segment boundary). Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-mem.c | 17 + drivers/usb/host/xhci-ring.c | 620

[RFC PATCH 20/20] xhci: unit test ring enqueue/dequeue routines

2014-08-22 Thread Dan Williams
and that the infrastructure is custom rather than generic. That said, it serves its purpose of exercising the corner cases of the scatterlist parsing implementation in xhci. Cc: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/Kconfig

Re: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-22 Thread Dan Williams
On Fri, Aug 22, 2014 at 10:57 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 22 Aug 2014, Dan Williams wrote: v1.0 hosts require that TD-fragments (portions of a TD that do not end on a MPB boundary) not cross a TRB segment boundary. This constraint is in addition to the constraint

Re: [PATCH] net/usb/hso: Add support for Option GTM671WFS

2014-08-05 Thread Dan Williams
,,V,,N*53 $GPGSA,A,1,,,*1E On Mon, Aug 4, 2014 at 8:30 PM, Dan Williams d...@redhat.com wrote: On Mon, 2014-08-04 at 11:20 +0200, Ricardo Ribalda Delgado wrote: Suggested-by: Dan Williams d...@redhat.com Before we apply this patch though, can you grab

Re: [PATCH] net/usb/hso: Add support for Option GTM671WFS

2014-08-05 Thread Dan Williams
/ttyHS0 /dev/ttyHS1 /dev/ttyHS2 /dev/ttyHS3 /dev/ttyHS4 /dev/ttyHS5 Acked-by: Dan Williams d...@redhat.com root@qt5022:~# lsusb -d 0af0: -vvv Bus 002 Device 003: ID 0af0:9200 Option Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00

Re: [PATCH] serial/option: Add support for Option GTM671WFS

2014-08-05 Thread Dan Williams
On Mon, 2014-08-04 at 11:12 +0200, Ricardo Ribalda Delgado wrote: Hello Dan Are you 100% sure these don't go into the 'hso' driver? 'option' is used for mostly older Option devices (like 5+ years old). I tried to find information about this module, and the closest I could come for

Re: [PATCH] net/usb/hso: Add support for Option GTM671WFS

2014-08-04 Thread Dan Williams
On Mon, 2014-08-04 at 11:20 +0200, Ricardo Ribalda Delgado wrote: Suggested-by: Dan Williams d...@redhat.com Before we apply this patch though, can you grab for the following for me? cat /sys/class/tty/*/hsotype and lets see if the firmware actually responds. Also, do you get an 'hso0

Re: USB modem interface not detected sometimes

2014-08-01 Thread Dan Williams
On Fri, 2014-08-01 at 21:44 +0530, Rahul Bedarkar wrote: Hi, I have USB modem which has also support for micro SD card. With kernel version 3.15 and later, I am facing a issue with modem interface detection. When I connect it first time only storage interface is detected. I had to

Re: [PATCH] serial/option: Add support for Option GTM671WFS

2014-08-01 Thread Dan Williams
On Fri, 2014-08-01 at 14:00 +0200, Ricardo Ribalda Delgado wrote: After this patch: [5.389385] usbserial: USB Serial support registered for GSM modem (1-port) [5.390181] option 2-1.4:1.0: GSM modem (1-port) converter detected [5.390556] usb 2-1.4: GSM modem (1-port) converter now

Re: [xhci] kernel BUG at include/linux/scatterlist.h:115!

2014-07-30 Thread Dan Williams
: Dan Williams dan.j.willi...@intel.com AuthorDate: Tue Jul 22 00:08:51 2014 -0700 Commit: Dan Williams dan.j.willi...@intel.com CommitDate: Thu Jul 24 18:12:38 2014 -0700 xhci: unit test ring enqueue/dequeue routines Given the complexity of satisfying xhci 1.0+ host trb

Re: Problem with D-Link USB 3.0 to Gigabit Ethernet Adapter DUB-1312

2014-07-25 Thread Dan Williams
On Wed, Jul 23, 2014 at 6:52 AM, Marek Uher xu...@seznam.cz wrote: Hi Sarah, Thank you very much for your answer. I bought three same all-in-one, low-energy and space effective computers from ASUS. There isn’t any possibility to add an additional extension PCIe card. There is only

Re: 03f0:521d Hewlett-Packard (HP hs3110)

2014-07-23 Thread Dan Williams
On Wed, 2014-07-23 at 14:33 +, Stanescu Victor wrote: /dev/cdc-wdm2 doesn't work. Further more, instead of freezing at cat, it freezes from echo. Ctrl-c doesn't stop the frozen echo. I'm pretty sure this device does not expose QMI at all, from looking at through the drivers. The driver

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

2014-07-07 Thread Dan Williams
On Mon, 2014-07-07 at 11:06 +0200, Olivier Sobrie wrote: When the module sends bursts of data, sometimes a deadlock happens in the hso driver when the tty buffer doesn't get the chance to be flushed quickly enough. To avoid this, first, we remove the endless while loop in put_rx_bufdata()

Re: Re:Re: move ZTE CDMA device pid from zte_ev.c back to option.c and modify a parameter in zte_ev.ko

2014-06-23 Thread Dan Williams
On Mon, 2014-06-23 at 18:15 +0800, 刘磊 wrote: Could you try the first patch (only) and see if it fixes the problem? Does it also fix the problem you're having with PID 0xfffe? yes, the first patch could solve the problem with pid 0xfffe. When you you have tested the first patch, could you

Re: [RFC] xhci: Fix xhci block system enter system suspend state.

2014-06-23 Thread Dan Williams
On Sun, Jun 22, 2014 at 7:33 AM, Alan Stern st...@rowland.harvard.edu wrote: On Sun, 22 Jun 2014, Wang, Yu wrote: From: Wang, Yu yu.y.w...@intel.com The system suspend flow as following: 1, Freeze all user processes and kenrel threads. 2, Trying to suspend all devices. 2.1, If pci device

Re: [PATCH net,stable] net: huawei_cdc_ncm: increase command buffer size

2014-06-18 Thread Dan Williams
) Cc: Enrico Mioso mrkiko...@gmail.com Reported-by: Dan Williams d...@redhat.com Signed-off-by: Bjørn Mork bj...@mork.no Tested-by: Dan Williams d...@redhat.com 'CRLF^SYSCFGEX: (00,01,02,03,99),((400380,GSM900/GSM1800/WCDMA2100),(6a8,GSM850/GSM1900/WCDMA850/AWS/WCDMA1900),(3fff,All

Re: [PATCH 0/3] port power control fixes for 3.16-rc2

2014-06-18 Thread Dan Williams
On Wed, Jun 18, 2014 at 1:18 AM, Bjørn Mork bj...@mork.no wrote: Dan Williams dan.j.willi...@intel.com writes: I put patch 3 usb: fix hub-port pm_runtime_enable() vs runtime pm transitions through it's paces, but I'd still like to see a positive test report from Bjørn... even if it's too late

Re: [PATCH 3/3] usb: fix hub-port pm_runtime_enable() vs runtime pm transitions

2014-06-18 Thread Dan Williams
On Wed, Jun 18, 2014 at 7:54 AM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 17 Jun 2014, Dan Williams wrote: Commit 9262c19d14c4 usb: disable port power control if not supported in wHubCharacteristics gated enabling runtime pm for usb_port devices on whether the parent hub supports

[PATCH 0/3] port power control fixes for 3.16-rc2

2014-06-17 Thread Dan Williams
power off by enforcing the PM_QOS_NO_POWER_OFF constraint from the kernel rather than disabling runtime power management. --- Dan Williams (3): usb: improve not suspended yet message in hub_suspend() usb: quiet peer failure warning, disable poweroff usb: fix hub-port

[PATCH 2/3] usb: quiet peer failure warning, disable poweroff

2014-06-17 Thread Dan Williams
In the case where platform firmware has specified conflicting values for port locations it is confusing and otherwise not helpful to throw a backtrace. Instead, include enough information to determine that firmware has done something wrong and globally disable port poweroff. Signed-off-by: Dan

[PATCH 3/3] usb: fix hub-port pm_runtime_enable() vs runtime pm transitions

2014-06-17 Thread Dan Williams
-by: Bjørn Mork bj...@mork.no Reported-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c |6 drivers/usb/core/hub.h |2 + drivers/usb/core/port.c | 65 +-- 3 files

[PATCH 1/3] usb: improve not suspended yet message in hub_suspend()

2014-06-17 Thread Dan Williams
://marc.info/?l=linux-usbm=140290586301336w=2 Reported-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c

Re: [PATCH 0/3] port power control fixes for 3.16-rc2

2014-06-17 Thread Dan Williams
On Tue, Jun 17, 2014 at 5:06 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jun 17, 2014 at 04:16:16PM -0700, Dan Williams wrote: Fallout / regression fixes for the port power control rework that landed in 3.16-rc1. 1/ Cosmetic fix to an error message 2/ Handle ACPI port-location

  1   2   3   4   5   6   7   >