Re: [PATCH v5 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Sat, Mar 17, 2018 at 11:07:27AM +1100, Benjamin Herrenschmidt wrote: On Sat, 2018-03-17 at 04:29 +0800, kbuild test robot wrote: Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [if your patch is applied to the wrong git tree, please drop

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

On Fri, Jan 26, 2018 at 10:58:56AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2018-01-24 at 11:30 +0800, kbuild test robot wrote: Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.15-rc9 next-20180119]

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

kbuild just spit out the following warning for this patch: drivers/usb/host/max3421-hcd.c:1707:2-8: preceding lock on line 1702 Error ids grouped by kconfigs: recent_errors └── i386-allmodconfig └── drivers-usb-host-max3421-hcd.c:preceding-lock-on-line I don't really know what it means,

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

Hi Josh, On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: Fengguang, assuming it's reliably recreatable, any chance you could recreate with the following patch? Sorry, here's a version which actually compiles.

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

Hi Josh, On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: Fengguang, assuming it's reliably recreatable, any chance you could recreate with the following patch? Sure, I'll try your patch on v4.14-rc3 since it

Re: [LKP] [usb] bea5b158ff WARNING: CPU: 0 PID: 25 at drivers/usb/core/urb.c:338 usb_submit_urb

The dummy_udc WARN is gone with this patch for 100+ times of boot tests. Tested-by: Xiaolong Ye Thanks, Xiaolong Thanks, Xiaolong. I will submit a patch for it. Thank you Peter! We've been noised by this warning for quite some time. Fengguang -- To unsubscribe from

[usb] bea5b158ff WARNING: CPU: 0 PID: 25 at drivers/usb/core/urb.c:338 usb_submit_urb

[Sorry, resend to correct Felipe's email address] Greetings, This debug patch possibly discloses some USB/I2C bugs. Since the USB warning shows up earlier in dmesg, it might also be the root cause of the I2C bug. The attached reproduce-* script may help debug them.

[usb] bea5b158ff WARNING: CPU: 0 PID: 25 at drivers/usb/core/urb.c:338 usb_submit_urb

Greetings, This debug patch possibly discloses some USB/I2C bugs. Since the USB warning shows up earlier in dmesg, it might also be the root cause of the I2C bug. The attached reproduce-* script may help debug them. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

Re: [usb:usb-next 124/126] ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined!

On Mon, Sep 12, 2016 at 11:36:20AM +0800, Peter Chen wrote: On Mon, Sep 12, 2016 at 07:16:07AM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: ab57f86198d6ff20371613d4a02fd4841972a5c0 commit:

Re: [usb:usb-next 124/126] ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined!

Hi Peter, On Mon, Sep 12, 2016 at 11:36:20AM +0800, Peter Chen wrote: On Mon, Sep 12, 2016 at 07:16:07AM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: ab57f86198d6ff20371613d4a02fd4841972a5c0 commit:

Re: [PATCH] HID: fix noderef.cocci warnings

nter > > sizeof when applied to a pointer typed expression gives the size of the > pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > CC: Masaki Ota <masaki@jp.alps.com> > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > --- &g

[PATCH] usb: gadget: f_hid: hidg_alloc() can be static

drivers/usb/gadget/function/f_hid.c:852:21: sparse: symbol 'hidg_alloc' was not declared. Should it be static? Signed-off-by: Fengguang Wu fengguang...@intel.com --- f_hid.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb

[PATCH] usb: gadget: fix ptr_ret.cocci warnings

drivers/usb/gadget/udc/r8a66597-udc.c:1849:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu fengguang...@intel.com --- r8a66597-udc.c |5 + 1 file

[xhci] kernel BUG at arch/x86/mm/physaddr.c:26!

Hi Dan, Just in case it helps, here we find a different bug message in the same commit. git://git.kernel.org/pub/scm/linux/kernel/git/djbw/usb.git td-fragments-v1 commit e65e21a542cab81d794db4e5fe919c4e1d624ea7 Author: Dan Williams dan.j.willi...@intel.com AuthorDate: Tue Jul 22 00:08:51

drivers/usb/musb/tusb6010.c:946:2: error: implicit declaration of function 'irq_set_irq_type'

Greetings, These *huge number* of *long standing* errors make me wonder whether the below USB driver code should be disabled on s390? tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master head: 9064171268d838b8f283fe111ef086b9479d059a commit:

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions gadgets

On Mon, Mar 04, 2013 at 10:28:09PM +0100, Sebastian Andrzej Siewior wrote: Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc into the kernel. The problem was that u_serial was used by g_cdc before u_serial was initialized. In the module case eveything is initialized

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions gadgets

On Tue, Mar 05, 2013 at 05:57:34PM +0800, Fengguang Wu wrote: On Mon, Mar 04, 2013 at 10:28:09PM +0100, Sebastian Andrzej Siewior wrote: Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc into the kernel. The problem was that u_serial was used by g_cdc before u_serial

Re: [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common()

On Wed, Feb 27, 2013 at 12:49:35PM +0200, Felipe Balbi wrote: Hi, On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu wrote: Greetings, I got the below warning and the first bad commit is can you send a fixup patch ? Sorry I don't have the fix. Maarten once proposed : Can you

Re: [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common()

On Sat, Mar 02, 2013 at 02:41:07PM +0100, Sebastian Andrzej Siewior wrote: On 03/02/2013 02:37 PM, Fengguang Wu wrote: On Wed, Feb 27, 2013 at 12:49:35PM +0200, Felipe Balbi wrote: Hi, On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu wrote: Greetings, I got the below warning

[PATCH] usb: gadget: make userial_init() static

Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/usb/gadget/u_serial.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/usb/gadget/u_serial.c 2013-02-03 09:50:18.422689811 +0800 +++ linux-next/drivers/usb/gadget/u_serial.c2013-02-03 09

[PATCH] usb: gadget: make gzero_options static

Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/usb/gadget/zero.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/usb/gadget/zero.c 2013-02-03 09:50:18.426689812 +0800 +++ linux-next/drivers/usb/gadget/zero.c2013-02-03 09:53

Re: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote: On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote: [snip] I am formatting and re-test the patches. I will send out today. Thanks. great, please make sure to compile test on x86 and ARM with allyesconfig, allnoconfig

[usb:usb-next 4/10] drivers/usb/misc/usb3503.c:238 usb3503_probe() error: we previously assumed 'pdata' could be null (see line 196)

) ? hub : standby); --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More

Re: [usb:usb-next 4/10] drivers/usb/misc/usb3503.c:238 usb3503_probe() error: we previously assumed 'pdata' could be null (see line 196)

Dongjin, Do I need to send another patch on top of it to fix the warning or Yes, you'll need to send another incremental fix to Greg. Thanks, Fengguang -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] usb: misc: usb3503_probe() can be static

Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/usb/misc/usb3503.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/usb/misc/usb3503.c 2013-01-12 13:12:34.367933402 +0800 +++ linux-next/drivers/usb/misc/usb3503.c 2013-01-12 13:12

[balbi-usb:gadget 13/13] drivers/usb/gadget/m66592-udc.c:1756:1: warning: data definition has no type or storage class

module_platform_driver_probe(m66592_driver, m66592_probe); --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [net-next:master 209/235] drivers/net/usb/smsc95xx.c:1134:39-50: ERROR: reference preceded by free on line 1136

support for more frame types :: TO: Steve Glendinning steve.glendinn...@shawell.net :: CC: David S. Miller da...@davemloft.net --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation

Re: [usb:usb-next 92/93] drivers/usb/chipidea/../host/ehci.h:665:2: error: implicit declaration of function 'readl'

On Fri, Nov 02, 2012 at 03:13:54PM -0400, Alan Stern wrote: On Sat, 3 Nov 2012, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: bc8d51ea7e8ae0abb90fa89407b55a7e0bcb0a2a commit: 09f6ffde2ecef4cc4e2a5edaa303210cabd96f57 [92/93

Re: [usb:usb-next 87/89] usbmisc_imx6q.c:(.text+0xa30): multiple definition of `ehci_init_driver'

On Fri, Nov 02, 2012 at 11:13:56AM +0200, Felipe Balbi wrote: Hi, On Fri, Nov 02, 2012 at 02:05:52AM +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 99f91934a907df31ba878dfdd090002049dc476a commit:

[usb:usb-next 92/93] drivers/usb/chipidea/../host/ehci.h:665:2: error: implicit declaration of function 'readl'

} 8cd42e97 Kumar Gala 2006-01-20 680 --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

On Thu, Nov 01, 2012 at 04:47:14PM +0300, Max Filippov wrote: On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: On Thu, Nov 01, 2012 at 12:33:39PM

Re: [usb:usb-next 89/89] drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be'

Hi Alan, It's hard to know which headers are needed for foreign architectures. Still, I think this ought to fix the problems you found. Can you test this patch? Yes, it works. Thanks for the quick fix! Thanks, Fengguang Index: usb-3.7/drivers/usb/host/ehci-platform.c

Re: [balbi-usb:i2c-transferred-bytes-on-NACK 7/9] drivers/media/i2c/adv7604.c:406:9: warning: initialization makes integer from pointer without a cast

On Wed, Oct 24, 2012 at 04:37:20PM +0300, Felipe Balbi wrote: Hi, On Wed, Oct 24, 2012 at 09:23:23PM +0800, Fengguang Wu wrote: Sorry, this should really be CCed to the media list. I'll use the list recommended by get_maintainer.pl in future. Actually, I would suggest only testing

Re: [PATCH usb:usb-next] USB: ezusb: make some vars/funcs static

On Thu, Sep 27, 2012 at 10:10:26AM -0700, Greg KH wrote: On Thu, Sep 27, 2012 at 02:24:13PM +0800, Fengguang Wu wrote: Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/usb/misc/ezusb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) tree: git

[PATCH usb:usb-next] USB: ezusb: make some vars/funcs static

Signed-off-by: Fengguang Wu fengguang...@intel.com --- drivers/usb/misc/ezusb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 70c048a238c780c226eb4b115ebaa908cb3b34ec commit

[usb:usb-next 25/32] drivers/usb/serial/omninet.c:165:6: warning: unused variable 'i'

build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

usb-serial.c:1415 code aligned with following code on line 1416

= serial_drivers; *sd; ++sd) { 1414 if ((*sd)-reset_resume) 1415 udriver-reset_resume = usb_serial_reset_resume; 1416 break; 1417 } --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan

ehci-dbg.c:656 fill_periodic_buffer() warn: variable dereferenced before check 'p.qh' (see line 599)

Source Technology Centre Fengguang Wu w...@linux.intel.com Intel Corporation -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu w...@linux.intel.com Intel Corporation -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

On Wed, Sep 12, 2012 at 03:02:13PM +0300, Felipe Balbi wrote: Hi, On Wed, Sep 12, 2012 at 11:50:57AM +0300, Dan Carpenter wrote: On Wed, Sep 12, 2012 at 04:26:22PM +0800, Fengguang Wu wrote: Hi Felipe, FYI, there are new smatch warnings show up in tree: git

Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)

On Mon, Sep 10, 2012 at 07:05:15PM +0200, Sebastian Andrzej Siewior wrote: On 09/10/2012 06:40 PM, Fengguang Wu wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master head: d9c88901337158c9f253a7de58a10b5125d61d26 commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f

Re: [balbi-usb:master 18/19] drivers/usb/musb/musb_core.c:357:21: error: 'struct usb_phy' has no member named 'state'

as a reviewer in the to list of the patch. Plz verify and let me know if you still see any issues. It should be fine if you already verified the patch with allmodconfig build test. When a commit tagged with Reported-by: Fengguang Wu fengguang...@intel.com is pushed to the git tree, the build system

Re: BUG: unable to handle kernel paging request in usb_match_id()

Hi Bjørn, -static const struct usb_device_id id_table[] __devinitconst = { +static const struct usb_device_id id_table[] = { Good catch! It magically fixed the oops. So that id_table was freed sometime with __devinitconst? There are some more usb_device_id .* __devinitconst users in the

Re: BUG: unable to handle kernel paging request in usb_match_id()

On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote: Hi Bjørn, -static const struct usb_device_id id_table[] __devinitconst = { +static const struct usb_device_id id_table[] = { Good catch! It magically fixed the oops. So that id_table was freed sometime with __devinitconst

Re: BUG: unable to handle kernel paging request in usb_match_id()

On Sun, Aug 05, 2012 at 09:58:26AM -0700, Greg KH wrote: On Sun, Aug 05, 2012 at 10:59:38AM +0800, Fengguang Wu wrote: Hi all, This line triggers an oops in kvm boot test: usb_match_id(): == 748 for (; id-idVendor || id-idProduct || id-bDeviceClass || 749