[PATCH] ACS ACR122U not working: pn533_usb 1-1:1.0: NFC: fix memdup.cocci warnings

linuxfoundation.org> Signed-off-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- url: https://github.com/0day-ci/linux/commits/Greg-KH/NFC-pn533-don-t-send-USB-data-off-of-the-stack/20180518-100416 :: branch date: 54 minutes ago

Re: [PATCH 3/3] usb: dwc2: Add High Bandwidth ISOC OUT support (fwd)

...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 3/3] usb: dwc2: Add High Bandwidth ISOC OUT support CC: kbuild-...@01.org In-Reply-To: <5bb6a333b4bf915cbc17742cf9f6b01ee36a1e0a.1521187611.git.hmi...@synopsys.com> References: <5bb6a333b4bf915cbc17742cf9f6b0

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub (fwd)

rom: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub CC: kbuild-...@01.org In-Reply-To: <2018012716.7039-2-b...@kernel.crashing.org> References: &

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Wed, 20 Dec 2017, Joe Perches wrote: > On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > > Why you didn't send that patch to the sysfs maintainer is a bit odd... > > > > :) > > > > > > So here's an opportunity for you: > > > > > > The sysfs maintainer hasn't added

Re: [PATCH] USB: emi26: Delete an error message for a failed memory allocation in emi26_writememory()

On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 13:03:21 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by:

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 10:20:49PM +0100, Julia Lawall wrote: > > > > > > On Wed, 22 Nov 2017, Joe Perches wrote: > > > > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > > There

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license

Re: [Outreachy kernel] Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 22 Nov 2017, Joe Perches wrote: > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

On Thu, 19 Oct 2017, Laurent Pinchart wrote: > Hi Christoph, > > On Thursday, 19 October 2017 17:06:57 EEST Christoph Hellwig wrote: > > > Now we have 9 const instances of the config_item_type structure that are > > > identical, with only the .ct_owner field set. Should they be all merged > > >

Re: [PATCH v2 00/15] make structure field, function arguments and structures const

On Tue, 17 Oct 2017, Greg KH wrote: > On Mon, Oct 16, 2017 at 05:18:39PM +0200, Bhumika Goyal wrote: > > Make the ci_type field and some function arguments as const. After this > > change, make config_item_type structures as const. > > > > * Changes in v2- Combine all the followup patches and

[usb:usb-testing 9/39] drivers/usb/host/max3421-hcd.c:1707:2-8: preceding lock on line 1702 (fwd)

It looks like an unlock is needed before line 1707. julia -- Forwarded message -- Date: Thu, 5 Oct 2017 19:35:31 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: [usb:usb-testing 9/39] driv

[PATCH 0/3] constify snd_rawmidi_ops structures

These snd_rawmidi_ops structures are only passed as the third argument of snd_rawmidi_set_ops. This argument is const, so the snd_rawmidi_ops structures can be const too. Done with the help of Coccinelle. --- drivers/hid/hid-prodikeys.c |2 +- drivers/usb/gadget/function/f_midi.c

[PATCH 1/3] usb: gadget: f_midi: constify snd_rawmidi_ops structures

These snd_rawmidi_ops structures are only passed as the third argument of snd_rawmidi_set_ops. This argument is const, so the snd_rawmidi_ops structures can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/gadget/fu

[PATCH 0/5] constify videobuf_queue_ops structures

These videobuf_queue_ops structures are only passed as the second argument to videobuf_queue_vmalloc_init, which is declared as const. Thus the videobuf_queue_ops structures themselves can be const. Done with the help of Coccinelle. --- drivers/media/pci/cx18/cx18-streams.c

[PATCH 5/5] [media] zr364xx: constify videobuf_queue_ops structures

+const struct videobuf_queue_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/zr364xx/zr364xx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/media/usb/zr364xx/zr364xx.c

[PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc

qe_ep0_desc is only passed as the second argument to qe_ep_init, which is const, so qe_ep0_desc can be const too. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- I got a lot of warnings when compiling this file, but none seemed to be r

[PATCH] usb: xhci: fix call_kern.cocci warnings

GFP_KERNEL used when a lock is held. Convert to GFP_ATOMIC to avoid the possibility of deadlock. Fixes: 725d53536473 ("usb: xhci: Add DbC support in xHCI driver") Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fengguang Wu <fengguang...@intel.com> --

[PATCH 00/12] constify mmc_host_ops structures

The mmc_host_ops structure is only stored in the ops field of an mmc_host structure, which is declared as const. Thus the mmc_host_ops structure itself can be const. Done with the help of Coccinelle. --- drivers/mmc/host/bcm2835.c |2 +- drivers/mmc/host/davinci_mmc.c |2 +-

[PATCH 08/12] mmc: vub300: constify mmc_host_ops structures

off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/mmc/host/vub300.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c index fbeea1a..6e08597 100644 --- a/drivers/mmc/host/vub300.c +++ b/drivers/mmc/host/vub300.c @

[PATCH 01/11] isp1362-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/isp1362-hcd.c |2

[PATCH 02/11] usb: host: max3421-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/max3421-hcd.c |2

[PATCH 04/11] usb: host/sl811-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/sl811-hcd.c |2 +-

[PATCH 03/11] usb: r8a66597-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/r8a66597-hcd.c |2

[PATCH 00/11] constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. // @r disable optional_qualifier@ identifier i; position p; @@ static struct hc_driver i@p = { ... };

[PATCH 05/11] usb: host: u132-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/u132-hcd.c |2 +-

[PATCH 06/11] usb: renesas_usbhs: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/renesas_usbhs/mod_host.c

[PATCH 07/11] isp116x-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/isp116x-hcd.c |2

[PATCH 08/11] USB: HWA: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/hwa-hc.c |2 +-

[PATCH 11/11] c67x00-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/c67x00/c67x00-hcd.c |2

[PATCH 09/11] USB: whci-hcd: constify hc_driver structures

The hc_driver structure is only passed as the first argument to usb_create_hcd, which is declared as const. Thus the hc_driver structure itself can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/whci/hcd.c |2 +-

Re: [PATCH 4/8] pid.c: Add implementation for find_ge_pid

On Fri, 14 Jul 2017, Gargi Sharma wrote: > Earlier bitmap was traversed to find the pid greater or equal to nr > (passed as a parameter). Now a call to idr_get_next fetches the id > greater than or equal to nr. > > Signed-off-by: Gargi Sharma > --- > kernel/pid.c | 8

Re: [PATCH 3/8] pid.c: Add IDR implementation for alloc_pid and free_pid

On Fri, 14 Jul 2017, Gargi Sharma wrote: > In pid_alloc function, idr_preload function is used along with > idr_alloc_cyclic. > idr_alloc_cyclic is used instead of idr_alloc because we might want to > reuse the unassigned integers. The rest of the code is same as the previous > alloc_pid, which

[PATCH 01/15] wusbcore: dev-sysfs: use permission-specific DEVICE_ATTR variants

TTR(x, \(0444\|S_IRUGO\), x_show, NULL); + DEVICE_ATTR_RO(x); // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/wusbcore/dev-sysfs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/dev-sysfs.c b/drivers/usb/wusbcore/dev-sysfs.c i

[PATCH 02/15] wusbcore: wusbhc: use permission-specific DEVICE_ATTR variants

_ATTR_RW; identifier rw.x,rw.x_show,rw.x_store; @@ - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store); + DEVICE_ATTR_RW(x); // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/wusbcore/wusbhc.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-)

[PATCH 00/15] use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO etc. for read only attributes etc. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The complete semantic patch is as follows: (http://coccinelle.lip6.fr/) // @ro@ declarer name DEVICE_ATTR; identifier x,x_show; @@

Re: question about drivers/usb/musb/musb_core.c

On Fri, 28 Oct 2016, Bin Liu wrote: > On Fri, Oct 28, 2016 at 04:53:03PM -0400, Greg Kroah-Hartman wrote: > > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > >

Re: question about drivers/usb/musb/musb_core.c

On Fri, 28 Oct 2016, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > > The file drivers/usb/musb/musb_core.c contains the code: > > > > > &

Re: question about drivers/usb/musb/musb_core.c

[Corrected email for Felipe] On Fri, 28 Oct 2016, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > > The file drivers/usb/musb/musb_core.c contains the code

Re: question about drivers/usb/musb/musb_core.c

On Fri, 28 Oct 2016, Julia Lawall wrote: > The file drivers/usb/musb/musb_core.c contains the code: > > static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store); > > Is it correct to have NULL in the third argument for an attribute that can > be read? Should the permission be 04

question about drivers/usb/musb/musb_core.c

The file drivers/usb/musb/musb_core.c contains the code: static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store); Is it correct to have NULL in the third argument for an attribute that can be read? Should the permission be 0444 instead? thanks, julia -- To unsubscribe from this list: send the line

Re: [Outreachy kernel] [PATCH 5/6] staging: lustre: Remove unnecessary 'return'

On Thu, 15 Sep 2016, Rehas Sachdeva wrote: > Fixes checkpatch.pl warning: > WARNING: void function return statements are not generally useful. It would be better to say what you did, rather than saying fix. Here you could say: Remove unnecessary void return at the end of a function. Issue

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrot

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents b

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Joe Perches wrote: > On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > > Constify local structures. > > Thanks Julia. > > A few suggestions & questions: > > Perhaps the script should go into scripts/coccinelle/ > so that future

[PATCH 16/26] ezusb: constify local structures

in a variable. Declare structures having all of these properties as const. Done using Coccinelle. Based on a suggestion by Joe Perches <j...@perches.com>. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- The semantic patch seems too long for a commit log, but is in the

[PATCH 00/26] constify local structures

Constify local structures. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // // The first rule ignores some cases that posed problems @r disable optional_qualifier@ identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer}; identifier i !=

[PATCH 0/5] constify ethtool_ops structures

Constify ethtool_ops structures. --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |2 +- drivers/net/ethernet/synopsys/dwc_eth_qos.c |2 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c |2 +- drivers/net/usb/r8152.c |2 +-

Re: [PATCH 10/11] soc: ti: knav_qmss_queue: use of_property_read_bool

On Fri, 5 Aug 2016, Robin Murphy wrote: > Hi Julia, > > On 05/08/16 09:56, Julia Lawall wrote: > > Use of_property_read_bool to check for the existence of a property. > > This caught my eye since Rob told me off for doing the same recently[1]. > > > The semanti

[PATCH 02/11 v2] usb: host: fsl-mph-dr-of: use of_property_read_bool

; + x = of_property_read_bool(e1,e2); // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: special case for propagating true and false drivers/usb/host/fsl-mph-dr-of.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/usb/host/fsl-

[PATCH 02/11] usb: host: fsl-mph-dr-of: use of_property_read_bool

else S2 // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/fsl-mph-dr-of.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c index 1044b0f..8bbca74 100644 --- a/drivers/us

[PATCH 00/11] use of_property_read_bool

Use of_property_read_bool to check for the existence of a property. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S2,S1; @@ - if (of_get_property(e1,e2,NULL)) + if (of_property_read_bool(e1,e2)) S1

Re: [PATCH 0982/1285] Replace numeric parameter like 0444 with macro

On Tue, 2 Aug 2016, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

[PATCH] USB: ftdi_sio: constify ftdi_sio_quirk structures

The ftdi_sio_quirk structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/serial/ftdi_sio.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

Re: [PATCH v6 10/12] usb: dbc: add handshake between debug target and host

Please check. As far as I can see, the call to early_xdbc_read ends up at xdbc_bulk_transfer, which return negative error codes on failure. julia On Tue, 26 Jan 2016, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1453781665-4714-11-git-send-email-baolu...@linux.intel.com> >

[PATCH] usb: gadget: rndis: fix itnull.cocci warnings

The index variable of list_for_each_entry_safe is an offset from a list pointer, and thus should not be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Geliang Tang <geliangt...@163.com> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawal

Re: [patch v2] usb: gadget: f_midi: missing unlock on error path

On Tue, 5 Jan 2016, Felipe Ferreri Tonello wrote: > Hi Dan, > > On 05/01/16 12:44, Dan Carpenter wrote: > > On Tue, Jan 05, 2016 at 01:28:11PM +0100, Julia Lawall wrote: > >> > >> > >> On Tue, 5 Jan 2016, kbuild test robot wrote: > >> > >

Re: [patch v2] usb: gadget: f_midi: missing unlock on error path

On Tue, 5 Jan 2016, kbuild test robot wrote: > Hi Dan, > > [auto build test WARNING on balbi-usb/next] > [also build test WARNING on v4.4-rc8 next-20160105] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: >

[PATCH] usbip: fix odd_ptr_err.cocci warnings

PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Nobuo Iwata <nobuo.iw...@fujixerox.co.jp> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- I haven't ch

[PATCH] usb: renesas_usbhs: constify usbhs_pkt_handle structures

The usbhs_pkt_handle structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/renesas_usbhs/fifo.c | 20 ++-- drivers/usb/renesas_usbhs/fifo.h

[PATCH 0/7] fix error return code

The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ... when

[PATCH 4/7] usb: gadget: legacy: fix error return code

hen != *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/gadget/legacy/acm_ms.c |4 +++- drivers/usb/gadget/legacy/audio.c|4 +++- drivers/usb/gadget/legacy/cdc2.c |4 +++- dr

[PATCH 0/2] remove assignment from IS_ERR argument

The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S1,S2; @@ +e1 = e2; if (IS_ERR( e1 - = e2 )) S1 else S2 // --- drivers/usb/mon/mon_text.c |6 -- ipc/mqueue.c |3 ++- 2 files changed, 6

[PATCH 2/2] USB: usbmon: remove assignment from IS_ERR argument

The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S1,S2; @@ +e1 = e2; if (IS_ERR( e1 - = e2 )) S1 else S2 // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/mon/mon_text.c |6 --

Re: [PATCH] usb: gadget: rndis: fix itnull.cocci warnings

On Tue, 22 Dec 2015, Felipe Balbi wrote: > Julia Lawall <julia.law...@lip6.fr> writes: > > > The index variable of list_for_each_entry_safe is never NULL. > > > > Generated by: scripts/coccinelle/iterators/itnull.cocci > > > > CC: Geliang Tang <geli

Re: [PATCH 7/9] usb: dwc2: host: use list_for_each_entry_safe

The call on line 1120 looks suspicious, because qtd could be non-null but also not a valid element, if the loop has exited normally. julia On Sat, 19 Dec 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: >

Re: [PATCH 5/9] usb: xhci: use list_for_each_entry

Geliang, Please check whether it is acceptable that last_unlinked_td point to the dummy entry at th beginning of the list, in the case where the list_for_each_entry loop runs out normally. It seems that you have sent a bunch of these patches. Please recheck them all to see if they really follow

[PATCH] usb: gadget: rndis: fix itnull.cocci warnings

The index variable of list_for_each_entry_safe is never NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Geliang Tang <geliangt...@163.com> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- rndis.c

[PATCH 2/2] USB: constify usb_mon_operations structure

The usb_mon_operations structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/core/hcd.c |4 ++-- drivers/usb/mon/mon_main.c |2 +- 2 files changed, 3 insertions(+), 3 del

[PATCH 1/2] USB: constify usb_mon_operations structure

The usb_mon_operations structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- include/linux/usb/hcd.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/usb/h

[PATCH v2] USB: constify usb_mon_operations structure

The usb_mon_operations structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: Merge the previous 1/2 and 2/2 patches. drivers/usb/core/hcd.c |4 ++-- drivers/usb/mon/mon_main.c

Re: [PATCH v2] usb: chipidea: removing of_find_property

Please check. The code, with the blank line on line 692, looks strange. julia On Tue, 17 Nov 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.tr...@gmail.com> > TO: Saurabh Sengar > CC: m...@mansr.com,

[PATCH] fix compare_const_fl.cocci warnings

Move constants to the right of binary operators. Semantic patch information: Depends on personal taste in some cases. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Dave Penkler <dpenk...@gmail.com> Signed-off-by: Fengguang Wu <fengguang...@intel.com> Signed-o

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

Coccinelle suggests the following patch. But the code is curious. Is the function expected to always return a failure value? thanks, julia On Thu, 17 Sep 2015, kbuild test robot wrote: > TO: Andrzej Pietrasiewicz > CC: kbuild-...@01.org > CC: Felipe Balbi

[PATCH 16/39] usb: gadget: drop null test before destroy functions

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drive

[PATCH 18/39] whci: drop null test before destroy functions

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/us

[PATCH 39/39] usb: host: drop null test before destroy functions

\|mempool_destroy\|dma_pool_destroy\)(x); x = NULL; -} // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/usb/host/fotg210-hcd.c | 12 drivers/usb/host/fusbh200-hcd.c | 12 2 files changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/f

[PATCH 00/39] drop null test before destroy functions

Recent commits to kernel/git/torvalds/linux.git have made the following functions able to tolerate NULL arguments: kmem_cache_destroy (commit 3942d29918522) mempool_destroy (commit 4e3ca3e033d1) dma_pool_destroy (commit 44d7175da6ea) These patches remove the associated NULL tests for the files

[PATCH 05/39] xhci: drop null test before destroy functions

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/us

Re: [PATCH] usb: chipidea: usbmisc_imx: fix returnvar.cocci warnings

Please take a look. thanks, julia On Wed, 25 Mar 2015, kbuild test robot wrote: TO: Peter Chen peter.c...@freescale.com CC: Greg Kroah-Hartman gre...@linuxfoundation.org CC: linux-usb@vger.kernel.org CC: linux-ker...@vger.kernel.org drivers/usb/chipidea/usbmisc_imx.c:277:5-8: Unneeded

[PATCH 20/27] usb: r8a66597-hcd: Use setup_timer

); +setup_timer(t,f,d); -t.function = f; -t.data = d; // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/host/r8a66597-hcd.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c index c4bcfae

[PATCH 23/27] usb: isp1760: Use setup_timer

); +setup_timer(t,f,d); -t.function = f; -t.data = d; // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/host/isp1760-hcd.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c index 395649f..79261d5

[PATCH 10/27] xhci-mem: Use setup_timer

); +setup_timer(t,f,d); -t.data = d; -t.function = f; // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/host/xhci-mem.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 5cb3d7a..e72265c

[PATCH 21/27] usb: oxu210hp-hcd: Use setup_timer

); +setup_timer(t,f,d); -t.function = f; -t.data = d; // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/host/oxu210hp-hcd.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c index 036924e

[PATCH 9/27] xhci: Use setup_timer

); +setup_timer(t,f,d); -t.data = d; -t.function = f; // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/host/xhci.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 01fcbb5..ae6d650 100644

[PATCH 22/27] usb: sl811-hcd: Use setup_timer

); +setup_timer(t,f,d); -t.function = f; -t.data = d; // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/host/sl811-hcd.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c index 25fb1da..cef3140 100644

[PATCH 0/27] Use setup_timer

These patches group a call to init_timer and initialization of the function and data fields into a call to setup_timer. Is there is no initialization of the data field before add_timer is called, the the data value is set to 0UL. If the data value has a cast to something other than unsigned

[PATCH 8/20] USB: isp1760: fix misspelling of current function in string

Replace a misspelled function name by %s and then __func__. The function name starts with isp, not ips. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- The semantic patch

[PATCH 18/20] usb: gadget: fix misspelling of current function in string

Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- The semantic patch is difficult to summarize, but is available

Re: [PATCH 8/20] USB: isp1760: fix misspelling of current function in string

On Sun, 7 Dec 2014, Jeremiah Mahler wrote: Julia, On Sun, Dec 07, 2014 at 08:20:50PM +0100, Julia Lawall wrote: Replace a misspelled function name by %s and then __func__. The function name starts with isp, not ips. This was done using Coccinelle, including the use

Re: [PATCH 0/20] fix misspelling of current function in string

On Mon, 8 Dec 2014, Julian Calaby wrote: Hi Julia, On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall julia.law...@lip6.fr wrote: These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself

[PATCH 8/8] wusb: replace memset by memzero_explicit

From: Julia Lawall ju...@diku.dk Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr

[PATCH 0/8] replace memset by memzero_explicit

Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; local idexpression e;

[PATCH 8/8 v2] wusb: replace memset by memzero_explicit

From: Julia Lawall julia.law...@lip6.fr Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. A simplified version of the semantic patch that makes this change is as follows: (http

[PATCH 0/8] replace memset by memzero_explicit

Memset on a local variable may be removed when it is called just before the variable goes out of scope. Using memzero_explicit defeats this optimization. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; local idexpression e;

[PATCH 4/4] usbip: remove unneeded structure

From: Julia Lawall julia.law...@lip6.fr Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x,i; @@ { ... when any -struct i x; +... when != x - memset(x

[PATCH 0/4] remove unneeded array

Remove an array or structure that only serves as the first argument to memset. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier x; type T; @@ { ... when any -T x[...]; +... when != x - memset(x,...); ...+ } @@ identifier x,i;

[PATCH] usb: gadget: fix platform_no_drv_owner.cocci warnings

Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Julia Lawall julia.law...@lip6.fr --- bdc_core.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers

[PATCH] usb: dwc3: return error code from the most recent call

From: Julia Lawall julia.law...@lip6.fr Copy-paste error from the previous block of error handling code. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e,e1; @@ if (IS_ERR(e)) { ... ( ret = PTR_ERR(e

  1   2   >