[PATCH v2] usb: host: add DT bindings for faraday fotg2

2018-10-11 Thread Linus Walleij
From: Hans Ulli Kroll This adds device tree bindings for the Faraday FOTG2 dual-mode host controller. Cc: devicet...@vger.kernel.org Signed-off-by: Hans Ulli Kroll Acked-by: Rob Herring Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Changed "OTH" to "OTG" - C

[PATCH] usb: host: fotg2: Fix potential NULL dereference

2018-09-18 Thread Linus Walleij
it on the remove path. Use the platform_device_[set|get]_drvdata() since this is a platform device. Fixes: ffa8a31b5b3b ("usb: host: fotg2: add silicon clock handling") Reported-by: Dan Carpenter Cc: Dan Carpenter Signed-off-by: Linus Walleij --- drivers/usb/host/fotg210-hcd.c | 7 ++- 1 fi

[PATCH v2] usb: host: fotg2: add silicon clock handling

2018-09-01 Thread Linus Walleij
the clock. If there is no clock available on the platform, we live without it. Make sure to percolate probe deferrals. Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Handle probe deferrals on the clock controller, no matter how unlikely they are. - Send the patch to get Gemini USB roll

[PATCH] usb: phy: ab8500: Drop AB8540/9540 support

2018-03-22 Thread Linus Walleij
Pallardy <loic.palla...@st.com> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- drivers/usb/phy/phy-ab8500-usb.c | 506 --- 1 file changed, 506 deletions(-) diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c index

Re: [PATCH 2/2] usb: gadget: udc: atmel: convert to use GPIO descriptors

2018-02-07 Thread Linus Walleij
oches <ludovic.desroc...@microchip.com> Reviewed-by: Linus Walleij <linus.wall...@linaro.org> Thank you for doing gpiod conversions. Making the world a better place! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver

2017-08-07 Thread Linus Walleij
On Tue, Aug 1, 2017 at 11:24 AM, Johan Hovold <jo...@kernel.org> wrote: > On Tue, Aug 01, 2017 at 08:49:02AM +0200, Linus Walleij wrote: >> On Thu, Jul 6, 2017 at 10:49 PM, Anatolij Gustschin <ag...@denx.de> wrote: >> >> > Add driver for CBUS pins on FT232H. T

Re: [PATCH 2/3] gpio: Add FT232H CBUS GPIO driver

2017-08-01 Thread Linus Walleij
symbol I guess I can merge it orthogonally if I am sure Lee will pick the MFD part. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/7] driver core: fix automatic pinctrl management

2017-05-30 Thread Linus Walleij
rstand what you mean. > Fix this by checking the new of_node_reused flag and skipping automatic > pinctrl configuration during probe if set. Seems like a solid idea. I hope we don't need another quirk for ACPI. Acked-by: Linus Walleij <linus.wall...@linaro.org> Yours, Linus Wallei

Re: [PATCH 4/5 v3] usb: host: fotg2: add Gemini-specific handling

2017-04-25 Thread Linus Walleij
and drivers for the Gemini clock controller and reset controller, so we might want to queue the clock handling at least. I'm happy if you pick some of these patches and keep them in your queue BTW. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 1/5 v3] usb: host: add DT bindings for faraday fotg2

2017-04-25 Thread Linus Walleij
a,gemini-usb", "faraday,fotg210"; > + compatible = "cortina,gemini-usb", "faraday,fotg210-dr"; But this would be wrong, because the compatible should only indicate what kind of hardware it is, not how it is going to be used (whether as host only, sla

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

2017-04-21 Thread Linus Walleij
. >> >> Hans can you add: >> >> compatible = "cortina,gemini-fotg", "faraday,fotg210-hcd" or something >> as composite compatible for our controller? I hacked on it a bit and sent out. Hope you don't hate it too much. > I prefer > "faraday,fotg210-usb2" I simply named it after the IP core name, which is just "faraday,fotg210". > I've got rejected by Rob due the fact this is an dual role controller, > which supports both host and device mode. And DT must reflect this desgn > pattern. > > Currently I'm wrappingt my head around the design of the fsl-mph-dr-of.c > driver to use this as a blueprint for the Faraday driver. I don't know how much more of the dual-mode we need to reflect, I guess it comes up in OTG mode since we don't parse the host-only or device-only attributes (yet). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/5 v3] usb: host: fotg2: add device tree probing

2017-04-21 Thread Linus Walleij
From: Hans Ulli Kroll <ulli.kr...@googlemail.com> Add device tree probing to the fotg2 driver. Signed-off-by: Hans Ulli Kroll <ulli.kr...@googlemail.com> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- ChangeLog v2->v3: - Change compatible to "faraday,fot

[PATCH 5/5 v3] ARM: dts: Add the FOTG210 USB host to Gemini

2017-04-21 Thread Linus Walleij
SquareOne NAS/router since this instead has a VIA host controller soldered on the PCI port, and can gate off these USB host controllers. Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- USB maintainers: I will merge this through the ARM SoC tree, the patch is only included in the

[PATCH 3/5 v3] usb: host: fotg2: add silicon clock handling

2017-04-21 Thread Linus Walleij
the clock. Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- drivers/usb/host/fotg210-hcd.c | 26 ++ drivers/usb/host/fotg210.h | 3 +++ 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/f

[PATCH 1/5 v3] usb: host: add DT bindings for faraday fotg2

2017-04-21 Thread Linus Walleij
From: Hans Ulli Kroll <ulli.kr...@googlemail.com> This adds device tree bindings for the Faraday FOTG2 dual-mode host controller. Cc: devicet...@vger.kernel.org Signed-off-by: Hans Ulli Kroll <ulli.kr...@googlemail.com> Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --

[PATCH 4/5 v3] usb: host: fotg2: add Gemini-specific handling

2017-04-21 Thread Linus Walleij
as "wakeup-source" using the standard DT bindings, we also enable this in the global controller for respective port. Signed-off-by: Linus Walleij <linus.wall...@linaro.org> --- drivers/usb/host/Kconfig | 1 + drivers/usb/host/fotg210-hcd.c | 76 +

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

2017-03-29 Thread Linus Walleij
restricted by the IP > configuration or SoC integration? The former is a user choice and > shouldn't be part of DT. The latter should be implied by an SoC > specific compatible string. Using only a compatible string for a > licensed IP is not specific enough as vendors use di

Re: [PATCH v1] usb: dwc3: pci: Switch to devm_acpi_dev_add_driver_gpios()

2017-03-23 Thread Linus Walleij
case assignment fails to allow user > see the cause of a potential issue. > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > > Linus, according to preliminary agreement with Felipe it may go through > GPIO subsystem instead of pulling from it.

Re: [PATCH 3/3] DT: add Faraday Tec. as vendor

2017-02-12 Thread Linus Walleij
y, so now I'm editing the drivers a bit... Rob could you pick this patch directly to the DT tree so we need not worry about the vendor thing? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.o

Re: [PATCH 0/3] usb: add device tree support for fotg2-hcd driver

2017-02-10 Thread Linus Walleij
ini.dtsi set as status = "disabled"; and gemini-nas4220b.dts mainly just setting status = "okay"; I can merge this on top of the rest of the stuff in my tree that should go upstream to ARM SoC. Yours. Linus Walleij -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

2017-02-10 Thread Linus Walleij
On Wed, Feb 8, 2017 at 9:00 PM, Hans Ulli Kroll <ulli.kr...@googlemail.com> wrote: > This adds DT bindings for the Faraday FOTG2 host controller. > > Signed-off-by: Hans Ulli Kroll <ulli.kr...@googlemail.com> Reviewed-by: Linus Walleij <linus.wall...@linaro.or

Re: [PATCH 3/3] DT: add Faraday Tec. as vendor

2017-02-10 Thread Linus Walleij
On Wed, Feb 8, 2017 at 9:00 PM, Hans Ulli Kroll <ulli.kr...@googlemail.com> wrote: > add Faraday Technology Corporation as vendor faraday for DT > > Signed-off-by: Hans Ulli Kroll <ulli.kr...@googlemail.com> Reviewed-by: Linus Walleij <linus.wall...@linaro.or

Re: [PATCH 1/3 v2] usb: host: fotg2: add device tree probing

2017-02-10 Thread Linus Walleij
On Thu, Feb 9, 2017 at 3:20 PM, Hans Ulli Kroll <ulli.kr...@googlemail.com> wrote: > Add device tree probe for fotg2 driver > > v2: > fix in wrong MODULE_DEVICE_TABLE > > Signed-off-by: Hans Ulli Kroll <ulli.kr...@googlemail.com> Acked-by: Linus Wal

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-26 Thread Linus Walleij
On Wed, Oct 26, 2016 at 11:09 AM, Johan Hovold <jo...@kernel.org> wrote: > On Tue, Oct 25, 2016 at 11:34:40AM +0200, Linus Walleij wrote: >> I was thinking on either reusing the .names field of the >> struct gpiochip to name the lines for the userspace >> chardev. With

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-25 Thread Linus Walleij
a special function to name the lines from drivers like this that hang off a pluggable bus. Johan/Martyn what is your idea? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [balbi-usb:testing/next 57/84] drivers/usb/dwc3/dwc3-st.c:328:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state'

2016-10-21 Thread Linus Walleij
a bug in . Something along the > lines of below should be enough: I don't think so, that include file looks pretty solid. I think the actual problem is that dwc3-st.c doesn't #include even if it is using the functions from it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-12 Thread Linus Walleij
a.co.uk> (...) > V7: - Using GPIO private data for GPIO bits. > - Adding limited .set_single_ended() and direction support. > - Simplifying attach() and removing release() as it's no longer required. >From a GPIO point of view: Reviewed-by: Linus Walleij <linus.wall...@lin

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-10 Thread Linus Walleij
iven in unexpected ways. Does that sould acceptable? I'm pretty sure it's OK, I just want you to consider and think these things over. Your conclusion is as good as mine. I suspect I will just ACK your patch when you have it working. Yours, Linus Walleij -- To unsubscribe from this list: send the

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-04 Thread Linus Walleij
(priv->gc.label) + gpiochip_remove(>gc); +} Should not be needed with the devm_* call above doing garbage collection. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RESEND PATCH v5 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-08-11 Thread Linus Walleij
t doesn't > provide an explicit input mode, though the state of the GPIO can be read > when used in open-drain mode. Like with pin use, the mode is configured in > the one-time programable PROM and can't be changed at runtime. > > Signed-off-by: Martyn Welch <martyn.we...@collabor

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread Linus Walleij
hunfeng Yun <chunfeng@mediatek.com> This looks like it can be merged orthogonally to all the other patches, but I don't understand the patch or if it is correct. Hongzhou/Yingjoe, can either of you review this patch? Yours, Linus Walleij -- To unsubscribe from this list: send the

Re: [PATCH v10 4/9] phy: Add Tegra XUSB pad controller support

2016-04-26 Thread Linus Walleij
lements the binding change, does your Acked-by on > the binding apply to this part as well? Sure Acked-by: Linus Walleij <linus.wall...@linaro.org> Sorry for missing to reply to this, have been swamped. Basically I trust anything that you and Stephen agree on. Yours, Linus Walleij -

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-04-18 Thread Linus Walleij
On Mon, Apr 18, 2016 at 1:12 PM, Thierry Reding <thierry.red...@gmail.com> wrote: > On Tue, Mar 15, 2016 at 10:01:25AM +0100, Linus Walleij wrote: >> On Fri, Mar 4, 2016 at 5:19 PM, Thierry Reding <thierry.red...@gmail.com> >> wrote: >> >> >

Re: [PATCH v5 1/2] USB: serial: cp210x: Adding GPIO support for CP2105

2016-03-31 Thread Linus Walleij
k> Looking good from a GPIO point of view. Acked-by: Linus Walleij <linus.wall...@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-22 Thread Linus Walleij
ed ACKs after -rc1? Please send me the patches I can just merge into the pinctrl tree separately if possible, I encourage any DTS changes to go in orthogonally through ARM SoC. The DTS business I regard as kind of its own tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] pinctrl: Intel: add RX invertion config

2016-03-19 Thread Linus Walleij
On Wed, Mar 16, 2016 at 2:34 PM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote: >> - What is a HPD interrupt? > > hotplug interrupt, fires when you plug in a cable. > >> - What is a Type-C DP HPD? > > usb

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-03-15 Thread Linus Walleij
ike Stephen's ACK on this to keep things together, thanks. Please resend the pinctrl patches to me after v4.6-rc1 with the apropriate ACKs (hoping they will appear). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to ma

Re: [PATCH v10 2/9] dt-bindings: pinctrl: Deprecate Tegra XUSB pad controller binding

2016-03-15 Thread Linus Walleij
e merging. Will the new binding also work with SuperDuperSpeed USB and SuperSuperMegaUltraOrtonSpeed USB I wonder... or will we change the bindings again? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to ma

Re: [PATCH] usb: musb: ux500: Fix NULL pointer dereference at system PM

2016-01-28 Thread Linus Walleij
s: 7d32cdef5356 ("usb: musb: fail with error when no DMA...") > Signed-off-by: Ulf Hansson <ulf.hans...@linaro.org> Acked-by: Linus Walleij <linus.wall...@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH 0/3] gpio: rcar: Remove obsolete platform data support

2015-10-16 Thread Linus Walleij
hese first to avoid breaking the build. Acked-by: Linus Walleij <linus.wall...@linaro.org> Include this in your pull request. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] pinctrl: sh-pfc: Stop including

2015-10-16 Thread Linus Walleij
Uytterhoeven <geert+rene...@glider.be> Acked-by: Linus Walleij <linus.wall...@linaro.org> Include this in your pull request to me. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord..

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-07-16 Thread Linus Walleij
On Sat, Jul 4, 2015 at 12:13 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Jun 2, 2015 at 2:18 PM, Linus Walleij linus.wall...@linaro.org wrote: On Sat, May 30, 2015 at 10:29 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman gre

Re: [PATCH 2/2] gpio: gpio-ftdi-cbus: add driver for FTDI CBUS GPIOs

2015-07-15 Thread Linus Walleij
-cbus_mask = ~((1 offset) 4); I usually replace: (1 offset) with #include linux/bitops.h BIT(offset) so it's clear what is happening. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] USB: ftdi_sio: add CBUS mode for FT232R devices

2015-06-30 Thread Linus Walleij
. Waiting for Johan's review on both patches. Need his or Greg's ACK on patch 1 if I should merge through the GPIO tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] usb: dwc3: pci: make better use of gpiod API

2015-06-16 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/21] On-demand device registration

2015-06-15 Thread Linus Walleij
on at compile time. We discarded that development path years ago. We have no clue, this is resolved at runtime. Alas, people still create super-optimized systems using exactly this knowledge, but it is not our main target here, it is a special optimization case. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 00/21] On-demand device registration

2015-06-11 Thread Linus Walleij
On Wed, Jun 10, 2015 at 12:19 PM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: On 10 June 2015 at 09:30, Linus Walleij linus.wall...@linaro.org wrote: regulator_get(...) - not available, so: - identify target regulator provider - this will need instrumentation - probe it It then turns out

Re: [PATCH 00/21] On-demand device registration

2015-06-10 Thread Linus Walleij
On Tue, Jun 2, 2015 at 12:14 PM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: On 2 June 2015 at 10:48, Linus Walleij linus.wall...@linaro.org wrote: This is what systemd is doing in userspace for starting services: ask for your dependencies and wait for them if they are not there. So

Re: [PATCH 00/21] On-demand device registration

2015-06-02 Thread Linus Walleij
(!) and DMA channels for example.) So if this should be solved it should be solved in an abstract way in the device driver core available for all, then have calls calling out to DT, ACPI, possibly even PCI or USB (as these enumerate devices themselves) to obtain a certain dependency. Yours, Linus

Re: [PATCH] USB: ftdi_sio: add GPIO support

2015-06-02 Thread Linus Walleij
useful here. What is buys is centralizing code into the proper drivers/gpio folder of the kernel. So more of a maintenance point than a mechanics/performance point. We do have GPIO drivers scattered all over the kernel so one more or less wouldn't matter so much... Yours, Linus Walleij

Re: [PATCH v8 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-05-21 Thread Linus Walleij
); (...) } Simple, syscon is the MFD hub. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-07 Thread Linus Walleij
On Fri, Feb 20, 2015 at 8:17 PM, David Cohen david.a.co...@linux.intel.com wrote: On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: I would put this adjacent to the phy driver somewhere in drivers/usb/* and make the actual USB-driver thing handle its GPIOs directly. But I guess

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-07 Thread Linus Walleij
, not a generic GPIO problem. So the solution must be confined to the GPIO ACPI portions of the GPIO code, not altering central mechanisms. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Linus Walleij
thing handle its GPIOs directly. But I guess David and Felipe have already discussed that as we're seeing this patch? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-02-04 Thread Linus Walleij
gpiod_direction_output_raw() to avoid the inversion in the core. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-02-04 Thread Linus Walleij
pass GPIOD_OUT_HIGH it should set the raw value to 0 if it was inverted. Else find the bug... is the GPIO line clearly marked as inverted wherever it is described? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 1/2] Documentation: dt-bindings: Add aliases information for Exynos7 pin controllers

2015-01-12 Thread Linus Walleij
On Wed, Dec 10, 2014 at 9:39 AM, Vivek Gautam gautam.vi...@samsung.com wrote: Adding list of aliases for supported Exynos7 pin controller blocks. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Linus Walleij linus.wall...@linaro.org Patch

Re: [PATCH V3 2/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2015-01-12 Thread Linus Walleij
gautam.vi...@samsung.com Cc: Tomasz Figa tomasz.f...@gmail.com Cc: Linus Walleij linus.wall...@linaro.org --- Changes since V2: - Added documentation on alias for BUS1 pin controller block. Patch applied with Tomasz ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 2/3] gpio: dln2: use bus_sync_unlock instead of scheduling work

2015-01-08 Thread Linus Walleij
On Fri, Jan 9, 2015 at 12:40 AM, Octavian Purdila octavian.purd...@intel.com wrote: On Thu, Jan 1, 2015 at 9:56 AM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila octavian.purd...@intel.com wrote: Use the irq_chip bus_sync_unlock method

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-01-08 Thread Linus Walleij
vuport_init(void) +{ + return platform_driver_register(vuport_driver); +} +subsys_initcall(vuport_init); Usually we try to avoid this kind of early initcalls. Doesn't deferred probe work as intended? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH v2 1/4] gpio: dln2: fix issue when an IRQ is unmasked then enabled

2015-01-07 Thread Linus Walleij
. IRQS_PENDING). Signed-off-by: Octavian Purdila octavian.purd...@intel.com This patch applied for fixes. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled

2015-01-05 Thread Linus Walleij
On Wed, Dec 31, 2014 at 9:55 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila octavian.purd...@intel.com wrote: As noticed during suspend/resume operations, the IRQ can be unmasked then disabled in suspend and eventually enabled in resume

Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled

2014-12-31 Thread Linus Walleij
. IRQS_PENDING). Signed-off-by: Octavian Purdila octavian.purd...@intel.com Patch applied for fixes. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/3] gpio: dln2: use bus_sync_unlock instead of scheduling work

2014-12-31 Thread Linus Walleij
drivers. Signed-off-by: Octavian Purdila octavian.purd...@intel.com Patch applied for fixes. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-12-03 Thread Linus Walleij
On Mon, Dec 1, 2014 at 3:21 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: On Fri, Nov 28, 2014 at 9:15 PM, Linus Walleij linus.wall...@linaro.org wrote: Apart from that, there are *again* a lot of Exynos patches flying around and I start to loose track of them. If they do not apply

Re: [PATCH v1] usb: phy: generic: migrate to gpio_desc

2014-11-28 Thread Linus Walleij
looks fine, but let's get a review from Linus W. Linus, can you have a look below ? Is this being used the way you intended ? BTW, we need support DT and pdata platforms here. This definately make things better so: Acked-by: Linus Walleij linus.wall...@linaro.org One comment though

Re: [PATCH 6/8] usb: musb: Pass fifo_mode in platform data

2014-11-28 Thread Linus Walleij
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren t...@atomide.com wrote: This allows setting the correct fifo_mode when multiple MUSB glue layers are built-in. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc

Re: [PATCH 5/8] usb: musb: Change end point selection to use new IO access

2014-11-28 Thread Linus Walleij
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren t...@atomide.com wrote: This allows the endpoints to work when multiple MUSB glue layers are built in. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Apelete

Re: [PATCH V2 1/2] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-11-28 Thread Linus Walleij
available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org If the change looks good, will it be possible to pick it fo 3.19

Re: [PATCH 4/8] usb: musb: Change to use new IO access

2014-11-25 Thread Linus Walleij
On Mon, Nov 24, 2014 at 8:05 PM, Tony Lindgren t...@atomide.com wrote: Change to use new IO access. This allows us to build in multiple MUSB glue layers. Cc: Fabio Baltieri fabio.balti...@linaro.org Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Signed-off

Re: [GIT PULL] Immutable branch between MFD, GPIO and I2C

2014-11-14 Thread Linus Walleij
MFD alone from the GPIO side of things. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND V4 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-10-31 Thread Linus Walleij
mappins a top-level binding rather than a pinconfig binding. - Add #defines for the padctl lanes. Acked-by: Linus Walleij linus.wall...@linaro.org I guess you will take this patch along with the rest through ARM SoC or so? Yours. Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH v3 3/3] gpio: add support for Cypress CYUSBS234 USB-GPIO adapter

2014-10-27 Thread Linus Walleij
term and maintenance of your driver, but it's your pick. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 3/4] gpiolib: add irq_not_threaded flag to gpio_chip

2014-10-27 Thread Linus Walleij
. Rebase and you can drop this patch. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 4/4] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-10-27 Thread Linus Walleij
Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api-manual.pdf Signed-off-by: Daniel Baluta daniel.bal...@intel.com Signed-off-by: Octavian Purdila octavian.purd...@intel.com Looks good to me. Acked-by: Linus Walleij linus.wall

Re: [PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

2014-09-25 Thread Linus Walleij
gets this - tells GPIOlib to use active low Or in worst case the polarity is hard-coded in the driver (!) That was not a clean separation, the driver should not need to care about polarity, the core should handle this. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH v6 partial 0/2] pxa27x_udc port to device-tree and gpio_desc

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 10:26 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Sep 24, 2014 at 9:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: I have not found in the gpiolib anything for a driver to set that active_low value, only for machine code. The legacy behaviour

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
); + udc-mach = mach; + } } else { udv-gpiod = devm_gpiod_get(pdev-dev, ...); } Here you can also use the flags. So the idea is to use device-bound GPIOs for the future. Please consult Documentation/gpio/consumer.txt Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH v6 2/2] usb: gadget: pxa27x_udc: add devicetree support

2014-09-25 Thread Linus Walleij
, enum gpiod_flags flags); Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 11:47 AM, robert.jarz...@free.fr wrote: De: Linus Walleij linus.wall...@linaro.org @@ -2415,7 +2411,13 @@ static int pxa_udc_probe(struct platform_device *pdev) { struct resource *regs; struct pxa_udc *udc = memory; - int retval = 0, gpio

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
mailer sent of the mail before I was finished. Well you got the solution anyway, check it out. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v6 partial v2 1/3] usb: gadget: pxa27x_udc: prepare device-tree support

2014-09-25 Thread Linus Walleij
On Thu, Sep 25, 2014 at 3:44 PM, robert.jarz...@free.fr wrote: Could you also review patch 1/3 while at it ;) ? This is patch 1/3... I guess you mean the others. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH v5 3/4] gpiolib: add irq_not_threaded flag to gpio_chip

2014-09-24 Thread Linus Walleij
adding interfaces with no users, but this seems very useful, so patch applied. I guess your driver will appear on v3.19+ so then you can rely on this having been merged for v3.18. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-05 Thread Linus Walleij
on in-kernel tests and working on a better userspace GPIO interface than the sysfs thing. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-04 Thread Linus Walleij
it with the rest of the patches through the MFD tree so: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

2014-09-04 Thread Linus Walleij
checkpatch.pl's warning This has been looking nice from the GPIO side of things for a while so: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/3] gpio: add support for the Diolan DLN-2 USB-GPIO driver

2014-08-29 Thread Linus Walleij
GPIOLIB_IRQCHIP or grep the git log to see how this works in practice. You need to use some container_of() operations. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-08-29 Thread Linus Walleij
through the Tegra tree. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-28 Thread Linus Walleij
defined suggested by gno...@lxorguk.ukuu.org.uk 3: use true instead of 1 corrected by Linus Walleij 4: ignore return value of gpiochip_remove suggested by Linus Walleij 5: fix multi gpio_chips registered by pl2303 can't be distinguished in kernel space. This is OK with me now, Reviewed

Re: [PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-23 Thread Linus Walleij
from gpiochip_remove() and have removed the __must_check tag in the gpio tree, so just call gpiochip_remove() unconditionally and ignore any compile error messages for now. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-07-07 Thread Linus Walleij
On Fri, Jun 13, 2014 at 8:31 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 13, 2014 at 09:25:07AM +0200, Linus Walleij wrote: But I also want to bring the device model into question: normally when a mother device spawns children across different subsystems we model them

Re: [PATCH] USB: ftdi_sio: add GPIO support

2014-06-13 Thread Linus Walleij
is device core maintainer and may have better ideas about this! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb: musb: ux500: don't propagate the OF node

2014-06-10 Thread Linus Walleij
...@vger.kernel.org Cc: Lee Jones lee.jo...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/usb/musb/ux500.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c index

[PATCH] usb: gadget: fix pxa25x compilation problems

2013-11-18 Thread Linus Walleij
mach/hardware.h, which was needed for the driver to compile. Fix this up by explicitly including the necessary mach/hardware.h header. Reported-by: Russell King li...@arm.linux.org.uk Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/usb/gadget/pxa25x_udc.c | 1 + 1 file changed, 1

[PATCH] usb: musb: name ux500 platforms more broadly

2013-09-06 Thread Linus Walleij
The Kconfig help text is talking about the U5500 which is no longer supported by the kernel. Name the help text after the config symbol which is more correct. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/usb/musb/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [Ksummit-2013-discuss] Topic: where should the border between userspace and kernel be?

2013-07-16 Thread Linus Walleij
for a conference this year.) Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/39] ARM: ux500: Stop passing MMC's platform data for Device Tree boots

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 11:15 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 15 May 2013, Linus Walleij wrote: On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote: It was required to pass DMA channel configuration information to the MMC driver before the new DMA API

Re: [PATCH 06/39] ARM: ux500: Move SDI (MMC) and UART devices under more descriptive heading

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 11:17 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 15 May 2013, Linus Walleij wrote: On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote: Now DMA DT bindings exist and are in use by he MMC and UART drivers, it should be possible to remove

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Linus Walleij
and will aid us when we come to enable the driver for Device Tree. Cc: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Fabio Baltieri fabio.balti...@linaro.org Signed-off-by: Lee Jones lee.jo...@linaro.org Patch applied to my

Re: [PATCH 20/39] usb: musb: ux500: move channel number knowledge into the driver

2013-05-30 Thread Linus Walleij
. This also removes quite a bit of complexity from the driver and will aid us when we come to enable the driver for Device Tree. Cc: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Fabio Baltieri fabio.balti...@linaro.org Signed-off

  1   2   >