Re: USB role switches, usb-connector, typec and device trees

On 2018-06-13 15:51, Heikki Krogerus wrote: On Tue, Jun 12, 2018 at 07:16:03PM +0200, Mats Karrman wrote: On 2018-06-07 14:01, Heikki Krogerus wrote: On Thu, Jun 07, 2018 at 09:22:56AM +0200, Hans de Goede wrote: Hi, On 06-06-18 23:36, Mats Karrman wrote: Hello Gentlemen, I'm trying

Re: USB role switches, usb-connector, typec and device trees

On 2018-06-13 09:06, Andrzej Hajda wrote: On 12.06.2018 19:33, Mats Karrman wrote: Hi Andrzej, On 2018-06-07 13:40, Andrzej Hajda wrote: On 06.06.2018 23:36, Mats Karrman wrote: Hello Gentlemen, I'm trying to get my head around USB role switches in connection with Type-C ports and device

Re: USB role switches, usb-connector, typec and device trees

Hi Andrzej, On 2018-06-07 13:40, Andrzej Hajda wrote: On 06.06.2018 23:36, Mats Karrman wrote: Hello Gentlemen, I'm trying to get my head around USB role switches in connection with Type-C ports and device-trees. So far I have not found much documentation, e.g. there are no device-tree

Re: USB role switches, usb-connector, typec and device trees

On 2018-06-07 14:01, Heikki Krogerus wrote: On Thu, Jun 07, 2018 at 09:22:56AM +0200, Hans de Goede wrote: Hi, On 06-06-18 23:36, Mats Karrman wrote: Hello Gentlemen, I'm trying to get my head around USB role switches in connection with Type-C ports and device-trees. So far I have

Re: [PATCH v6 00/15] staging: typec: tcpci: move out of staging

Hello Li Jun, I have been testing these patches on top of usb-next using an i.MX6, a nxp ptn5110 evaluation board and a bunch of usbc devices. So far everything seem to work fine! :-) However, I have only tested host mode and I have some test cases left I want to cover. Just to let you know

USB role switches, usb-connector, typec and device trees

Hello Gentlemen, I'm trying to get my head around USB role switches in connection with Type-C ports and device-trees. So far I have not found much documentation, e.g. there are no device-tree bindings documented and really no good examples in existing device trees, although there has been some

Re: [PATCH 1/1] usb: chipidea: host: fix disconnection detect issue

ot plug event, then the disconnection will not be detected by hardware. Fixes: 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd") Cc: Martin Blumenstingl Reported-by: Mats Karrman Signed-off-by: Peter Chen Works for me! Tested on SolidRun Hummingboard fsl,

Re: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

On 2018-06-05 02:54, Peter Chen wrote: And this is what the "decompiled" device tree entry for the USB controller and phy look like:             usb@2184200 {                compatible = "fsl,imx6q-usb", "fsl,imx27-usb";                 reg = <0x2184200 0x200>;                

Re: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

On 2018-06-04 03:14, Peter Chen wrote: causes a regression for me on my SolidRun Hummingboard (NXP i.MX6 DL SoC with chipidea controller). Example: -- Cold boot of system. -- Plug in USB memory stick --> Attached OK. -- Mount disk --> OK, "ls" works -- Unmount disk --> OK -- Unplug USB

Re: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

Hi, On 2018-06-01 16:08, Mats Karrman wrote: Hi Peter, On 2018-06-01 03:30, Peter Chen wrote: After bisecting usb-next starting from tag 'v4.16' to current head I found that the commit:      commit 4e88d4c083016454f179686529ae65d70b933b58      Author: Martin Blumenstingl      Date

Re: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

Hi Peter, On 2018-06-01 03:30, Peter Chen wrote: After bisecting usb-next starting from tag 'v4.16' to current head I found that the commit:    commit 4e88d4c083016454f179686529ae65d70b933b58    Author: Martin Blumenstingl    Date:   Sat Mar 3 22:43:03 2018 +0100        usb: add

Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

Hi, After bisecting usb-next starting from tag 'v4.16' to current head I found that the commit:    commit 4e88d4c083016454f179686529ae65d70b933b58    Author: Martin Blumenstingl    Date:   Sat Mar 3 22:43:03 2018 +0100        usb: add a flag to skip PHY initialization to struct usb_hcd

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

On 2018-05-17 13:50, Heikki Krogerus wrote: On Wed, May 16, 2018 at 11:11:02PM +0200, Mats Karrman wrote: On 05/16/2018 01:43 PM, Heikki Krogerus wrote: On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: Hi Heikki, On 05/15/2018 09:30 AM, Heikki Krogerus wrote: Hi Mats

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

On 05/16/2018 01:43 PM, Heikki Krogerus wrote: > On Tue, May 15, 2018 at 11:24:07PM +0200, Mats Karrman wrote: >> Hi Heikki, >> >> On 05/15/2018 09:30 AM, Heikki Krogerus wrote: >> >>> Hi Mats, >>> >>> On Fri, May 11, 2018 at 09:28:04PM +0200

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

Hi, On 05/16/2018 02:25 PM, Heikki Krogerus wrote: > Hi guys, > > On Tue, May 15, 2018 at 10:52:57PM +0200, Mats Karrman wrote: >> Hi, >> >> On 05/14/2018 11:36 AM, Jun Li wrote: >> >>> Hi >>>> -Original Message- >>>> F

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

Hi Heikki, On 05/15/2018 09:30 AM, Heikki Krogerus wrote: > Hi Mats, > > On Fri, May 11, 2018 at 09:28:04PM +0200, Mats Karrman wrote: >> On 2018-05-11 13:14, Heikki Krogerus wrote: >> >>> On Fri, May 11, 2018 at 11:05:55AM +0200, Mats Karrman wrote: >>>

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

Hi, On 05/14/2018 11:36 AM, Jun Li wrote: > Hi >> -Original Message- >> From: Mats Karrman [mailto:mats.dev.l...@gmail.com] >> Sent: 2018年5月12日 3:56 >> To: Jun Li <jun...@nxp.com>; robh...@kernel.org; gre...@linuxfoundation.org; >> heikki.kroge

Re: [PATCH v5 14/14] staging: typec: tcpci: move tcpci driver out of staging

Hi Li Jun, This patch takes away building the entire staging/typec tree but this is still not empty after your patch, another driver "tcpci_rt1711h" is there. Better just remove tcpci from staging/typec/{Kconfig,Makefile} // Mats On 2018-05-03 02:24, Li Jun wrote: Move TCPCI(Typec port

Re: [PATCH v5 05/14] usb: typec: add API to get typec basic port power and data config

Hi Li Jun, On 2018-05-03 02:24, Li Jun wrote: This patch adds 3 APIs to get the typec port power and data type, and preferred power role by its name string. Signed-off-by: Li Jun --- drivers/usb/typec/class.c | 52 +++

Re: [PATCH v5 03/14] staging: typec: tcpci: add compatible string for nxp ptn5110

Hi Li Jun, On 2018-05-03 02:24, Li Jun wrote: Add nxp ptn5110 typec controller compatible string: usb-tcpci,ptn5110, which is a standard tcpci chip with power delivery support. Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

Hi Li Jun, On 2018-05-03 02:24, Li Jun wrote: Add bingdings supported by current typec driver, so user can pass all those properties via dt. Signed-off-by: Li Jun --- .../bindings/connector/usb-connector.txt | 44 +++ include/dt-bindings/usb/pd.h

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

On 2018-05-11 13:14, Heikki Krogerus wrote: On Fri, May 11, 2018 at 11:05:55AM +0200, Mats Karrman wrote: On 2018-05-10 19:49, Heikki Krogerus wrote: On Thu, May 10, 2018 at 10:04:21AM +0200, Mats Karrman wrote: Hi, On 05/09/2018 02:49 PM, Heikki Krogerus wrote: On Tue, May 08, 2018

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

Hi, On 05/08/2018 04:25 PM, Heikki Krogerus wrote: > Hi, > > On Mon, May 07, 2018 at 11:19:40PM +0200, Mats Karrman wrote: >>>> Even so, when the mux driver "set" function is called, it will just get the >>>> mode argument but since the mode (TYPEC_ST

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

Hi Heikki, On 05/07/2018 03:39 PM, Heikki Krogerus wrote: > Hi Mats, > > On Fri, May 04, 2018 at 06:57:31PM +0200, Mats Karrman wrote: >> On 2018-05-04 16:56, Heikki Krogerus wrote: >> >>> On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: >>>>

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

On 2018-05-04 16:56, Heikki Krogerus wrote: On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: Hi Heikki, On 2018-05-02 10:25, Heikki Krogerus wrote: On Wed, May 02, 2018 at 11:23:35AM +0300, Heikki Krogerus wrote: Hi Mats, On Wed, May 02, 2018 at 12:21:07AM +0200, Mats

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

Hi Heikki, On 2018-05-02 10:25, Heikki Krogerus wrote: On Wed, May 02, 2018 at 11:23:35AM +0300, Heikki Krogerus wrote: Hi Mats, On Wed, May 02, 2018 at 12:21:07AM +0200, Mats Karrman wrote: The current naming used for tcpc_mux_mode constants makes too much assumptioms about the usage

[RFC PATCH 5/7] usb: typec: mux: pi3usb30532: Add support for supported mode properties

Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- drivers/usb/typec/mux/pi3usb30532.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c index d995883..3e564e6

[RFC PATCH 7/7] usb: typec: mux: Allow default mux mode to be specified

This patch allows the default mux mode to be specified using a firmware property. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- drivers/usb/typec/mux/pi3usb30532.c | 18 ++ drivers/usb/typec/tcpm.c| 2 +- include/linux/usb/typec.h |

[RFC PATCH 3/7] usb: typec: Add API to find mux mode from its string representation

Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- drivers/usb/typec/class.c | 22 ++ include/linux/usb/typec.h | 1 + 2 files changed, 23 insertions(+) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 53df10d..c5432f4 100644 --- a/drive

[RFC PATCH 0/7] Fixe some issues with Type-C muxes

SBSS maybe that should be the default. Mats Karrman (7): usb: typec: Generalize mux mode names usb: typec: Move mux mode type definition to limit dependency usb: typec: Add API to find mux mode from its string representation dt-bindings: usb: Add general documentation for USB Type-C muxes usb:

[RFC PATCH 6/7] dt-bindings: usb: typec-mux: Add property for default mux mode

For some devices it is necessary to specify a different initial mux mode to use after connection. E.g. some devices may not have USB SS support but just USB HS and an alternate mode and thus prefer TYPEC_MUX_NONE as default mode. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.

[RFC PATCH 1/7] usb: typec: Generalize mux mode names

not fit the new concept and currently have no in-tree users. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- drivers/usb/typec/mux/pi3usb30532.c | 7 --- drivers/usb/typec/tcpm.c| 2 +- include/linux/usb/tcpm.h| 21 ++--- 3 files chang

[RFC PATCH 4/7] dt-bindings: usb: Add general documentation for USB Type-C muxes

This patch adds documentation of properties allowing the supported set of mux modes to be restricted in situations where a bad mode selection may have negative effects. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- Documentation/devicetree/bindings/usb/typec-mux.tx

[RFC PATCH 2/7] usb: typec: Move mux mode type definition to limit dependency

To avoid unnecessary dependencies on tcpm.h and to pave the way for comming patches, move the tcpc_mux_mode enum from tcpm.h to typec.h and change its name to typec_mux_mode (the enum constants already follow this naming). Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- drive

Re: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

Hi Li Jun, Are you working on an updated version of this patch series? I'm pondering other changes that builds on these patches (the documentation and the fwnode added to the tcpc_dev and tcpm primarily). Btw, there is a semi-colon missing in your example below. BR // Mats On 2018-03-28

Re: [PATCH v2 2/5] usb: typec: fusb302: remove max_snk_* for sink config

Hi Li, On 2018-03-23 15:58, Li Jun wrote: Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Signed-off-by: Li Jun --- drivers/usb/typec/fusb302/fusb302.c | 51 +++-- 1 file changed, 37

Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

Hi Li, On 03/28/2018 06:06 PM, Li Jun wrote: > In case of drp toggling, we may need set correct cc value for role control > after attach as it may never been set. > > Signed-off-by: Li Jun > --- > drivers/usb/typec/tcpm.c | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

Hi Li, On 03/28/2018 06:06 PM, Li Jun wrote: > Add bingdings supported by current typec driver, so user can pass > all those properties via dt. > > Signed-off-by: Li Jun > --- > .../bindings/connector/usb-connector.txt | 39 > ++ > 1 file changed,

Re: [PATCH] staging: typec: rt1711h typec chip driver

Hi, On 2018-03-16 13:58, Greg KH wrote: On Fri, Mar 16, 2018 at 05:12:49PM +0800, ShuFan Lee wrote: From: ShuFan Lee Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB Type-C functionalities. Add definition of

Re: [PATCH v3 05/12] usb: typec: add API to get sink and source config

Hi, On 2018-03-13 10:34, Li Jun wrote: This patch add 2 APIs to get sink and source power config from firmware description in case the port supports PD. Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 47 +++

Re: [PATCH v3 02/12] dt-bindings: usb: add documentation for typec port controller(TCPCI)

Hi, On 2018-03-13 10:34, Li Jun wrote: TCPCI stands for typec port controller interface, its implementation has full typec port control with power delivery support, it's a standard i2c slave with GPIO input as irq interface, detail see spec "Universal Serial Bus Type-C Port Controller

[PATCH v2] typec: fusb302: Use dev_err during probe

If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- Changes since v1: - Driver is no longer in stageing. - Removed accidental change o

Re: [PATCH] typec: fusb302: Use dev_err during probe

On 2017-11-23 23:12, Guenter Roeck wrote: On 11/23/2017 01:41 PM, Mats Karrman wrote: If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.

[PATCH] typec: fusb302: Use dev_err during probe

If probe fails, fusb302_debugfs_exit is called making it impossible to view any logs so use normal dev_err for any error messages during probe. Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- drivers/staging/typec/fusb302/fusb302.c | 21 +++-- 1 file chang

[PATCH v4] usb: typec: Don't prevent using constant typec_mode_desc initializers

In some situations, e.g. when registering alternate modes for local typec ports, it may be handy to use constant mode descriptors. Allow this by changing the mode descriptor arguments of typec_port_register_altmode() et.al. to using const pointers. Signed-off-by: Mats Karrman <mats.de

[PATCH v3] usb: typec: Don't prevent using constant typec_mode_desc initializers

Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- v3: - Fixed damaged white-space, finally? v2: - Fixed damaged white-space - Added signed-off-by drivers/usb/typec/typec.c | 11 ++- include/linux/usb/typec.h | 6 +++--- 2 files changed, 9 insertions(+), 8 deletions(-)

[PATCH v2] usb: typec: Don't prevent using constant typec_mode_desc initializers

Signed-off-by: Mats Karrman <mats.dev.l...@gmail.com> --- v2: - Fixed damaged white-space - Added signed-off-by drivers/usb/typec/typec.c | 11 ++- include/linux/usb/typec.h | 6 +++--- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/typec/typec.c b/d

Re: [RFC PATCH v5 1/2] usb: typec: USB Type-C Port Manager (tcpm)

Hello Guenter, Some corrections and suggestions follow. And then of course it would be nice to factor out the alternate mode handling so new mode handlers could be registered as needed :) BR // Mats On 04/22/2017 12:15 AM, Guenter Roeck wrote: From: Guenter Roeck This

[PATCH] usb: typec: Don't prevent using constant typec_mode_desc initializers

From 98ff2be4de83f4d4b5293bfa424c274b25400e1e Mon Sep 17 00:00:00 2001 From: Mats Karrman <mats.dev.l...@gmail.com> Date: Mon, 24 Apr 2017 15:21:39 +0200 Subject: [PATCH] usb: typec: Don't prevent using constant typec_mode_desc initializers --- drivers/usb/typec/typec.

usb: typec: Missing link for altmode active store

Hello Heikki, I'm working with the new typec class code and have run into a problem. The struct typec_capability defines a callback function as: int (*activate_mode)(const struct typec_capability *, int mode, int activate); From the capability I can get to the corresponding port/plug/partner

Re: USB Type-C Port Manager API concern

On 04/14/2017 04:57 AM, Guenter Roeck wrote: ... Overall I think there is an assumption in any API that any callback functions provided in a registration call can immediately be called. Otherwise any API would be in trouble. Can you modify your code to not require the port pointer in its

Re: USB Type-C Port Manager API concern

On 04/09/2017 05:16 PM, Guenter Roeck wrote: Hi Mats, On Sun, Apr 09, 2017 at 01:09:57AM +0200, Mats Karrman wrote: I'm working on a tcpi driver and have some concern about the tcpm api. The tcpm_register_port() is typically called from the probe function of tcpi driver where the tcpm_port

USB Type-C Port Manager API concern

Hi Guenter, From a previous thread: On 03/08/2017 02:38 AM, Guenter Roeck wrote: On 03/07/2017 02:30 PM, Mats Karrman wrote: [ ... ] I'm still struggling to catch up on what you guys have been up to during the last year or so :-) and came across some patches of Guenter from last October

Re: [PATCH v17 0/3] USB Type-C Connector class

On 03/21/2017 11:37 AM, Heikki Krogerus wrote: I'm lost in the long thread here, is this series still ready to be merged in, or is there another version that is being worked on? There was one documentation fix proposed Mats. The rest of the thread was not about these patches. I'll send one

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 2017-03-08 14:58, Heikki Krogerus wrote: On Tue, Mar 07, 2017 at 11:30:54PM +0100, Mats Karrman wrote: If I read Heikki's original suggestion I understand it like the DP driver would be responsible for AM specific USB PD/VDM communication. But wouldn't that lead to a lot of code

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 2017-03-06 14:14, Heikki Krogerus wrote: Hi Mats, On Fri, Mar 03, 2017 at 08:27:08PM +0100, Mats Karrman wrote: My system is a bit different. It's an i.MX6 SoC with the typec phy and DP controller connected directly to the SoC and it's using DTB/OF. Is this "DP controller" a

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 2017-03-03 13:59, Heikki Krogerus wrote: On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: How would something like that sound to you guys? Complicated... Need to marinate on that for a while ;) My system is a bit different. It's an i.MX6 SoC with the typec phy and DP

Re: [PATCH v17 2/3] usb: USB Type-C connector class

On 2017-03-03 04:13, Guenter Roeck wrote: On 03/02/2017 07:22 AM, Mats Karrman wrote: Looking forward, one thing I have run into is how to connect the typec driver with a driver for an alternate mode. E.g. the DisplayPort Alternate Mode specification includes the HPD (hot plug) and HPD

Re: [PATCH v17 2/3] usb: USB Type-C connector class

Hi Heikki, Good to see things are happening with Type-C! On 2017-02-21 15:24, Heikki Krogerus wrote: ... +When connected, the partner will be presented also as its own device under +/sys/class/typec/. The parent of the partner device will always be the port it +is attached to. The partner