From: "Peter E. Berger" <pber...@brimson.com>
Fix non-standard formatting in some of the comments.
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 148 +
1 file changed, 96 insertions(+),
From: "Peter E. Berger" <pber...@brimson.com>
While working on a previous patchset for this driver [1] we were
hampered by the facts that download_fw() is very long and its return
paths are so complicated. Thus we were compelled to put the patched
request_firmware() call in edge
From: "Peter E. Berger" <pber...@brimson.com>
Remove unused "dev" parameter from build_i2c_fw_hdr() and its caller.
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
From: "Peter E. Berger" <pber...@brimson.com>
Use serial->interface instead of serial->dev for messages in download_fw().
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
From: "Peter E. Berger" <pber...@brimson.com>
Remove extra blank lines in the several places where functions were
separated by more than one.
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 6 --
1 file changed, 6 deletions(-)
di
From: "Peter E. Berger" <pber...@brimson.com>
Separate the download and boot mode code from download_fw() into two new
helper functions: do_download_mode() and do_boot_mode().
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/us
From: "Peter E. Berger" <pber...@brimson.com>
Move request_firmware from edge_startup to download_fw.
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 56 +-
1 file changed, 30 insertions(+),
From: "Peter E. Berger" <pber...@brimson.com>
Remove unused "dev" argument from build_i2c_fw_hdr() and its caller.
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
From: "Peter E. Berger" <pber...@brimson.com>
Remove leading tabs in do_download_mode and fixup problems
flagged by checkpatch.pl
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 314 +++-
From: "Peter E. Berger" <pber...@brimson.com>
Move request_firmware from edge_startup to download_fw
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 56 --
1 file changed, 29 insertions(+),
From: "Peter E. Berger" <pber...@brimson.com>
While working on a previous patchset for this driver [1] we were hampered
by the fact that download_fw() is very long and its return paths are so
complicated that we were compelled to the put the request_firmware() call
in edge_startup
From: "Peter E. Berger" <pber...@brimson.com>
Separate the download and boot mode code from download_fw() into two new
helper functions: do_download_mode() and do_boot_mode(), and fix formatting
in some of the comments.
Signed-off-by: Peter E. Berger <pber...@brimson.com>
-
From: "Peter E. Berger" <pber...@brimson.com>
Use serial->interface instead of serial->dev for messages in download_fw().
Signed-off-by: Peter E. Berger <pber...@brimson.com>
---
drivers/usb/serial/io_ti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
From: Peter E. Berger pber...@brimson.com
When using Edgeport/416 models with newer firmware (sometime after
firmware version 4.80.0), idle ports are automatically bounced
(disconnected and then reconnected) approximately every 60 seconds.
This breaks programs (e.g: minicom) where idle periods
From: Peter E. Berger pber...@brimson.com
I found that when using the Edgeport EP/416, idle ports are regularly
bounced (disconnected and then reconnected). I discussed this with the
manufacturer (Digi International) and learned that EP/416 devices now
ship from the factory running firmware
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport
devices such as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version
on the EP/416. The current download code is broken in a few ways
From: Peter E. Berger pber...@brimson.com
Do what we can to verify that the driver's firmware image is valid
(before attempting to download it to the Edgeport) by adding a new
function, check_fw_sanity(), and a call to it in in download_fw().
Note: It looks like some Edgeports (models like
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport devices such as
the EP/416 and EP/421 (devices with on-board E2PROM). One of the problems
is that the default 1 second timeout in ti_vsend_sync() is insufficient
for download operations. This patch
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport devices such as
the EP/416 and EP/421 (devices with on-board E2PROM). One of the problems
is that the default 1 second timeout in ti_vsend_sync() is insufficient
for download operations. This patch
From: Peter E. Berger pber...@brimson.com
I found that when using the Edgeport EP/416, idle ports are regularly
bounced (disconnected and then reconnected). I discussed this with the
manufacturer (Digi International) and learned that EP/416 devices now
ship from the factory running firmware
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport
devices such as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version
on the EP/416. The current download code is broken in a few ways
From: Peter E. Berger pber...@brimson.com
When using Edgeport/416 models with newer firmware (sometime after
firmware version 4.80.0), idle ports are automatically bounced
(disconnected and then reconnected) approximately every 60 seconds.
This breaks programs (e.g: minicom) where idle periods
From: Peter E. Berger pber...@brimson.com
Do what we can to verify that the driver's firmware image is valid
(before attempting to download it to the Edgeport) by adding a new
function, check_fw_sanity(), and a call to it in in download_fw().
Note: It looks like some Edgeports (models like
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport
devices such as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version
on the EP/416. The current download code is broken in a few ways
From: Peter E. Berger pber...@brimson.com
Do what we can to verify that the driver's firmware image is valid
(before attempting to download it to the Edgeport) by adding a new
function, check_fw_sanity(), and a call to it in in download_fw().
Also add an fw == NULL check in edge_startup().
Note
From: Peter E. Berger pber...@brimson.com
When using newer Edgeport devices such as the EP/416, idle ports are
automatically bounced (disconnected and then reconnected) approximately
every 60 seconds. This breaks programs (e.g: minicom) where idle periods
are common, normal and expected.
I
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport devices such as
the EP/416. One of the problems is that the default 1 second timeout
in ti_vsend_sync() is insufficient for download operations. This patch
increases the download timeout to 10
From: Peter E. Berger pber...@brimson.com
I found that when using newer Edgeport devices such as the EP/416,
idle ports are regularly bounced (disconnected and then reconnected).
I discussed this with the manufacturer (Digi International) and learned
that some newer Edgeport devices now ship from
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport devices such as
the EP/416. One of the problems is that the default 1 second timeout
in ti_vsend_sync() is insufficient for download operations. This patch
increases the download timeout to 10
From: Peter E. Berger pber...@brimson.com
When using newer Edgeport devices such as the EP/416, idle ports are
automatically bounced (disconnected and then reconnected) approximately
every 60 seconds. This breaks programs (e.g: minicom) where idle periods
are common, normal and expected.
I
From: Peter E. Berger pber...@brimson.com
I found that when using newer Edgeport devices such as the EP/416,
idle ports are regularly bounced (disconnected and then reconnected).
I discussed this with the manufacturer (Digi International) and learned
that some newer Edgeport devices now ship from
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport
devices such as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version
on the EP/416. The current download code is broken in a few ways
From: Peter E. Berger pber...@brimson.com
Add edge_heartbeat_reschedule() helper function and call it
from edge_startup() and edge_resume().
Signed-off-by: Peter E. Berger pber...@brimson.com
---
drivers/usb/serial/io_ti.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport
devices such as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version
on the EP/416. The current download code is broken in a few ways
From: Peter E. Berger pber...@brimson.com
I found that when using newer Edgeport devices such as the EP/416,
idle ports are regularly bounced (disconnected and then reconnected).
I discussed this with the manufacturer (Digi International) and learned
that some newer Edgeport devices now ship from
From: Peter E. Berger pber...@brimson.com
Instead of having ti_vsend_sync() decide when to use non-default timeouts,
make timeout a parameter and leave the decision to the caller.
Signed-off-by: Peter E. Berger pber...@brimson.com
---
drivers/usb/serial/io_ti.c | 28
From: Peter E. Berger pber...@brimson.com
When using newer Edgeport devices such as the EP/416, idle ports are
automatically bounced (disconnected and then reconnected) approximately
every 60 seconds. This breaks programs (e.g: minicom) where idle periods
are common, normal and expected.
I
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport devices such as
the EP/416. One of the problems is that the default 1 second timeout
in ti_vsend_sync() is insufficient for download operations. This patch
increases the download timeout to 10
From: Peter E. Berger pber...@brimson.com
Move INIT_DELAY_WORK out of the if block.
Signed-off-by: Peter E. Berger pber...@brimson.com
---
drivers/usb/serial/io_ti.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
From: Peter E. Berger pber...@brimson.com
Call cancel_delayed_work_sync() unconditionally in edge_release()
and edge_suspend().
Signed-off-by: Peter E. Berger pber...@brimson.com
---
drivers/usb/serial/io_ti.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb
From: Peter E. Berger pber...@brimson.com
The firmware has a build_number field, though it is apparently unused
(according to observations of the three firmware images I have seen and
confirmed by Digi Tech Support). This comment describes its structure,
in case it is populated in a future
From: Peter E. Berger pber...@brimson.com
- Replace a dev_dbg() with dev_err().
- Drop unneeded dev_dbg().
Signed-off-by: Peter E. Berger pber...@brimson.com
---
drivers/usb/serial/io_ti.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/serial/io_ti.c b
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport
devices such as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version on
the EP/416. This patch adds a fw_version field
From: Peter E. Berger pber...@brimson.com
When using newer Edgeport devices such as the EP/416, idle ports are
automatically bounced (disconnected and then reconnected) approximately
every 60 seconds. This breaks programs (e.g: minicom) where idle periods
are common, normal and expected.
I
From: Peter E. Berger pber...@brimson.com
The io_ti driver fails to download firmware to Edgeport devices such
as the EP/416, even when the on-disk firmware image
(/lib/firmware/edgeport/down3.bin) is more current than the version
on the EP/416. The current download code is broken in a few ways
From: Peter E. Berger pber...@brimson.com
I found that when using newer Edgeport devices such as the EP/416,
idle ports are regularly bounced (disconnected and then reconnected).
I discussed this with the manufacturer (Digi International) and learned
that some newer Edgeport devices now ship from
46 matches
Mail list logo
