Re: [PATCH 20/22] USB: gadget: udc: pxa27x_udc: no need to check return value of debugfs_create functions

all, so remove > those variables from the device structure. > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Felipe Balbi > Signed-off-by: Greg Kroah-Hartman Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line

Re: [PATCH v1 07/14] USB: gadget: pxa27x: Re-use DEFINE_SHOW_ATTRIBUTE() macro

Andy Shevchenko <andriy.shevche...@linux.intel.com> writes: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Cc: Daniel Mack <dan...@zonque.org> > Cc: Haojian Zhuang <haojian.zhu...@gmail.com> > Cc:

Re: [PATCH v1 06/14] USB: gadget: pxa25x: Re-use DEFINE_SHOW_ATTRIBUTE() macro

Andy Shevchenko <andriy.shevche...@linux.intel.com> writes: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Cc: Daniel Mack <dan...@zonque.org> > Cc: Haojian Zhuang <haojian.zhu...@gmail.com> > Cc:

Re: [PATCH][V2] usb: gadget: pxa27x: Remove redundant assignment to is_short and dev

adget/udc/pxa27x_udc.c:1141:2: warning: Value stored > to 'dev' is never read Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 22/24] USB: gadget: udc: Remove redundant license text

.com> > Cc: Sylvain Lemieux <slemieux.t...@gmail.com> > Cc: Daniel Mack <dan...@zonque.org> > Cc: Haojian Zhuang <haojian.zhu...@gmail.com> > Cc: Robert Jarzmik <robert.jarz...@free.fr> > Cc: Michal Simek <michal.si...@xilinx.com> > Cc: "Sören B

Re: [PATCH v2 2/2] usb: gadget: pxa27x: Test for a valid argument pointer

Petr Cvek <petr.c...@tul.cz> writes: > A call usb_put_phy(udc->transceiver) must be tested for a valid pointer. > Use an already existing test for usb_unregister_notifier call. > > Reported-by: Robert Jarzmik <robert.jarz...@free.fr> > Signed-off-by: Petr Cvek <p

Re: [PATCH v2 1/2] usb: gadget: pxa27x: Remove duplicate function prototype

Petr Cvek <petr.c...@tul.cz> writes: > Functions udc_enable() and udc_disable() have a duplicated prototype. > Remove it. > > Signed-off-by: Petr Cvek <petr.c...@tul.cz> Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert -- To unsubscribe

Re: [PATCH 1/2] [TRIVIAL] usb: gadget: Remove duplicated function declaration in pxa27x_udc

Petr Cvek writes: > Remove duplicated function declaration for udc_enable() and udc_disable(). The patch title looks a bit tool long to me, and that also applied to your second one. Moreover the correct prefix for this driver (for the title) is : usb: gadget: pxa27x:

Re: [PATCH 2/2] usb: gadget: Add test if argument pointer has a valid value in pxa27x_udc

Petr Cvek <petr.c...@tul.cz> writes: > Move call usb_put_phy(udc->transceiver) inside a valid pointer test. > > Reported-by: robert.jarz...@free.fr I'd rather have my normal signature here : Reported-by: Robert Jarzmik <robert.jarz...@free.fr> > Signed-off-by: Petr Cv

Re: [RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

ay, the code (specified as !in_interrupt()) > seems to work fine > (after torture reloads). Can the caller (udc core) be changed to be able to > sleep? This question is for Felipe. From the several years back when I wrote this code I think it was granted that the pullup() callback was no

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

Petr Cvek <petr.c...@tul.cz> writes: > Dne 12.2.2017 v 13:02 Robert Jarzmik napsal(a): > That's weird I even removed pxa_set_udc_info() from magician machine init and > it still fails. > Host cable and/or actual camera is not required. It fails without them. > > So you

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

Petr Cvek writes: > Hi > > any news? Yeah, I don't have the error on my mainstone, which kind of hinders my debug capability. I have tried your script, and this is what I get : - dmesg | tail random: crng init done gadgetfs: USB Gadget filesystem, version 24

Re: [BUG] usb: gadget: Kernel oops with UVC USB gadget and configfs

Petr Cvek writes: > Setting the UVC gadget with configfs and then reloading UDC controler driver > (pxa27x_udc) causes kernel to fail. > > UDC subsystem was patched only in decreasing maxpacket size for UVC, addition > of more predefined endpoints for pxa27x_udc and addition of

Re: [PATCH] usb: gadget: udc: constify usb_ep_ops structures

A smaller version of the script) For pxa27x_udc.c : Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: Convert pr_warning to pr_warn

Joe Perches <j...@perches.com> writes: > Use the more common logging mechanism. > > Miscellanea: > > o Realign multiline statements > o Coalesce format > > Signed-off-by: Joe Perches <j...@perches.com> For pxa25x_udc.h: Acked-by: Robert Jarzmik <robe

Re: [RFC] usb: phy: generic: get rid of VBUS handling

Felipe Balbi <felipe.ba...@linux.intel.com> writes: > Hi Robert, > > Robert Jarzmik <robert.jarz...@free.fr> writes: >> Felipe Balbi <felipe.ba...@linux.intel.com> writes: >> >>> Hi, >>> >>> Robert Jarzmik <robert.jarz...@free.

[PATCH 3/3] usb: phy: generic: remove the vbus dependency

*() is not necessary anymore. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/usb/phy/phy-generic.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 41b8aff9b925..c14e767a3fbf

[PATCH 2/3] usb: phy: generic: cope with initial state

, and the gadget will be aware it should answer enumeration and go forth Without this fix, the USB cable must be removed and replugged for any gadget relying on phy-generic and its gpio vbus handling to work. The problem was seen on a pxa27x architecture based board on a devicetree build. Signed-off-by

[PATCH 1/3] usb: gadget: pxa27x: add phy notifier event handler

platforms, we'll rely on the probe deferral, and the phy can be gadget API agnostic. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/usb/gadget/udc/pxa27x_udc.c | 51 +++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drive

Re: [RFC] usb: phy: generic: get rid of VBUS handling

Felipe Balbi writes: >> - amend the drivers (for my part I have pxa27x_udc.c and probably >> pxa25x_udc.c) >> to subscribe to the notifier, and in the action function call either >> usb_gadget_vbus_connect() or usb_gadget_vbus_disconnect(). >> >> Would that kind

Re: [RFC] usb: phy: generic: get rid of VBUS handling

Felipe Balbi writes: > Hi Robert, > > your commit 7acc9973e3c4 ("usb: phy: generic: add vbus support") added > GPIO-based VBUS handling for phy-generic.c, but that ends up calling > usb_gadget_vbus_connect() which forces NOP to depend on the gadget API. > > I was

Re: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument

ect than "Fixes" : Fixes: 70189a63d408 ("usb: gadget: pxa27x_udc: convert to udc_start/udc_stop") Apart form that: Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb&

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

Arnd Bergmann writes: > Coming back to the specific pxa25x_udc case: using __raw_* accessors > in the driver would possibly end up breaking the PXA25x machines in > the (very unlikely) case that someone wants to make it work with > big-endian kernels, assuming it does not have the

[PATCH] usb: host: ohci-pxa27x: propagate the irq error code

. Even if in this specific case the driver was not broken, because the interrupt controller is always probed before drivers, propagate the proper return code. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/usb/host/ohci-pxa27x.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH 0/7] USB changes for rare warnings

Felipe Balbi writes: > Hi Arnd, > >> arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h | 198 - >> arch/arm/mach-pxa/include/mach/pxa25x-udc.h | 163 > > for arch/arm I need Acked-by from relevant folks. You already have mine for

Re: [PATCH 2/7] usb: gadget: pxa25x_udc cleanup

h should > not be changing the behavior of the driver, other than using > ioremap() on the platform resource to replace the hardcoded > virtual address pointers. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Robert Jarzmik <robert.jarz...@free.fr> It's too bad cocc

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

Arnd Bergmann writes: > ixp4xx and pxa25x both use this driver and provide a slightly > different set of register definitions for it. Aside from that, > the definition in the ixp4xx-regs.h header conflicts with the > on in the pxa27x device driver when compile-testing that: > > In

Re: [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio

and after this patch. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> For pxa25x_udc: Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

Arnd Bergmann <a...@arndb.de> writes: > On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote: >> > This addresses both issues by moving all the definitions into the >> > pxa25x_udc driver itself. It turns out the only difference between >> > them was

Re: [PATCH] usb: gadget: pxa27x: fix suspend callback

Felipe Balbi writes: > pxa27x disconnects pullups on suspend but doesn't > notify the gadget driver about it, so gadget driver > can't disable the endpoints it was using. > > This causes problems on resume because gadget core > will think endpoints are still enabled and just >

Re: [PATCH] usb: gadget: pxa27x: fix suspend callback

e still enabled and just > ignore the following usb_ep_enable(). > > Fix this problem by calling > gadget_driver->disconnect(). > > Cc: <sta...@vger.kernel.org> # v3.10+ > Signed-off-by: Felipe Balbi <ba...@ti.com> Tested-by: Robert Jarzmik <robert.jarz...@free

Re: [4.4-rc1 regression] pxa27x_udc and suspend/resume

Robert Jarzmik <robert.jarz...@free.fr> writes: > Felipe Balbi <ba...@ti.com> writes: > >> Hi, >> >> without any sort of logs it a bit difficult :-) Care to send some output >> of the failure ? Are there any oopses or what exactly happens ? &g

Re: [4.4-rc1 regression] pxa27x_udc and suspend/resume

Felipe Balbi writes: > Hi, > > without any sort of logs it a bit difficult :-) Care to send some output > of the failure ? Are there any oopses or what exactly happens ? Ah well, the UDC is the only way to "speak" to the board (no UART), so I don't have any written feedback

Re: [4.4-rc1 regression] pxa27x_udc and suspend/resume

Felipe Balbi writes: > Hi, > > this could be a bug in either g_ether or pxa27x... Seems like something > is enabling endpoints which were already enabled. Not sure if this is > pxa27x not _really_ disabling endpoints or g_ether being stupid. You're probably right. >From what I

Re: [4.4-rc1 regression] pxa27x_udc and suspend/resume

Felipe Balbi writes: > Hi, > >> Euh it's expected to work _after resume_. > > sure is, but you can't expect it to have a proper IP. From host's > perspective this is a brand new usb0 network interface. Unless you have > dhcp client running on the phone and a server on your PC, you

Re: [4.4-rc1 regression] pxa27x_udc and suspend/resume

Felipe Balbi writes: > Hi, > you can increase fbcon verbosity, right ? I guess that was > CONFIG_MESSAGE_LOGLEVEL_DEFAULT. Sure. > Set it to 9 and you should get everything. Another option is to change > dev_* to dev_crit() and KERN_* to KERN_CRIT. > >> I know there is not

[4.4-rc1 regression] pxa27x_udc and suspend/resume

Hi Robert and Felipe, I experience a regression in the 4.4-rc1 kernel which appeared between v4.3 and v4.4-rc1. The test : - boot the mioa701 kernel (ie. pxa27x_udc driver) - echo mem > /sys/power/state - resume from "Suspend to RAM" with a key press - try to use the udc (in my case,

Re: [PATCH v3 42/46] usb: gadget: move ep_matches() from epautoconf to udc-core

Alan Stern st...@rowland.harvard.edu writes: Hi Alan, On Sat, 25 Jul 2015, Robert Jarzmik wrote: Petr Cvek petr.c...@tul.cz writes: On 23.7.2015 21:46, Alan Stern wrote: It seems that it allows using a BULK endpoint for requested INT endpoint. For my PXA27x machine the original code

Re: [PATCH v3 42/46] usb: gadget: move ep_matches() from epautoconf to udc-core

Petr Cvek petr.c...@tul.cz writes: On 23.7.2015 21:46, Alan Stern wrote: It seems that it allows using a BULK endpoint for requested INT endpoint. For my PXA27x machine the original code returns BULK EP even with valid INT endpoint definition (because BULK EPs are defined earlier than INT

Re: [PATCH] usb: pass flags parameter to gpiod_get functions

Alexandre Courbot acour...@nvidia.com writes: On 03/28/2015 04:30 AM, Uwe Kleine-König wrote: Looks good, but can't we also merge the call to gpiod_direction to avoid using GPIOD_ASIS? The golden rule is that a direction should not remain in an unknown state after being requested. This

Re: [PATCH] usb: pass flags parameter to gpiod_get functions

Felipe Balbi ba...@ti.com writes: Looks good to me: Acked-by: Felipe Balbi ba...@ti.com Same for me: Acked-by: Robert Jarzmik robert.jarz...@free.fr Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: [PATCH 10/27] pxa27x_udc: Remove use of seq_printf return value

by returning immediately and remove the unnecessary labels. Signed-off-by: Joe Perches j...@perches.com Tested-by: Robert Jarzmik robert.jarz...@free.fr Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

Fabio Estevam feste...@gmail.com writes: On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik robert.jarz...@free.fr wrote: All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb

[PATCH v3 2/2] usb: phy: generic: fix the vbus interrupt request

-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/usb/phy/phy-generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index bdb4cb3..48af068 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

Fabio Estevam feste...@gmail.com writes: Since the power GPIO is mapped as active-low, its actual signal will be 0 after this code. Contrary to the legacy integer GPIO interface, the active-low property is handled during mapping and is thus transparent to GPIO consumers. ,which is exactly

[PATCH v3 1/2] usb: phy: generic: fix the gpios to be optional

All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Tested-by: Fabio Estevam

Re: [PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

Fabio Estevam feste...@gmail.com writes: Why do you set it to zero independently of the GPIO active level flag? I don't. Please have a look at gpiod_direction_output() first, especially : if (test_bit(FLAG_ACTIVE_LOW, desc-flags)) ,which correctly puts the GPIO output to the correct

[PATCH v2 2/2] usb: phy: generic: fix the vbus interrupt request

-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/usb/phy/phy-generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 9f08c1e..af32ce2 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy

[PATCH v2 1/2] usb: phy: generic: fix the gpios to be optional

All the gpios, ie. reset-gpios and vbus-detect-gpio, should be optional and not prevent the driver from working. Fix the regression in the behavior introduced by commit usb: phy: generic: migrate to gpio_desc. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: correctly handle

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

Felipe Balbi ba...@ti.com writes: nop-gpiod_reset = devm_gpiod_get_optional(dev, reset); if (gpiod_is_active_low(nop-gpiod_reset)) gpiod_direction_output(nop-gpiod_reset, GPIOD_OUT_LOW); else gpiod_direction_output(nop-gpiod_reset,

Re: [PATCH] usb: phy: generic: fix the gpios to be optional

Felipe Balbi ba...@ti.com writes: At the same time, declare the interrupt as one shot so that it is masked until the end of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq requested with handler=NULL and !ONESHOT for irq 63 Shouldn't this be

[PATCH] usb: phy: generic: fix the gpios to be optional

of the threaded handler. This prevents the irq core from spitting out an error : Threaded irq requested with handler=NULL and !ONESHOT for irq 63 Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/usb/phy/phy-generic.c | 13 +++-- 1 file changed, 7 insertions(+), 6

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

- Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list linux-usb@vger.kernel.org Envoyé: Mardi 27 Janvier 2015 13:41:57 Objet

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

too, it works in mine ... Cheers. -- Robert ---8--- [1] Patch From 4005a6abf519272267399ac4030a5671f7877ca4 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik robert.jarz...@free.fr Date: Tue, 27 Jan 2015 06:27:03 +0100 Subject: [PATCH] usb: phy: generic: fix the gpios to be optional All the gpios, ie

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

Felipe Balbi ba...@ti.com writes: diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 9a826ff31951..34231c31cd1a 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -219,11 +219,11 @@ int usb_phy_gen_create_phy(struct device *dev,

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

- Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list linux-usb@vger.kernel.org Envoyé: Mardi 27 Janvier 2015 10:40:35 Objet

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

- Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list linux-usb@vger.kernel.org Envoyé: Mardi 27 Janvier 2015 12:23:43 Objet

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

Fabio Estevam feste...@gmail.com writes: On Sat, Dec 6, 2014 at 7:05 PM, Robert Jarzmik robert.jarz...@free.fr wrote: Change internal gpio handling from integer gpios into gpio descriptors. This change only addresses the internal API and device-tree/ACPI, while the legacy platform data

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

Robert Jarzmik robert.jarz...@free.fr writes: I'm not convinced of the so many issues. So far I see the gpiod_get_optional() requirement, which is a one liner patch. Would you try the following patch to see if it fixes all your concerns please ? Cheers. -- Robert ---8--- From

Re: [PATCH v2] usb: phy: generic: Do not fail when 'reset-gpios' is not used

Fabio Estevam feste...@gmail.com writes: On Fri, Jan 23, 2015 at 2:12 AM, Fabio Estevam feste...@gmail.com wrote: Will need to debug more. The problem here is that: nop-gpiod_reset = devm_gpiod_get(dev, reset-gpios); Always return -2. On imx51-babbage.dts we pass 'reset-gpios' and it

Re: [PATCH] usb: phy: make GPIOs optional for the generic phy

...@synopsys.com Reviewed-by: Robert Jarzmik robert.jarz...@free.fr Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

Paul Zimmerman paul.zimmer...@synopsys.com writes: The patch below fixes it. And it seems like the right thing to me, since GPIOs should be optional for a generic phy, I would think. But my device tree foo is very weak, so I'm not sure. CCing Robert, who touched the generic phy code last.

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

Felipe Balbi ba...@ti.com writes: Hi, Happy new year Felipe, sorry for the long delay, got caught up with other stuff. It's now in my testing/next and I'll start testing with the boards I have. Excellent news. Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 0/3] usb: phy: generic: device-tree support

Robert Jarzmik robert.jarz...@free.fr writes: Hi Felipe, This is the 2nd opus of this serie. For patches 1 and 2, all comments have been addressed. For patch 3, you had a question about device charging spec and the regulator timings. I read the specs, saw the 15mn timing you were speaking

[PATCH v2 0/3] usb: phy: generic: device-tree support

. -- Robert Robert Jarzmik (3): usb: phy: generic: migrate to gpio_desc usb: phy: nop: device tree documentation for vbus usb: phy: generic: add vbus support .../devicetree/bindings/usb/usb-nop-xceiv.txt | 8 ++ drivers/usb/phy/phy-generic.c | 146

[PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

in the commit message so that this patch gets some testing as I'm pretty sure it's buggy. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Acked-by: Linus Walleij linus.wall...@linaro.org --- Since v1: added Linus's ack --- drivers/usb/phy/phy-generic.c | 61

[PATCH v2 2/3] usb: phy: nop: device tree documentation for vbus

Enhance the phy documentation by adding 2 new optional bindings : - the vbus gpio, which detects usb insertion - the vbus regulator, which provides current drawn from the usb cable Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: changed vbus-gpios to vbus-detect-gpio

[PATCH v2 3/3] usb: phy: generic: add vbus support

Add support for vbus detection and power supply. This code is more or less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a power supply activation which draws current from the VBus. Signed-off-by: Robert

Re: [PATCH v1] usb: phy: generic: migrate to gpio_desc

Alexandre Courbot gnu...@gmail.com writes: I think what you want to do is explained in the Platform Data section of Documentation/gpio/board.txt Ah yeah, already one year and I never checked again this documemtation. Thanks. -- Robert -- To unsubscribe from this list: send the line

Re: [PATCH v1] usb: phy: generic: migrate to gpio_desc

Linus Walleij linus.wall...@linaro.org writes: This definately make things better so: Acked-by: Linus Walleij linus.wall...@linaro.org Thanks. One comment though: if (dev-of_node) { (...) + nop-gpiod_reset = devm_gpiod_get(dev, reset-gpios); + err =

Re: [PATCH v2 2/3] usb: phy: add lubbock phy driver

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: Extract lubbock-specific code from pxa25x_udc driver. As a bonus, phy driver determines connector/VBUS status by reading CPLD register. Also it uses a work to call into udc stack, instead of pinging vbus session right from irq handler. This

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

OK Dmitry, I pulled through, the interrupts are working back. Actually one of the blockers I have is in pxa25x_udc, and it is also in your phy-lubbock.c. The bottom of the error is that disable_irq() is called from within a irq handler, and it deadlocks. A disable_irq_nosync() should be used ...

Lubbock interrupts fix (was lubbock udc phy)

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: 2014-11-27 1:12 GMT+03:00 Robert Jarzmik robert.jarz...@free.fr: OK Dmitry, I pulled through, the interrupts are working back. What was the problem? Hardware issues? Firmware in CPLD being of old revision? There were basically 2 problems

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

Felipe Balbi ba...@ti.com writes: @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { } while (0) #define remove_debug_files(dev) \ do { \ - if (dev-debugfs_udc) \ - debugfs_remove(dev-debugfs_udc); \ +

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

Felipe Balbi ba...@ti.com writes: On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { } while (0) #define remove_debug_files(dev) \ do { \ - if (dev

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: 2014-11-22 20:49 GMT+03:00 Robert Jarzmik robert.jarz...@free.fr: Next point would be (from my POV) to make sure that lubbock_unmask_irq() is called and works as expected. Actually the problem is probably within the CPLD. Irrespective

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Robert Jarzmik robert.jarz...@free.fr writes: Okay, now my ADSL line is repaired, thank you Mr farmer I drive a tractor but I don't care about telephone posts, I'll fetch your changes and make a test. Let's say I schedule this for saturday. Removed people from the list for the tests aspect

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: Hello, 2014-11-22 20:18 GMT+03:00 Robert Jarzmik robert.jarz...@free.fr: Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: 2014-11-22 16:56 GMT+03:00 Robert Jarzmik robert.jarz...@free.fr: Robert Jarzmik robert.jarz...@free.fr writes

Re: [PATCH v1] usb: phy: nop: device tree documentation for vbus

Felipe Balbi ba...@ti.com writes: On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote: hsusb1_phy { @@ -26,8 +31,11 @@ Example: clock-names = main_clk; vcc-supply = hsusb1_vcc_regulator; reset-gpios = gpio1 7 GPIO_ACTIVE_LOW

Re: [PATCH v1] usb: phy: generic: add vbus support

Felipe Balbi ba...@ti.com writes: On Sun, Nov 09, 2014 at 03:58:14PM +0100, Robert Jarzmik wrote: +if (!enabled) { +ret = regulator_enable(vbus_draw); +if (ret 0) +return; +nop

Re: [PATCH v1] usb: phy: nop: device tree documentation for vbus

Felipe Balbi ba...@ti.com writes: On Fri, Nov 21, 2014 at 06:17:58PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: On Sun, Nov 09, 2014 at 02:02:18PM +0100, Robert Jarzmik wrote: hsusb1_phy { @@ -26,8 +31,11 @@ Example: clock-names = main_clk

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: I have sketched a compile-tested only PHY for the Lubbock platform. Could you please take a look and test. git://git.infradead.org/users/dbaryshkov/zaurus.git lubbock Okay, now my ADSL line is repaired, thank you Mr farmer I drive a

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: Change clk_enable/disable() calls to clk_prepare_enable() and clk_disable_unprepare(). Signed-off-by: Dmitry Eremin-Solenikov dbarysh...@gmail.com --- drivers/usb/gadget/udc/pxa25x_udc.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: Hello, OK, I will take a look. It seems the correct way would be to strip this code away to a phy, like gpio-vbus or nop phys. Do you have access to lubbock (or maybe Daniel, Haojian or Russell has?)? Actually Russell kindly gave me his, so

Re: [PATCH v1] usb: phy: generic: add vbus support

Robert Jarzmik robert.jarz...@free.fr writes: Add support for vbus detection and power supply. This code is more or less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a power supply activation which draws

Re: [PATCH 1/2] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: Change clk_enable/disable() calls to clk_prepare_enable() and clk_disable_unrepapre(). = clk_disable_unprepare() (typo) Otherwise, good for me, ack. Cheers. -- Robert -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] usb: gadget: pxa27x_udc: prepare/unprepare clocks in pxa-ssp

Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: Change clk_enable/disable() calls to clk_prepare_enable() and clk_disable_unrepapre(). No, there are already patches for this in Felipe's next tree : git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next Cheers. --

[PATCH v1] usb: phy: generic: migrate to gpio_desc

in the commit message so that this patch gets some testing as I'm pretty sure it's buggy. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/usb/phy/phy-generic.c | 58 --- drivers/usb/phy/phy-generic.h | 4 +-- 2 files changed, 18 insertions

Re: [PATCH v1] usb: phy: generic: migrate to gpio_desc

Robert Jarzmik robert.jarz...@free.fr writes: } else if (pdata) { type = pdata-type; clk_rate = pdata-clk_rate; needs_vcc = pdata-needs_vcc; - nop-gpio_reset = pdata-gpio_reset; - } else { - nop-gpio_reset = -1

[PATCH v1] usb: phy: nop: device tree documentation for vbus

Enhance the phy documentation by adding 2 new optional bindings : - the vbus gpio, which detects usb insertion - the vbus regulator, which provides current drawn from the usb cable Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt

[PATCH v1] usb: phy: generic: add vbus support

Add support for vbus detection and power supply. This code is more or less stolen from phy-gpio-vbus-usb.c, and aims at providing a detection mechanism for VBus (ie. usb cable plug) based on a GPIO line, and a power supply activation which draws current from the VBus. Signed-off-by: Robert

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

Felipe Balbi ba...@ti.com writes: fine by me, as long as their all optional and agreed with devicetree folks. I think we still have time for v3.19 if you manage to finish this before next week's end. I will try, no promise I'll succeed in this window. At least I should fire out within the

Re: [PATCH] usb: gadget: udc: pxa27x: fix build warning when !OF

this issue (in [1]) ? Cheers. -- Robert [1] Patch From: Robert Jarzmik robert.jarz...@free.fr Subject: [PATCH v1] usb: gadget: pxa27x_udc: fix warning in non device-tree build To: Felipe Balbi ba...@ti.com Cc: linux-usb@vger.kernel.org, Robert Jarzmik robert.jarz...@free.fr Date: Wed, 29 Oct 2014 21:58

Re: [PATCH] usb: gadget: udc: pxa27x: fix build warning when !OF

Felipe Balbi ba...@ti.com writes: On Thu, Nov 06, 2014 at 04:17:48PM -0600, Felipe Balbi wrote: I seem to have missed that, let me replace the patches and use yours. now done. Thanks. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

Felipe Balbi ba...@ti.com writes: Hi, On Sun, Nov 02, 2014 at 07:11:49PM +0100, Robert Jarzmik wrote: In order to prepare device-tree conversion, port gpio_vbus to use gpio_desc. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Can we just convert users of this to a phy-generic.c

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

Felipe Balbi ba...@ti.com writes: On Wed, Nov 05, 2014 at 08:46:58PM +0100, Robert Jarzmik wrote: Well, let's add that :-) Just make it optional. It's pointless to have 80% duplicated code just because of 20% missing in phy-generic :-) Then we avoid adding gpio-vbus specific DT properties

Re: [PATCH v1 1/3] usb: phy: device-tree documentation for gpio-vbus

Philipp Zabel philipp.za...@gmail.com writes: Hi Robert, On Sun, Nov 2, 2014 at 7:11 PM, Robert Jarzmik robert.jarz...@free.fr wrote: Maybe duplicate the comment from the driver here how his is about B peripheral only devices Yeah sure, for v2. +Required properties: +- compatible

[PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

In order to prepare device-tree conversion, port gpio_vbus to use gpio_desc. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/usb/phy/phy-gpio-vbus-usb.c | 105 +++- 1 file changed, 56 insertions(+), 49 deletions(-) diff --git a/drivers/usb/phy

[PATCH v1 1/3] usb: phy: device-tree documentation for gpio-vbus

Add documentation for device-tree binding of the generic gpio-vbus phy controller. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/phy/gpio-vbus.txt | 23 ++ 1 file changed, 23 insertions(+) create mode

[PATCH v1 3/3] usb: phy: add device-tree support for gpio-vbus

Add device-tree support for the generic gpio-vbus driver. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: devicet...@vger.kernel.org --- drivers/usb/phy/phy-gpio-vbus-usb.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c b

  1   2   >