Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-08-19 Thread Santosh Shilimkar
On 8/19/2016 12:30 AM, Roger Quadros wrote: Hi Santosh, So I'm 99.9% convinced that the proposed change is correct. I will got with that then :-) and take my objection back. Just saying that if there other breakages which I can't recollect now, those drivers needs to be patched as well.

Re: [PATCH 1/1] ARM: dma: fix dma_max_pfn()

2016-08-18 Thread Santosh Shilimkar
s intended for or what the problem was, which would've been helpful. From what I recollect, we did these changes to make the max pfn behave same on ARM arch as other archs. This patch was evolved as part of fixing the max*pfn assumption. commit 26ba47b18318abe7dadbe9294a611c0e932651d8 Author: Santosh

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

2016-04-04 Thread santosh shilimkar
On 4/3/2016 11:28 PM, Felipe Balbi wrote: santosh shilimkar <santosh.shilim...@oracle.com> writes: +Arnd, RMK, On 4/1/2016 4:57 AM, Felipe Balbi wrote: Hi, Grygorii Strashko <grygorii.stras...@ti.com> writes: On 04/01/2016 01:20 PM, Felipe Balbi wrote: [.

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

2016-04-01 Thread santosh shilimkar
+Arnd, RMK, On 4/1/2016 4:57 AM, Felipe Balbi wrote: Hi, Grygorii Strashko writes: On 04/01/2016 01:20 PM, Felipe Balbi wrote: [...] commit 7ace8fc8219e4cbbfd5b4790390d9a01a2541cdf Author: Yoshihiro Shimoda Date: Mon Jul 13

Re: [PATCH] usb: dwc3: core: avoid NULL pointer dereference

2015-07-15 Thread santosh shilimkar
, This is patch is urgently required to be applied to master for v4.2 for fixing a crash seen on keystone based boards (K2HK, K2L and K2E EVMs). Please merge it asap. I assume you are you sending this one for rc's ? Feel free to use my ack if you need one. Acked-by: Santosh Shilimkar ssant...@kernel.org

Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

2014-04-02 Thread Santosh Shilimkar
. CC: Kishon Vijay Abraham I kis...@ti.com CC: Felipe Balbi ba...@ti.com CC: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com nice :-) Acked-by: Felipe Balbi ba...@ti.com Greg, if your tree isn't closed yet, could you consider this patch

Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

2014-04-02 Thread Santosh Shilimkar
On Wednesday 02 April 2014 02:16 PM, Greg KH wrote: On Wed, Apr 02, 2014 at 01:53:19PM -0400, Santosh Shilimkar wrote: On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote: Hi, On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii

Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

2014-03-13 Thread Santosh Shilimkar
reference in Generic PHY APIs stubs in the same way as it was done by the patch 04c2facad8fee66c981a51852806d8923336f362 drivers: phy: Make NULL a valid phy reference. CC: Kishon Vijay Abraham I kis...@ti.com CC: Felipe Balbi ba...@ti.com CC: Santosh Shilimkar santosh.shilim...@ti.com Signed

Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

2014-03-13 Thread Santosh Shilimkar
On Thursday 13 March 2014 09:43 PM, Kishon Vijay Abraham I wrote: Hi Santosh, On Thursday 13 March 2014 07:07 PM, Santosh Shilimkar wrote: On Thursday 13 March 2014 07:11 PM, Strashko, Grygorii wrote: This fixes a regression on Keystone 2 platforms caused by patch

Re: [PATCH] usb: dwc3: keystone: switch to use runtime pm

2014-01-31 Thread Santosh Shilimkar
On Friday 31 January 2014 08:20 AM, Grygorii Strashko wrote: The Keystone PM management layer has been implemented using PM bus for power management clocks. As result, most of Keystone drivers don't need to manage clocks directly. They just need to enable runtime PM and use it to handle their

Re: [PATCH] usb: dwc3: keystone: switch to use runtime pm

2014-01-31 Thread Santosh Shilimkar
On Friday 31 January 2014 10:19 AM, Felipe Balbi wrote: Hi, On Fri, Jan 31, 2014 at 03:20:26PM +0200, Grygorii Strashko wrote: The Keystone PM management layer has been implemented using PM bus for power management clocks. As result, most of Keystone drivers don't need to manage clocks

Re: [PATCH] usb: dwc3: keystone: switch to use runtime pm

2014-01-31 Thread Santosh Shilimkar
On Friday 31 January 2014 10:47 AM, Felipe Balbi wrote: On Fri, Jan 31, 2014 at 10:43:21AM -0500, Santosh Shilimkar wrote: On Friday 31 January 2014 10:19 AM, Felipe Balbi wrote: Hi, On Fri, Jan 31, 2014 at 03:20:26PM +0200, Grygorii Strashko wrote: The Keystone PM management layer has been

Re: [PATCH] usb: dwc3: keystone: switch to use runtime pm

2014-01-31 Thread Santosh Shilimkar
On Friday 31 January 2014 11:45 AM, Felipe Balbi wrote: On Fri, Jan 31, 2014 at 10:50:40AM -0500, Santosh Shilimkar wrote: On Friday 31 January 2014 10:47 AM, Felipe Balbi wrote: On Fri, Jan 31, 2014 at 10:43:21AM -0500, Santosh Shilimkar wrote: On Friday 31 January 2014 10:19 AM, Felipe Balbi

Re: [PATCH] usb: dwc3: keystone: switch to use runtime pm

2014-01-31 Thread Santosh Shilimkar
On Friday 31 January 2014 05:15 PM, Felipe Balbi wrote: Hi, On Fri, Jan 31, 2014 at 02:20:48PM -0500, Santosh Shilimkar wrote: [ snip ] note that because of pm_runtime_set_active() that first pm_runtime_get_sync() in probe() will simply increase the reference counter without calling my

Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning

2013-12-13 Thread Santosh Shilimkar
On Friday 13 December 2013 12:23 AM, David Cohen wrote: On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote: On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 08:51 PM, David Cohen wrote: On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-13 Thread Santosh Shilimkar
On Thursday 12 December 2013 07:43 PM, Felipe Balbi wrote: On Thu, Dec 12, 2013 at 07:29:24PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: A bare-minimum PM implementation which will server as building block for more complex s/server/serve

Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-12 Thread Santosh Shilimkar
On Thursday 12 December 2013 02:41 PM, Felipe Balbi wrote: On Thu, Dec 12, 2013 at 02:36:01PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote: Hi, On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote: +static int kdwc3_remove(struct

Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support

2013-12-12 Thread Santosh Shilimkar
On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: A bare-minimum PM implementation which will server as building block for more complex s/server/serve ;-) PM implementation in the future. At the least will not leave clocks on unnecessarily when e.g. a user write mem to

[PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning

2013-12-12 Thread Santosh Shilimkar
...@linux.intel.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- drivers/usb/host/xhci-plat.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index d9c169f

Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to avoid warning

2013-12-12 Thread Santosh Shilimkar
On Thursday 12 December 2013 08:51 PM, David Cohen wrote: On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote: Otherwise you get below build warnings drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function] drivers/usb/host

Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-10 Thread Santosh Shilimkar
On Monday 09 December 2013 09:51 PM, Balbi, Felipe wrote: Hi, On Mon, Dec 09, 2013 at 05:17:03PM -0500, WingMan Kwok wrote: +static void kdwc3_enable_irqs(struct dwc3_keystone *kdwc) +{ +u32 val; + +val = kdwc3_readl(kdwc-usbss, USBSS_IRQENABLE_SET_0); +val =

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-10 Thread Santosh Shilimkar
On Monday 09 December 2013 09:54 PM, Balbi, Felipe wrote: Hi, On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: +ret = usb_add_phy_dev(k_phy-usb_phy_gen.phy); +if (ret) +return ret; +k_phy-usb_phy_gen.phy.init = keystone_usbphy_init; +

Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

2013-12-10 Thread Santosh Shilimkar
On Monday 09 December 2013 11:47 PM, Felipe Balbi wrote: Hi again, On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote: +static int keystone_usbphy_init(struct usb_phy *phy) +{ +struct keystone_usbphy *k_phy = dev_get_drvdata(phy-dev); +u32 val; + +val =

Re: [PATCH] usb: dwc3: omap: remove unnecessary lock

2013-12-09 Thread Santosh Shilimkar
...@ti.com --- Acked-by: Santosh Shilimkar santosh.shilim...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/5] usb: dwc3: Add Keystone specific glue layer

2013-12-06 Thread Santosh Shilimkar
On Friday 06 December 2013 03:28 PM, Felipe Balbi wrote: Hi, On Wed, Dec 04, 2013 at 03:10:07PM -0500, WingMan Kwok wrote: Add Keystone platform specific glue layer to support USB3 Host mode. Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah

Re: [PATCH v2 2/5] usb: phy: Add keystone usb phy driver

2013-12-06 Thread Santosh Shilimkar
On Wednesday 04 December 2013 03:10 PM, WingMan Kwok wrote: Add Keystone platform USB PHY driver support. Current main purpose of this driver is to enable the PHY reference clock gate on the Keystone SoC. Otherwise it is a nop PHY. Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Felipe

Re: [PATCH v2 3/5] ARM: dts: keystone: Add usb phy devicetree bindings

2013-12-06 Thread Santosh Shilimkar
On Friday 06 December 2013 03:30 PM, Felipe Balbi wrote: On Wed, Dec 04, 2013 at 03:10:09PM -0500, WingMan Kwok wrote: Added device tree support for TI's Keystone USB PHY driver and updated the Documentation with device tree binding information. Cc: Santosh Shilimkar santosh.shilim...@ti.com

Re: [PATCH v2 0/5] Kesytone II USB support

2013-12-06 Thread Santosh Shilimkar
. Patchset are tested on Keystone II EVM with USB2.0 and USB3.0 flash drives. Cc: Santosh Shilimkar santosh.shilim...@ti.com WingMan Kwok (5): usb: dwc3: Add Keystone specific glue layer usb: phy: Add keystone usb phy driver Please update the minor comments on patch 1 and resubmit

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-27 Thread Santosh Shilimkar
On Wednesday 27 November 2013 12:41 PM, Felipe Balbi wrote: Hi, On Wed, Nov 27, 2013 at 02:49:54PM +0530, George Cherian wrote: + error = of_platform_populate(node, NULL, NULL, dev); + if (error) { + dev_err(pdev-dev, failed to create dwc3 core\n); + goto err_core;

Re: [PATCH 2/3] ARM: dts: keystone: Add usb devicetree bindings

2013-11-27 Thread Santosh Shilimkar
On Wednesday 27 November 2013 04:59 AM, George Cherian wrote: On 11/26/2013 1:46 AM, WingMan Kwok wrote: Added device tree support for TI's Keystone USB driver and updated the Documentation with device tree binding information. On Keystone II platforms, we use no-op phy driver. Cc: Santosh

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-26 Thread Santosh Shilimkar
On Tuesday 26 November 2013 12:16 PM, Felipe Balbi wrote: On Mon, Nov 25, 2013 at 07:49:01PM -0500, Santosh Shilimkar wrote: On Monday 25 November 2013 03:39 PM, Felipe Balbi wrote: Hi, [...] + kdwc3_dma_mask = dma_get_mask(dev); + dev-dma_mask = kdwc3_dma_mask; + + error

Re: [PATCH 2/3] ARM: dts: keystone: Add usb devicetree bindings

2013-11-25 Thread Santosh Shilimkar
driver. Cc: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: WingMan Kwok w-kw...@ti.com --- [...] BTW, some preliminary TRM coming my way would be cool, so I can better understand how this HW behaves. A board would also go a long way, so I could test this myself (we are part

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-25 Thread Santosh Shilimkar
On Monday 25 November 2013 03:39 PM, Felipe Balbi wrote: Hi, [...] +kdwc3_dma_mask = dma_get_mask(dev); +dev-dma_mask = kdwc3_dma_mask; + +error = kdwc3_enable(kdwc); I would drop this function and just add your clk_prepare() here, then move clk_enable()/clk_disable() to