Re: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-02-20 Thread Andy Shevchenko
---------- > ------------ > From 32ea5fda7654e7c081fff161544da73d53bf8fac Mon Sep 17 00:00:00 2001 > From: Felipe Balbi <felipe.ba...@linux.intel.com> > Date: Thu, 15 Feb 2018 13:03:38 +0200 > Subject: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_

Re: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-02-15 Thread Felipe Balbi
--- From 32ea5fda7654e7c081fff161544da73d53bf8fac Mon Sep 17 00:00:00 2001 From: Felipe Balbi <felipe.ba...@linux.intel.com> Date: Thu, 15 Feb 2018 13:03:38 +0200 Subject: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro ...in

Re: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-02-15 Thread Andy Shevchenko
On Thu, 2018-02-15 at 13:16 +0200, Felipe Balbi wrote: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > Reviewed-by: Andy Shevchenko Though one comment below. > Signed-off-by: Felipe Balbi

[PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-02-15 Thread Felipe Balbi
...instead of open coding file operations followed by custom ->open() callbacks per each attribute. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debugfs.c | 79 -- 1 file changed, 34 insertions(+), 45 deletions(-)