RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

Hi Geert, On Friday, January 05, 2018, Geert Uytterhoeven wrote: > > But then...the number goes back to '73' when you look at it in > > /proc/interrupts. > > Having an identical number in /proc/interrupts is a coincidence. > These numbers are virtual, and may change even across reboots. I'm not

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

Hi Chris, On Fri, Jan 5, 2018 at 1:54 PM, Chris Brandt wrote: > On Friday, January 05, 2018, Geert Uytterhoeven wrote: >> > + interrupts = ; >> >> "41", all other interrupt properties already have the SPI offset >> subtracted? > > The actual HW vector

RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

Hi Geert, Thanks for the review. On Friday, January 05, 2018, Geert Uytterhoeven wrote: > > + interrupts = ; > > "41", all other interrupt properties already have the SPI offset > subtracted? The actual HW vector number in the hardware manual is '73'. As you know, you need to

RE: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

On Friday, January 05, 2018, Sergei Shtylyov wrote: > > + usbhs0: usbhs@e801 { > > The node names should be generic, i.e "usb@e801". > > > + compatible = "renesas,usbhs-r7s72100"; > > + reg = <0xe801 0x1A0>; > > Lowercase in the hex values, please be

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

On Thu, Jan 04, 2018 at 03:01:50PM -0500, Chris Brandt wrote: > Add USB device support. > > Signed-off-by: Chris Brandt Hi Chris, it looks like there have been some requests for (minor) changes to this patch. Please consider addressing those and reposting. -- To

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

Hello! On 1/4/2018 11:01 PM, Chris Brandt wrote: Add USB device support. Signed-off-by: Chris Brandt --- arch/arm/boot/dts/r7s72100.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100.dtsi

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

On Thu, Jan 4, 2018 at 9:01 PM, Chris Brandt wrote: > Add USB device support. > > Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven Minor nits below. > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++

[PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

Add USB device support. Signed-off-by: Chris Brandt --- arch/arm/boot/dts/r7s72100.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index ab9645a42eca..eb414e735185 100644