Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-19 Thread Arnd Bergmann
On Monday, September 19, 2016 10:29:27 AM CEST Kishon Vijay Abraham I wrote: > On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote: > > On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I > > wrote: > >> This way the driver will be probed only once (the reset can

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-18 Thread Kishon Vijay Abraham I
Hi, On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote: > Hi Kishon, > > On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I > wrote: >> Hi, >> >> On Friday 09 September 2016 09:44 PM, Martin Blumenstingl wrote: >>> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-18 Thread Martin Blumenstingl
Hi Kishon, On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 09 September 2016 09:44 PM, Martin Blumenstingl wrote: >> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >>> However, the problem with all of the solutions

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-16 Thread Arnd Bergmann
On Friday, September 16, 2016 1:49:59 PM CEST Kishon Vijay Abraham I wrote: > > I think the offset information can come from the devicetree too. The phy can > be > modeled something like below. > > usb-phys@c000 { > compatible =

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-16 Thread Kishon Vijay Abraham I
Hi, On Friday 09 September 2016 09:44 PM, Martin Blumenstingl wrote: > On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >> However, the problem with all of the solutions proposed (runtime PM ones >> included) is that we're forcing a board-specific design issue (2 devices

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-15 Thread Philipp Zabel
Hi Martin, Am Mittwoch, den 14.09.2016, 23:23 +0200 schrieb Martin Blumenstingl: [...] > > We could add a triggered flag or a counter to struct reset_control, and > > have reset_control_reset_once do nothing if it is already set / > > incremented. Since the reset_control goes away with the last

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Martin Blumenstingl
On Wed, Sep 14, 2016 at 10:37 AM, Philipp Zabel wrote: > Am Dienstag, den 13.09.2016, 20:38 +0200 schrieb Martin Blumenstingl: >> Hi Philipp, >> >> On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel >> wrote: >> > Hi Martin, >> > >> > Am Freitag, den

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Martin Blumenstingl
On Wed, Sep 14, 2016 at 10:37 AM, Philipp Zabel wrote: > Am Dienstag, den 13.09.2016, 17:59 -0700 schrieb Kevin Hilman: >> Martin Blumenstingl writes: >> >> > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel >> >

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Philipp Zabel
Am Dienstag, den 13.09.2016, 20:38 +0200 schrieb Martin Blumenstingl: > Hi Philipp, > > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel wrote: > > Hi Martin, > > > > Am Freitag, den 09.09.2016, 22:36 +0200 schrieb Martin Blumenstingl: > >> On Fri, Sep 9, 2016 at 5:33 PM,

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Philipp Zabel
Am Dienstag, den 13.09.2016, 17:59 -0700 schrieb Kevin Hilman: > Martin Blumenstingl writes: > > > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel > > wrote: > > [...] > > >>> I added Philipp and Hans to this thread - maybe they can

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-14 Thread Philipp Zabel
Am Dienstag, den 13.09.2016, 17:59 -0700 schrieb Kevin Hilman: > Martin Blumenstingl writes: > > > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel > > wrote: > > [...] > > >>> I added Philipp and Hans to this thread - maybe they can

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-13 Thread Kevin Hilman
Martin Blumenstingl writes: > On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel wrote: [...] >>> I added Philipp and Hans to this thread - maybe they can comment on this. >>> To sum it up, our problem is: >>> - there are two separate

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-13 Thread Martin Blumenstingl
Hi Philipp, On Tue, Sep 13, 2016 at 5:28 PM, Philipp Zabel wrote: > Hi Martin, > > Am Freitag, den 09.09.2016, 22:36 +0200 schrieb Martin Blumenstingl: >> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >> > Martin Blumenstingl

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-13 Thread Philipp Zabel
Hi Martin, Am Freitag, den 09.09.2016, 22:36 +0200 schrieb Martin Blumenstingl: > On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: > > Martin Blumenstingl writes: > > > >> On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-12 Thread Kevin Hilman
Martin Blumenstingl writes: > On Fri, Sep 9, 2016 at 10:36 PM, Martin Blumenstingl > wrote: >> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >>> Martin Blumenstingl

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-09 Thread Martin Blumenstingl
On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: > Martin Blumenstingl writes: > >> On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks wrote: >>> On 08/09/16 21:42, Kevin Hilman wrote: Ben Dooks

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-09 Thread Martin Blumenstingl
On Fri, Sep 9, 2016 at 7:21 PM, Ben Dooks wrote: > On 09/09/16 17:14, Martin Blumenstingl wrote: >> >> On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >>> >>> However, the problem with all of the solutions proposed (runtime PM ones >>>

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-09 Thread Ben Dooks
On 09/09/16 17:14, Martin Blumenstingl wrote: On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: However, the problem with all of the solutions proposed (runtime PM ones included) is that we're forcing a board-specific design issue (2 devices sharing a reset line) into a

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-09 Thread Kevin Hilman
Martin Blumenstingl writes: > On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: >> However, the problem with all of the solutions proposed (runtime PM ones >> included) is that we're forcing a board-specific design issue (2 devices >>

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-09 Thread Martin Blumenstingl
On Fri, Sep 9, 2016 at 5:33 PM, Kevin Hilman wrote: > However, the problem with all of the solutions proposed (runtime PM ones > included) is that we're forcing a board-specific design issue (2 devices > sharing a reset line) into a driver that should not have any >

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-09 Thread Kevin Hilman
Martin Blumenstingl writes: > On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks wrote: >> On 08/09/16 21:42, Kevin Hilman wrote: >>> >>> Ben Dooks writes: >>> On 08/09/16 20:52, Martin Blumenstingl wrote:

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-08 Thread Martin Blumenstingl
On Thu, Sep 8, 2016 at 10:53 PM, Ben Dooks wrote: > On 08/09/16 21:42, Kevin Hilman wrote: >> >> Ben Dooks writes: >> >>> On 08/09/16 20:52, Martin Blumenstingl wrote: On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-08 Thread Ben Dooks
On 08/09/16 21:42, Kevin Hilman wrote: Ben Dooks writes: On 08/09/16 20:52, Martin Blumenstingl wrote: On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: + phy = devm_phy_create(>dev, NULL, _meson_usb2_ops); + if (IS_ERR(phy)) { +

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-08 Thread Kevin Hilman
Ben Dooks writes: > On 08/09/16 20:52, Martin Blumenstingl wrote: >> On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: + phy = devm_phy_create(>dev, NULL, _meson_usb2_ops); + if (IS_ERR(phy)) { + dev_err(>dev,

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-08 Thread Ben Dooks
On 08/09/16 20:52, Martin Blumenstingl wrote: On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: + phy = devm_phy_create(>dev, NULL, _meson_usb2_ops); + if (IS_ERR(phy)) { + dev_err(>dev, "failed to create PHY\n"); + return PTR_ERR(phy); +

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-08 Thread Martin Blumenstingl
On Thu, Sep 8, 2016 at 9:35 PM, Kevin Hilman wrote: >> + phy = devm_phy_create(>dev, NULL, _meson_usb2_ops); >> + if (IS_ERR(phy)) { >> + dev_err(>dev, "failed to create PHY\n"); >> + return PTR_ERR(phy); >> + } >> + >> + if

Re: [PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-08 Thread Ben Dooks
On 08/09/16 20:35, Kevin Hilman wrote: Martin Blumenstingl writes: This is a new driver for the USB PHY found in Meson8b and GXBB SoCs. Signed-off-by: Martin Blumenstingl Signed-off-by: Jerome Brunet

[PATCH 4/7] phy: meson: add USB2 PHY support for Meson8b and GXBB

2016-09-04 Thread Martin Blumenstingl
This is a new driver for the USB PHY found in Meson8b and GXBB SoCs. Signed-off-by: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/phy/Kconfig | 11 ++ drivers/phy/Makefile | 1 +