Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-25 Thread Hans de Goede
Hi, On 22-08-16 18:10, Bin Liu wrote: On Mon, Aug 22, 2016 at 05:55:50PM +0200, Hans de Goede wrote: Hi, On 22-08-16 17:38, Bin Liu wrote: On Mon, Aug 22, 2016 at 05:32:57PM +0200, Hans de Goede wrote: When switching from host to peripheral mode, if an usb device is still plugged and

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Bin Liu
On Mon, Aug 22, 2016 at 05:55:50PM +0200, Hans de Goede wrote: > Hi, > > On 22-08-16 17:38, Bin Liu wrote: > >On Mon, Aug 22, 2016 at 05:32:57PM +0200, Hans de Goede wrote: > > > > >>>When switching from host to peripheral mode, if an usb device is still > >>>plugged and enumerated,

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Hans de Goede
Hi, On 22-08-16 17:38, Bin Liu wrote: On Mon, Aug 22, 2016 at 05:32:57PM +0200, Hans de Goede wrote: When switching from host to peripheral mode, if an usb device is still plugged and enumerated, how do you handle the device disconnect? The phy code will report vbus low for long enough

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Bin Liu
On Mon, Aug 22, 2016 at 05:32:57PM +0200, Hans de Goede wrote: > HI, > > On 22-08-16 17:24, Bin Liu wrote: > >On Mon, Aug 22, 2016 at 05:08:56PM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 22-08-16 16:11, Bin Liu wrote: > >>>Hi, > >>> > >>>On Sun, Aug 21, 2016 at 12:10:26PM +0200, Hans de

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Hans de Goede
HI, On 22-08-16 17:24, Bin Liu wrote: On Mon, Aug 22, 2016 at 05:08:56PM +0200, Hans de Goede wrote: Hi, On 22-08-16 16:11, Bin Liu wrote: Hi, On Sun, Aug 21, 2016 at 12:10:26PM +0200, Hans de Goede wrote: Hi, On 19-08-16 23:30, Bin Liu wrote: Hi, On Mon, Aug 15, 2016 at 09:21:32PM

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Bin Liu
On Mon, Aug 22, 2016 at 05:08:56PM +0200, Hans de Goede wrote: > Hi, > > On 22-08-16 16:11, Bin Liu wrote: > >Hi, > > > >On Sun, Aug 21, 2016 at 12:10:26PM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 19-08-16 23:30, Bin Liu wrote: > >>>Hi, > >>> > >>>On Mon, Aug 15, 2016 at 09:21:32PM +0200,

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Hans de Goede
Hi, On 22-08-16 16:11, Bin Liu wrote: Hi, On Sun, Aug 21, 2016 at 12:10:26PM +0200, Hans de Goede wrote: Hi, On 19-08-16 23:30, Bin Liu wrote: Hi, On Mon, Aug 15, 2016 at 09:21:32PM +0200, Hans de Goede wrote: This allows run-time dr_mode switching support via the "mode" musb sysfs

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-22 Thread Bin Liu
Hi, On Sun, Aug 21, 2016 at 12:10:26PM +0200, Hans de Goede wrote: > Hi, > > On 19-08-16 23:30, Bin Liu wrote: > >Hi, > > > >On Mon, Aug 15, 2016 at 09:21:32PM +0200, Hans de Goede wrote: > >>This allows run-time dr_mode switching support via the "mode" musb > >>sysfs attribute. > >> >

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-21 Thread Hans de Goede
Hi, On 19-08-16 23:30, Bin Liu wrote: Hi, On Mon, Aug 15, 2016 at 09:21:32PM +0200, Hans de Goede wrote: This allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- drivers/usb/musb/sunxi.c | 52

Re: [PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-19 Thread Bin Liu
Hi, On Mon, Aug 15, 2016 at 09:21:32PM +0200, Hans de Goede wrote: > This allows run-time dr_mode switching support via the "mode" musb > sysfs attribute. > > Signed-off-by: Hans de Goede > --- > drivers/usb/musb/sunxi.c | 52 >

[PATCH v2 7/7] musb: sunxi: Add support for platform_set_mode

2016-08-15 Thread Hans de Goede
This allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- drivers/usb/musb/sunxi.c | 52 1 file changed, 48 insertions(+), 4 deletions(-) diff --git