Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
On 13 October 2016 at 20:17, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: > @@ -241,6 +241,9 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep > *dep, unsigned cmd, > int susphy = false;

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Felipe Balbi
Hi, Baolin Wang writes: @@ -241,6 +241,9 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, int susphy = false; int ret = -EINVAL;

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
Hi Felipe, On 13 October 2016 at 19:22, Felipe Balbi wrote: > > Hi, > > Janusz Dziedzic writes: Baolin Wang writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
Hi, On 13 October 2016 at 19:22, Felipe Balbi wrote: > > Hi, > > Janusz Dziedzic writes: Baolin Wang writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Felipe Balbi
Hi, Janusz Dziedzic writes: >>> Baolin Wang writes: >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 1783406..ca2ae5b 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Janusz Dziedzic
On 13 October 2016 at 12:41, Baolin Wang wrote: > On 13 October 2016 at 17:49, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
On 13 October 2016 at 17:49, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 1783406..ca2ae5b 100644 --- a/drivers/usb/dwc3/gadget.c +++

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index 1783406..ca2ae5b 100644 >>> --- a/drivers/usb/dwc3/gadget.c >>> +++ b/drivers/usb/dwc3/gadget.c >>> @@ -241,6 +241,9 @@ int

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
On 13 October 2016 at 16:28, Janusz Dziedzic wrote: > On 13 October 2016 at 10:21, Baolin Wang wrote: >> Hi, >> >> On 13 October 2016 at 16:16, Janusz Dziedzic >> wrote: >>> On 13 October 2016 at 09:37, Baolin Wang

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Janusz Dziedzic
On 13 October 2016 at 10:21, Baolin Wang wrote: > Hi, > > On 13 October 2016 at 16:16, Janusz Dziedzic > wrote: >> On 13 October 2016 at 09:37, Baolin Wang wrote: >>> Hi, >>> >>> On 13 October 2016 at 15:06, Felipe

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
Hi, On 13 October 2016 at 16:16, Janusz Dziedzic wrote: > On 13 October 2016 at 09:37, Baolin Wang wrote: >> Hi, >> >> On 13 October 2016 at 15:06, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Baolin Wang

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Janusz Dziedzic
On 13 October 2016 at 09:37, Baolin Wang wrote: > Hi, > > On 13 October 2016 at 15:06, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: >>> When system has stpped the gadget, we should avoid queuing any requests >> >>

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
Hi, On 13 October 2016 at 15:06, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> When system has stpped the gadget, we should avoid queuing any requests > > queueing is *not* a problem. Starting is. In fact, that's what your > patch is doing.

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Felipe Balbi
Hi, Baolin Wang writes: > When system has stpped the gadget, we should avoid queuing any requests queueing is *not* a problem. Starting is. In fact, that's what your patch is doing. > which will cause tranfer failed. Thus adding some disconnect checking to

[RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-04 Thread Baolin Wang
When system has stpped the gadget, we should avoid queuing any requests which will cause tranfer failed. Thus adding some disconnect checking to avoid this situation. Signed-off-by: Baolin Wang --- Changes since v2: - Move disconnect checking into