RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Mon, 25 Apr 2016, Matthew Giassa wrote: > > Good morning Alan, > > The most recent patch you provided resolved the lockup issue I have been > encountering. I will carry out full release testing shortly to further > validate it. > > Would this be something that could be proposed for

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

Good morning Alan, The most recent patch you provided resolved the lockup issue I have been encountering. I will carry out full release testing shortly to further validate it. Would this be something that could be proposed for inclusion in the kernel, pending cosmetic changes (ie: `alantest',

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

Please remember to use Reply-To-All so that your messages get sent to the mailing list as well as to me. On Thu, 21 Apr 2016, Matthew Giassa wrote: > Hi Alan, > > I've tested your latest patch, and here is a subset of the output in > `dmesg': ... > [ 44.975704] enable LPM > [ 44.975707]

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Fri, 15 Apr 2016, Matthew Giassa wrote: > Good afternoon Alan, > > Attached is the requested usbmon output. I started the camera, had a lot > of config read/write calls complete, and was able to eventually get one > frame of image data to be saved and rendered. Obviously something is going

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Matthew Giassa wrote: > The patch did not have any noticeable effect, and the cameras remain in > the problematic state. Can you provide a usbmon trace for a kernel using the second patch? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 2016-04-14 at 10:38 -0400, Alan Stern wrote: > > So we have quirk for it. The ability to trigger this quirk the hard > way > > would be useful for debugging. Thus I believe that this patch is a > good > > idea. > > If this is for debugging then maybe it belongs in debugfs. Doing it >

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Matthew Giassa wrote: > This patch works. Thank you Alan. > > What should we do next if I want to push it upstream? Do you propose and > sign off on it, and I mark it as reviewed? I don't know about that patch. Other people may object to disabling LPM for all Point Grey

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

/in/giassa e-mail: matt...@giassa.net website: www.giassa.net > Original Message > Subject: RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm > From: Alan Stern <st...@rowland.harvard.edu> > Date: Thu, April 14, 2016 10:31 am > To: Matthew Giassa <

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Alan Stern wrote: > On Thu, 14 Apr 2016, Matthew Giassa wrote: > > > Replying in-line: > > > > > > You are correct: the software claims and releases certain interfaces > > > > frequently. > > > > > > How frequently? The usbmon log you attached to the Bugzilla report > >

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Matthew Giassa wrote: > Replying in-line: > > > > You are correct: the software claims and releases certain interfaces > > > frequently. > > > > How frequently? The usbmon log you attached to the Bugzilla report > > shows it happening at intervals of approximately 20-40

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

: https://ca.linkedin.com/in/giassa e-mail: matt...@giassa.net website: www.giassa.net > Original Message > Subject: RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm > From: Alan Stern <st...@rowland.harvard.edu> > Date: Thu, April 14, 2016 8:56 am > To:

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

Replying in-line: > > You are correct: the software claims and releases certain interfaces > > frequently. > > How frequently? The usbmon log you attached to the Bugzilla report > shows it happening at intervals of approximately 20-40 ms (sometimes > longer) -- and often with no messages sent

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Matthew Giassa wrote: > I should also note that these "control" r/w calls are made very > frequently. A thread is spawned for each camera that periodically polls > for things like exposure levels, average brightness, etc, to update a > metrics cache and UI display for said

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Matthew Giassa wrote: > Hi Alan, > > You are correct: the software claims and releases certain interfaces > frequently. How frequently? The usbmon log you attached to the Bugzilla report shows it happening at intervals of approximately 20-40 ms (sometimes longer) -- and

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

id metrics. Matthew Giassa, MASc, BASc, EIT Security and Embedded Systems Specialist linkedin: https://ca.linkedin.com/in/giassa e-mail: matt...@giassa.net website: www.giassa.net > Original Message ---- > Subject: RE: [PATCH 1/1] usb: lpm: add boot flag to di

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

/in/giassa e-mail: matt...@giassa.net website: www.giassa.net > Original Message > Subject: Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm > From: Mathias Nyman <mathias.ny...@linux.intel.com> > Date: Thu, April 14, 2016 5:32 am > To: Matthew Giassa <m

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

: matt...@giassa.net website: www.giassa.net > Original Message -------- > Subject: Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm > From: Alan Stern <st...@rowland.harvard.edu> > Date: Thu, April 14, 2016 7:57 am > To: Mathias Nyman <mathias.ny...@linu

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Mathias Nyman wrote: > On 14.04.2016 01:36, Greg KH wrote: > > On Wed, Apr 13, 2016 at 03:21:09PM -0700, Matthew Giassa wrote: > >> The devices support LPM and are USB3.0 certified, and they work fine in > >> Windows using the same Intel 8/9/10 Series USB host controllers,

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 14 Apr 2016, Oliver Neukum wrote: > On Wed, 2016-04-13 at 15:11 -0700, Greg KH wrote: > > On Wed, Apr 13, 2016 at 02:37:35PM -0700, Matthew Giassa wrote: > > > Thank you for the feedback Greg. This is my first attempt to submit a > > > kernel patch. > > > > > > Is there a better approach

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Wed, 13 Apr 2016, Matthew Giassa wrote: > Mathias provided me with some usb device calls I could use to resolve > this in software (pm_runtime_get_xxx(), pm_runtime_put()), but I'm not > familiar with the API, so I'd need some help figure out how to get the > `struct device*' handle for my

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On 14.04.2016 01:42, Matthew Giassa wrote: Mathias provided me with some usb device calls I could use to resolve this in software (pm_runtime_get_xxx(), pm_runtime_put()), but I'm not familiar with the API, so I'd need some help figure out how to get the `struct device*' handle for my current

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On 14.04.2016 01:36, Greg KH wrote: On Wed, Apr 13, 2016 at 03:21:09PM -0700, Matthew Giassa wrote: The devices support LPM and are USB3.0 certified, and they work fine in Windows using the same Intel 8/9/10 Series USB host controllers, along with Renesas and Fresco controllers. On Linux the

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Thu, 2016-04-14 at 10:53 +0200, Bjørn Mork wrote: > Even more valuable when you make it device or bus specific. I don't see > Greg arguing against a knob to turn off LPM. Only the slegde hammer > operated master switch implementation :) We do have nousb and autosuspend=-1 And it is easy to

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

Oliver Neukum writes: > On Wed, 2016-04-13 at 14:33 -0700, Greg KH wrote: > >> But larger issue, no new module parameters for things like this. No one >> will use them and they aren't device or bus specific. It's a huge >> hammer that isn't nice to use. > > But this is a

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Wed, 2016-04-13 at 15:11 -0700, Greg KH wrote: > On Wed, Apr 13, 2016 at 02:37:35PM -0700, Matthew Giassa wrote: > > Thank you for the feedback Greg. This is my first attempt to submit a > > kernel patch. > > > > Is there a better approach to this? The only other option at my disposal > > is

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Wed, 2016-04-13 at 14:33 -0700, Greg KH wrote: > But larger issue, no new module parameters for things like this. No one > will use them and they aren't device or bus specific. It's a huge > hammer that isn't nice to use. But this is a valuable debug tool. Regards

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

/in/giassa e-mail: matt...@giassa.net website: www.giassa.net > Original Message > Subject: Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm > From: Greg KH <gre...@linuxfoundation.org> > Date: Wed, April 13, 2016 3:36 pm > To: Matthew Giassa <

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Wed, Apr 13, 2016 at 03:21:09PM -0700, Matthew Giassa wrote: > The devices support LPM and are USB3.0 certified, and they work fine in > Windows using the same Intel 8/9/10 Series USB host controllers, along > with Renesas and Fresco controllers. On Linux the devices either seize > up or slow

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

== Matthew Giassa, MASc, BASc, EIT Security and Embedded Systems Specialist linkedin: https://ca.linkedin.com/in/giassa e-mail: matt...@giassa.net website: www.giassa.net > Original Message ---- > Subject: Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm >

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Wed, Apr 13, 2016 at 02:37:35PM -0700, Matthew Giassa wrote: > Thank you for the feedback Greg. This is my first attempt to submit a > kernel patch. > > Is there a better approach to this? The only other option at my disposal > is to add about 200 products to the quirks.c file, and routinely

RE: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

means of disabling LPM, ideally on a per-device basis. > Original Message > Subject: Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm > From: Greg KH <gre...@linuxfoundation.org> > Date: Wed, April 13, 2016 2:33 pm > To: Matthew Giassa <matt...@giassa.

Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

On Wed, Apr 13, 2016 at 02:25:08PM -0700, Matthew Giassa wrote: > commit 4e8998d462ab06900949a3099706a19177484c09 > Author: Matthew > Date: Wed Apr 13 13:37:21 2016 -0700 Why is this here? > > Adding new kernel parameter that allows users to skip the check > for