RE: [PATCH 3/3] usb: chipidea: use hrtimer for otg fsm timers

2015-02-28 Thread Peter Chen
@@ -579,8 +579,15 @@ int ci_otg_fsm_work(struct ci_hdrc *ci) * a_idle to a_wait_vrise when power up */ if ((ci-fsm.id) || (ci-id_event) || -

RE: [PATCH 3/3] usb: chipidea: use hrtimer for otg fsm timers

2015-02-27 Thread Peter Chen
Why you use unsigned, but not unsigned int or unsigned long? unsigned is equal to unsigned int, currently only 13 timers are defined, so unsigned is okay, for possible future extension, I will change it to be unsigned long Since I see you use unsigned long below, I have this

Re: [PATCH 3/3] usb: chipidea: use hrtimer for otg fsm timers

2015-02-27 Thread Li Jun
On Sat, Feb 28, 2015 at 09:43:30AM +0800, Chen Peter-B29397 wrote: Why you use unsigned, but not unsigned int or unsigned long? unsigned is equal to unsigned int, currently only 13 timers are defined, so unsigned is okay, for possible future extension, I will change it to be

Re: [PATCH 3/3] usb: chipidea: use hrtimer for otg fsm timers

2015-02-26 Thread Li Jun
On Thu, Feb 26, 2015 at 07:25:56PM +0800, Peter Chen wrote: On Mon, Feb 09, 2015 at 02:54:48PM +0800, Li Jun wrote: From: Li Jun b47...@freescale.com Current otg fsm timers are using controller 1ms irq and count it, this patch is to replace it with hrtimer solution, use one hrtimer for

Re: [PATCH 3/3] usb: chipidea: use hrtimer for otg fsm timers

2015-02-26 Thread Peter Chen
On Mon, Feb 09, 2015 at 02:54:48PM +0800, Li Jun wrote: From: Li Jun b47...@freescale.com Current otg fsm timers are using controller 1ms irq and count it, this patch is to replace it with hrtimer solution, use one hrtimer for all otg timers. Signed-off-by: Li Jun jun...@freescale.com ---