Re: new usb LTE modem device

2017-08-09 Thread Dan Williams
On Wed, 2017-08-09 at 11:19 +0700, Lars Melin wrote: > On 8/9/2017 02:33, Bjørn Mork wrote: > > > > The qmi_wwan part looks fine to me. But you > > will need to split it in two patches since the two > > drivers are parts of different subsystems. > > > > The option driver use interface blacklists

AW: AW: new usb LTE modem device

2017-08-09 Thread Giuseppe Lippolis
> sendsetup is to prevent the driver from sending a specific USB control > message for setting up serial parameters, which some devices ignore and > cause the driver to stall. > > reserved is what you're looking for. This one tells option not to bind to the > given USB interfaces. > > So for

Re: new usb LTE modem device

2017-08-08 Thread Lars Melin
On 8/9/2017 02:33, Bjørn Mork wrote: The qmi_wwan part looks fine to me. But you will need to split it in two patches since the two drivers are parts of different subsystems. The option driver use interface blacklists instead of multiple match entries. You should probably follow the same

Re: AW: new usb LTE modem device

2017-08-08 Thread Dan Williams
On Tue, 2017-08-08 at 22:22 +0200, Giuseppe Lippolis wrote: > > The option driver use interface blacklists instead of multiple > > match entries. > > You should probably follow the same style there. But this is up to > > Johan... > > Can I ask what ist he difference between .sendsetup and

AW: new usb LTE modem device

2017-08-08 Thread Giuseppe Lippolis
> The option driver use interface blacklists instead of multiple match entries. > You should probably follow the same style there. But this is up to Johan... Can I ask what ist he difference between .sendsetup and .reserved and how to use the bitmask in drivers/usb/serial/option.c ? Thanks,

Re: new usb LTE modem device

2017-08-08 Thread Bjørn Mork
On August 8, 2017 9:22:29 PM CEST, Giuseppe Lippolis wrote: >> But we already have many Sierra devices with 2 QMI interfaces (the >3rd one >> is documented and verified non-functional for unknown reasons). And >these >> tend to come with multiple OEM device IDs. So a

AW: new usb LTE modem device

2017-08-08 Thread Giuseppe Lippolis
> But we already have many Sierra devices with 2 QMI interfaces (the 3rd one > is documented and verified non-functional for unknown reasons). And these > tend to come with multiple OEM device IDs. So a whitelist method could > reduce the number of matching entries considerably. Feel free to

Re: new usb LTE modem device

2017-08-08 Thread Bjørn Mork
"Giuseppe Lippolis" writes: > Hi all, > I'm working to port OpenWRT/LEDE on a new router with embedded usb LTE > modem. > The modem have 3 qmi_wwan interfaces and 2 option. > > I would like to prepare the patch, but before I would like to know if using > the

new usb LTE modem device

2017-08-07 Thread Giuseppe Lippolis
Hi all, I'm working to port OpenWRT/LEDE on a new router with embedded usb LTE modem. The modem have 3 qmi_wwan interfaces and 2 option. I would like to prepare the patch, but before I would like to know if using the QMI_FIXED_INTF macro is the best way to identify the interface or if there is a