Re: [linux-usb-devel] sleep_on in usb drivers

2001-05-02 Thread Oliver Neukum
On Thursday, 3. May 2001 00:54, Martin Diehl wrote: > On Wed, 2 May 2001, Oliver Neukum wrote: > > as was recently discussed, sleep_on and derivates, which have a little > > race problem are used 21 times in drivers/usb > > and 12 more in drivers/usb/serial ;-) Oh boy. > > The attached patch sh

Re: [linux-usb-devel] sleep_on in usb drivers

2001-05-02 Thread Greg KH
On Thu, May 03, 2001 at 12:54:59AM +0200, Martin Diehl wrote: > On Wed, 2 May 2001, Oliver Neukum wrote: > > > as was recently discussed, sleep_on and derivates, which have a little race > > problem are used 21 times in drivers/usb > > and 12 more in drivers/usb/serial ;-) Yeah, I just realize

[linux-usb-devel] USB Modem

2001-05-02 Thread Peter Robinson
Hi All, I have the following USB Modem, as you can see below it appears to be Comm class but it isn't being claimed by the acm driver. But that doesn't necessarily supprise me as the are other sub classes (I think) of the comm class that aren't necessarily acm. Anyway does the sub=80 and/or Pro

Re: [linux-usb-devel] [PATCH] correct baud rate in mct_u232 usb serial driver

2001-05-02 Thread Greg KH
On Wed, May 02, 2001 at 04:31:34PM +0200, Stelian Pop wrote: > This patch fixes the baud rate in the mct_u232 driver when > used with the Sitecom device. > > I only have the Sitecom device available so I've corrected the > baud rate calculation only for this model. Someone with a > real MCT or

Re: [linux-usb-devel] Re: [experimental PATCH] uhci/queued bulkimprovement?

2001-05-02 Thread Martin Diehl
On Wed, 2 May 2001, Johannes Erdfelt wrote: > Does this patch fix it? I haven't had the chance to test it myself, but it > compiles atleast. Unfortunately not better: - "Element != First TD" warning still there - still stops after some time on non-idle box (same signature) - almost instantaneous

Re: [linux-usb-devel] [experimental PATCH] uhci/queued bulkimprovement?

2001-05-02 Thread David Brownell
> @@ -181,7 +181,9 @@ > dma_addr_t dma_handle; > struct uhci_td *td; > > - td = pci_pool_alloc(uhci->td_pool, GFP_DMA | GFP_ATOMIC, &dma_handle); > + /* pci_pool uses pci_alloc_consistent() which adds GFP_DMA if required */ > + > + td = pci_pool_alloc(uhci->td_pool, GFP_ATOMIC, &dma_handle);

[linux-usb-devel] Re: [experimental PATCH] uhci/queued bulk improvement?

2001-05-02 Thread Martin Diehl
On Wed, 2 May 2001, Johannes Erdfelt wrote: > I suggest you go and read the UHCI docs and understand how the schedule > is processed. Ok, seems I should check that. My reading of UHCI-1.1 docs, p32 was, the HC would never advance to the next QH on NAK (or other error)... > This fix will fail fo

[linux-usb-devel] Re: [experimental PATCH] uhci/queued bulk improvement?

2001-05-02 Thread Johannes Erdfelt
On Thu, May 03, 2001, Martin Diehl <[EMAIL PROTECTED]> wrote: > turns out much interrupt work (like ping -f localhost) was a pretty > reliable trigger for the problem I've seen (uhci failes do IOC after > some queued bulk processing). Does this patch fix it? I haven't had the chance to test it my

[linux-usb-devel] [PATCH] Keyspan_PDA firmware patch

2001-05-02 Thread Greg KH
Hi, Here's a patch that clears up some of the licensing and copyright issues around the keyspan_pda_fw.h file (go to the debian-legal mailing list if anyone's interested in the Keyspan firmware discussion.) It's against 2.4.4 but applies cleanly to 2.4.5-pre1. thanks, greg k-h diff -Nru a/dr

[linux-usb-devel] [PATCH] USB Keyspan driver patch

2001-05-02 Thread Greg KH
Here's a patch from Hugh Blemings that fixes some character size logic in the keyspan.c driver. It is against 2.4.4 but applies cleanly to 2.4.5-pre1. thanks, greg k-h diff -Nru a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c --- a/drivers/usb/serial/keyspan.c Wed May 2 16

[linux-usb-devel] Re: [experimental PATCH] uhci/queued bulk improvement?

2001-05-02 Thread Johannes Erdfelt
On Thu, May 03, 2001, Martin Diehl <[EMAIL PROTECTED]> wrote: > turns out much interrupt work (like ping -f localhost) was a pretty > reliable trigger for the problem I've seen (uhci failes do IOC after > some queued bulk processing). The real problem is that transfers get stalled because of a ra

Re: [linux-usb-devel] sleep_on in usb drivers

2001-05-02 Thread Martin Diehl
On Wed, 2 May 2001, Oliver Neukum wrote: > as was recently discussed, sleep_on and derivates, which have a little race > problem are used 21 times in drivers/usb and 12 more in drivers/usb/serial ;-) > The attached patch should fix one such place in printer. Don't want to be pedantic, but the

[linux-usb-devel] [experimental PATCH] uhci/queued bulk improvement?

2001-05-02 Thread Martin Diehl
Hi, turns out much interrupt work (like ping -f localhost) was a pretty reliable trigger for the problem I've seen (uhci failes do IOC after some queued bulk processing). Hence all kinds of races and interrupt pileup was what I was looking for. One candidate is the HC which updates various fiel

[linux-usb-devel] (no subject)

2001-05-02 Thread Antonis Georgiou
I install Mandrake 8 and during the installation my USB ( InteliExplorer Mous) was working ok. After i finnished it and the pc rebooted when linux started in KDE environment the mouse wasend working. I installed it with 2.4 kernel Is there any way to make it work without going back to the olde

[linux-usb-devel] Mandrake 8 and USB Mouse problems

2001-05-02 Thread Antonis Georgiou
I install Mandrake 8 and during the installation my USB mouse ( InteliExplorer Mouse) was working ok. After i finnished it and the pc rebooted when linux started in KDE environment the mouse wasend working. I installed it with 2.4 kernel Is there any way to make it work without going back to t

[linux-usb-devel] sleep_on in usb drivers

2001-05-02 Thread Oliver Neukum
Hi list, as was recently discussed, sleep_on and derivates, which have a little race problem are used 21 times in drivers/usb The attached patch should fix one such place in printer. It even compiles. 20 more to go. People let's kill them all. Regards Oliver --- driver

[linux-usb-devel] [PATCH] correct baud rate in mct_u232 usb serial driver

2001-05-02 Thread Stelian Pop
This patch fixes the baud rate in the mct_u232 driver when used with the Sitecom device. I only have the Sitecom device available so I've corrected the baud rate calculation only for this model. Someone with a real MCT or DLINK device should verify the original baud rate calculation, because I

Re: [linux-usb-devel] PATCH -- hub.c

2001-05-02 Thread Brad Hards
Pete Zaitcev wrote: > > > From: David Brownell <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED] > > Date: Tue, 01 May 2001 15:44:06 -0700 > > > Here's a small patch to make the hub driver understand > > that devices can disconnect during enumeration. [...] > > Looks ok at first glance. Let me appl

Re: [linux-usb-devel] [PATCH] hid gamepad Saitek X6-34U

2001-05-02 Thread Magnus Damm
> > Why are you doing it that way? How about: > > #define USB_VENDOR_ID_MEGAWORLD 0x07b5 > #define USB_DEVICE_ID_MEGAWORLD_USB_GAMEPAD 0x9902 > > and then modify the device table to: > > static struct usb_device_id hid_usb_ids [] = { > { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS, >

Re: [linux-usb-devel] [PATCH] hid gamepad Saitek X6-34U

2001-05-02 Thread Brad Hards
Magnus Damm wrote: > > Hi, > > This patch makes a "Saitek X6-34U" gamepad useful with Linux. > It seems that the device reports itself with device class == 0. > Forcing hid.c to accept it fixes the problem. Why are you doing it that way? How about: #define USB_VENDOR_ID_MEGAWORLD 0x07b5 #def

[linux-usb-devel] [PATCH] hid gamepad Saitek X6-34U

2001-05-02 Thread Magnus Damm
Hi, This patch makes a "Saitek X6-34U" gamepad useful with Linux. It seems that the device reports itself with device class == 0. Forcing hid.c to accept it fixes the problem. The patch is against linux-2.2.19 vendor URL: http://www.mega-world.com/mx-634.htm logs: May 1 19:42:49 maxine kern