[linux-usb-devel] Re: PATCH 2.5.8-pre2 usbnet-0406

2002-04-06 Thread Greg KH
On Sat, Apr 06, 2002 at 03:41:16PM -0800, David Brownell wrote: > Hi Greg, > > Can you merge this into Linus' tree? It: Applied, thanks. greg k-h ___ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/l

Re: [linux-usb-devel] cardbus and ehci

2002-04-06 Thread David Brownell
> I was wondering if anyone has had any luck getting a cardbus usb host > controller to work. When I insert the ehci-hcd module, it detects my > card but complains because it doesn't have an irq (I'm assuming that it > needs a cardbus driver to assign the irq). Some kernels and laptops seem to

[linux-usb-devel] cardbus and ehci

2002-04-06 Thread Raj Laud
I was wondering if anyone has had any luck getting a cardbus usb host controller to work. When I insert the ehci-hcd module, it detects my card but complains because it doesn't have an irq (I'm assuming that it needs a cardbus driver to assign the irq). I wrote a simple cardbus driver to assign

[linux-usb-devel] PATCH 2.5.8-pre2 usbnet-0406

2002-04-06 Thread David Brownell
Hi Greg, Can you merge this into Linus' tree? It: - adds ethtool support (based on code from Brad Hards) - makes diagnostic level configurable (ethtool, module param) - fixes a minor mem_flags goof (thanks Oliver!) - device identifers now use devpath (stable ID) not devnum I'll

Re: [linux-usb-devel] skbuff voodo (was: Re: [patch] rtl8150)

2002-04-06 Thread Alan Cox
> ... though that's not the real voodoo I was referring to, > that's just a (longstanding?) documentation goof. Yep. One to submit a patch for ___ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinf

[linux-usb-devel] Support for Creative Webcam Go Plus

2002-04-06 Thread Diego Calleja
I only wanted to ask if there's any support for Creative Webcam Go Plus. ___ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Re: [linux-usb-devel] skbuff voodo (was: Re: [patch] rtl8150)

2002-04-06 Thread David Brownell
> > You mean dev_alloc_skb() I think -- documented as "for sending", > > (which might be a bug), and reserving an unspecified number of > > bytes (which is 16 today). > > Its for sending data up to the network stack Through the netif_rx() routine ... "receive" processing, as it's called consiste

Re: [linux-usb-devel] skbuff voodo (was: Re: [patch] rtl8150)

2002-04-06 Thread Alan Cox
> You mean dev_alloc_skb() I think -- documented as "for sending", > (which might be a bug), and reserving an unspecified number of > bytes (which is 16 today). Its for sending data up to the network stack Alan ___ [EMAIL PROTECTED] To unsubscribe, us

[linux-usb-devel] double free on error in rtl8150

2002-04-06 Thread Oliver Neukum
Hi, in probe() you'll do a double free, if allocating only some urbs fails. alloc_all_urbs() must not only free allocated urbs in the error case, but set the pointers of the device descriptor to NULL. Regards Oliver ___ [EMAIL

Re: [linux-usb-devel] skbuff voodo (was: Re: [patch] rtl8150)

2002-04-06 Thread David Brownell
> alloc_skb will always get an skb->data object that is 4 byte aligned. You mean dev_alloc_skb() I think -- documented as "for sending", (which might be a bug), and reserving an unspecified number of bytes (which is 16 today). Regular alloc_skb() doesn't reserve any bytes, but it does work to g

[linux-usb-devel] rtl8150 as found in 2.4.19-pre6

2002-04-06 Thread Oliver Neukum
Hi, in static void ctrl_callback(struct urb *urb) you are using clean_bit on an usigned int. On some architectures this will bomb. You need to define flags as unsigned long. in static int write_mii_word(rtl8150_t *dev, u8 phy, __u8 indx, u16 reg) you are using HZ which is architecture dependend.

Re: [linux-usb-devel] Re: [patch] rtl8150

2002-04-06 Thread Alan Cox
> Isn't it better if the alignment is done by default by alloc_skb and > let the driver writer to take care the future skb_reserve() will be > 4 (or 8 or whatever) bytes alignedex. Not all hardware can DMA to arbitary boundaries. In those cases it needs to be aligned 4 byte (eg many older pci net

Re: [linux-usb-devel] Re: [patch] rtl8150

2002-04-06 Thread Alan Cox
> By the way, I have looked at the code for alloc_skb in > linux-2.5.8-pre1/net/core/skbuff.c and have no idea how this can > help alignment. Also, to my knowledge, all USB host controllers > do DMA (I mean PCI bus mastering, not using the motherboard's DMA > controllers). The driver seems

Re: [linux-usb-devel] Re: [patch] rtl8150

2002-04-06 Thread Alan Cox
> I wonder if anyone has actually benchmarked this. Yes. And you forgot to add in the IP/TCP 4 byte long options as well. > given that it also takes a few cycles for skb_reserve to increment > to pointers in struct sk_buff. But, OK, I guess it makes sense if > actually does save time on a

Re: [linux-usb-devel] Re: [PATCH INCLUDED] Samsung Uproar / MP3player support

2002-04-06 Thread Oliver Neukum
Am Samstag, 6. April 2002 10:49 schrieb Jacek Pliszka: > On Sat, 6 Apr 2002, Oliver Neukum wrote: > > You can set them from a hotplug script (or devfs - but it's rude to > > require devfs). > > I got confused. > > what is the difference between usbfs, devfs and usbdevfs ? > There's no difference

Re: [linux-usb-devel] Re: [PATCH INCLUDED] Samsung Uproar / MP3player support

2002-04-06 Thread Jacek Pliszka
On Sat, 6 Apr 2002, Oliver Neukum wrote: > You can set them from a hotplug script (or devfs - but it's rude to require > devfs). I got confused. what is the difference between usbfs, devfs and usbdevfs ? I know it is kind of stupid to write programs which use it and do not know what is it but,

Re: [linux-usb-devel] Re: [PATCH INCLUDED] Samsung Uproar / MP3 player support

2002-04-06 Thread Oliver Neukum
Am Samstag, 6. April 2002 04:55 schrieb Patrick J. Kobly: > On Wed, Apr 03, 2002 at 06:55:19PM -0800, Greg KH wrote: > > On Wed, Apr 03, 2002 at 07:21:21PM -0700, Patrick J. Kobly wrote: > > > I'm sending this out now, so that I can get comments, recommendations > > > and device ID's for Samsung M