hi,
i have a ohci usb controller mq1132 on sa1110, i am writing the dma
handle to the hc->reg->hcca after doing a pci_alloc_consistent for hcca
system resident memory structure inspite of that the framenumber in the
hcca doesn't get updated (why is hc not writing to it?) i don't have
sa, and
Hi,
cdc-ether has the same problem as cdc-acm.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===
[E
Hi,
the patch turns it into GFP_ATOMIC.
Question:
if (!urb->status & !acm->throttle) {
...
}
if (acm->throttle) {
...
}
What protects acm->throttle? Can there be data loss?
Regards
Oliver
You can import this changeset into BK by pipin
On Mon, 16 Dec 2002 02:17:33 +0200
Kari Hameenaho <[EMAIL PROTECTED]> wrote:
> On Mon, 16 Dec 2002 00:29:24 +0100
> "Oliver Neukum" <[EMAIL PROTECTED]> wrote:
>
> > The only issue that I see is that you made common code for doing so
> > but failed to put proper locking into it, which means refere
static void usb_write_callback(struct urb *urb, struct pt_regs *regs)
{
struct midi_out_endpoint *ep = (struct midi_out_endpoint *)urb->context;
if ( waitqueue_active( &ep->wait ) )
wake_up_interruptible( &ep->wait );
}
Always wake up unconditionally.
> Here is the most minimal patch with that approach.
Looking very good.
Regards
Oliver
---
This SF.NET email is sponsored by: Order your Holiday Geek Presents Now!
Green Lasers, Hip Geek T-Shirts, Remote Control Tanks
On Wed, 18 Dec 2002 11:57:48 +0100
Oliver Neukum <[EMAIL PROTECTED]> wrote:
> Am Mittwoch, 18. Dezember 2002 01:46 schrieb Kari Hameenaho:
> > On Wed, 18 Dec 2002 01:18:19 +0100
> >
> > "Oliver Neukum" <[EMAIL PROTECTED]> wrote:
> > > > So here cleanup will use NULL pointer for sure, it set set to
Hi,
this removes the spinlocks in close, so that
the synchronous unlinking is safe.
I think I got the obvious stuff now. Could somebody with such
a device please test it?
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive
Hi,
I am not sure what this code was supposed to do, but it can stop khubd
indefinitely. It has to go.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
Hi folks,
what's a driver supposed to do if it detects a stall?
You can't call usb_clear_halt().
Would anybody object to a helper that solves the
issue by means of a work queue?
Regards
Oliver
---
This sf.net email is
Hi,
speedtouch povides an ioctl handler through usbfs.
It must not be reentered. A semaphore ensures that.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
=
Hi,
usb_clear_halt cannot be used from a completion handler because it sleeps
As that code path would have crashed the driver, it's obviously not needed
and can be removed.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receiv
Here we go again.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===
[EMAIL PROTECTED], 2002-12-18 14:
Oliver Neukum wrote:
Am Mittwoch, 18. Dezember 2002 06:19 schrieb Duncan SANDS:
Hi Oliver, I think the driver should really be converted to using a
workqueue instead.
If it were a new driver of course.
But the current approach works in principle. As I am not the driver's
maintainer, I jus
Hi,
irqsave spinlocks in an interrupt handler are superfluous.
Simple spinlocks are sufficient and quicker. As this is in
interrupt context, every cycle counts.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to r
Am Mittwoch, 18. Dezember 2002 01:46 schrieb Kari Hameenaho:
> On Wed, 18 Dec 2002 01:18:19 +0100
>
> "Oliver Neukum" <[EMAIL PROTECTED]> wrote:
> > > So here cleanup will use NULL pointer for sure, it set set to NULL in
> > > other path and tested to be NULL in the other.
> >
> > Both take usblp->
Am Mittwoch, 18. Dezember 2002 06:19 schrieb Duncan SANDS:
> > Hi,
> >
> > this makes sure that the kernel thread is dead and gone on module unload.
> >
> > Regards
> > Oliver
>
> Hi Oliver, I think the driver should really be converted to using a
> workqueue instead.
If it were a
Am Mittwoch, 18. Dezember 2002 01:46 schrieb Pete Zaitcev:
> > From: Oliver Neukum <[EMAIL PROTECTED]>
> > Date: Wed, 18 Dec 2002 01:20:56 +0100
> >
> > unknown ioctls return -ENOTTY and nothing else.
> > - return -ENOIOCTLCMD;
> > + return -ENOTTY;
>
> Does it pop to userland i
ChangeSet 1.894, 2002/12/18 00:18:53-08:00, [EMAIL PROTECTED]
[PATCH] ehci, more small fixes
- some access to urb->hcpriv and urb->status needed to be
locked using urb->lock
- paranoia: don't depend on two values being in lock-step.
diff -Nru a/drivers/usb/host/ehci-q.c b/drivers/usb/host/eh
ChangeSet 1.893, 2002/12/18 00:12:02-08:00, [EMAIL PROTECTED]
[PATCH] USB: warn users that they should not be using the usbdevfs name.
diff -Nru a/drivers/usb/core/inode.c b/drivers/usb/core/inode.c
--- a/drivers/usb/core/inode.c Wed Dec 18 00:34:05 2002
+++ b/drivers/usb/core/inode.c Wed Dec
ChangeSet 1.883.3.7, 2002/12/16 10:49:56-08:00, [EMAIL PROTECTED]
[PATCH] usb-storage: fixup interpret_urb_result()
This patch fixes interpret_urb_result in two major ways:
(1) Uses a switch() instead of nested if() statements
(2) Handle -EREMOTEIO to indicate a short scatter-gather transfer
di
ChangeSet 1.883.3.15, 2002/12/17 22:22:16-08:00, [EMAIL PROTECTED]
[PATCH] hub driver uses dev_info(), less log clutter
This patch converts most common hub diagnostics to use the
device model diagnostic macros ... not all, someone should
reduce the number of err() strings for "bogus hub" cases,
a
ChangeSet 1.883.3.16, 2002/12/17 22:38:44-08:00, [EMAIL PROTECTED]
[PATCH] USB: whiteheat: fix some gcc 3.2 warning messages
diff -Nru a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
--- a/drivers/usb/serial/whiteheat.cWed Dec 18 00:34:10 2002
+++ b/drivers/usb/serial/white
ChangeSet 1.883.3.12, 2002/12/17 21:51:12-08:00, [EMAIL PROTECTED]
[PATCH] USB: speedtouch: eliminate sleep_on
diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
--- a/drivers/usb/misc/speedtouch.c Wed Dec 18 00:34:31 2002
+++ b/drivers/usb/misc/speedtouch.c Wed De
ChangeSet 1.883.3.9, 2002/12/16 18:13:47-08:00, [EMAIL PROTECTED]
[PATCH] USB: usbserial: Add a short_name field to work better with sysfs.
This cleans up the bus/usb-serial/drivers/ directory
diff -Nru a/drivers/usb/serial/belkin_sa.c b/drivers/usb/serial/belkin_sa.c
--- a/drivers/usb/serial/b
ChangeSet 1.883.3.14, 2002/12/17 21:57:17-08:00, [EMAIL PROTECTED]
[PATCH] USB: proper error return for usblcd
unknown ioctls return -ENOTTY and nothing else.
diff -Nru a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c
--- a/drivers/usb/misc/usblcd.c Wed Dec 18 00:34:21 2002
+++ b/drivers
ChangeSet 1.883.3.5, 2002/12/16 10:35:48-08:00, [EMAIL PROTECTED]
[PATCH] 2.5.51 More typedef removal from usbvideo
This patch against 2.5.51 removes the remaining typedefs from usbvideo
typedef enum { .. } ScanState_t -> enum ScanState
typedef enum { .. } ParseState_t -> enum ParseState
typedef
ChangeSet 1.883.3.13, 2002/12/17 21:51:57-08:00, [EMAIL PROTECTED]
[PATCH] USB: fix an unlinking race in speedtouch driver
checking for -EINPROGRESS is wrong.
diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
--- a/drivers/usb/misc/speedtouch.c Wed Dec 18 00:34:26 20
ChangeSet 1.883.3.10, 2002/12/17 20:40:12-08:00, [EMAIL PROTECTED]
[PATCH] USB: usb-storage bugfix
Don't try to dereference the interrupt endpoint if it doesn't exist.
diff -Nru a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
--- a/drivers/usb/storage/usb.c Wed Dec 18 00:34:41 2002
+++
ChangeSet 1.883.3.11, 2002/12/17 21:49:24-08:00, [EMAIL PROTECTED]
[PATCH] USB: clean kernel thread exit for speedtouch
this makes sure that the kernel thread is dead and gone on module unload.
- use a completion to wait for the kernel thread's death
diff -Nru a/drivers/usb/misc/speedtouch.c
ChangeSet 1.883.3.1, 2002/12/16 10:31:05-08:00, [EMAIL PROTECTED]
[PATCH] ehci-hcd (1/2): portability (2.4), tasklet,
This should be innocuous; I expect most folk won't notice anything
better (or worse) from this patch unless they're using Intel EHCI.
removing tasklet
- parts of davem's pa
ChangeSet 1.883.3.2, 2002/12/16 10:31:24-08:00, [EMAIL PROTECTED]
[PATCH] ehci-hcd (2/2): rest of tasklet remove
This is the rest of the work to remove the tasklet: the non-syntax
portions which affect work scheduling. It's not quite davem's version;
it's got locking updates, which among other t
ChangeSet 1.883.3.8, 2002/12/16 16:35:58-08:00, [EMAIL PROTECTED]
[PATCH] USB: speedtouch driver memory allocation deadlock fix
diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
--- a/drivers/usb/misc/speedtouch.c Wed Dec 18 00:34:51 2002
+++ b/drivers/usb/misc/speedt
ChangeSet 1.883.3.6, 2002/12/16 10:45:26-08:00, [EMAIL PROTECTED]
[PATCH] USB: PWC 8.10 for 2.5.51
Well, two patches in one... These patches will bring the PWC (Philips
Webcam) driver in both 2.4.20 and 2.5.51 up to version 8.10. Functionally,
the two branches are the same (about 70% of the code
ChangeSet 1.883.3.3, 2002/12/16 10:31:41-08:00, [EMAIL PROTECTED]
[PATCH] usbnet: zaurus, oops, etc
This patch:
- Removes Pavel's Zaurus-private crc32 code; the base patch
was from Pavel.
- Addresses two issues Toby Milne reported against the Zaurus:
(a) if skbs had extra framing added (
ChangeSet 1.883.3.4, 2002/12/16 10:31:59-08:00, [EMAIL PROTECTED]
[PATCH] ehci misc patches
small fixes flushed by the hunt for bigger game:
- terminate td lists with dummy, not list end marker
- use alt_next only for real short control reads
- un-halt async qhs before scheduling
- deletes unuse
Please pull from: bk://linuxusb.bkbits.net/linus-2.5
thanks,
greg k-h
drivers/usb/core/hcd.c |5
drivers/usb/core/hub.c | 61 +++
drivers/usb/core/inode.c |5
drivers/usb/host/ehci-dbg.c| 37 ++-
drivers/usb/host/ehci-hcd.c
37 matches
Mail list logo
