[linux-usb-devel] question on storage_probe()

2003-03-29 Thread Oliver Neukum
Hi, is the following code from storage_probe() necessary: #ifdef CONFIG_USB_STORAGE_SDDR09 if (protocol == US_PR_EUSB_SDDR09 || protocol == US_PR_DPCM_USB) { /* set the configuration -- STALL is an acceptable response here */ result = usb_set_configuration(

[linux-usb-devel] removing unnecessary calls to usb_set_configuration

2003-03-29 Thread Oliver Neukum
Hi, these calls either are unnecessary or harmful. Regards Oliver You can import this changeset into BK by piping this whole message to: '| bk receive [path to repository]' or apply the patch as usual. ===

[linux-usb-devel] Question on setting configuration in audio

2003-03-29 Thread Oliver Neukum
Hi Alan, Thomas, could you tell me why this piece of code is in audio_probe() ? if (usb_set_configuration(dev, config->desc.bConfigurationValue) < 0) { printk(KERN_ERR "usbaudio: set_configuration failed (ConfigValue 0x%x)\n", config->desc.bConfigurationValue);

[linux-usb-devel] probing in cdc-acm

2003-03-29 Thread Oliver Neukum
Hi, looking into cdc-acm it seems to me that the driver simply iterates over all available configurations and switches to them. Isn't that obviously buggy, as their may be already other drivers bound to other interfaces of the device ? Regards Oliver ---

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.4.21-pre6

2003-03-29 Thread John Goerzen
Greg KH <[EMAIL PROTECTED]> writes: > Here are some USB updates and bugfixes for 2.4.21-pre6. These are all > changes and bugfixes that have been in 2.5 for a while. Lots of good > memory leak fixes are in here. Greg, Thanks for these patches. I noticed a lot of USB storage fixes, and so I ha

[linux-usb-devel] Re: locking reset/probe

2003-03-29 Thread Oliver Neukum
> Well I asked Pat, and he said it was ok to use. > > I'd prefer that, as we would not have to grab yet-another-lock in the > probe sequence. Just document it well :) Here it is. This time locking and doing the operation is seperated. Some firmware loaders need to do a reset during probe.

[linux-usb-devel] Freecom USB Drive

2003-03-29 Thread Michael Vetter
Hello, got a Problem with my USB Harddisk. It is an Freecom USB 2.0 Chassis wiht a Maxtor Harddisk in. First, my Suse 8.1 at my primary Computer doesn't found anything, but then, when I installed the 2.4.20 Matel KErnel optimized for AMD CPUs it got to run. Now I want to run it at my Laptop

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.66

2003-03-29 Thread John Goerzen
Linus Torvalds <[EMAIL PROTECTED]> writes: > In other words: _despite_ your luddite ways you actually have more > information available to you than you would have had without BK. Not everyone that doesn't use BitKeeper is a luddite. For instance, Ben Collins has been explicitly prevented from us