Re: [linux-usb-devel] [PATCH] Fix gadget serial response on USB_CDC_REQ_SET_LINE_CODING

2007-03-19 Thread Li Yang-r58472
-Original Message- From: David Brownell [mailto:[EMAIL PROTECTED] Sent: Monday, March 19, 2007 3:03 PM To: Li Yang-r58472 Cc: linux-usb-devel@lists.sourceforge.net; [EMAIL PROTECTED] Subject: Re: [linux-usb-devel] [PATCH] Fix gadget serial response on USB_CDC_REQ_SET_LINE_CODING

Re: [linux-usb-devel] 2.6.21-rc4: pl2303 disconnect oops

2007-03-19 Thread Adrian Bunk
On Mon, Mar 19, 2007 at 08:41:33AM +0200, Meelis Roos wrote: I was using my laptop as the serial console of another computer with pl2303 usb-to-serial cable. minicom was running but I do not remember whether the other end was connected or was already disconnected. Anyway, I unplugged the

[linux-usb-devel] Writing HID driver for a USB phone handset IPEVO VP170 (0x1778:0x0403)

2007-03-19 Thread Robin H. Johnson
Hi, USB drivers in general are something a little new to me, but I picked up a USB phone handset a little while ago, and while the USB-Audio portion of it works great, none of the buttons actually do anything, and the LED doesn't light up yet. Here's the manuf's page on the phone:

[linux-usb-devel] drivers/usb/misc/iowarrior.c: NULL dereference

2007-03-19 Thread Adrian Bunk
The Coverity checker spotted the following NULL dereference: -- snip -- ... static ssize_t iowarrior_write(struct file *file, const char __user *user_buffer, size_t count, loff_t *ppos) { ... if (!int_out_urb) {

[linux-usb-devel] [2.6 patch] drivers/usb/input/gtco.c: fix a use-before-check

2007-03-19 Thread Adrian Bunk
NULL checks should be before the first dereference. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.21-rc3-mm2/drivers/usb/input/gtco.c.old 2007-03-19 09:29:44.0 +0100 +++ linux-2.6.21-rc3-mm2/drivers/usb/input/gtco.c 2007-03-19

Re: [linux-usb-devel] drivers/usb/misc/iowarrior.c: NULL dereference

2007-03-19 Thread Oliver Neukum
Am Montag, 19. März 2007 10:25 schrieb Adrian Bunk: static ssize_t iowarrior_write(struct file *file, const char __user *user_buffer, size_t count, loff_t *ppos) { ... if (!int_out_urb) {

[linux-usb-devel] こんにちは(^^ ♪

2007-03-19 Thread 美樹
はじめまして美樹です。 掲示板で見て趣味合うかなって思ってメールしちゃいました。 イキナリでゴメンなさいm(__)m こういう感じで知り合えるのに憧れてて初挑戦しちゃいました。 お返事もらえたら簡単な自己紹介しますネ(^_-)-☆ もしそんな気なかったらそう言ってもらえれば諦めますので。 もちろん仲良くなれた方が嬉しいけど。 お返事気長に待ってま〜す(^_^)/~ http://www.itfeelit.com/m-box - Take

[linux-usb-devel] Fw: [Bugme-new] [Bug 8231] New: USB_SUSPEND couse usb scanner to freeze on scan.

2007-03-19 Thread Andrew Morton
Begin forwarded message: Date: Mon, 19 Mar 2007 00:31:13 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 8231] New: USB_SUSPEND couse usb scanner to freeze on scan. http://bugzilla.kernel.org/show_bug.cgi?id=8231 Summary: USB_SUSPEND couse usb

Re: [linux-usb-devel] Fw: [Bugme-new] [Bug 8231] New: USB_SUSPEND couse usb scanner to freeze on scan.

2007-03-19 Thread Oliver Neukum
Steps to reproduce: 1. Use USB_SUSPEND enabled kernel, like default kernel in Ubuntu 7.04 or kompile vanila kernel. 2. Attach scanner and execute ~# scanimage -d snapscan test.pnm This doesn't tell us why the scanner froze. Please recompile your kernel with CONFIG_USB_DEBUG and provide the

[linux-usb-devel] [PATCH]Re: drivers/usb/misc/iowarrior.c: NULL dereference

2007-03-19 Thread Oliver Neukum
Am Montag, 19. März 2007 10:25 schrieb Adrian Bunk: The Coverity checker spotted the following NULL dereference: And this fixes an oops upon allocation failures. Regards Oliver Signed-off-by: Oliver Neukum [EMAIL PROTECTED] - ---

[linux-usb-devel] [PATCH]endianness in mos7720

2007-03-19 Thread Oliver Neukum
Hi, there's code unclean w.r.t. endianness in the mos7720 driver. Regards Oliver Signed-off-by: Oliver Neukum [EMAIL PROTECTED] -- --- a/drivers/usb/serial/mos7720.c 2007-03-13 09:33:49.0 +0100 +++ b/drivers/usb/serial/mos7720.c 2007-03-14

Re: [linux-usb-devel] Writing HID driver for a USB phone handset IPEVO VP170 (0x1778:0x0403)

2007-03-19 Thread Jiri Kosina
On Mon, 19 Mar 2007, Robin H. Johnson wrote: Here is the interface and endpoint for the controls. I find it odd that the HID Report Descriptor is not present. I suspect it will contain the LED control as well. Could you please compile some recent kernel with HID debugging support (Device

[linux-usb-devel] [patch 0/8] Composite Devices Support

2007-03-19 Thread Felipe Balbi
The following patch series add support for composite devices into the USB Gadget Framework. * patch-composite-device-db.diff * patch-composite-device-kconfig.diff * patch-composite-device-db02.diff * patch-composite-device-functions.diff *

[linux-usb-devel] [patch 3/8] PATCH Modifications on David Brownells patch.

2007-03-19 Thread Felipe Balbi
Makes the code a little bit better and adds some functions to the Composite Framework. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Ragner Magalhaes [EMAIL PROTECTED] --- Index: linux-omap-2.6-ragner/drivers/usb/gadget/composite.c

[linux-usb-devel] [patch 1/8] Add linux/usb/composite.h interfaces for composite gadget drivers:

2007-03-19 Thread Felipe Balbi
- struct usb_function ... grouping one or more interfaces into a function that will often be managed as one unit; - struct usb_composite_driver ... grouping one or more such functions into a gadget driver. - struct usb_composite_dev ... what's managed by the

[linux-usb-devel] [patch 2/8] Kconfig Modifications for USB Composite Devices Support

2007-03-19 Thread Felipe Balbi
Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Ragner Magalhaes [EMAIL PROTECTED] --- Index: linux-2.6/drivers/usb/gadget/Kconfig === --- linux-2.6.orig/drivers/usb/gadget/Kconfig +++

[linux-usb-devel] [patch 4/8] The Composite Gadget itself.

2007-03-19 Thread Felipe Balbi
This gadget is built using a generic approach. To use this composite gadget, just load the gadget modules and plug-in the USB Cable. The g_midi.c file was not modified yet. Will come in a separate patch. Signed-off-by: Felipe Balbi [EMAIL PROTECTED]

[linux-usb-devel] [patch 5/8] Serial Gadget Suppor

2007-03-19 Thread Felipe Balbi
This patch adds some ifdefs to make the serial gadget work as a usb_function module. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Ragner Magalhes [EMAIL PROTECTED] --- Index: linux-2.6/drivers/usb/gadget/serial.c

[linux-usb-devel] [patch 6/8] Ether Gadget Support

2007-03-19 Thread Felipe Balbi
This patch adds some ifdefs to make the ether gadget work as a usb_function module. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Ragner Magalhes [EMAIL PROTECTED] --- Index: linux-2.6/drivers/usb/gadget/ether.c

[linux-usb-devel] [patch 8/8] Omap_udc Modification

2007-03-19 Thread Felipe Balbi
This patch adds some endpoints into omap_udc fifo_mode for the three already modified gadget to work together Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Ragner Magalhes [EMAIL PROTECTED] --- Index: linux-2.6/drivers/usb/gadget/omap_udc.c

Re: [linux-usb-devel] [PATCH] usb/serial/whiteheat: Convert to generic boolean

2007-03-19 Thread Stuart MacDonald
From: Richard Knutsson [mailto:[EMAIL PROTECTED] Okay by me. Thanks Richard. Signed-off-by: Stuart MacDonald [EMAIL PROTECTED] ..Stu Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with allyes, allmod allno on i386 diff --git a/drivers/usb/serial/whiteheat.c

[linux-usb-devel] [6/6] 2.6.21-rc4: known regressions

2007-03-19 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly

Re: [linux-usb-devel] [patch 7/8] File Storage Gadget Support

2007-03-19 Thread Alan Stern
On Mon, 19 Mar 2007, Felipe Balbi wrote: This patch adds some ifdefs to make the file-storage gadget work as a usb_function module. This is really ugly. You have added _lots_ of changes like this: @@ -1127,3 +1150,8 @@ static void fsg_disconnect(struct usb_ga { +#ifdef

[linux-usb-devel] autosuspend default

2007-03-19 Thread Oliver Neukum
Hi, I got another bug report about a scanner disconnecting when suspended. Could we introduce a setting for deciding whether unbound devices should by default be subject to autosuspend? Regards Oliver

Re: [linux-usb-devel] remote-wakeup/sus/res

2007-03-19 Thread Alan Stern
On Mon, 19 Mar 2007, Pandita, Vikram wrote: Hi  In my platform the CONFIG_PM is not enabled yet as we are in initial stages of development. Are the features of suspend/resume/remote-wakeup dependent on PM? Yes. In this situation : 1) How can I test the REMOTE-WAKEUP for my device? 2)

Re: [linux-usb-devel] autosuspend default

2007-03-19 Thread Alan Stern
On Mon, 19 Mar 2007, Oliver Neukum wrote: Hi, I got another bug report about a scanner disconnecting when suspended. Could we introduce a setting for deciding whether unbound devices should by default be subject to autosuspend? That's what the new quirks are for. Besides, what's wrong

Re: [linux-usb-devel] autosuspend default

2007-03-19 Thread Oliver Neukum
Am Montag, 19. März 2007 17:21 schrieb Alan Stern: On Mon, 19 Mar 2007, Oliver Neukum wrote: Hi, I got another bug report about a scanner disconnecting when suspended. Could we introduce a setting for deciding whether unbound devices should by default be subject to autosuspend?

Re: [linux-usb-devel] autosuspend default

2007-03-19 Thread Alan Stern
On Mon, 19 Mar 2007, Oliver Neukum wrote: Am Montag, 19. März 2007 17:21 schrieb Alan Stern: On Mon, 19 Mar 2007, Oliver Neukum wrote: Hi, I got another bug report about a scanner disconnecting when suspended. Could we introduce a setting for deciding whether unbound devices

Re: [linux-usb-devel] [2/6] 2.6.21-rc2: known regressions

2007-03-19 Thread Ingo Molnar
* Pavel Machek [EMAIL PROTECTED] wrote: Some day we may have modesetting support in the kernel for some graphics hw, right now it's pretty damn spotty. Yep, that's the way to go. hey, i wildly supported this approach ever since 1996, when GGI came up :-/ Ingo

Re: [linux-usb-devel] [linux-pm] [2/6] 2.6.21-rc2: known regressions

2007-03-19 Thread Jim Gettys
On Sun, 2007-03-18 at 17:07 +0100, Ingo Molnar wrote: * Pavel Machek [EMAIL PROTECTED] wrote: Some day we may have modesetting support in the kernel for some graphics hw, right now it's pretty damn spotty. Yep, that's the way to go. hey, i wildly supported this approach ever

[linux-usb-devel] [PATCH] UHCI: Fix problem caused by lack of terminating QH

2007-03-19 Thread Alan Stern
This patch (as871) fixes a problem introduced by an earlier change. It turns out that some systems really do need to have a terminating skeleton QH present whenever FSBR is on. I don't know any way to tell which systems do need it and which don't; the easiest answer is to have it there always.

[linux-usb-devel] [PATCH] UHCI: Add some WARN_ON()s

2007-03-19 Thread Alan Stern
This patch (as872) adds some WARN_ON()s to various error checks which are never supposed to fail. Unsettlingly, one of them has shown up in a user's log! Maybe making the warning more visible and having the call-stack information available will help pinpoint the source of the problem.

[linux-usb-devel] [patch] usb video class support

2007-03-19 Thread Ragner Magalhaes
USB Video Class Support The following patch implements USB Video Class 1.1 as defined at USB Device Class Definition for Video Devices, available at: http://www.usb.org/developers/devclass_docs/USB_Video_Class_1_1.zip Signed-off-by: Ragner N Magalhaes [EMAIL PROTECTED] --- Index:

[linux-usb-devel] [PATCH 1/8] USB: fix usb-serial regression

2007-03-19 Thread Greg Kroah-Hartman
From: Jim Radford [EMAIL PROTECTED] This patch reverts d9a7ecacac5f8274d2afce09aadcf37bdb42b93a since it breaks drivers that need to access the -port[] array in shutdown (most of them). Signed-Off: Jim Radford [EMAIL PROTECTED] Acked-by: Mark Lord [EMAIL PROTECTED] Signed-off-by: Greg

[linux-usb-devel] [PATCH 3/8] USB: RAZR v3i unusual_devs

2007-03-19 Thread Greg Kroah-Hartman
From: Pete Zaitcev [EMAIL PROTECTED] This adds an unusual_devs entry for the Motorola RAZR 3vi. From: Pete Zaitcev [EMAIL PROTECTED] Signed-off-by: Phil Dibowitz [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/storage/unusual_devs.h | 10 ++ 1

[linux-usb-devel] [PATCH 2/8] USB: two more device ids for dm9601 usbnet driver

2007-03-19 Thread Greg Kroah-Hartman
From: Jon Dowland [EMAIL PROTECTED] This patch for the linux-usb-devel tree adds two more product ids to the dm9601 driver. These ids were found on rebadged dm9601 devices in the wild. Signed-off-by: Jon Dowland [EMAIL PROTECTED] Acked-by: Peter Korsgaard [EMAIL PROTECTED] Signed-off-by: Greg

[linux-usb-devel] [PATCH 4/8] USB: necessary update for mos7720 driver

2007-03-19 Thread Greg Kroah-Hartman
From: Oliver Neukum [EMAIL PROTECTED] these devices have a shared interrupt endpoint. For serialcore to pass an interrupt endpoint to a subdriver, the subdriver must define and _export_ a fitting callback. The mos7720 driver failed to do so. This led invariably to an oops upon open. This patch

[linux-usb-devel] [PATCH 5/8] airprime: USB ID for Novatel EV620 mini PCI-E card

2007-03-19 Thread Greg Kroah-Hartman
From: Mark Glines [EMAIL PROTECTED] Add an ID to recognise the Novatel EV620 wireless adapter. http://www.novatelwireless.com/products/expedite/ev620.html It looks like a mini PCI-Express adapter. The mPCIE connector includes USB pins... the card shows up to the system as a USB device, and

[linux-usb-devel] [PATCH 7/8] USB: berry_charge: correct dbg string for second magic command

2007-03-19 Thread Greg Kroah-Hartman
From: Ken L Johnson [EMAIL PROTECTED] I was testing the berry_charge module with my Blackberry 8700c and had great success, thanks. Looking at the code for my own learning I noticed the following cut and paste error... just a nit. Signed-off-by: Ken L Johnson [EMAIL PROTECTED] Signed-off-by:

[linux-usb-devel] [PATCH 6/8] usblp: quirk flag and device entry for Seiko Epson M129C printer

2007-03-19 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as872) adds a device table entry and a new quirk flag to the usblp driver for the Seiko Epson Receipt printer. This printer returns Vendor-Specific values for bInterfaceClass and bInterfaceSubClass, but the bInterfaceProtocol value is valid and it

[linux-usb-devel] [PATCH 8/8] USB: new Novatel device ids for option driver

2007-03-19 Thread Greg Kroah-Hartman
This moves all of the Novatel device ids to the option driver, where they belong. Thanks to Novatel for providing a list of all supported devices. Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/serial/airprime.c |5 - drivers/usb/serial/option.c | 15

Re: [linux-usb-devel] [patch] usb video class support

2007-03-19 Thread Paulo Marques
Ragner Magalhaes wrote: USB Video Class Support The following patch implements USB Video Class 1.1 as defined at USB Device Class Definition for Video Devices, available at: Are you aware of all the owrk done by

Re: [linux-usb-devel] [patch] usb video class support

2007-03-19 Thread David Brownell
On Monday 19 March 2007 1:29 pm, Ragner Magalhaes wrote: The following patch implements USB Video Class 1.1 as defined at USB Device Class Definition for Video Devices, available at: No it doesn't ... it declares on-the-wire *structures* passed. There's not one line of implementation code there

Re: [linux-usb-devel] [patch 8/8] Omap_udc Modification

2007-03-19 Thread David Brownell
On Monday 19 March 2007 8:10 am, Felipe Balbi wrote: This patch adds some endpoints into omap_udc fifo_mode for the three already modified gadget to work together However, it's legit for code to hard-wire knowledge that a given fifo_mode, a given endpoint exists ... so what you

Re: [linux-usb-devel] [PATCH] usb/net/dm9601: fix sparse NULL warnings

2007-03-19 Thread Peter Korsgaard
Randy == Randy Dunlap [EMAIL PROTECTED] writes: Hi, Randy From: Randy Dunlap [EMAIL PROTECTED] Randy Fix sparse NULL warnings: Randy drivers/usb/net/dm9601.c:88:23: warning: Using plain integer Randy as NULL pointer drivers/usb/net/dm9601.c:174:22: warning: Randy Using plain integer as

[linux-usb-devel] [GIT PATCH] USB fixes for 2.6.21-rc4

2007-03-19 Thread Greg KH
Here are some USB fixes and new device ids against 2.6.21-rc4. These patches contain a fix for a regression that is on Adrian's list with regards to usb-serial drivers oopsing, and they also add a number of different device ids and other minor updates. All of these have been in the -mm releases.

[linux-usb-devel] [PATCH 1/1] race condition fixes for usb-serial

2007-03-19 Thread John
This is a fix for race condition in usb-serial.c between serial_open and usb_serial_disconnect (kernel version 2.6.21-rc3) Prior to this patch instances of usb_serial were not ref-counted consistently, which caused serial_open to reuse already deleted instance. For more details search Web for

Re: [linux-usb-devel] polling mechanism for media presence

2007-03-19 Thread Allen Curtis
Desirable solution would be to poll for media and generate hotplug events so this device can be handled like the other USB interface in the system. We have registered this an an unusual device and created a custom initialization function. What is the next step? Why have you created your