[linux-usb-devel] [PATCH 02/29] USB: remove useless check in mos7840 found by coverity

2007-05-23 Thread Greg Kroah-Hartman
From: Oliver Neukum [EMAIL PROTECTED] this useless check should be removed. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/serial/mos7840.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git

[linux-usb-devel] [GIT PATCH] USB fixes for 2.6.22-rc2

2007-05-23 Thread Greg KH
Here are some USB fixes against your 2.6.22-rc2 tree. They fix a number of minor and semi-major issues (suspend to ram should now work properly for everyone that was hitting the USB can't suspend error) and add a number of new device ids to various USB drivers. All of these, except for the new

[linux-usb-devel] [PATCH 01/29] USB: fix omninet memory leak found by coverity

2007-05-23 Thread Greg Kroah-Hartman
From: Oliver Neukum [EMAIL PROTECTED] the transfer of allocating the descriptor in attach and no longer in open was incomplete resulting in a memory leak coverity spotted. This fix is against the patch set you posted. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Greg

[linux-usb-devel] [PATCH 03/29] usb-storage: ignore Sitecom WL-117 USB-WLAN

2007-05-23 Thread Greg Kroah-Hartman
From: Matthew Davidson [EMAIL PROTECTED] The Sitecom WL-117 is another driverless ZD1211 device where the virtual windows driver CD must be ejected before the WLAN device appears. zd1211rw takes care of the ejecting, but usb-storage must be told not to claim the device. From: Matthew Davidson

[linux-usb-devel] [PATCH 04/29] USB: fix more ftdi-elan/u132-hcd #include lossage

2007-05-23 Thread Greg Kroah-Hartman
From: David Brownell [EMAIL PROTECTED] Partial fix for bogosity in the ftdi-elan and u132-hcd drivers ... these have no business including with the internals of other drivers, much less doing so in a broken way!! A previous patch resolved one build fix, this resolves another... Signed-off-by:

[linux-usb-devel] [PATCH 05/29] USB: handle more rndis_host oddities

2007-05-23 Thread Greg Kroah-Hartman
From: David Brownell [EMAIL PROTECTED] Workaround another device firmware bug, wherein CDC descriptors get placed in a wrong place never previously observed in the wild. Fix a bug where a seeming RNDIS device returns a bogus response during device initialization. Signed-off-by: David Brownell

[linux-usb-devel] [PATCH 06/29] USB: remove usb DocBook warnings

2007-05-23 Thread Greg Kroah-Hartman
From: David Brownell [EMAIL PROTECTED] This just removes some warnings generated by the Docbook tools when turning USB (host and peripheral side) kerneldoc into HTML; they're all about missing ID attributes. Signed-off-by: David Brownell [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL

[linux-usb-devel] [PATCH 07/29] USB: address FIXME in usbnet w.r.t drivers claiming multiple interfaces

2007-05-23 Thread Greg Kroah-Hartman
From: Oliver Neukum [EMAIL PROTECTED] This fixes the issue of drivers claiming multiple interfaces. Operations are stopped as soon as an interface is suspend and resumed only as all interfaces have been resumed. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: David Brownell [EMAIL

[linux-usb-devel] [PATCH 08/29] EHCI: fix problem with BIOS handoff

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as882) fixes a problem with the EHCI BIOS handoff. On my machine, the BIOS configures the controller and the handoff fails, leaving the controller configured. During resume-from-disk, this confuses ehci-hcd into thinking that the controller has not

[linux-usb-devel] [PATCH 09/29] USB: more autosuspend timer stuff

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as879) ties up some loose ends from an earlier patch. These are things I didn't think to include at the time but which clearly belonged there. If an autosuspend fails because driver activity races with the autosuspend call, restart

[linux-usb-devel] [PATCH 10/29] USB: remove unneeded WARN_ON

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as883) removes an out-of-date WARN_ON from the main HCD endpoint-disable routine. The warning is triggered whenever an endpoint is disabled while the root hub is suspended. In the past that may not have been legal, but it definitely is legal now.

[linux-usb-devel] [PATCH 11/29] USB: New device PID for ftdi_sio driver

2007-05-23 Thread Greg Kroah-Hartman
From: Neil \Superna\ ARMSTRONG [EMAIL PROTECTED] Hello, I need to use MaxStream's PKG-U modules which includes a ftdi sio chipset for usb2serial communication, here are the patches for handling Maxstream's modules. The VID PID to use with the open-source driver are provided on the CD-ROM

[linux-usb-devel] [PATCH 12/29] USB: set the correct Interrupt interval in usb_bulk_msg

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as902) fixes a mistake I introduced into usb_bulk_msg(). usb_fill_int_urb() already does the bit-shifting calculation for high-speed Interrupt intervals; it shouldn't be done twice. Signed-off-by: Alan Stern [EMAIL PROTECTED] ---

[linux-usb-devel] [PATCH 14/29] USB: auerswald: fix file release handler

2007-05-23 Thread Greg Kroah-Hartman
From: Andrew Morton [EMAIL PROTECTED] If this down_interruptible() does fail due to signal_pending() then the state of the driver will get trashed in interesting ways, because userspace cannot and will not retry the close(). Cc: Jiri Slaby [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[linux-usb-devel] [PATCH 13/29] USB: fsl_usb2_udc: Fix UMTI_WIDE support and a compile warning

2007-05-23 Thread Greg Kroah-Hartman
From: Li Yang [EMAIL PROTECTED] Change PORT_WIDTH bit for UMTI_WIDE mode and fix a compile warning introduced in last revision. Signed-off-by: Li Yang [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/gadget/fsl_usb2_udc.c |8 +--- 1 files changed, 5

[linux-usb-devel] [PATCH 15/29] USB: Remove duplicate IDs from option card driver

2007-05-23 Thread Greg Kroah-Hartman
From: Ben Collins [EMAIL PROTECTED] Cc: Matthias Urlichs [EMAIL PROTECTED] Signed-off-by: Ben Collins [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/serial/option.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[linux-usb-devel] [PATCH 17/29] USB: remove short initial timeout for device descriptor fetch

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as905) removes a micro-optimization from the hub port initialization code. Previously we had been using a short timeout on the first attempt the read the device descriptor; now we will use the standard timeout length. It's not clear that the short

[linux-usb-devel] [PATCH 18/29] USB: don't try to kzalloc 0 bytes

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as907) prevents us from trying to allocate 0 bytes when an interface has no endpoint descriptors. Signed-off-by: Alan Stern [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/core/config.c | 10 ++ 1

[linux-usb-devel] [PATCH 20/29] USB: Fix debug output of ark3116

2007-05-23 Thread Greg Kroah-Hartman
From: Jan Engelhardt [EMAIL PROTECTED] Fix debug output. Previously, it would output 0xFFB0 on 32-bit archs (and probably 0xFFB0 on 64-bits), because buf is taken as signed char, which is promoted to signed int, while %x always expects an unsigned int. Signed-off-by: Jan

[linux-usb-devel] [PATCH 22/29] USB: Fix USB OHCI Subvendor for Toshiba Portege 4000

2007-05-23 Thread Greg Kroah-Hartman
From: Andrey Borzenkov [EMAIL PROTECTED] This fixes a bug in an OHCI quirk handler for Portege 4000; the Subvendor is 0x1179 (PCI_VENDOR_ID_TOSHIBA) not 0x102f (PCI_VENDOR_ID_TOSHIBA_2) bugid 8510 00:02.0 USB Controller [0c03]: ALi Corporation USB 1.1 Controller [10b9:5237] (rev 03) (prog-if 10

[linux-usb-devel] [PATCH 19/29] USB: Onetouch - switch to using input_dev-dev.parent

2007-05-23 Thread Greg Kroah-Hartman
From: Dmitry Torokhov [EMAIL PROTECTED] In preparation for struct class_device - struct device input core conversion, switch to using input_dev-dev.parent when specifying device position in sysfs tree. Also, do not access input_dev-private directly, use helpers. Signed-off-by: Dmitry Torokhov

[linux-usb-devel] [PATCH 21/29] USB: usblp: Use correct DMA address in case of probe error

2007-05-23 Thread Greg Kroah-Hartman
From: Pete Zaitcev [EMAIL PROTECTED] Looks like the error path had a copy-paste error. The normal exit path uses correct URB already. Signed-off-by: Pete Zaitcev [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/class/usblp.c |2 +- 1 files changed, 1

[linux-usb-devel] [PATCH 23/29] USB: make the autosuspend workqueue thread freezable

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as881b) makes the ksuspend_usb_wq workqueue freezable. We don't want a rogue workqueue thread running around, unexpectedly suspending or resuming USB devices in the middle of a system sleep transition. This fixes Bugzilla #8498. Signed-off-by:

[linux-usb-devel] [PATCH 24/29] USB: handle errors in power/level attribute

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as906) improves the error handling for the USB power/level attribute file. If an error occurs, the original power-level settings will be restored. Signed-off-by: Alan Stern [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] ---

[linux-usb-devel] [PATCH 25/29] USB: fix ratelimit call semantics

2007-05-23 Thread Greg Kroah-Hartman
From: Alan Stern [EMAIL PROTECTED] This patch (as910) fixes a ratelimit modification so that the original error-handling path will be followed even when the log-rate limitation kicks in. Signed-off-by: Alan Stern [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] ---

[linux-usb-devel] [PATCH 26/29] USB: ftdi_sio: Add USB Product Id for OpenDCC

2007-05-23 Thread Greg Kroah-Hartman
From: Guido Scholz [EMAIL PROTECTED] USB product id registration for the OpenDCC (www.opendcc.de) model railway central unit. Applies to 2.6.21.1. Signed-off-by: Guido Scholz [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/serial/ftdi_sio.c |1 +

[linux-usb-devel] [PATCH 27/29] USB: ldusb bugfix

2007-05-23 Thread Greg Kroah-Hartman
From: Oliver Neukum [EMAIL PROTECTED] This patch fixes a problem reported with consecutive reads in the ldusb driver. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/misc/ldusb.c | 35 +++ 1

[linux-usb-devel] [PATCH 29/29] USB: Add support for Olimex arm-usb-ocd JTAG interface serial port

2007-05-23 Thread Greg Kroah-Hartman
From: Tony Lindgren [EMAIL PROTECTED] This patch adds support for the serial port on Olimex arm-usb-ocd JTAG interface. The device appears as two serial ports, but the first one is reserved for the JTAG interface. The JTAG interface can be used with OpenOCD from userspace. For more information,

[linux-usb-devel] [PATCH 28/29] USB: Add support for Sierra Wireless Aircard 595U

2007-05-23 Thread Greg Kroah-Hartman
From: Danny Budik [EMAIL PROTECTED] This patch adds support for the newly released Aircard 595U EVDO modem to the Sierra Wireless driver (sierra.c) in kernel 2.6.21. I suspect that my mailer may be mangling patches so let me know and I'll try to resend it. From: Danny Budik [EMAIL PROTECTED]

[linux-usb-devel] [PATCH 16/29] USB: Deref URB after usbmon is done with it

2007-05-23 Thread Greg Kroah-Hartman
From: Pete Zaitcev [EMAIL PROTECTED] I haven't personally run across an oops because of this, but I feel safer with this fix in place. Signed-off-by: Pete Zaitcev [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] --- drivers/usb/core/hcd.c |2 +- 1 files changed, 1

Re: [linux-usb-devel] [PATCH] USB Core hub.c: prevent re-enumeration on HNP

2007-05-23 Thread Pandita, Vikram
-Original Message- From: Alan Stern [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 22, 2007 7:45 PM To: Pandita, Vikram Cc: David Brownell; USB development list Subject: RE: [linux-usb-devel] [PATCH] USB Core hub.c On Tue, 22 May 2007, Pandita, Vikram wrote: From: Alan Stern

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 00:42:33 -0700 Andrew Morton [EMAIL PROTECTED] wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/ This is intermittently getting resume-from-RAM failures. It is not sufficiently repeatable to be able to bisect. [ 1381.119362]

Re: [linux-usb-devel] anchors and their use

2007-05-23 Thread Oliver Neukum
Am Dienstag, 22. Mai 2007 17:12 schrieb Alan Stern: Very good. I did notice two more things: Timeouts are specified in jiffies, so your timeout argument should be long or unsigned long, not int. There's a race if two threads call usb_unanchor_urb() for the same

Re: [linux-usb-devel] Is usb_buffer_alloc a generic URB buffer allocator ? (was Split Bulk Transfers)

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 04:18 schrieb Pete Zaitcev: Running DMA into vmalloc area can be done with some effort. I think that one can use __vmalloc() with GFP_DMA32 instead of vmalloc(). The original implementation of it was in V4L, copied multiply times all over the kernel since. Kraxel

[linux-usb-devel] [PATCH] asix.c - Add Belkin F5D5055 ids

2007-05-23 Thread David Hollis
The attached patch adds the device IDs for the Belkin F5D5055 device. Reported by Andy Juniper [EMAIL PROTECTED] Signed-off-by: David Hollis [EMAIL PROTECTED] -- David Hollis [EMAIL PROTECTED] --- a/drivers/net/usb/asix.c 2007-05-11 08:18:35.0 -0400 +++ b/drivers/net/usb/asix.c

Re: [linux-usb-devel] New USB stack on FreeBSD w/Linux emulation layer coming

2007-05-23 Thread Oliver Neukum
Am Dienstag, 22. Mai 2007 17:23 schrieb Alan Stern: On Tue, 22 May 2007, Laurent Pinchart wrote: The usb_buffer_alloc name is misleading. Many USB driver developers believe it is a generic purpose buffer allocator. I'd like to change usb_buffer_alloc to make it a general purpose

Re: [linux-usb-devel] autosuspend for HID devices, take #2

2007-05-23 Thread Oliver Neukum
Am Dienstag, 22. Mai 2007 18:50 schrieb Jiri Kosina: I think that this is unfortunately not true. Let's take system with multiple keyboards and their LEDs as an excellent example again. If you kill the interrupt URB, there is nothing what will prevent other keyboard (PS/2 or even USB

Re: [linux-usb-devel] New USB stack on FreeBSD w/Linux emulation layer coming

2007-05-23 Thread David Brownell
On Wednesday 23 May 2007, Oliver Neukum wrote: I thought a bit about this. Maybe there _is_ room for an allocator that will provide memory the HCD can get at, but without the full overhead of allocating a coherent buffer. kmalloc() does exactly that...

Re: [linux-usb-devel] autosuspend for HID devices, take #2

2007-05-23 Thread Oliver Neukum
Am Dienstag, 22. Mai 2007 19:18 schrieb Alan Stern: On Tue, 22 May 2007, Oliver Neukum wrote: Yes, but if you are in pre_reset, chances are something is wrong with the devices. Outright slaughter of all outstanding URBs is better than waiting for them to complete. Fair enough. I

Re: [linux-usb-devel] New USB stack on FreeBSD w/Linux emulation layer coming

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 10:48 schrieb David Brownell: On Wednesday 23 May 2007, Oliver Neukum wrote: I thought a bit about this. Maybe there _is_ room for an allocator that will provide memory the HCD can get at, but without the full overhead of allocating a coherent buffer.

Re: [linux-usb-devel] How to talk to USB HCD Drivers?

2007-05-23 Thread Pandita, Vikram
On Tue, May 22, 2007 at 12:06:54PM +0530, Pandita, Vikram wrote: Hi Felipe Sent: Monday, May 21, 2007 3:56 PM Hello all, is there a way to use libusb to talk directly to hcd drivers? what I'm wondering to do is to develop an application similar to the USBHSET tool from usb.org in

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Rafael J. Wysocki
On Wednesday, 23 May 2007 09:48, Andrew Morton wrote: On Wed, 23 May 2007 00:42:33 -0700 Andrew Morton [EMAIL PROTECTED] wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/ This is intermittently getting resume-from-RAM failures. It is not

Re: [linux-usb-devel] autosuspend for HID devices, take #2

2007-05-23 Thread Oliver Neukum
Am Dienstag, 22. Mai 2007 18:50 schrieb Jiri Kosina: On Tue, 22 May 2007, Alan Stern wrote: But if you kill the interrupt URB then there will be no more inputs and hence nothing to generate any more output.  Thus, when suspending you should kill the inputs and wait for the outputs to

Re: [linux-usb-devel] [PATCH] asix.c - Add Belkin F5D5055 ids

2007-05-23 Thread David Brownell
On Wednesday 23 May 2007, David Hollis wrote: --- a/drivers/net/usb/asix.c2007-05-11 08:18:35.0 -0400 +++ b/drivers/net/usb/asix.c2007-05-23 03:27:29.0 -0400 All these net/usb patches should go to the netdev list now, unless there's some USB infrastructure issue to

Re: [linux-usb-devel] How to talk to USB HCD Drivers?

2007-05-23 Thread David Brownell
On Wednesday 23 May 2007, Pandita, Vikram wrote: On Tue, May 22, 2007 at 12:06:54PM +0530, Pandita, Vikram wrote: Hi Felipe Sent: Monday, May 21, 2007 3:56 PM Hello all, is there a way to use libusb to talk directly to hcd drivers? what I'm wondering to do is to develop an

[linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Oliver Neukum
Hi, this may be it. open issues: - waiting on Jiri's comment about what to do if waiting for io gets a timeout during suspend() Other than that it has all features I planned for and were requested. It should work now. I am now taking comments on coding style :-) I request testing and remind

[linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Sam Liddicott
I've got some ftdi usb-serial devices causing mass USB hanging on SOME hardware often; it seems when the remote serial device asserts DSR or some such handshaking line. On a problem device, lsusb shows: Bus 002 Device 001: ID : Bus 001 Device 005: ID 0403:6001 Future Technology Devices

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Jiri Kosina
On Wed, 23 May 2007, Oliver Neukum wrote: - waiting on Jiri's comment about what to do if waiting for io gets a timeout during suspend() Hi Oliver, I think that whenever usbhid_wait_io() times out during suspend, it is fine to kill the URB, as it doesn't seem to make any more harm compared

Re: [linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 13:07 schrieb Sam Liddicott: I've got some ftdi usb-serial devices causing mass USB hanging on SOME hardware often; it seems when the remote serial device asserts DSR or some such handshaking line. Which kernel version? Can you provide a dmesg with timestamps?

Re: [linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 14:20 schrieb Sam Liddicott: Sorry, I thought I'd said: 2.4.20-8 (rh9) , 2.6.18-4-686 (debian 4), 2.6.20-15 (ubuntu feisty) I tried a 2.6.22rc2 build based on the debian .config file but it wouldn't boot, so I got something wrong. Please try a vanilla kernel. Can

Re: [linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 15:13 schrieb Sam Liddicott: and here is where the handshake line changes to make the serial port online May 23 12:04:33 shep kernel: usb 1-2.2: USB disconnect, address 5 May 23 12:04:33 shep kernel: ftdi_sio 1-2.2:1.0: device disconnected May 23 12:04:33 shep

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 13:36 schrieb Jiri Kosina: On Wed, 23 May 2007, Oliver Neukum wrote: - waiting on Jiri's comment about what to do if waiting for io gets a timeout during suspend() Hi Oliver, I think that whenever usbhid_wait_io() times out during suspend, it is fine to

Re: [linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 15:42 schrieb Sam Liddicott: May 23 14:32:48 shep kernel: drivers/usb/serial/ftdi_sio.c: Detected FT232BM May 23 14:32:48 shep kernel: usb 1-2.2: FTDI USB Serial Device converter now attached to ttyUSB1 Here I power up the remote device May 23 14:33:32 shep

Re: [linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 15:55 schrieb Sam Liddicott: * Oliver Neukum wrote, On 23/05/07 14:46: Am Mittwoch, 23. Mai 2007 15:42 schrieb Sam Liddicott: May 23 14:32:48 shep kernel: drivers/usb/serial/ftdi_sio.c: Detected FT232BM May 23 14:32:48 shep kernel: usb 1-2.2: FTDI USB

Re: [linux-usb-devel] [PATCH] USB Core hub.c: prevent re-enumeration on HNP

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Pandita, Vikram wrote: New proposed patch based on your inputs: Patch is to prevent the OTG host of doing 3 times enumeration of device when the Host suspends for HNP. The error code used in this case is ENOTSUPP. Signed-off-by: Vikram Pandita [EMAIL PROTECTED] ---

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Jiri Kosina
On Wed, 23 May 2007, Oliver Neukum wrote: I have quite a lot of things pending, but will test this ASAP. I've tested normal operations on OHCI and EHCI and STR with a mouse, a keyboard and a PID joystick (just plugged in) Hi Oliver, well, I remember to having this reported also against one

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 16:23 schrieb Jiri Kosina: On Wed, 23 May 2007, Oliver Neukum wrote: I have quite a lot of things pending, but will test this ASAP. I've tested normal operations on OHCI and EHCI and STR with a mouse, a keyboard and a PID joystick (just plugged in) Hi Oliver,

Re: [linux-usb-devel] crash for ftdi_sio

2007-05-23 Thread Sam Liddicott
* Oliver Neukum wrote, On 23/05/07 15:03: Sorry for the harsh words. Your attention more than compensates, I thank you. Please recompile with USB_DEBUG. This may yield more info. The build will probably take all night, but I'll have details first thing tomorrow. Sam

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Jiri Kosina
On Wed, 23 May 2007, Oliver Neukum wrote: well, I remember to having this reported also against one of the very first versions of your patch - I still experience loss of events from the device that is being woken up shortly after it goes to suspend. I.e. as soon as the device goes to

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 16:37 schrieb Jiri Kosina: On Wed, 23 May 2007, Oliver Neukum wrote: well, I remember to having this reported also against one of the very first versions of your patch - I still experience loss of events from the device that is being woken up shortly after

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Rafael J. Wysocki wrote: On Wednesday, 23 May 2007 09:48, Andrew Morton wrote: On Wed, 23 May 2007 00:42:33 -0700 Andrew Morton [EMAIL PROTECTED] wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/ This is

Re: [linux-usb-devel] [PATCH] USB Core hub.c: prevent re-enumeration on HNP

2007-05-23 Thread David Brownell
On Wednesday 23 May 2007, Alan Stern wrote: On Wed, 23 May 2007, Pandita, Vikram wrote: New proposed patch based on your inputs: Patch is to prevent the OTG host of doing 3 times enumeration of device when the Host suspends for HNP. The error code used in this case is ENOTSUPP.

Re: [linux-usb-devel] [PATCH] USB: prevent char device open/deregister race

2007-05-23 Thread Alan Stern
On Tue, 22 May 2007, Greg KH wrote: On Tue, May 22, 2007 at 11:46:41AM -0400, Alan Stern wrote: This patch (as908) adds central protection in usbcore for the prototypical race between opening and unregistering a char device. The spinlock used to protect the minor-numbers array is replaced

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Oliver Neukum wrote: I will debug. Maybe just this particular keyboard is clumsy. I will try with various different hardware. But if there are lots of HID hardware out there which expose this broken behavior, it would be bad. No, I cannot replicate this. I see all

Re: [linux-usb-devel] [PATCH] USB: prevent char device open/deregister race

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 17:28 schrieb Alan Stern: Although I really hate rw locks, I'll let it go for now, we can easily change it to a normal mutex in the future... In case it wasn't already obvious, the reason for making it an rwsem was so that multiple open() calls could run

Re: [linux-usb-devel] anchors and their use

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Oliver Neukum wrote: OK, these are fixed and the timeout given in milliseconds, as David recommended. I looked into the inlining issue and the inlined version wins in terms of size. @@ -1270,6 +1287,11 @@ extern struct urb *usb_get_urb(struct ur extern int

Re: [linux-usb-devel] autosuspend for HID devices, take #2

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Oliver Neukum wrote: That gives me an idea. Resumption of a device has to be done in task context. So if I allocate a private freezable work queue for HID resumption, the freezer would guard against illicit resumptions, wouldn't it? You can use the ksuspend_usb_wq

Re: [linux-usb-devel] anchors and their use

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 17:39 schrieb Alan Stern: On Wed, 23 May 2007, Oliver Neukum wrote: OK, these are fixed and the timeout given in milliseconds, as David recommended. I looked into the inlining issue and the inlined version wins in terms of size. @@ -1270,6 +1287,11 @@

Re: [linux-usb-devel] autosuspend for HID devices, take #2

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 17:42 schrieb Alan Stern: On Wed, 23 May 2007, Oliver Neukum wrote: That gives me an idea. Resumption of a device has to be done in task context. So if I allocate a private freezable work queue for HID resumption, the freezer would guard against illicit

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 10:47:04 -0400 (EDT) Alan Stern [EMAIL PROTECTED] wrote: On Wed, 23 May 2007, Rafael J. Wysocki wrote: On Wednesday, 23 May 2007 09:48, Andrew Morton wrote: On Wed, 23 May 2007 00:42:33 -0700 Andrew Morton [EMAIL PROTECTED] wrote:

Re: [linux-usb-devel] [PATCH] EHCI: Safe endianness for transfer buffers after reset in case of HUB with TT

2007-05-23 Thread Vladimir Barinov
On Wednesday 23 May 2007 04:12, you wrote: This patch is really mangled, can you try fixing your email client and try again? Sure. The second try after changing encoding to us-ascii Vladimir = CUT HERE This patch fixes the endianness select for transfer buffers in EHCI

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Jiri Kosina
On Wed, 23 May 2007, Alan Stern wrote: I suspect it is keyboard-dependent. For example, the keyboard's internal buffer might be able to hold no more than one event, because the designers expected the host to poll frequently. Since the polling can't occur during the wakeup interval,

[linux-usb-devel] [patch]Re: autosuspend for HID devices, take #2

2007-05-23 Thread Oliver Neukum
Am Mittwoch, 23. Mai 2007 17:42 schrieb Alan Stern: On Wed, 23 May 2007, Oliver Neukum wrote: That gives me an idea. Resumption of a device has to be done in task context. So if I allocate a private freezable work queue for HID resumption, the freezer would guard against illicit

Re: [linux-usb-devel] anchors and their use

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Oliver Neukum wrote: +extern int usb_wait_anchor_empty_timeout +(struct usb_anchor *anchor, unsigned long timeout); Suspicious line break. This is what I get when I want to keep the 80 column limit. I would write it like this: extern int

Re: [linux-usb-devel] autosuspend for HID devices, take #4

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Jiri Kosina wrote: On Wed, 23 May 2007, Alan Stern wrote: I suspect it is keyboard-dependent. For example, the keyboard's internal buffer might be able to hold no more than one event, because the designers expected the host to poll frequently. Since the polling

[linux-usb-devel] autosuspend for HID devices, take #5

2007-05-23 Thread Oliver Neukum
Hi, (on0001) this version uses usbcore pm workqueue as Alan suggested. It is relative to the last patch I sent, which I retroactively christen on. Regards Oliver --- linux-2.6.22-rc2/include/linux/hid.h2007-05-22 14:50:58.0 +0200 +++

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Andrew Morton wrote: This is intermittently getting resume-from-RAM failures. It is not sufficiently repeatable to be able to bisect. [ 1381.119362] PM: Preparing system for mem sleep [ 2331.798452] Stopping tasks ... [ 2351.760431] Stopping kernel

Re: [linux-usb-devel] anchors and their use

2007-05-23 Thread Oliver Neukum
Here we go again. Regards Oliver --- --- a/drivers/usb/core/hcd.c2007-05-22 14:50:32.0 +0200 +++ b/drivers/usb/core/hcd.c2007-05-22 15:36:17.0 +0200 @@ -1412,6 +1412,8 @@ void usb_hcd_giveback_urb (struct usb_hc }

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Oleg Nesterov
On 05/23, Andrew Morton wrote: On Wed, 23 May 2007 10:47:04 -0400 (EDT) Alan Stern [EMAIL PROTECTED] wrote: Is it possible to get an Alt-SysRq-T stack trace during those 20 seconds? Knowing what those threads are waiting for would be a big help. [ 144.201264] khubd D

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Oleg Nesterov
On 05/23, Alan Stern wrote: Okay, it's clear that the two threads are in deadlock. It's not clear how the deadlock arose to begin with -- apparently there was a remote wakeup request for a root hub at the same time as a device below that root hub was disconnected, which doesn't make much

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Alan Stern
On Wed, 23 May 2007, Oleg Nesterov wrote: On 05/23, Alan Stern wrote: Okay, it's clear that the two threads are in deadlock. It's not clear how the deadlock arose to begin with -- apparently there was a remote wakeup request for a root hub at the same time as a device below that

[linux-usb-devel] [PATCH] digi_acceleport further buffer clean up

2007-05-23 Thread Al Borchers
Greg -- Some further cleanup after Oliver's patch to update the tty buffering. The input buffer is not used at all anymore, so I removed it. This applies to 2.6.22-rc2 _after_ Oliver's patch, Digi AccelePort adapted to new tty buffering. -- Al Signed-off-by: Al Borchers [EMAIL PROTECTED]

Re: [linux-usb-devel] [PATCH] USB: prevent char device open/deregister race

2007-05-23 Thread Greg KH
On Tue, May 22, 2007 at 11:46:41AM -0400, Alan Stern wrote: This patch (as908) adds central protection in usbcore for the prototypical race between opening and unregistering a char device. The spinlock used to protect the minor-numbers array is replaced with an rwsem, which can remain locked

[linux-usb-devel] [PATCH] USB: prevent char device open/deregister race

2007-05-23 Thread Alan Stern
This patch (as908) adds central protection in usbcore for the prototypical race between opening and unregistering a char device. The spinlock used to protect the minor-numbers array is replaced with an rwsem, which can remain locked across a call to a driver's open() method. This guarantees that

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Andrew Morton
On Wed, 23 May 2007 17:17:09 -0600 Zan Lynx [EMAIL PROTECTED] wrote: On Wed, 2007-05-23 at 00:42 -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/ - A new readahead patch series. This needs serious review and performance

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Jiri Kosina
On Wed, 23 May 2007, Zan Lynx wrote: I am having weird problems with USB keyboard and mouse. The USB keyboard will drop keystrokes, but not all of them. The mouse seems to move fine but drops clicks. Could be that an occasional missed move event isn't noticeable. Nothing is logged when

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Dmitry Torokhov
Hi Jiri, On Wednesday 23 May 2007 19:40, Jiri Kosina wrote: This is pretty strange. Mouse shouldn't be claimed by hiddev. Seems like this mouse probably has some interesting HID report descriptor. Could you please recompile with CONFIG_HID_DEBUG enabled and send me the output? It looks

Re: [linux-usb-devel] [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-23 Thread Phil Dibowitz
Ben Collins wrote: Various unusual dev entries accumulated from Ubuntu bug reports. CC: Phil Dibowitz [EMAIL PROTECTED] NACK. Two fixes I'd like to see fixed. +/* SanDisk that has a second LUN for a driver ISO, reported by + * Ben Collins [EMAIL PROTECTED] */ +UNUSUAL_DEV( 0x0781, 0x5406,

Re: [linux-usb-devel] [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-23 Thread Ben Collins
On Wed, 2007-05-23 at 20:59 -0700, Phil Dibowitz wrote: Ben Collins wrote: Various unusual dev entries accumulated from Ubuntu bug reports. CC: Phil Dibowitz [EMAIL PROTECTED] NACK. Two fixes I'd like to see fixed. +/* SanDisk that has a second LUN for a driver ISO, reported by +

Re: [linux-usb-devel] [PATCH 6/6] UNUSUAL_DEV: Sync up some reported devices from Ubuntu

2007-05-23 Thread Phil Dibowitz
Note, I've taken LKML off the CC list anyone interested in this on there is also on linux-usb-devel. I've also added the usb-storage list. See rest of response below. Ben Collins wrote: +/* SanDisk that has a second LUN for a driver ISO, reported by + * Ben Collins [EMAIL PROTECTED] */