Alan Stern wrote:
On Mon, 11 Jun 2007, Craig W. Nadler wrote:
+
+ first_intf = intf_assoc->bFirstInterface;
+ last_intf = first_intf + (intf_assoc->bInterfaceCount - 1);
+ if (inum >= first_intf && inum <= last_intf) {
+ if (!retval
From: Craig W. Nadler <[EMAIL PROTECTED]>
EHCI_HUB_CTRL: Fixes a bug with setting the value of the port number.
The ehci_hub_control() function in driver/usb/host/ehci-hub.c takes a u16 parameter
called wIndex. The least significant byte of this parameter holds the port number
relevant to the
On Monday, 11 June 2007 22:10, Alan Stern wrote:
> On Mon, 11 Jun 2007, Rafael J. Wysocki wrote:
>
> > > At that point, does "lspci -vv" show that the controller is trying to
> > > signal a wakeup event? That is, is the PME# signal asserted?
> > >
> > > (Not that knowing this will help very muc
Yoshihiro:
While going through the HCDs, I found this bug and some simplifications
in your driver. While you hold a spinlock, memory allocation cannot
use anything other than GFP_ATOMIC.
Do you agree that the patch below is correct? If yes, then I will fold
it in with the new urb->status updat
Hi,
usb_unlink_urb() is asynchronous, therefore an URB's buffer may not
be freed without waiting for the completion handler. This patch switches
to usb_kill_urb(), which is synchronous.
Thanks to Alan for making me look at the remaining users of usb_unlink_urb()
Regards
Ol
On Wed, 13 Jun 2007, Grant Likely wrote:
> I think we're crossing wires here. In this particular case, I think
> the hub support code is sufficiently small that it doesn't need to be
> split off into a separate file. (It's only 180 lines) I'm not
> suggesting that the hub support stuff be moved
Am Mittwoch, 13. Juni 2007 schrieb Alan Stern:
> IMO the fine distinctions above simply don't matter. Drivers don't
> care anyway, since they can't know what stage the URB is at when they
> try to unlink it.
>
> The only possible place where this might matter is in usbtest, which
> specifically
Olav:
While going through the HCDs, I found this possible bug in your driver.
Do you agree that the patch below is needed? If yes, then I will fold
it in with the new urb->status updates.
Alan Stern
Index: usb-2.6/drivers/usb/host/isp116x-hcd.c
==
On 6/13/07, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Wed, 13 Jun 2007, Grant Likely wrote:
>
> > On 6/13/07, Alan Stern <[EMAIL PROTECTED]> wrote:
> > > On Wed, 13 Jun 2007, Grant Likely wrote:
> > >
> > > > On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> > > > > > "Grant" == Grant L
On Wed, 13 Jun 2007, Grant Likely wrote:
> On 6/13/07, Alan Stern <[EMAIL PROTECTED]> wrote:
> > On Wed, 13 Jun 2007, Grant Likely wrote:
> >
> > > On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> > > > > "Grant" == Grant Likely <[EMAIL PROTECTED]> writes:
> > > >
> > > > Hi,
> > > >
>
Dave and everyone else:
The meaning of the return value from usb_unlink_urb() is not as clear
as it should be. The value is used in only a handful of drivers,
mostly for debugging output. David's code uses it for warnings and
error messages, but not for altering the control flow.
The real quest
Hi,
this patch implements autosuspend for the usblcd driver. It uses
the new usb_anchor infrastructure. Many thanks to Georges for testing.
Regards
Oliver
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
--
--- a/drivers/usb/misc/usblcd.c 2007-06-11 15:46:44.0 +0
On 6/13/07, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Wed, 13 Jun 2007, Grant Likely wrote:
>
> > On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> > > > "Grant" == Grant Likely <[EMAIL PROTECTED]> writes:
> > >
> > > Hi,
> > >
> > > Grant> Rather than c67x00-hub.c being compiled seper
On Wed, 13 Jun 2007, Grant Likely wrote:
> On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> > > "Grant" == Grant Likely <[EMAIL PROTECTED]> writes:
> >
> > Hi,
> >
> > Grant> Rather than c67x00-hub.c being compiled seperately, the
> > Grant> original code had c67x00-hub.c *included*
On 6/13/07, phil culler <[EMAIL PROTECTED]> wrote:
>
> On 6/13/07, Grant Likely <[EMAIL PROTECTED]> wrote:
> > On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> > > > "Grant" == Grant Likely <[EMAIL PROTECTED] > writes:
> > >
> > > Hi,
> > >
> > > Grant> Rather than c67x00-hub.c being c
On 6/12/07, Peter Korsgaard <[EMAIL PROTECTED]> wrote:
> > "Grant" == Grant Likely <[EMAIL PROTECTED]> writes:
>
> Hi,
>
> Grant> Rather than c67x00-hub.c being compiled seperately, the
> Grant> original code had c67x00-hub.c *included* by c67x00-hcd.c.
> Grant> This is a very bad idea. Sim
Jiri Slaby napsal(a):
> Andrew Morton napsal(a):
>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
> after plugging my camera in, I get this:
[...]
> USB Mass Storage support registered.
> WARNING: at /home/l/latest/xxx/drivers/usb/core/urb.c:293 usb_submi
Andrew Morton napsal(a):
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/
Hi,
after plugging my camera in, I get this:
usb 1-1: new full speed USB device using uhci_hcd and address 2
usb 1-1: new device found, idVendor=07b4, idProduct=0105
usb 1-1: new de
18 matches
Mail list logo
