-by: Laurent Pinchart [EMAIL PROTECTED]
Acked-by: Alan Stern [EMAIL PROTECTED]
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML
of wIndex are nonzero only for the
PORT_FEAT_INDICATOR and PORT_FEAT_TEST features, and ehci-hcd is the
only driver to support either of those. Hence it is the only driver is
need of this change. However I think it's not a bad idea to update
every driver anyhow.
Alan Stern
Greg:
Please send the usb-g_file_storage-call-allow_signal patch to Linus in
time to appear in 2.6.22. The g_file_storage driver doesn't work under
the vanilla kernel without it.
Thanks,
Alan Stern
-
This SF.net email
On Mon, 11 Jun 2007, Greg KH wrote:
On Mon, Jun 11, 2007 at 11:33:24AM -0400, Alan Stern wrote:
Greg:
Please send the usb-g_file_storage-call-allow_signal patch to Linus in
time to appear in 2.6.22. The g_file_storage driver doesn't work under
the vanilla kernel without it.
Ok
hierarchy.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net
that would be good to do.
That can be the second major alteration -- first get rid of
urb-status, then change URB allocation. Large changes like this take
some time...
Alan Stern
-
This SF.net email is sponsored by DB2 Express
.
Hmmm... If you turn on CONFIG_USB_DEBUG, what shows up in
/sys/class/usb_host/usb_hostN/registers where N is the bus number of
the controller?
Also, can you post a dmesg log (with CONFIG_USB_DEBUG enabled) showing
what happens during the suspend and immediate resume?
Alan Stern
On Tue, 12 Jun 2007, Robert de Rooy wrote:
Yes that works.
I tried to plug and unplug the device repeatedly and each time it came
up in full-speed mode.
Good! I'm glad that companion attribute file has come in handy for
someone. :-)
Alan Stern
routine, for backward
compatibility).
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http
.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2
about is this:
CPU 0
-
call usb_hcd_giveback_urb
call urb-complete
call usb_submit_urb
It doesn't involve multiple threads or unlinking.
Alan Stern
-
This SF.net email
On Sun, 10 Jun 2007, Robert de Rooy wrote:
Alan Stern wrote:
Unfortunately you posted the system log file instead of the dmesg log,
and your syslogd was configured not to retain debug-level messages.
Ok, I did not realize my syslog was filtering the debug-level messages,
here
On Sun, 10 Jun 2007, Oliver Neukum wrote:
Am Sonntag, 10. Juni 2007 schrieb Alan Stern:
On Sun, 10 Jun 2007, Oliver Neukum wrote:
Am Sonntag, 10. Juni 2007 schrieb Greg KH:
Yes, it could be done that way, I think. It'll take more work than a
simple search-and-replace
of port_num.
Third, exactly the same bug is present in all of the HCDs. Why change
only ehci-hcd? Please fix all of them. And don't forget
drivers/usb/gadget/dummy-hcd.c!
Alan Stern
-
This SF.net email is sponsored by DB2
On Fri, 8 Jun 2007, Greg KH wrote:
On Fri, Jun 08, 2007 at 05:08:47PM -0400, Alan Stern wrote:
This patch (as927) fixes a recently-introduced refcounting bug in
ehci-hcd. It's important to remember the difference between
pre-decrement and post-decrement!
Signed-off-by: Alan Stern
On Sat, 9 Jun 2007, Robert de Rooy wrote:
Alan Stern wrote:
Robert, it would help somewhat if you could build a kernel with
CONFIG_USB_DEBUG turned on and post the dmesg log showing what happens
when you plug in one of those non-working devices.
Sorry, yes I should have done
/pci/devices/.../power/wakeup
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http
On Fri, 8 Jun 2007, Greg KH wrote:
On Fri, Jun 08, 2007 at 05:12:05PM -0400, Alan Stern wrote:
This patch (as926) replaces urb-status with urb-core_status, in an
attempt to help prevent drivers from abusing the API by polling
urb-status. The original field remains for use by drivers
On Fri, 8 Jun 2007, Steinar H. Gunderson wrote:
On Thu, Jun 07, 2007 at 01:04:12PM -0400, Alan Stern wrote:
Probably because you're not using UHCI. The real question is, does it
work _with_ the patch?
I've tested the following patch combination:
1. Your bulk - interrupt at low
On Thu, 7 Jun 2007, Greg KH wrote:
On Thu, Jun 07, 2007 at 10:53:29AM -0400, Alan Stern wrote:
To tell you the truth, I rather think there's not much point in keeping
usb-try-to-debug-bug-8561.patch around. Anything seriously wrong that
it could catch ought to have shown up long ago
descriptors (as904).
http://marc.info/?l=linux-usb-develm=117881905102712w=2
Is it still in your queue?
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2
On Fri, 8 Jun 2007, Nicolas Mailhot wrote:
Le mardi 05 juin 2007 à 17:00 -0400, Alan Stern a écrit :
Here's a patch. Anybody see anything wrong with it? I don't have any
devices with non-ASCII characters in the default language descriptors
for testing. It would be nice
On Fri, 8 Jun 2007, Robert Marquardt wrote:
Alan Stern schrieb:
The current Unicode usage in the kernel is not nearly as simple as you
seem to think. It includes lots of local assumptions, features that
aren't documented or commented, special-purpose inline code, and so
. It gives up after four attempts.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http
This patch (as904) adds code to check for endpoint descriptor bInterval
values outside the legal limits. Illegal values are set to 32 ms, which
seems like a reasonable default.
This fixes Bugzilla #8432.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/usb/core/config.c
A noticeable number of low-speed devices mistakenly include
descriptors for Bulk endpoints, which is forbidden by the USB spec.
In an attempt to make such devices more usable, this patch (as924)
converts the descriptors to Interrupt with an interval of 1 ms.
Signed-off-by: Alan Stern [EMAIL
to the completion handler. Of course this
won't solve all the races, but it might help reduce the bug reports...
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
On Fri, 8 Jun 2007, Greg KH wrote:
On Fri, Jun 08, 2007 at 10:35:05PM +0200, Johannes Berg wrote:
On Fri, 2007-04-20 at 11:33 -0400, Alan Stern wrote:
This patch (as901) fixes an oversight in ohci-hcd. The
hub_status_data routine must not try to access the controller's
memory-mapped
This patch (as927) fixes a recently-introduced refcounting bug in
ehci-hcd. It's important to remember the difference between
pre-decrement and post-decrement!
Signed-off-by: Alan Stern [EMAIL PROTECTED]
CC: David Brownell [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/usb/host/ehci-mem.c
This patch (as926) replaces urb-status with urb-core_status, in an
attempt to help prevent drivers from abusing the API by polling
urb-status. The original field remains for use by drivers, but it
isn't set until an URB is about to be handed to its completion
routine.
Signed-off-by: Alan Stern
/usbmon.txt)?
Have you tried turning on CONFIG_USB_DEBUG and then looking at the
debugging files under /sys/class/usb_host/usb_host1?
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE
...)
My vote goes toward reverting usb-try-to-debug-bug-8561.patch.
However just to be thorough, for anyone wants to keep it here's an
untested patch to remove those false alarms.
Alan Stern
-
Remove some false alarms generated by usb-try-to-debug-bug-8561.patch
-speed devices out there that we might want to add
this patch.
Alan Stern
Index: usb-2.6/drivers/usb/core/config.c
===
--- usb-2.6.orig/drivers/usb/core/config.c
+++ usb-2.6/drivers/usb/core/config.c
@@ -124,6 +124,21 @@ static int
On Thu, 7 Jun 2007, Robert Marquardt wrote:
Alan Stern schrieb:
Any suggestions for the best way to organize all this?
First a list of all files handling Unicode and a list of all files in
need of handling Unicode is needed (for all Linux).
A first step would be to centralize
On Thu, 7 Jun 2007, Steinar H. Gunderson wrote:
On Thu, Jun 07, 2007 at 11:06:55AM -0400, Alan Stern wrote:
You'll need more than this. For the device to work at all, usbcore has
to be told that the endpoint is interrupt rather than bulk.
For some reason, it actually works without
On Thu, 7 Jun 2007, Steinar H. Gunderson wrote:
On Thu, Jun 07, 2007 at 01:04:12PM -0400, Alan Stern wrote:
For some reason, it actually works without such a patch. Don't ask me why
:-)
Probably because you're not using UHCI.
Well, I'm not using OHCI, but I guess you're referring
On Thu, 7 Jun 2007, David Brownell wrote:
On Thursday 07 June 2007, Alan Stern wrote:
full handling of Unicode? You must be kidding. Do you have any idea
how difficult it is to do something as simple as converting between
lower- and uppercase?
Case conversion is another one
or
synchronized with. A call is synchronous if all its actions have
finished by the time the call returns. Asynchronous is the opposite
-- some of the actions may not have finished when the call returns.
Alan Stern
-
This SF.net email
.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2
errors are reported. The dev_err() statement should always be
executed when there is an overcurrent change; it shouldn't depend on
whether the overcurrent feature is set at the moment.
Remember, the message reports an overcurrent _change_, not an
overcurrent _state_.
Alan Stern
On Wed, 6 Jun 2007, Guennadi Liakhovetski wrote:
On Tue, 5 Jun 2007, Alan Stern wrote:
I just tried doing what you said:
modprobe net2280
dd if=/dev/zero of=/tmp/b bs=1M count=5 ; \
modprobe g_file_storage file=/tmp/b
No problem; it worked fine. But my
On Tue, 5 Jun 2007, David Brownell wrote:
Date: Tue, 5 Jun 2007 17:00:56 -0400 (EDT)
From: Alan Stern [EMAIL PROTECTED]
Does anybody think it would be worthwhile to convert string
descriptors
from UCS-16 to UTF-8 (instead of Latin1) when we read them in?
Or even UTF
On Wed, 6 Jun 2007, Nicolas Mailhot wrote:
So, should I test the original patch or wait while you tweak it?
Go ahead and test it as is. It ought to work well enough, and if
there's something terribly wrong I'd like to know sooner rather than
later.
Alan Stern
mangled the patch when you saved it to a
file. For example, it may have stripped trailing blanks from the ends
of lines.
If necessary you can apply the patch by hand with a little bit of cut
paste. It's not very big.
Alan Stern
.
Return an error for invalid codes or ignore them.
Stop at NUL or take a length argument.
Any suggestions for the best way to organize all this?
Alan Stern
-
This SF.net email is sponsored by DB2 Express
On Mon, 4 Jun 2007, Michael Hanselmann wrote:
On Sat, Jun 02, 2007 at 10:49:44AM -0400, Alan Stern wrote:
Then later on, when the hub driver is resumed it will see the flag and
disconnect all the devices below the root hub.
For instance, you could force ohci-hcd to report connect-change
unless the user does something unintuitive and
undocumented. :-)
When you say the enumeration fails, what exactly goes wrong? I've
never tried using g_file_storage with a newly-created backing file.
Alan Stern
] option_write+0xa7/0xef [option]
Okay, from this it looks like there's a problem in the option.c serial
driver. Glancing at the code, it's obvious why: The thing totally
abuses the USB API.
Try applying this patch; it should help.
Alan Stern
Index: usb-2.6/drivers/usb/serial/option.c
it in time for 2.6.22.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http
g_file_storage file=/tmp/b
No problem; it worked fine. But my version of the driver includes the
patch, of course. And this was under 2.6.22-rc3.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2
with unmounting.
What you need to do is reduce the amount of memory used for I/O
buffers. However I don't know how you can control it. Maybe people on
LKML can provide some advice.
Alan Stern
-
This SF.net email is sponsored by DB2
be trying to figure out what (if any) differences there are
between the bulk endpoints from the kernel's point of view.
However, if anyone has some suggestions on where else to look, I'd
certainly appreciate it.
What does usbmon show? (See Documentation/usb/usbmon.txt.)
Alan Stern
On Mon, 4 Jun 2007, David Brownell wrote:
On Monday 04 June 2007, Pete Zaitcev wrote:
On Mon, 4 Jun 2007 16:52:01 -0400 (EDT), Alan Stern [EMAIL PROTECTED]
wrote:
Does anybody think it would be worthwhile to convert string descriptors
from UCS-16 to UTF-8 (instead of Latin1) when
to break some protocols.
For another, it would be better to make the test at one place, in your
controller driver, instead of spread out among multiple gadget drivers.
Alan Stern
-
This SF.net email is sponsored by DB2
in the same directory as the unbind file.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now
at the moment.
Sometimes you just run up across marginal hardware; there isn't much
you can do except to change it. In this case, I would certainly be
suspicious of the computer's USB host controller.
Alan Stern
-
This SF.net email
Regarding:
http://bugzilla.kernel.org/show_bug.cgi?id=8310
Does anybody think it would be worthwhile to convert string descriptors
from UCS-16 to UTF-8 (instead of Latin1) when we read them in?
Alan Stern
device entry. Maybe also see what ACPI reports.
Alan Stern
Index: usb-2.6/drivers/base/power/sysfs.c
===
--- usb-2.6.orig/drivers/base/power/sysfs.c
+++ usb-2.6/drivers/base/power/sysfs.c
@@ -45,10 +45,6 @@ static ssize_t state_store
plug it back in, the
old entry would hang around indefinitely, using up resources for no
good reason.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express
On Sun, 3 Jun 2007, Uncle George wrote:
Alan Stern wrote:
Another way of thinking about it: Suppose an existing device entry was
not removed (or least made inaccessible) when you unplugged the device
-- the idea being that the existing entry could be reused if you
plugged
On Sat, 2 Jun 2007, Vincent Bernat wrote:
OoO En ce milieu de nuit étoilée du mardi 29 mai 2007, vers 03:59, Alan
Stern [EMAIL PROTECTED] disait:
It looks like the phone's firmware is broken. Does it work with other
non-Linux computer systems? Can you get a firmware update from
On Sat, 2 Jun 2007, Michael Hanselmann wrote:
On Fri, Jun 01, 2007 at 10:19:30AM -0400, Alan Stern wrote:
@@ -779,7 +790,11 @@ static int ohci_restart (struct ohci_hcd
*/
spin_lock_irq(ohci-lock);
disable (ohci);
+
+#ifdef CONFIG_PM
usb_root_hub_lost_power
).
I'm amazed that such things can lay in plain view for years.
Am I missing something here?!
Amazing indeed.
Do you think your new routine should be merged with urb_unlink()? The
two always get called together.
Alan Stern
usb_root_hub_lost_power(ohci_to_hcd(ohci)-self.root_hub);
+#endif
+
Suppose CONFIG_PM isn't defined. How are you going to let usbcore
know about all the old connections which no longer exist?
Alan Stern
-
This SF.net email is sponsored
the error.
Alan Stern
Index: usb-2.6/drivers/usb/core/urb.c
===
--- usb-2.6.orig/drivers/usb/core/urb.c
+++ usb-2.6/drivers/usb/core/urb.c
@@ -233,6 +233,12 @@ int usb_submit_urb(struct urb *urb, gfp_
|| dev-state
sw-iommu.
Do you think your new routine should be merged with urb_unlink()? The
two always get called together.
Probably a good idea. How about now?
Looks good to me.
Alan Stern
-
This SF.net email is sponsored
On Tue, 29 May 2007, Ragner N Magalhães wrote:
On 5/28/07, Alan Stern [EMAIL PROTECTED] wrote:
On Mon, 28 May 2007, Ragner N Magalhães wrote:
Hi all,
I am working with OMAP H2 and when I run rmmod g_file_storage, it
stay waiting some thing and not terminate ...
Somebody know
From: Oleg Nesterov [EMAIL PROTECTED]
New changes in the signal-handling code require compensating changes
in g_file_storage. This patch (as913) by Oleg Nesterov makes the
code use allow_signal() instead of sigprocmask().
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/drivers
This patch (as914) replaces a call to flush_scheduled_work() with
cancel_work_sync(), in order to help avoid potential deadlocks.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/hid/usbhid/hid-core.c
On Wed, 30 May 2007, Dan Aloni wrote:
On Tue, May 29, 2007 at 05:50:49PM -0400, Alan Stern wrote:
On Tue, 29 May 2007, Dan Aloni wrote:
Hello,
We have a system where the rootfs is a partition on a USB device,
and I've noticed upon a few rare cases where the USB controller
simplified.
Suspend and resume handling for root hubs is now completely
separate from that of non-root devices.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version
count as targeted.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
CC: David Brownell [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/usb/core/hub.c
===
--- usb-2.6.orig/drivers/usb/core/hub.c
+++ usb-2.6/drivers/usb/core/hub.c
@@ -1334,7
-resume routines in hub.c include:
Removal of checks for root devices (since they will never
be triggered), and
Removal of checks for NULL or invalid device pointers (these
were left over from earlier kernel versions and aren't needed
at all).
Signed-off-by: Alan
are a few cosmetic changes involving
whitespace and use of braces.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/usb/core/hub.c
===
--- usb-2.6.orig/drivers/usb/core/hub.c
+++ usb-2.6/drivers/usb/core/hub.c
-storage makes the usb_stor_report_bus_reset()
routine acquire the host lock instead of requiring the caller to hold
it already.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
CC: Jiri Kosina [EMAIL PROTECTED]
CC: Matthew Dharm [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/hid/usbhid/hid-core.c
-CONFIG_USB_SUSPEND case.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/usb/core/generic.c
===
--- usb-2.6.orig/drivers/usb/core/generic.c
+++ usb-2.6/drivers/usb/core/generic.c
@@ -219,8 +219,6 @@ static int generic_resume
cleaner than before.
The sysfs interface is updated to add the new attribute file, and
there are corresponding documentation updates.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/include/linux/usb.h
===
--- usb
On Wed, 30 May 2007, David Brownell wrote:
On Wednesday 30 May 2007, Alan Stern wrote:
Propagating the change into the OTG HNP handler requires a slight
addition to the OTG whitelist checking code: A device not attached to
the OTG port should always count as targeted.
No, that's
changes is_targeted()
and leave the rest as is. That should answer your objection and fix
the problem about doing HNP on the wrong port, both.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express
on the wrong port when a non-targeted device is
plugged into a non-OTG port.
Signed-off-by: Alan Stern [EMAIL PROTECTED]
---
Index: usb-2.6/drivers/usb/core/hub.c
===
--- usb-2.6.orig/drivers/usb/core/hub.c
+++ usb-2.6/drivers/usb/core/hub.c
-by: Alan Stern [EMAIL PROTECTED]
---
On Tue, 29 May 2007, Linus Torvalds wrote:
Ok, let's merge the fix them. Alan, can you send it up-stream with the
proper commit message and sign-off?
Here it is. This will apply to 2.6.22-rc3. I'll let you duke it out
with Greg and Andrew to see who wants
to unplug one
device and plug in another (or swap memory cards) in the span of a few
seconds.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control
is the controller's device ID. You
can increase the amount of information in the file by setting the
debug= module parameter for uhci-hcd to values higher than 1.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download
/devices/D/power/level
where D is the device name of the parent hub. Try various combinations
to see what works.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2
in g_file_storage, what shows up in the dmesg
log?
When the rmmod is waiting, what does a stack trace (Alt-SysRq-T) show?
Really, you shouldn't expect people to be able to help if you don't
provide any information...
Alan Stern
the insmod to load any usb modules needed. I have
a sandisk micro 256MB. There's no linux driver for it so I thought I'd write
one.
What do you mean, no Linux driver for the SanDisk micro? Of course
there's a driver for it: usb-storage.
Alan Stern
power it off ...
In fact, Linux doesn't do very much in response to an
overcurrent-change status. The hub driver clears the
overcurrent-change feature and then tells the hub to enable power on
all ports. It never tries to turn off port power, under any
circumstances.
Alan Stern
report a stall!!
That line doesn't make sense at all. Hosts don't stall endpoints;
slaves do. The most the host can do is tell the slave to set the
endpoint's HALT feature, and I doubt they meant that.
Alan Stern
On Thu, 24 May 2007, David Brownell wrote:
On Thursday 24 May 2007, Alan Stern wrote:
Dave:
In this section from usb_new_device():
if (!is_targeted(udev)) {
/* Maybe it can talk to us, though we can't talk to it.
* (Includes HNP test device
,
This proves quite definitely that the auto-stop mechanism is not
related to the disconnection.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
, as far as I know.
You'll have to try writing your own.
You're right that the workaround doesn't seem like a good design. What
would happen when a real PID error occurs? Admittedly this is highly
unlikely.
Alan Stern
-efficient I/O bus.)
Okay. Then does this patch look good?
Alan Stern
Index: usb-2.6/drivers/usb/core/hub.c
===
--- usb-2.6.orig/drivers/usb/core/hub.c
+++ usb-2.6/drivers/usb/core/hub.c
@@ -1334,7 +1334,6 @@ static void show_string
to usb1 so in theory it
shouldn't matter. In practice, you never know...
If you really want to prevent the auto-stop, you have to edit the
source code. In drivers/usb/host/uhci-hub.c, make any_ports_active()
return 1 always.
Alan Stern
timestamps. (Hint: CONFIG_PRINTK_TIME.)
My impression is that some user program is starting up during the
suspend and waking up your USB controllers, thereby aborting the
suspend. PPC is odd in this respect, because it doesn't freeze tasks
before suspending.
Alan Stern
is required to have no
more than one USB connection, so the port number would always be equal
to udev-portnum and to 1.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version
On Thu, 24 May 2007, Greg KH wrote:
On Wed, May 23, 2007 at 06:25:36PM +0200, Oliver Neukum wrote:
Am Mittwoch, 23. Mai 2007 17:42 schrieb Alan Stern:
On Wed, 23 May 2007, Oliver Neukum wrote:
That gives me an idea.
Resumption of a device has to be done in task context. So if I
,
post_reset. It's more natural to do suspend, resume, pre_reset,
post_reset.
There is no call to usb_pm_put_interface().
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version
);
release_address(udev);
usb_put_dev(udev);
- if (status == -ENOTCONN)
+ if ((status == -ENOTCONN) || (status == -ENOTSUPP))
break;
}
This looks good.
Acked-by: Alan Stern [EMAIL PROTECTED]
Alan Stern
-T stack trace during those 20
seconds? Knowing what those threads are waiting for would be a big
help.
Alan Stern
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express
On Tue, 22 May 2007, Greg KH wrote:
On Tue, May 22, 2007 at 11:46:41AM -0400, Alan Stern wrote:
This patch (as908) adds central protection in usbcore for the
prototypical race between opening and unregistering a char device.
The spinlock used to protect the minor-numbers array is replaced
301 - 400 of 6192 matches
Mail list logo