Re: [linux-usb-devel] [PATCH 5/9] pcmcia: conf.ConfigBase and conf.Present consolidation

2006-12-06 Thread Karsten Keil
rivers/isdn/hisax/elsa_cs.c| 17 - > drivers/isdn/hisax/sedlbauer_cs.c | 10 > drivers/isdn/hisax/teles_cs.c | 17 - Acked-by: Karsten Keil <[EMAIL PROTECTED]> for ISDN. ... -- Karsten Keil SuSE Labs ISDN development

[linux-usb-devel] Re: [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX

2006-03-03 Thread Karsten Keil
also use WARN_ON() and BUG_ON() for that, you then get a more > readable oops message (with filename and line information) > Yes, but please only WARN_ON(), BUG_ON should be only used, if here is no way to recover or if continue will cause major data corruption,

Re: [linux-usb-devel] [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface

2005-12-14 Thread Karsten Keil
bersome, even though normal users will probably > never connect more than one of these devices. > > Is there a better alternative? See above, I would drop procfs completly. -- Karsten Keil SuSE Labs ISDN development --- This S