Re: [linux-usb-devel] usb-storage error handling does not work

2002-09-30 Thread Yuri Per
Alan Stern wrote: >>Are there any plans to backport usb-storage changes to kernel 2.4? >> >> >One URL is > http://www.geocrawler.com/lists/3/SourceForge/2571/475/9524582/ > > Here is an updated version of this patch for the case somebody else whants it. Yuri diff -u usb-2.5/driv

Re: [linux-usb-devel] One more usb-storage error handling patch for2.5

2002-09-29 Thread Yuri Per
Alan Stern wrote: >Okay, you've convinced me. But if the scsi layer ignores the return value >from the bus reset function (or more accurately, if the scsi drivers >always return SUCCESS), why isn't that function declared as returning >void? > > Error should be returned from this function only

Re: [linux-usb-devel] One more usb-storage error handling patch for2.5

2002-09-27 Thread Yuri Per
Alan Stern wrote: >It doesn't seem right to return a code indicating success when in fact we >don't know whether the device reset worked or not. > Scsi layer will do it itself. There is no need to reimplement its logic. If you take a look at scsi various controllers implementation of bus reset

Re: [linux-usb-devel] One more usb-storage error handling patch for2.5

2002-09-27 Thread Yuri Per
disconnect() and probe() should be simulated only when usb_reset_device() result was successful, as it is done now. The only change is that scsi layer now allowed to make later one more attempt to perform the request. Yuri Alan Stern wrote: >On Fri, 27 Sep 2002, Yuri Per wr

[linux-usb-devel] One more usb-storage error handling patch for 2.5

2002-09-27 Thread Yuri Per
Failed usb_reset_device() means only that reset is not yet completed. If we will return success from bus_reset(), scsi layer will wait for 5 seconds during which device will probably reconnect. --- a/drivers/usb/storage/scsiglue.cFri Sep 27 18:20:19 2002 +++ b/drivers/usb/storage/scsiglue.c

Re: [linux-usb-devel] usb-storage error handling does not work

2002-09-27 Thread Yuri Per
David Brownell wrote: > Err, this morning Yuri sent a trace on 2.5.38 which showed an INQUIRY > issue. > > Matthew Dharm wrote: > >> 2.5 fixes this -- we changed the SCSI layer INQUIRY logic to act more >> like >> windows. > This 255-byte INQUIRY came from user-mode program ioctl, it's not a k

Re: [linux-usb-devel] usb-storage error handling does not work

2002-09-26 Thread Yuri Per
David Brownell wrote: > Out of curiousity, which kind of support does your motherboard provide? > There's the south bridge (VT8235), or the standalone chip (VT6202). > > It might matter; the VT602 hasn't always worked for me in PCI cards > (due to what seem like PCI problems). The patches I sent

[linux-usb-devel] usb-storage error handling does not work

2002-09-24 Thread Yuri Per
I have problems with USB 2.0 IDE adapter connected to USB 2.0 port on VIA motherboard. I am using 2.4.20-pre7 with patches sent to this list David Brownell (older version hangs after loading ehci-hcd). The device works for some time, but when read command timeouts the following happens: 1) I