Re: [linux-usb-devel] [PATCH as526] UHCI: Detect invalid ports

2005-06-01 Thread Alan Stern
On Tue, 31 May 2005, Glenn Maynard wrote: > On Tue, May 31, 2005 at 04:33:21PM -0400, Alan Stern wrote: > > -* are. However, according to the UHCI spec, Bit 7 of the port > > +* are. However according to the UHCI spec, Bit 7 of the port > > > > - /* Anything less than 2 or greater th

Re: [linux-usb-devel] [PATCH as526] UHCI: Detect invalid ports

2005-05-31 Thread Glenn Maynard
On Tue, May 31, 2005 at 04:33:21PM -0400, Alan Stern wrote: > - * are. However, according to the UHCI spec, Bit 7 of the port > + * are. However according to the UHCI spec, Bit 7 of the port > - /* Anything less than 2 or greater than 7 is weird, > - * so we'll ignore it. > +

[linux-usb-devel] [PATCH as526] UHCI: Detect invalid ports

2005-05-31 Thread Alan Stern
Greg: This patch changes the way uhci-hcd detects valid ports. The specification doesn't mention any way to find out how many ports a controller has, so the driver has to use some heuristics, reading the port status and control register and deciding whether the value makes sense. With this p