On Friday 05 January 2007 10:33 am, Oliver Neukum wrote:
> >
> > Are all of these prototypes really needed?
>
> Yes. Compilation breaks without them.
No. Fixable by a better sequencing of functions.
Maybe one or two should be needed, at most; it's
unusual to need more than that, and atypical t
On Fri, Jan 05, 2007 at 07:33:40PM +0100, Oliver Neukum wrote:
> Am Freitag, 5. Januar 2007 19:10 schrieb Greg KH:
> > On Fri, Jan 05, 2007 at 02:39:21PM +0100, Oliver Neukum wrote:
> > > +
> > > +#define WDM_MINOR_BASE 32
> >
> > Where did you get this minor number from? I think it conflicts wit
Am Freitag, 5. Januar 2007 19:10 schrieb Greg KH:
> On Fri, Jan 05, 2007 at 02:39:21PM +0100, Oliver Neukum wrote:
> > +/* --- prototypes --- */
> > +
> > +static int __init wdm_init(void);
> > +static void __exit wdm_exit(void);
> > +
> > +static int wdm_probe(struct usb_interface *intf, const str
On Fri, Jan 05, 2007 at 02:39:21PM +0100, Oliver Neukum wrote:
> +/* --- prototypes --- */
> +
> +static int __init wdm_init(void);
> +static void __exit wdm_exit(void);
> +
> +static int wdm_probe(struct usb_interface *intf, const struct usb_device_id
> *id);
> +static void wdm_disconnect(struct
Am Donnerstag, 4. Januar 2007 19:38 schrieb Pete Zaitcev:
> On Thu, 4 Jan 2007 17:59:41 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote:
>
> > + case USB_CDC_DMM_TYPE:
> > + maxcom = le16_to_cpu(*((u16 *)(buffer + 5)));
>
> What an atrocious way to program. If you insis
Am Donnerstag, 4. Januar 2007 19:38 schrieb Pete Zaitcev:
> On Thu, 4 Jan 2007 17:59:41 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote:
>
> > + case USB_CDC_DMM_TYPE:
> > + maxcom = le16_to_cpu(*((u16 *)(buffer + 5)));
>
> What an atrocious way to program. If you insis
On Thu, 4 Jan 2007 17:59:41 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> + case USB_CDC_DMM_TYPE:
> + maxcom = le16_to_cpu(*((u16 *)(buffer + 5)));
What an atrocious way to program. If you insist on saving a few instructions
by not using buffer[6]<<8|buffer[5]
Hi,
this is the first take at implementing CDC-WMC Device Management.
Comments please.
Regards
Oliver
--- drivers/usb/class/Kconfig~ 2007-01-01 01:53:20.0 +0100
+++ drivers/usb/class/Kconfig 2007-01-02 13:29:33.0 +0100
@@ -29,3 +29,14 @@
To compile this
