Re: [linux-usb-devel] Re: isp1161 HCD v0.8 hub problem

2001-10-04 Thread Roman Weissgaerber
Li Yi wrote: > > Sorry, Ben, > > The LR register store the instruction which will be executed later, so > it's memcpy cause the Oops. But you already check the hp->units_left, > so it should not be ATL buffer overflow. Have you changed something in the hc_add_trans function (e.g the len calcula

Re: [linux-usb-devel] Re: isp1161 HCD v0.8 hub problem

2001-10-04 Thread Li Yi
Sorry, Ben, The LR register store the instruction which will be executed later, so it's memcpy cause the Oops. But you already check the hp->units_left, so it should not be ATL buffer overflow. If I do not plug any devices into the hub, what I captured from usb bus is all NAK for the Interrupt PI

Re: [linux-usb-devel] Re: isp1161 HCD v0.8 hub problem

2001-10-03 Thread Li Yi
Hi, Ben, The Oops(LR= C00C4F38)is due to lwz r9,40(r31) the last two line in the hc_add_trans function: memcpy (ptd + 8, data, len); hp->tlp += ((len + 8 +3) & ~03); bl 2C290 is the address of memcpy function and  lwz r9,40(r31) is mapping to get hp->tlp value. I do not understand why here got th

Re: [linux-usb-devel] Re: isp1161 HCD v0.8 hub problem

2001-10-03 Thread Benjamin Herrenschmidt
> >I have problems with hub function of isp1161 V0.8, it Oops whenever I plug >in any USB devices like keyboard or mouse through a Belkin F5U100 Hub. But >if I plug the keyboard into the roothub OR if nothing on the hub, >everything is fine. Can you repeat it? Could you get some backtrace symbols

[linux-usb-devel] Re: isp1161 HCD v0.8 hub problem

2001-10-03 Thread Li Yi
Hi, Roman and Benjamin, I have problems with hub function of isp1161 V0.8, it Oops whenever I plug in any USB devices like keyboard or mouse through a Belkin F5U100 Hub. But if I plug the keyboard into the roothub OR if nothing on the hub, everything is fine. Can you repeat it? Li Yi usb.c: reg

Re: [linux-usb-devel] Re: isp1161 HCD v0.8 bulk problem

2001-09-25 Thread Roman Weissgaerber
Benjamin Herrenschmidt wrote: > > >Benjamin Herrenschmidt wrote: > >The one packet is a limitation of v0.8. But you can change it to > >a larger number e.g. 4 or 8 (max 19) by replacing the 1s in > >hc_add_trans()/hc_isp116x.c > > > >- if (len > maxps *1) > >-len = maxps * 1; > >+ if (len >

Re: [linux-usb-devel] Re: isp1161 HCD v0.8 bulk problem

2001-09-25 Thread Benjamin Herrenschmidt
>Benjamin Herrenschmidt wrote: >The one packet is a limitation of v0.8. But you can change it to >a larger number e.g. 4 or 8 (max 19) by replacing the 1s in >hc_add_trans()/hc_isp116x.c > >- if (len > maxps *1) >-len = maxps * 1; >+ if (len > maxps * 8) >+len = maxps * 8; > >A larger nu

Re: [linux-usb-devel] Re: isp1161 HCD v0.8 bulk problem

2001-09-25 Thread Roman Weissgaerber
Benjamin Herrenschmidt wrote: > > Ok, Back to USB hacking. > > I didn't reproduce my USB host disconnect problem after fixing a > problem with the IO timings on the CPU bus to the controller. > > However, I noticed another issue. I tried plugging an USB mass storage > device and experienced ver

[linux-usb-devel] Re: isp1161 HCD v0.8 bulk problem

2001-09-25 Thread Benjamin Herrenschmidt
Ok, Back to USB hacking. I didn't reproduce my USB host disconnect problem after fixing a problem with the IO timings on the CPU bus to the controller. However, I noticed another issue. I tried plugging an USB mass storage device and experienced very very slow transfer speed (about 4k/sec). Usi

[linux-usb-devel] Re: isp1161 HCD v0.8

2001-09-23 Thread Li Yi
Roman Weissgaerber wrote: > Li Yi wrote: > > > > Hi, Roman, > > > > I got two questions regarding your patch on isp1161 driver. > > 1. What will happen if the length is 1 byte in the READ_REGn16 function? > > OK, Seems to be a bug ;) As I used to read PTD and payload separately, I got that con

[linux-usb-devel] Re: isp1161 HCD v0.8

2001-09-21 Thread Roman Weissgaerber
Li Yi wrote: > > Hi, Roman, > > I got two questions regarding your patch on isp1161 driver. > 1. What will happen if the length is 1 byte in the READ_REGn16 function? It's a bug, but it should not hurt us because the block we are reading has to have at least one PTD in front and therefore shou

[linux-usb-devel] Re: isp1161 HCD v0.8

2001-09-21 Thread Roman Weissgaerber
Li Yi wrote: > > Hi, Roman, > > I got two questions regarding your patch on isp1161 driver. > 1. What will happen if the length is 1 byte in the READ_REGn16 function? OK, Seems to be a bug ;) > 2.As not much embedded device will use this kind of ISA card( hcport = > 0x290), they may directly

[linux-usb-devel] Re: isp1161 HCD v0.8

2001-09-21 Thread Li Yi
Hi, Roman, I got two questions regarding your patch on isp1161 driver. 1. What will happen if the length is 1 byte in the READ_REGn16 function? 2.As not much embedded device will use this kind of ISA card( hcport = 0x290), they may directly map those registers into memory and can do 1 step readi