Re: [linux-usb-devel] usbserial, io_edgeport: Remove CmdUrbs

2007-08-01 Thread Pete Zaitcev
On Mon, 30 Jul 2007 22:17:24 -0700, Greg KH [EMAIL PROTECTED] wrote: Sure, if you think it's better that there are not bitfields there, feel free to send me a patch. I suppose we'd need an Edgeport connected to a Mac, to see how the layout changes. I think just about every architecture uses

[linux-usb-devel] usbserial, io_edgeport: Remove CmdUrbs

2007-07-30 Thread Pete Zaitcev
Oliver converted CmdUrbs into an atomic with commit 96c706ed1c46470598d785124b2a7fb233b27dab . It seems like a waste to do for a long forgotten debugging aid. Let's just remove it altogether. Signed-off-by: Pete Zaitcev [EMAIL PROTECTED] diff --git a/drivers/usb/serial/io_edgeport.c

Re: [linux-usb-devel] usbserial, io_edgeport: Remove CmdUrbs

2007-07-30 Thread Greg KH
On Mon, Jul 30, 2007 at 12:58:57PM -0700, Pete Zaitcev wrote: Oliver converted CmdUrbs into an atomic with commit 96c706ed1c46470598d785124b2a7fb233b27dab . It seems like a waste to do for a long forgotten debugging aid. Let's just remove it altogether. Nah, as someone who has had to debug

Re: [linux-usb-devel] usbserial, io_edgeport: Remove CmdUrbs

2007-07-30 Thread Pete Zaitcev
On Mon, 30 Jul 2007 13:07:02 -0700, Greg KH [EMAIL PROTECTED] wrote: On Mon, Jul 30, 2007 at 12:58:57PM -0700, Pete Zaitcev wrote: Oliver converted CmdUrbs into an atomic with commit 96c706ed1c46470598d785124b2a7fb233b27dab . It seems like a waste to do for a long forgotten debugging aid.

Re: [linux-usb-devel] usbserial, io_edgeport: Remove CmdUrbs

2007-07-30 Thread Greg KH
On Mon, Jul 30, 2007 at 02:00:25PM -0700, Pete Zaitcev wrote: On Mon, 30 Jul 2007 13:07:02 -0700, Greg KH [EMAIL PROTECTED] wrote: On Mon, Jul 30, 2007 at 12:58:57PM -0700, Pete Zaitcev wrote: Oliver converted CmdUrbs into an atomic with commit 96c706ed1c46470598d785124b2a7fb233b27dab .