Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-03-11 Thread James Lamanna
Greg KH wrote: I don't think we have sent them to him yet :) They are probably in the latest -mm tree, right? I believe so. I just know Marcel was begging for them. -- James Lamanna Applied Minds, Inc. 1209 Grand Central Ave. Glendale, CA 91201 (818) 332-5214

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-03-11 Thread Greg KH
On Thu, Mar 11, 2004 at 09:40:48AM -0800, James Lamanna wrote: > Noticed my patches still weren't in 2.6.4 > Did Linus reject them? I don't think we have sent them to him yet :) They are probably in the latest -mm tree, right? Patience... greg k-h -

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-03-11 Thread James Lamanna
Noticed my patches still weren't in 2.6.4 Did Linus reject them? -- James Lamanna Applied Minds, Inc. 1209 Grand Central Ave. Glendale, CA 91201 (818) 332-5214 --- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presente

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-02-20 Thread Vojtech Pavlik
On Fri, Feb 20, 2004 at 12:20:00PM +0100, Marcel Holtmann wrote: > Hi Vojtech, > > > > >Yes, but we probably want to fill all the usages[] entries we allocated. > > > > > > > > > > Good point. I realized I made an error anyways. > > > Here's a new one. > > > > Ok, this one looks OK. Applied tog

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-02-20 Thread Marcel Holtmann
Hi Vojtech, > > >Yes, but we probably want to fill all the usages[] entries we allocated. > > > > > > > Good point. I realized I made an error anyways. > > Here's a new one. > > Ok, this one looks OK. Applied together with your multi patch #2. I haven't seen this patch in 2.6.3. Please submit i

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-02-02 Thread Greg KH
On Thu, Jan 22, 2004 at 04:47:57PM -0800, James Lamanna wrote: > Greg- > Use this 2.4.24 patch instead. > Contains a small fix pointed out by Vojtech. Thanks, I've applied this version and will send it to Marcelo after 2.4.25 is out. greg k-h

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread James Lamanna
Greg- Use this 2.4.24 patch instead. Contains a small fix pointed out by Vojtech. -- James Lamanna Applied Minds, Inc. 1209 Grand Central Ave. Glendale, CA 91201 (818) 332-5214 hid-complete-2.4.diff Description: Binary data

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread James Lamanna
If someone sends me the patch again, against the latest 2.4 kernel I will :) Here's the complete patch (both patches included) against 2.4.24. -- James Lamanna Applied Minds, Inc. 1209 Grand Central Ave. Glendale, CA 91201 (818) 332-5214 hid-complete-2.4.diff Description: Binary data

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread Greg KH
On Thu, Jan 22, 2004 at 11:44:32AM +0100, Vojtech Pavlik wrote: > On Thu, Jan 22, 2004 at 11:31:02AM +0100, Marcel Holtmann wrote: > > Hi Vojtech, > > > > > Ok, this one looks OK. Applied together with your multi patch #2. > > > > please also apply this to the 2.4 series and forward it to Marcelo

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread Vojtech Pavlik
On Thu, Jan 22, 2004 at 11:31:02AM +0100, Marcel Holtmann wrote: > Hi Vojtech, > > > Ok, this one looks OK. Applied together with your multi patch #2. > > please also apply this to the 2.4 series and forward it to Marcelo. Greg, can you? Thanks. -- Vojtech Pavlik SuSE Labs, SuSE CR -

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread Marcel Holtmann
Hi Vojtech, > Ok, this one looks OK. Applied together with your multi patch #2. please also apply this to the 2.4 series and forward it to Marcelo. Regards Marcel --- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread James Lamanna
Yes, but we probably want to fill all the usages[] entries we allocated. Good point. I realized I made an error anyways. Here's a new one. -- James Lamanna Applied Minds, Inc. 1209 Grand Central Ave. Glendale, CA 91201 (818) 332-5214 hid-core.diff Description: Binary data

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-22 Thread Vojtech Pavlik
On Wed, Jan 21, 2004 at 03:30:32PM -0800, James Lamanna wrote: > > > > >Yes, but we probably want to fill all the usages[] entries we allocated. > > > > Good point. I realized I made an error anyways. > Here's a new one. Ok, this one looks OK. Applied together with your multi patch #2. -- Vojt

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-21 Thread Vojtech Pavlik
On Wed, Jan 21, 2004 at 01:02:03PM -0800, James Lamanna wrote: > > > > >The patch is trying to fix a real bug (the code never expects the number > >of usages to be less than the number of values in a report), however the > >fix is wrong, because later in the hid_add_field() function it can cause >

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-21 Thread James Lamanna
The patch is trying to fix a real bug (the code never expects the number of usages to be less than the number of values in a report), however the fix is wrong, because later in the hid_add_field() function it can cause the loop whic assigns usages to the field->usage array to access data beyond th

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-21 Thread Vojtech Pavlik
On Thu, Jan 15, 2004 at 04:32:08PM +0100, Marcel Holtmann wrote: > is there any reason why this patch is not yet submitted to Marcelo and > Linus? It is needed for switching a Logitech HID/Bluetooth dongle from > HID into HCI mode. > > I've brought this up before and now that 2.6.0 is released, I

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-20 Thread James Lamanna
Here's version 2 of my patch to support writing multiple bytes to a usage. I've also made the type changes that Greg pointed out (though that may want to be broken out separately)... -- James Lamanna Applied Minds, Inc. 1209 Grand Central Ave. Glendale, CA 91201 (818) 332-5214 hid-multi2.diff Des

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-17 Thread Marcel Holtmann
Hi Vojtech, > #define DEBUG and #define DEBUG_DATA in hid-core.c, then plug in the > device, then dmesg. > > lsusb could possibly provide it, too. I found no way to do it with lsub under 2.6.1, so here is the complete dmesg part from the Logitech Bluetooth Hub. The important report id's are 16 a

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-17 Thread Vojtech Pavlik
On Sat, Jan 17, 2004 at 04:10:28PM +0100, Marcel Holtmann wrote: > Hi Vojtech, > > > And regarding the first patch - I'm still not convinced it's the right > > way to do it - James, can you send me a descriptor dump for that device? > > Maybe we're just misparsing the descriptor ... > > what com

RE: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-17 Thread James Lamanna
oops..missed reply all > And regarding the first patch - I'm still not convinced it's the right > way to do it - James, can you send me a descriptor dump for that device? > Maybe we're just misparsing the descriptor ... I can't get a lsusb -vv output at the moment (device is in use), but here

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-17 Thread Marcel Holtmann
Hi Vojtech, > And regarding the first patch - I'm still not convinced it's the right > way to do it - James, can you send me a descriptor dump for that device? > Maybe we're just misparsing the descriptor ... what command should I use to provide you with the descriptor? Regards Marcel -

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-17 Thread Vojtech Pavlik
On Fri, Jan 16, 2004 at 02:54:50PM -0800, Greg KH wrote: > On Fri, Jan 16, 2004 at 02:47:10PM -0800, James Lamanna wrote: > > > > > > > >When creating a structure for an ioctl, you have to explicitly state how > > >big the different fields are. Use the '__' types. So for your case, > > >you prob

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-16 Thread Greg KH
On Fri, Jan 16, 2004 at 02:47:10PM -0800, James Lamanna wrote: > > > > >When creating a structure for an ioctl, you have to explicitly state how > >big the different fields are. Use the '__' types. So for your case, > >you probably want to use the "__u32" types. > > Ah. > I guess I was followin

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-16 Thread James Lamanna
When creating a structure for an ioctl, you have to explicitly state how big the different fields are. Use the '__' types. So for your case, you probably want to use the "__u32" types. Ah. I guess I was following the example of struct hiddev_usage_ref. Maybe those in hiddev_usage_ref should also

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-16 Thread Greg KH
On Fri, Jan 16, 2004 at 01:18:57PM -0800, James Lamanna wrote: > >Well, you can implement it, and if it's sane, I'll probably accept it. > > > Considering this will be my first substantive patch to the kernel I've > probably done some horrible things, and you may not consider this a "sane" > inte

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-16 Thread James Lamanna
Well, you can implement it, and if it's sane, I'll probably accept it. Considering this will be my first substantive patch to the kernel I've probably done some horrible things, and you may not consider this a "sane" interface. Any criticisms, suggestions, etc... are appreciated. This patch need

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-16 Thread Marcel Holtmann
Hi Vojtech, > > I am no HID expert so I can't judge this, but I haven't had any problems > > with this patch and my devices. Without this patch the hiddev interface > > of the Logitech HID/Bluetooth dongle is not usable. The report we need > > to send has 6 fields of one byte size, but through the

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-15 Thread Vojtech Pavlik
On Thu, Jan 15, 2004 at 01:10:05PM -0800, James Lamanna wrote: > One other comment I had on this topic is would it be worthwhile to create > an interface that lets you write an arbitrary number of bytes to the > device? > I know some devices (Phidgets, the Logitech stuff that Marcel mentioned, >

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-15 Thread James Lamanna
One other comment I had on this topic is would it be worthwhile to create an interface that lets you write an arbitrary number of bytes to the device? I know some devices (Phidgets, the Logitech stuff that Marcel mentioned, etc..) use multi-byte packets. Have to iterate through all the individua

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-15 Thread James Lamanna
On Thu, 15 Jan 2004 16:59:09 +0100, Marcel Holtmann <[EMAIL PROTECTED]> wrote: Hi Vojtech, > is there any reason why this patch is not yet submitted to Marcelo and > Linus? It is needed for switching a Logitech HID/Bluetooth dongle from > HID into HCI mode. The part "I'm sure it breaks other dev

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-15 Thread Marcel Holtmann
Hi Vojtech, > > is there any reason why this patch is not yet submitted to Marcelo and > > Linus? It is needed for switching a Logitech HID/Bluetooth dongle from > > HID into HCI mode. > > The part "I'm sure it breaks other devices" perhaps? I am no HID expert so I can't judge this, but I haven'

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-15 Thread Vojtech Pavlik
On Thu, Jan 15, 2004 at 04:32:08PM +0100, Marcel Holtmann wrote: > Hi Folks, > > is there any reason why this patch is not yet submitted to Marcelo and > Linus? It is needed for switching a Logitech HID/Bluetooth dongle from > HID into HCI mode. The part "I'm sure it breaks other devices" perhaps

Re: [linux-usb-devel] Fixing HID support for non-explicitly specified usages

2004-01-15 Thread Marcel Holtmann
Hi Folks, is there any reason why this patch is not yet submitted to Marcelo and Linus? It is needed for switching a Logitech HID/Bluetooth dongle from HID into HCI mode. Regards Marcel > I've brought this up before and now that 2.6.0 is released, I'll bring it > up again. > Can we get the HID