Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-25 Thread Rene van Paassen
On 24/03/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > On Sat, 24 Mar 2007 17:23:55 +0100, René van Paassen <[EMAIL PROTECTED]> > wrote: > > > I will change the del_timer to del_timer_sync, to remove the race where > > the timer´s activity is running while the timer is being removed. > > > > Does

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-24 Thread Pete Zaitcev
On Sat, 24 Mar 2007 17:23:55 +0100, René van Paassen <[EMAIL PROTECTED]> wrote: > I will change the del_timer to del_timer_sync, to remove the race where > the timer´s activity is running while the timer is being removed. > > Does that sound reasonable? Yes, it's a good idea, however this is not

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-24 Thread René van Paassen
On Fri, 2007-03-09 at 21:44 -0500, Dmitry Torokhov wrote: > On Friday 09 March 2007 19:29, Pete Zaitcev wrote: > > > +/* Activity checking thread. If a sufficient period of inactivity is > > > detected, > > > + the tablet's proximity is reset. */ > > > +static void activity_check(unsigned long

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-15 Thread Pete Zaitcev
On Fri, 09 Mar 2007 20:27:30 -0600, Bryan Headley <[EMAIL PROTECTED]> wrote: > >> + /* We now will look for the evdev device which is mapped to > >> + * the tablet. The partial name is kept in the link list of > >> + * input_handles associated with this input device. > >> + * What identifie

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-09 Thread Dmitry Torokhov
On Friday 09 March 2007 19:29, Pete Zaitcev wrote: > > +/* Activity checking thread. If a sufficient period of inactivity is > > detected, > > +   the tablet's proximity is reset. */ > > +static void activity_check(unsigned long data) > > +{ > > + struct aiptek *aiptek = (struct aiptek *) dat

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-09 Thread Pete Zaitcev
On Fri, 09 Mar 2007 21:58:23 +0100, René van Paassen <[EMAIL PROTECTED]> wrote: [I'm cc-ing this to Dmitry because of input_sync() in a timer context below.] > Well, Петр, Linux is a pretty international effort after all. But for > now, for the sake of getting this driver where it belongs, I rob

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-09 Thread Dmitry Torokhov
Hi Rene, On 3/7/07, Rene van Paassen <[EMAIL PROTECTED]> wrote: > > /*** > + * Constants used in the sysfs files. This affords us a small size > + * optimization, plus maintains a single point of failure (misspellings.) > + */ >

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-07 Thread Pete Zaitcev
On Thu, 8 Mar 2007 01:17:02 +, Alan Cox <[EMAIL PROTECTED]> wrote: > > > + * Extra bits2004 René van Paassen <[EMAIL PROTECTED]> > > > +#define DRIVER_AUTHOR "Bryan W. Headley/Chris Atenasio/Cédric > > > Brun/René van Paassen" > > > > Please understand, patches are commonly sent na

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-07 Thread Alan Cox
> > + * Extra bits2004 René van Paassen <[EMAIL PROTECTED]> > > +#define DRIVER_AUTHOR "Bryan W. Headley/Chris Atenasio/Cédric > > Brun/René van Paassen" > > Please understand, patches are commonly sent naked in the mail, even > in this enlightened day of git and MIME. So, even if you s

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-07 Thread Pete Zaitcev
On Thu, 8 Mar 2007 00:02:48 +0100, "Rene van Paassen" <[EMAIL PROTECTED]> wrote: I don't mind this: > Signed-off-by: René van Paassen <[EMAIL PROTECTED]> This non-ASCII character is in the changelog, so it won't cause any spurious patch rejections. But this is bad: > + * Extra bits2004