Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-13 Thread Grant Likely
On 6/12/07, Peter Korsgaard [EMAIL PROTECTED] wrote: Grant == Grant Likely [EMAIL PROTECTED] writes: Hi, Grant Rather than c67x00-hub.c being compiled seperately, the Grant original code had c67x00-hub.c *included* by c67x00-hcd.c. Grant This is a very bad idea. Simplest solution is to

Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-13 Thread Alan Stern
On Wed, 13 Jun 2007, Grant Likely wrote: On 6/13/07, Alan Stern [EMAIL PROTECTED] wrote: On Wed, 13 Jun 2007, Grant Likely wrote: On 6/12/07, Peter Korsgaard [EMAIL PROTECTED] wrote: Grant == Grant Likely [EMAIL PROTECTED] writes: Hi, Grant Rather than c67x00-hub.c

Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-13 Thread Grant Likely
On 6/13/07, Alan Stern [EMAIL PROTECTED] wrote: On Wed, 13 Jun 2007, Grant Likely wrote: On 6/13/07, Alan Stern [EMAIL PROTECTED] wrote: On Wed, 13 Jun 2007, Grant Likely wrote: On 6/12/07, Peter Korsgaard [EMAIL PROTECTED] wrote: Grant == Grant Likely [EMAIL PROTECTED] writes:

Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-13 Thread Alan Stern
On Wed, 13 Jun 2007, Grant Likely wrote: I think we're crossing wires here. In this particular case, I think the hub support code is sufficiently small that it doesn't need to be split off into a separate file. (It's only 180 lines) I'm not suggesting that the hub support stuff be moved to

Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-12 Thread Peter Korsgaard
Grant == Grant Likely [EMAIL PROTECTED] writes: Hi, Grant Rather than c67x00-hub.c being compiled seperately, the Grant original code had c67x00-hub.c *included* by c67x00-hcd.c. Grant This is a very bad idea. Simplest solution is to merge the Grant two files into one and be done with it.