Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-28 Thread David Brownell
On Saturday 26 November 2005 5:37 pm, Ville Syrjälä wrote: > The usbtest module source code is at the end of this message. Actually it's in drivers/usb/misc/usbtest.c ... you should pick a different name for your debug driver! --- This SF.net

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-27 Thread Ville Syrjälä
On Sun, Nov 27, 2005 at 01:18:00PM -0500, Dmitry Torokhov wrote: > On Sunday 27 November 2005 11:30, Ville Syrjälä wrote: > > Actually input_device_register() can't actually fail so checking the > > return value isn't really needed. > > > > It can fail now and I have a patch that will cause it f

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-27 Thread Dmitry Torokhov
On Sunday 27 November 2005 11:30, Ville Syrjälä wrote: > Actually input_device_register() can't actually fail so checking the > return value isn't really needed. > It can fail now and I have a patch that will cause it fail if it fails to register device/attributes, so please check the return val

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-27 Thread Dmitry Torokhov
On Sunday 27 November 2005 12:23, Alan Stern wrote: > Today 12:23:33 >   > On Sun, 27 Nov 2005, Ville Syrjälä wrote: > > > > I suspect you are triggering a bug in the input layer.  Adding a few > > > debugging lines to the test driver, particularly in usbtest_delete, might > > > help pinpoint

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-27 Thread Alan Stern
On Sun, 27 Nov 2005, Ville Syrjälä wrote: > > I suspect you are triggering a bug in the input layer. Adding a few > > debugging lines to the test driver, particularly in usbtest_delete, might > > help pinpoint the bug. > > It explodes when I call input_free_device() which just a wrapper for >

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-27 Thread Ville Syrjälä
On Sun, Nov 27, 2005 at 09:59:43AM -0500, Alan Stern wrote: > On Sun, 27 Nov 2005, Ville Syrjälä wrote: > > > When I tried to reproduce the oops the box would just hang and when I > > eventually got oopses out of it they didn't seem very consistent. > > > > The usbtest module source code is at t

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-27 Thread Alan Stern
On Sun, 27 Nov 2005, Ville Syrjälä wrote: > When I tried to reproduce the oops the box would just hang and when I > eventually got oopses out of it they didn't seem very consistent. > > The usbtest module source code is at the end of this message. > > So I just compiled 2.6.15-rc2 with some deb

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-26 Thread Ville Syrjälä
On Sat, Nov 26, 2005 at 04:01:06PM -0500, Alan Stern wrote: > On Sat, 26 Nov 2005, Ville Syrjälä wrote: > > Doing rmmod/insmod or unplug/plug a few times causes kernel oopses. A > > simple usb test module which does nothing but register/unregister an > > input device in the probe()/disconnect() c

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-26 Thread Vojtech Pavlik
On Sat, Nov 26, 2005 at 04:01:06PM -0500, Alan Stern wrote: > On Sat, 26 Nov 2005, Ville Syrjälä wrote: > > > Here's a new driver for ATI/Philips USB RF remote controls. The hardware > > is made by Philips but the ATI Remote Wonder II is the only device I > > know to use this hardware. > > > >

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-26 Thread Alan Stern
On Sat, 26 Nov 2005, Ville Syrjälä wrote: > Here's a new driver for ATI/Philips USB RF remote controls. The hardware > is made by Philips but the ATI Remote Wonder II is the only device I > know to use this hardware. > > I'm hoping some USB/input gurus will point out any problems with the > co

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-26 Thread Ville Syrjälä
On Sat, Nov 26, 2005 at 06:05:00PM +0100, Oliver Neukum wrote: > Am Samstag, 26. November 2005 16:20 schrieb Ville Syrjälä: > > +   ar2->buf[i] = usb_buffer_alloc(udev, 4, GFP_KERNEL, > > &ar2->buf_dma[i]); > > +   if (!ar2->buf[i]) > > +   return -ENOME

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-26 Thread Oliver Neukum
Am Samstag, 26. November 2005 18:05 schrieb Oliver Neukum: > Am Samstag, 26. November 2005 16:20 schrieb Ville Syrjälä: > > +   ar2->buf[i] = usb_buffer_alloc(udev, 4, GFP_KERNEL, > > &ar2->buf_dma[i]); > > +   if (!ar2->buf[i]) > > +   return -ENOMEM; >

Re: [linux-usb-devel] [RFC][PATCH] Driver for ATI/Philips USB RF remotes

2005-11-26 Thread Oliver Neukum
Am Samstag, 26. November 2005 16:20 schrieb Ville Syrjälä: > +   ar2->buf[i] = usb_buffer_alloc(udev, 4, GFP_KERNEL, > &ar2->buf_dma[i]); > +   if (!ar2->buf[i]) > +   return -ENOMEM; > + > +   ar2->urb[i] = usb_alloc_urb(0, GFP_KERNEL); > +