Re: [linux-usb-devel] PATCH: Don't allocate transfer buffersonthestackin hub.c

2003-06-06 Thread Pete Zaitcev
> From: "Christopher Hoover" <[EMAIL PROTECTED]> > Date: Fri, 6 Jun 2003 10:58:50 -0700 > > So all I/O buffers _must_ be allocated using kmalloc() > > Use GFP_DMA flag on the kmalloc() call, too, whenever possible. > This will help avoid bounce buffering on some systems. Wrong!!! Where did yo

RE: [linux-usb-devel] PATCH: Don't allocate transfer buffersonthestackin hub.c

2003-06-06 Thread Christopher Hoover
> So all I/O buffers _must_ be allocated using kmalloc() Use GFP_DMA flag on the kmalloc() call, too, whenever possible. /* Flag - indicates that the buffer will be suitable for DMA. Ignored on some platforms, used as appropriate on others */ #define GFP_DMA __GFP_DMA This will

Re: [linux-usb-devel] PATCH: Don't allocate transfer buffersonthestackin hub.c

2003-06-06 Thread Oliver Neukum
> > > I don't follow you. What's inefficient about this? It looks like the > > > decision of whether or not to call dma_cache_wback_inv() has nothing to > > > do with what other data is stored in the same memory block with the > > > output buffer. And there's nothing that indicates > > > dma_ca

Re: [linux-usb-devel] PATCH: Don't allocate transfer buffersonthestackin hub.c

2003-06-06 Thread Alan Stern
On Thu, 5 Jun 2003, Oliver Neukum wrote: > > > extern inline dma_addr_t pci_map_single(struct pci_dev *hwdev, void *ptr, > > > size_t size, int direction) > > > { > > > if (direction == PCI_DMA_NONE) > > > BUG(); > > > > > > #ifndef CONFIG_COHERENT_IO