Re: [linux-usb-devel] [PATCH]generic usb serial driver

2007-03-31 Thread Oliver Neukum
Am Samstag, 31. März 2007 04:59 schrieb Alan Stern: > isn't clean -- but several drivers do it this way.  I'm not even certain > that adding smp_mb() to the completion routine will really fix it; memory > barriers have to be used in pairs, and so there would also need to be a > barrier between t

Re: [linux-usb-devel] [PATCH]generic usb serial driver

2007-03-31 Thread Alan Stern
On Sat, 31 Mar 2007, Oliver Neukum wrote: > Am Samstag, 31. März 2007 04:59 schrieb Alan Stern: > > isn't clean -- but several drivers do it this way.  I'm not even certain > > that adding smp_mb() to the completion routine will really fix it; memory > > barriers have to be used in pairs, and so

Re: [linux-usb-devel] [PATCH]generic usb serial driver

2007-03-31 Thread David Brownell
> That raises the question how the issue is to be solved. To me the obvious > solution to a lack of memory ordering is to specify memory ordering > explicitely. However, I seem to be in the minority. > > The other way around it would be to use wait_for_completion(). > Oppinions? Memory barriers a

Re: [linux-usb-devel] [PATCH]generic usb serial driver

2007-03-31 Thread David Brownell
On Friday 30 March 2007 7:59 pm, Alan Stern wrote: > > > Nope.  If an smp_mb() is needed, the reason is because of other > > > driver-internal bugs. > > > > > > Remember that the driver isn't allowed to so much as *LOOK* at any > > > field of an URB until the completion callback.  That generalize

Re: [linux-usb-devel] Help with testusb

2007-03-31 Thread David Brownell
On Friday 30 March 2007 11:10 am, Felipe Balbi wrote: > Hello all, > > I'm trying to run testusb on a tusb6010 device to test it's host mode > functionalities. I compiled the latest linux-omap gittree and enabled > the OTG mode. > > I'm setting it to host mode by echoing "host" to > /sys/devices/

Re: [linux-usb-devel] Earthmate LT-20 USB GPS Functionality Broken By 2.6.19 'cypress_m8' Patch

2007-03-31 Thread Neil Whelchel
On Tue, 27 Mar 2007, Marr wrote: > On Tuesday 27 March 2007 3:05am, Mike Isely wrote: >> On Mon, 26 Mar 2007, Marr wrote: >>> Greetings, >>> >>> *** Please CC: me on replies -- I'm not subscribed. >>> >>> A patch by Mike Isely that went into what became kernel 2.6.19 has >>> modified 'cypress_m8.c

Re: [linux-usb-devel] usb hid: reset NumLock

2007-03-31 Thread Jiri Kosina
On Fri, 30 Mar 2007, Pete Zaitcev wrote: > @@ -1328,9 +1340,18 @@ static int hid_probe(struct usb_interface *intf, const > struct usb_device_id *id) > return -ENODEV; > } > > - if ((hid->claimed & HID_CLAIMED_INPUT)) > + if ((hid->claimed & HID_CLAIMED_INPUT)) { >

Re: [linux-usb-devel] 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO

2007-03-31 Thread Randy Dunlap
On Tue, 20 Feb 2007 01:06:54 +0100 Adrian Bunk wrote: > On Sun, Jan 14, 2007 at 06:36:10AM -0800, David Brownell wrote: > > On Sunday 14 January 2007 1:10 am, Adrian Bunk wrote: > > > <-- snip --> > > > > Waiting for Tony to submit bugfixes to his driver... > > Still unfixed as of 2.6.20-mm1.

Re: [linux-usb-devel] 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO

2007-03-31 Thread David Brownell
On Thursday 29 March 2007 3:06 pm, Randy Dunlap wrote: > On Tue, 20 Feb 2007 01:06:54 +0100 Adrian Bunk wrote: > > > On Sun, Jan 14, 2007 at 06:36:10AM -0800, David Brownell wrote: > > > On Sunday 14 January 2007 1:10 am, Adrian Bunk wrote: > > > > <-- snip --> > > > > > > Waiting for Tony to s

Re: [linux-usb-devel] 2.6.20-rc4-mm1: different values for OHCI_QUIRK_ZFMICRO

2007-03-31 Thread Tony Olech
Sorry guys, I have spent the last three weeks trying to track down a problem one of our customers has been having, the only thing I have been able to determine is that using mutex'es the kernel crashes and using semaphores instead works. Now I realize that the target is to use mutexes, but I have b

[linux-usb-devel] [2/4] 2.6.21-rc5: known regressions (v2)

2007-03-31 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involv

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-03-31 Thread Jiri Kosina
On Fri, 30 Mar 2007, Dmitry Torokhov wrote: > There should be one device and your driver should simply do: > static void my_driver_hid_event(struct hid_device *hid, struct hid_field > *field, > struct hid_usage *usage, __s32 value) > { > if (special_processing_

Re: [linux-usb-devel] usb hid: reset NumLock

2007-03-31 Thread Pete Zaitcev
On Sat, 31 Mar 2007 21:35:19 +0200 (CEST), Jiri Kosina <[EMAIL PROTECTED]> wrote: > On Fri, 30 Mar 2007, Pete Zaitcev wrote: > I think I see an issue here. Imagine that you boot a system initially with > one keyboard connected (usb, ps/2, doesn't matter), and after some time > you connect secon

Re: [linux-usb-devel] [patch 2.6.21-rc5] usb-serial, ti_usb: fix usb configuration changing

2007-03-31 Thread Al Borchers
Greg, Oleg -- Quoting Greg KH <[EMAIL PROTECTED]>: > So please, just be patient. Wait for Al to forward it to me, with his > signed-off-by: and then I'll add it to my trees. Sorry I have been slow. I will test this patch and get it to you this weekend. Oleg made the changes I asked for and it

Re: [linux-usb-devel] [PATCH] USB: Allow transfer_buffer with transfer_dma, take #5

2007-03-31 Thread David Brownell
OK, here's a version that's trimmed down even more ... no reformatting, it only sets the transfer_buffer, uses #ifdef not #ifndef. Comments slimmed. Greg, this would be nice to have in 2.6.21 (just to make the N800 patchset simpler) but I can't say it's essential. - Dave = CUT HE

Re: [linux-usb-devel] [patch 2.6.21-rc5] usb-serial, ti_usb: fix usb configuration changing

2007-03-31 Thread Oleg Verych
On Sat, Mar 31, 2007 at 06:09:57PM -0500, Al Borchers wrote: > Greg, Oleg -- > > Quoting Greg KH <[EMAIL PROTECTED]>: > > So please, just be patient. Wait for Al to forward it to me, with his > > signed-off-by: and then I'll add it to my trees. > > Sorry I have been slow. I will test this patch