Use struct list_head rather than a singly linked list in udsl_vcc_data. Reject
attempts to open multiple vccs with the same vpi/vci pair. Some cleanups too.
speedtch.c | 204 +
1 files changed, 98 insertions(+), 106 deletions(-)
The list of open vccs is modified by open/close, and traversed by the
receive tasklet. This is the last race I know of in this driver.
speedtch.c | 20 ++--
1 files changed, 18 insertions(+), 2 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
Matthew Dharm [EMAIL PROTECTED] wrote:
Mike --
As far as I can tell, this patch was never accepted. Any idea when this
will be resolved?
usb-storage is still waiting to implement proper device unplug...
I reposted the patch with refreshed offsets for the newer kernel
version.
-andmike
This is (finally) the previous patch without the new ioctls and bigbangs.
Changes are (in brief - see the patch for proper credits etc):
Added CrystalFontz LCD device ID's
Added MatrixOrb ID's
Added throttle/unthrotle
Fixed FTDI_SIO bug
Added write_urb buffer pool for much better write
The potential issue with using unaligned buffers is related
to DMA-incoherent caches. If you have data laid out in memory
like this:
// cache line starts here
u8 cpu_writes_here_1 [size1];
u8 used_for_dma_read [dma_buflen];
u8 cpu_writes_here_2 [size2];
// cache
This code in cdc-ether.c, CDCEther_start_xmit()
2.5.x current but 2.4 seem wrong too:
// If we are told to transmit an ethernet frame that fits EXACTLY
// into an integer number of USB packets, we force it to send one
// more byte so the device will get a runt USB packet signalling the
// end
On 25 Mar 2003, Benjamin Herrenschmidt wrote:
This code in cdc-ether.c, CDCEther_start_xmit()
2.5.x current but 2.4 seem wrong too:
// If we are told to transmit an ethernet frame that fits EXACTLY
// into an integer number of USB packets, we force it to send one
// more byte so the
Alan Stern wrote:
The byte in question should be set to
0 before it is transmitted. Second, if this is a matter of sending a runt
USB packet, why not make it a 0-length packet instead of a 1-byte packet?
Set to zero or any other constant value, yes. Not a very
high bandwidth
Duncan Sands wrote:
The potential issue with using unaligned buffers is related
to DMA-incoherent caches. If you have data laid out in memory
like this:
// cache line starts here
u8 cpu_writes_here_1 [size1];
u8 used_for_dma_read [dma_buflen];
u8 cpu_writes_here_2 [size2];
//
srinivas yarra wrote:
Hi,
I am working on linux kernel 2.4.18. OHCI HCD. I have
You mean, usb-ohci. ohci-hcd is a different driver,
which is available on 2.4.21pre5 (separate patch) ut
not on 2.4.18 ...
the following doubt:
When the device enumeration fails (usb.c: USB device
not accepting new
If I remove the uhci_hcd or ehci_hcd module, then I
systematically get the following:
(EIP) run_timer_softirq+0xe3/0x400
timer_interrupt+0x1a3/0x3f0
do_softirq+0xa1/0xb0
do_IRQ+0x23f/0x380
common_interrupt+0x18/0x20
code: 89 50 04 89 02 C7 41
kernel/timer.c:302: spin_lock
On Mon, Mar 24, 2003 at 03:12:58PM +0100, Spang Oliver wrote:
Patch against 2.5.65
Applied, thanks.
greg k-h
---
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register
On Sun, Mar 23, 2003 at 06:40:44PM -0800, Randy.Dunlap wrote:
Hi,
Please apply to 2.5.65.
Reduces stack usage in emi26_load_firmware().
Builds. I don't have h/w to test it.
Applied, thanks.
greg k-h
---
This SF.net email is sponsored
On Sat, Mar 22, 2003 at 07:30:46PM -0800, Matthew Dharm wrote:
This patch (developed with assistance from Jan Harkes
[EMAIL PROTECTED]) makes the LUN field of a bulk-only transport come
from a known-good source, rather than the likely-good command-byte. It
also updates the ISD200 driver to
On Sun, Mar 23, 2003 at 12:03:20PM -0800, Matthew Dharm wrote:
This patch changes some debugging output to be a bit more clear, and
removes some un-needed code -- it's no longer possible for us to have
active URBs in the disconnect path.
Greg, please apply.
Applied, thanks.
greg k-h
On Sat, Mar 22, 2003 at 07:31:49PM -0800, Matthew Dharm wrote:
This patch initializes the URB status before it's used. While not
technically required, it's good programming practice (and a similar bug
just bit us on 2.4 with UHCI).
Greg, please apply.
Applied, thanks.
greg k-h
On Sat, Mar 22, 2003 at 06:01:35PM +1100, Brad Hards wrote:
As discussed at LCA 2003, I'm transfering maintainership of the CDC Ethernet
driver to you.
I've attached three patches to see it on its way:
Thanks, I've applied all of these patches.
cdc-181002.patch is a really old 2.4.
Hello,
I wonder, is ALi M5237 High Speed capable.
Thank you
Michael
---
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
ChangeSet 1.889.379.2, 2003/03/21 12:53:59-08:00, [EMAIL PROTECTED]
[PATCH] usb hub diagnostics
More uniformity-in-diagnostics work, and don't emit
a error message in one known non-error case.
drivers/usb/core/hub.c | 54 ++---
1 files changed, 29
ChangeSet 1.889.379.3, 2003/03/21 12:54:21-08:00, [EMAIL PROTECTED]
[PATCH] usbtest catch -ENOMEM
Smatch seems to be returning mostly false positives,
but not this time.
drivers/usb/misc/usbtest.c |2 ++
1 files changed, 2 insertions(+)
diff -Nru a/drivers/usb/misc/usbtest.c
ChangeSet 1.985.10.4, 2003/03/25 11:34:04-08:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: per vcc data cleanups
Use struct list_head rather than a singly linked list in udsl_vcc_data. Reject
attempts to open multiple vccs with the same vpi/vci pair. Some cleanups too.
ChangeSet 1.985.10.2, 2003/03/25 11:33:14-08:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: code reorganization
Remove dead code from sarlib, reorganize live sarlib code (trivial transformations).
drivers/usb/misc/speedtch.c | 312 ++--
1 files changed,
ChangeSet 1.985.10.8, 2003/03/25 11:54:38-08:00, [EMAIL PROTECTED]
[PATCH] USB: usb_skeleton.c trivial fix
Remove redundant __FILE__.
drivers/usb/usb-skeleton.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nru a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
---
ChangeSet 1.889.379.5, 2003/03/21 17:01:26-08:00, [EMAIL PROTECTED]
[PATCH] add missing usb_put_urb() after error
This is a multi-part message in MIME format.
drivers/usb/core/hcd.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/core/hcd.c
ChangeSet 1.985.10.14, 2003/03/25 13:30:08-08:00, [EMAIL PROTECTED]
[PATCH] USB: storage: add logging to reset
- add logging to reset
drivers/usb/storage/scsiglue.c | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff -Nru a/drivers/usb/storage/scsiglue.c
ChangeSet 1.985.10.12, 2003/03/25 13:23:01-08:00, [EMAIL PROTECTED]
[PATCH] USB: Another memory allocation in block IO error handling path
- memory allocation in block io error code path with GFP_KERNEL
drivers/usb/core/hub.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff
ChangeSet 1.985.10.3, 2003/03/25 11:33:39-08:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: trivial cleanups
drivers/usb/misc/speedtch.c | 110
1 files changed, 51 insertions(+), 59 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c
ChangeSet 1.985.10.7, 2003/03/25 11:54:15-08:00, [EMAIL PROTECTED]
[PATCH] USB: usb-skeleton, usbtest use real device ids
I'll be switching gadget zero to use real product IDs
(donated by NetChip), and these are the two drivers that
will need to recognize them.
drivers/usb/misc/usbtest.c |
ChangeSet 1.985.10.19, 2003/03/25 14:11:56-08:00, [EMAIL PROTECTED]
[PATCH] USB: CDC Ethernet zero packet fix
drivers/usb/net/cdc-ether.c | 19 ---
1 files changed, 4 insertions(+), 15 deletions(-)
diff -Nru a/drivers/usb/net/cdc-ether.c b/drivers/usb/net/cdc-ether.c
---
ChangeSet 1.985.10.15, 2003/03/25 13:45:34-08:00, [EMAIL PROTECTED]
[PATCH] usb-storage: LUN and isd200
This patch (developed with assistance from Jan Harkes
[EMAIL PROTECTED]) makes the LUN field of a bulk-only transport come
from a known-good source, rather than the likely-good command-byte.
ChangeSet 1.985.10.21, 2003/03/25 15:16:26-08:00, [EMAIL PROTECTED]
USB: remove unneeded #include linux/version.h
drivers/usb/class/audio.c|1 -
drivers/usb/core/buffer.c|1 -
drivers/usb/core/usb-debug.c |1 -
drivers/usb/host/ohci-hcd.c |1 -
ChangeSet 1.889.379.1, 2003/03/21 12:53:36-08:00, [EMAIL PROTECTED]
[PATCH] usb_connect() kerneldoc
previous text was wrong/confusing, all it does
is pick a number. this routine should be merged
with usb_new_device() someday, but doing that
would mean changing the hcds (as well as hub.c)
so
ChangeSet 1.985.10.5, 2003/03/25 11:34:31-08:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: eliminate ATM open/close races
The list of open vccs is modified by open/close, and traversed by the
receive tasklet. This is the last race I know of in this driver.
drivers/usb/misc/speedtch.c | 20
ChangeSet 1.985.10.13, 2003/03/25 13:29:44-08:00, [EMAIL PROTECTED]
[PATCH] USB: storage device reset cleanup
In the absence of far-reaching changes to the API, my suggestion is to
have the emulated SCSI bus reset code in usb-storage do nothing but log an
error message and return an error
ChangeSet 1.985.10.20, 2003/03/25 14:13:46-08:00, [EMAIL PROTECTED]
[PATCH] USB: CDC Ethernet maintainer transfer
CREDITS |4
MAINTAINERS |5 +++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff -Nru a/CREDITS b/CREDITS
--- a/CREDITS Tue Mar 25 16:44:31 2003
+++
ChangeSet 1.985.10.6, 2003/03/25 11:53:49-08:00, [EMAIL PROTECTED]
[PATCH] USB: missing include
at least Alpha needs mm.h for page_address.
drivers/usb/core/message.c |1 +
1 files changed, 1 insertion(+)
diff -Nru a/drivers/usb/core/message.c b/drivers/usb/core/message.c
---
Hi,
Here are some small USB changes. Basically all little cleanups and
bugfixes, nothing major.
Please pull from: bk://linuxusb.bkbits.net/linus-2.5
thanks,
greg k-h
CREDITS |4
MAINTAINERS |5
drivers/usb/Makefile|1
Oops, ignore this part, it's part of a separate patch :)
+/* Module parameters */
+MODULE_PARM(hid_poll_interval, i);
+MODULE_PARM_DESC(hid_poll_interval, polling interval, millseconds (default=10));
+
+#ifndef MODULE
+static int __init hid_poll_interval_setup(char *str)
+{
+
Oops, ignore this part, it's part of a separate patch :)
+/* Module parameters */
+MODULE_PARM(hid_poll_interval, i);
+MODULE_PARM_DESC(hid_poll_interval, polling interval, millseconds (default=10));
+
+#ifndef MODULE
+static int __init hid_poll_interval_setup(char *str)
+{
+
On Tue, 2003-03-25 at 21:29, Eric Wong wrote:
This patch adds support for controlling 400/800 cpi resolution and
SMS/Smart Scroll/Cruise control for certain Logitech mice. Disabling
SMS lets you use the extra buttons on MX500/700 as regular buttons if
an application supports evdev since
Greg KH [EMAIL PROTECTED] wrote:
On Tue, Mar 25, 2003 at 07:03:30PM -0800, Eric Wong wrote:
Oops, ignore this part, it's part of a separate patch :)
Can you send me an updated patch?
here ya go
diff -ruN a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
---
On Tue, Mar 25, 2003 at 10:00:07AM +0100, Duncan Sands wrote:
Use struct list_head rather than a singly linked list in udsl_vcc_data. Reject
attempts to open multiple vccs with the same vpi/vci pair. Some cleanups too.
Applied, thanks.
greg k-h
On Tue, Mar 25, 2003 at 10:31:50AM +0100, Duncan Sands wrote:
The list of open vccs is modified by open/close, and traversed by the
receive tasklet. This is the last race I know of in this driver.
Applied, thanks.
greg k-h
---
This SF.net
On Mon, Mar 24, 2003 at 06:02:32PM +0100, Duncan Sands wrote:
speedtch.c | 110 -
1 files changed, 51 insertions(+), 59 deletions(-)
Applied, thanks.
greg k-h
---
This SF.net email
On Mon, Mar 24, 2003 at 12:17:22PM +0100, Duncan Sands wrote:
Remove dead code from sarlib, reorganize live sarlib code (trivial transformations).
Applied, thanks.
greg k-h
---
This SF.net email is sponsored by:
The Definitive IT and
On Sat, Mar 22, 2003 at 02:38:22PM -0800, Matthew Dharm wrote:
Greg, please apply this to the 2.4 tree.
Applied, thanks.
greg k-h
---
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Wed, 26 Mar 2003 01:41, Benjamin Herrenschmidt wrote:
This code in cdc-ether.c, CDCEther_start_xmit()
2.5.x current but 2.4 seem wrong too:
// If we are told to transmit an ethernet frame that fits EXACTLY
// into an integer number of USB
Yes, although I sent a patch (that I'd been trying to get people to provide
test feedback on for months - I never saw the problem occur on my test setup)
to the l-u-devel mailing list that corrects this (a few days ago).
Are you actually seeing problems? Can you test the patches?
I've
On Sat, Mar 22, 2003 at 10:38:19PM +0100, Oliver Neukum wrote:
Am Samstag, 22. März 2003 21:53 schrieb Matthew Dharm:
I'm pretty much with Alan on this one. My personal style thinks that you
should log a message on entry to the function, log a different message if
there is more than 1
On Sat, Mar 22, 2003 at 05:18:40PM +0100, Oliver Neukum wrote:
In the absence of far-reaching changes to the API, my suggestion is to
have the emulated SCSI bus reset code in usb-storage do nothing but log an
error message and return an error code. For the time being, considering
how
50 matches
Mail list logo
