the dead lock by delaying the removal as
in the normal case.
--
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: dr
This patch merges list_del/INIT_LIST_HEAD calls into list_del_init ones.
--
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.tx
This patch fixes some incorrect returns using copy_to_user.
It is for 2.4.25 + the previous patch.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apa
check for 2.6.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: drivers/usb
one device
> where report_count exceeds maxusage.
>
> The following patch corrects the check for 2.6.
And here is the corresponding patch for 2.4.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.
Hi:
I've received the following report which indicates that the Sony Clie needs
the US_FL_FIX_INQUIRY flag set.
http://bugs.debian.org/243650
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
H
On Mon, Dec 08, 2003 at 04:37:26PM -0500, Alan Stern wrote:
> On Tue, 9 Dec 2003, Herbert Xu wrote:
>
> > On Mon, Dec 08, 2003 at 01:04:39PM -0500, Johannes Erdfelt wrote:
> >
> > > Regardless, this patch makes things worse. We need to wait for the next
> > >
one device
> where report_count exceeds maxusage.
>
> The following patch corrects the check for 2.6.
I've updated the patch for 2.6.6.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://go
x 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
This SF.Net email is sponsored by: SourceFo
free the DMA buffer that's in use as well?
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
check for 2.6.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: drivers/usb
one device
> where report_count exceeds maxusage.
>
> The following patch corrects the check for 2.6.
Here is the corresponding patch for 2.4.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.
This patch fixes some incorrect returns using copy_to_user.
It is for 2.4.26 + the previous patch.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apa
OCGUCODE &&
> uref->report_type == HID_REPORT_TYPE_INPUT)
> return -EINVAL;
Yes you're absolutely right. Thanks for the fix.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: h
nd are waiting for the
> hardware to let them go (like we have now) together with a record of the
> frame number at the time they were removed. There will also be another
OK, how about this patch?
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <
?
Let's fix QHs/TDs too. Plus I forgot to set the age when the current
pending list is removed...
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au
On Sat, Aug 09, 2003 at 10:25:39PM +1000, herbert wrote:
>
> This patch makes the HISAX ST5481 driver build again with 2.6.0-test3
> where the usb_host_config structure has changed.
And here is the patch.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu
ut! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
This SF.net email is sponsored by: SF.net Giveb
an URB and
then wait for it to be given back.
This patch fixes this by making the unlink schedule a tasklet to do the
cleanup rather than triggering an interrupt.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]&
changes this so we clean up those entries before the hardware
> is done, which is very bad.
Sorry about that. Can you please comment on the following patch which
no longer frees the QHs and TDs outside of the interrupt routine.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debi
NU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
This SF.net email is spons
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
This SF.net email is sponsored
;t reset during a
suspend/resume that message is not shown.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
kaweth_start_xmit to clobber the memory of the
existing TX URB.
The fix is to kill the TX URB in kaweth_close().
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gond
ld be active.
Similarly, once kaweth_close() calls netif_stop_queue() no further
calls to kaweth_start_xmit() will be made. Therefore it is not
needed for it to check kaweth->removed.
The following patch removes these unnecessary code.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Che
On Tue, Nov 08, 2005 at 07:24:29AM +0100, Oliver Neukum wrote:
> Am Dienstag, 8. November 2005 01:56 schrieb Herbert Xu:
> >
> > The kaweth driver does not delete the TX URB in kaweth_close().
> > As a result the TX URB may still be active in the USB subsystem.
> >
dev_close() if the interface is up.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/usb
at the
URB will not be resubmitted. Since you can't rely on urb->status to
always be ECONNRESET/ESHUTDOWN in a shutdown case, it should be removed.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gond
ks from the resubmit
function if usb_kill_urb() fails to kill it using unlink.
I'll send you a patch for that tomorrow.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbe
[KAWETH] Suppress errors when URB is unlinked
When an URB is unlinked the completion function will be called with
a non-zero status value. Since we can recognise those specific values
we shouldn't print an error message when we detect them.
Signed-off-by: Herbert Xu <[EMAIL PRO
ge when we detect them.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff
one device
> where report_count exceeds maxusage.
I've remove the changes unrelated to the boundary check. Please let me
know if you have any problems with this patch.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http:
Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
This SF.Net email is sponsored by the new
usb_bulk_msg return an error?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
rue.
Can you please give a sample execution path that triggers this bug?
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
//www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
This SF.Net email is sponsored by The 2004 JavaOne(SM
gt; +*/
> + mb();
>start_hc(uhci);
>
>init_stall_timer(hcd);
Any reason why a wmb() is not sufficient?
BTW it could just be my mailer but can you please check whether
you've got tabs in there instead of spaces?
Cheers,
--
Visit Openswan at http://www.openswan
e/asm-ppc/system.h says that mb() should be used, while
include/asm-ppc64/system.h says that wmb() should be and is used by
many drivers.
So which is it? Or perhaps we need something else?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]&g
On Sun, Jun 06, 2004 at 11:40:19AM +0200, Vojtech Pavlik wrote:
> On Fri, Jun 04, 2004 at 08:07:25PM +1000, Herbert Xu wrote:
> > On Thu, May 06, 2004 at 08:15:15PM +1000, herbert wrote:
> > >
> > > The current code is applying the maxusage limit to GUSAGE/SUSAGE. Thi
On Mon, Oct 11, 2004 at 02:21:47PM -0300, Marcelo Tosatti wrote:
> On Tue, Oct 05, 2004 at 10:49:14PM +1000, Herbert Xu wrote:
> >
> > There is a long-standing devfs_unregister oops in hid/hiddev. It's
> > caused by hid calling hiddev_exit before unregistering itse
to work,
> but I haven't tested hiddev (UPS or something ?).
Yes that's exactly the situation I'm in (APC UPS via USB) and it does fix
the OOPS for me when hid is unloaded with the UPS connected.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI
orthogonal to the problem your patch addresses.
It is unrelated to my issue but yet that fix is needed in 2.4 as well.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gond
iddev devices have been
disconnected.
This patch fixes that.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
Marcelo, the same fix is needed in 2.4 as well.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.a
44 matches
Mail list logo
