Re: [linux-usb-devel] Using Cypress EZ-Host on ML403/5

2007-05-22 Thread Grant Likely
a problem with. You need to provide a lot more detail about what you've done and what does not work. Also, please cc the mailing list when asking for help. It's the polite thing to do and there are more people than me who can help you. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab

[linux-usb-devel] [PATCH 0/6] Cleanups to c67x00 USB host controller driver

2007-06-12 Thread Grant Likely
Peter, Here's the series of changes that I've made to the c67x00 driver. Most of them are pretty straight forward. Most invasive is the rename of 'struct c67x00_drv' to 'struct c67x00_device' which is big and scary, but doesn't really do much. One thing that I haven't tackled is the layout of

[linux-usb-devel] [PATCH 1/6] [C67x00] Add test of active flag when checking TDs

2007-06-12 Thread Grant Likely
The active flag in a TD needs to be checked to determine whether or not the TD was processed in the frame. Without this check, the HCD assumes the TD completed successfully, when in reality it was not processed at all. Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/usb/c67x00/c67x00

[linux-usb-devel] [PATCH 2/6] [C67x00] Fix calculation of frame bandwidth

2007-06-12 Thread Grant Likely
Use the correct formulas and values for calculating the bittime within a frame. Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/usb/c67x00/c67x00-hcd.h | 10 ++-- drivers/usb/c67x00/c67x00-sched.c | 42 +--- 2 files changed, 45 insertions(+), 7

[linux-usb-devel] [PATCH 3/6] [C67x00] Remove unnecessary references to pt_regs

2007-06-12 Thread Grant Likely
Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/usb/c67x00/c67x00-sched.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/c67x00/c67x00-sched.c b/drivers/usb/c67x00/c67x00-sched.c index 0d08af7..3a870cf 100644 --- a/drivers/usb/c67x00/c67x00

[linux-usb-devel] [PATCH 4/6] [C67x00] Added error handling paths to lowlevel interface code

2007-06-12 Thread Grant Likely
() to die with lots of noise. The driver needs to be refactored to add in the failure paths so the driver can fail gracefully Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/usb/c67x00/c67x00-drv.c|8 - drivers/usb/c67x00/c67x00-ll-hpi.c | 57

[linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-12 Thread Grant Likely
Rather than c67x00-hub.c being compiled seperately, the original code had c67x00-hub.c *included* by c67x00-hcd.c. This is a very bad idea. Simplest solution is to merge the two files into one and be done with it. Signed-off-by: Grant Likely [EMAIL PROTECTED] --- drivers/usb/c67x00/c67x00-hcd.c

Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-13 Thread Grant Likely
On 6/12/07, Peter Korsgaard [EMAIL PROTECTED] wrote: Grant == Grant Likely [EMAIL PROTECTED] writes: Hi, Grant Rather than c67x00-hub.c being compiled seperately, the Grant original code had c67x00-hub.c *included* by c67x00-hcd.c. Grant This is a very bad idea. Simplest solution

Re: [linux-usb-devel] [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c

2007-06-13 Thread Grant Likely
On 6/13/07, Alan Stern [EMAIL PROTECTED] wrote: On Wed, 13 Jun 2007, Grant Likely wrote: On 6/13/07, Alan Stern [EMAIL PROTECTED] wrote: On Wed, 13 Jun 2007, Grant Likely wrote: On 6/12/07, Peter Korsgaard [EMAIL PROTECTED] wrote: Grant == Grant Likely [EMAIL PROTECTED] writes

Re: [linux-usb-devel] USB-related instability on 2.6.23-rc1

2007-07-31 Thread Grant Likely
On 7/31/07, Greg KH [EMAIL PROTECTED] wrote: On Tue, Jul 31, 2007 at 03:06:07PM -0600, Grant Likely wrote: I've attached my kernel config file and a dmesg output Can you enable CONFIG_USB_DEBUG and send the linux-usb-devel list and us, the output when you have these problems? Yes, I'll

Re: [linux-usb-devel] USB-related instability on 2.6.23-rc1

2007-07-31 Thread Grant Likely
On 7/31/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Greg KH wrote: On Tue, Jul 31, 2007 at 03:06:07PM -0600, Grant Likely wrote: I've attached my kernel config file and a dmesg output Can you enable CONFIG_USB_DEBUG and send the linux-usb-devel list and us, the output when you have