Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-28 Thread Craig W. Nadler
This version of the patch is against kernel 2.6.22-rc5 and has been checked with scripts/checkpatch.pl and sparse. Craig From: Craig W. Nadler [EMAIL PROTECTED] EHCI_HUB_CTRL: Fixes a bug with setting the value of the port number. The ehci_hub_control() function in driver/usb/host/ehci-hub.c

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-13 Thread Craig W. Nadler
From: Craig W. Nadler [EMAIL PROTECTED] EHCI_HUB_CTRL: Fixes a bug with setting the value of the port number. The ehci_hub_control() function in driver/usb/host/ehci-hub.c takes a u16 parameter called wIndex. The least significant byte of this parameter holds the port number relevant to the

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-12 Thread Alan Stern
[I hate it when people include a long quoted message in their replies for no good reason... Yes, lots of people do it out of sheer laziness and it's unfair for me to complain only to you. But still... ] On Mon, 11 Jun 2007, Craig W. Nadler wrote: After thinking about it, it seems very scary

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-11 Thread Alan Stern
On Sun, 10 Jun 2007, Craig W. Nadler wrote: --- a/drivers/usb/host/ehci-hub.c 2007-06-07 17:27:31.0 -0400 +++ b/drivers/usb/host/ehci-hub.c 2007-06-10 13:45:14.0 -0400 @@ -444,7 +444,8 @@ static int ehci_hub_control ( ) { struct ehci_hcd *ehci = hcd_to_ehci (hcd); int

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-11 Thread Craig W. Nadler
Alan Stern wrote: On Sun, 10 Jun 2007, Craig W. Nadler wrote: --- a/drivers/usb/host/ehci-hub.c 2007-06-07 17:27:31.0 -0400 +++ b/drivers/usb/host/ehci-hub.c 2007-06-10 13:45:14.0 -0400 @@ -444,7 +444,8 @@ static int ehci_hub_control ( ) { struct ehci_hcd *ehci = hcd_to_ehci

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-11 Thread Craig W. Nadler
Craig W. Nadler wrote: Alan Stern wrote: On Sun, 10 Jun 2007, Craig W. Nadler wrote: --- a/drivers/usb/host/ehci-hub.c 2007-06-07 17:27:31.0 -0400 +++ b/drivers/usb/host/ehci-hub.c 2007-06-10 13:45:14.0 -0400 @@ -444,7 +444,8 @@ static int ehci_hub_control ( ) { struct

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-10 Thread Alan Stern
On Sun, 10 Jun 2007, Craig W. Nadler wrote: From: Craig W. Nadler [EMAIL PROTECTED] EHCI_HUB_CTRL: Fixes a bug with a pointer to a port_status register. The ehci_hub_control() function in driver/usb/host/ehci-hub.c takes a u16 parameter called wIndex. The least significant byte of this

Re: [linux-usb-devel] [PATCH] USB: ehci_hub_control() (Kernel 2.6.21.4)

2007-06-10 Thread Craig W. Nadler
Alan Stern wrote: On Sun, 10 Jun 2007, Craig W. Nadler wrote: From: Craig W. Nadler [EMAIL PROTECTED] EHCI_HUB_CTRL: Fixes a bug with a pointer to a port_status register. The ehci_hub_control() function in driver/usb/host/ehci-hub.c takes a u16 parameter called wIndex. The least