Re: Q: Does mass storage gadget use DMA ?

On Mon, Feb 12, 2018 at 2:39 PM, Oliver Neukum wrote: > Am Sonntag, den 11.02.2018, 22:17 +0200 schrieb Ran Shalit: >> On Tue, Feb 6, 2018 at 8:55 AM, Felipe Balbi >> wrote: >> > >> > >> > Hi, >> > >> > Ran Shalit writes: >> >

Re: Q: Does mass storage gadget use DMA ?

On Thu, Feb 15, 2018 at 10:56 AM, Ran Shalit wrote: > On Mon, Feb 12, 2018 at 2:39 PM, Oliver Neukum wrote: >> Am Sonntag, den 11.02.2018, 22:17 +0200 schrieb Ran Shalit: >>> On Tue, Feb 6, 2018 at 8:55 AM, Felipe Balbi >>>

Re: [PATCH 6/6] usb: dwc2: Force mode optimizations

Hi, Grigor Tovmasyan writes: > Hi Balbi, > > I rebased this commit to your testing/next (see below). Are you sure you did? checking file drivers/usb/dwc2/core.c Hunk #1 FAILED at 367. Hunk #2 FAILED at 391. Hunk #3 FAILED at 403. Hunk #4 FAILED at 425. Hunk #5

Re: High CPU load produced by USB (DW2)

On 2/15/2018 5:20 PM, Mirza Krak wrote: > On 14 February 2018 at 13:07, Minas Harutyunyan > wrote: >> On 2/14/2018 12:57 PM, Mirza Krak wrote: >>> On 8 February 2018 at 14:53, Minas Harutyunyan >>> wrote: > > < snip > > >> >> I

[PATCH v2 1/1] usb: cdc_acm: prevent race at write to acm while system resumes

From: Dominik Bozek ACM driver may accept data to transmit while system is not fully resumed. In this case ACM driver buffers data and prepare URBs on usb anchor list. There is a little chance that two tasks put a char and initiate acm_tty_flush_chars(). In such a case,

Re: [PATCH] usb: musb: fix enumeration after resume

On Wed, 7 Feb 2018 14:37:00 -0600 Bin Liu wrote: > On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > > Hi, > > > > On Tue, 6 Feb 2018 12:46:05 -0600 > > Bin Liu wrote: > > > > > Hi, > > > > > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas

Re: Q: usb_control_msg() parameters

On Fri, Feb 16, 2018 at 8:54 AM, Greg KH wrote: > On Fri, Feb 16, 2018 at 01:00:06AM +0200, Ran Shalit wrote: >> Hello, >> >> I am trying to understand article on reverse engineering usb driver, >> published in >> http://www.linuxjournal.com/node/7353/print (2004) > >

Re: Q: usb_control_msg() parameters

On Fri, Feb 16, 2018 at 01:00:06AM +0200, Ran Shalit wrote: > Hello, > > I am trying to understand article on reverse engineering usb driver, > published in > http://www.linuxjournal.com/node/7353/print (2004) That article was written a _long_ time ago :( > I have difficulties understanding the

Re: Q: usb_control_msg() parameters

On Fri, Feb 16, 2018 at 09:02:11AM +0200, Ran Shalit wrote: > On Fri, Feb 16, 2018 at 8:54 AM, Greg KH wrote: > > On Fri, Feb 16, 2018 at 01:00:06AM +0200, Ran Shalit wrote: > >> Hello, > >> > >> I am trying to understand article on reverse engineering usb driver, > >>

[RFC PATCH v2 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

From: Maciej Purski Currently MHL chip must be turned on permanently to detect MHL cable. It duplicates micro-USB controller's (MUIC) functionality and consumes unnecessary power. Lets use extcon attached to MUIC to enable MHL chip only if it detects MHL cable.

[RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

These bindings allow to describe most known standard USB connectors and it should be possible to extend it if necessary. USB connectors, beside USB can be used to route other protocols, for example UART, Audio, MHL. In such case every device passing data through the connector should have

[RFC PATCH v2 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi

[RFC PATCH v2 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda --- .../connector/samsung,usb-connector-11pin.txt | 51 ++ 1 file changed, 51 insertions(+) create mode 100644

[RFC PATCH v2 5/6] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v2: changed label to follow local

Re: USB gadget : generic functionfs function has no os_desc while rndis function has, why?

On 02/11/2018 08:52 AM, Jun Sun wrote: Thanks for your reply, Krzysztof. I now understand all the fields. However, I just realize I can't really extend your example to cover my need, because your example uses RNDIS where kernel already support OS descriptor. In my case I'm preparing my own

Re: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

On Thu, 2018-02-15 at 13:16 +0200, Felipe Balbi wrote: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > Reviewed-by: Andy Shevchenko Though one comment below. > Signed-off-by: Felipe Balbi

Re: [PATCH 01/14] usb: dwc2: Rename hibernation to partial_power_down

Grigor Tovmasyan writes: > From: Vardan Mikayelyan > > No-op change, only rename. > > This code was misnamed originally. It was only responsible for partial > power down and not for hibernation. > > Rename core_params->hibernation to

Re: [PATCH 0/6] usb: dwc2: minor fixes

Felipe Balbi writes: > Hi, > > Grigor Tovmasyan writes: >> This series contains patches which are already have been sent in >> "usb: dwc2: fixes, enhancements and new features" series. >> >> That patch series was too large, and based on community

Re: [PATCH] usb: dwc2: Fix kernel doc's warnings.

Hi, Grigor Tovmasyan writes: > Added descriptions for all not described parameters. > > Signed-off-by: Grigor Tovmasyan Fails to apply: checking file drivers/usb/dwc2/core.c Hunk #2 succeeded at 390 with fuzz 2 (offset -11 lines). Hunk #3

Re: [PATCH 5/6] usb: dwc2: eliminate irq parameter from dwc2_gadget_init

Grigor Tovmasyan writes: > From: Vardan Mikayelyan > > The irq is available in hsotg already, so there's no need to pass it as > separate function parameter. > > Signed-off-by: Vardan Mikayelyan > Signed-off-by: Grigor

Re: [PATCH 0/6] usb: dwc2: minor fixes

Hi, Grigor Tovmasyan writes: > This series contains patches which are already have been sent in > "usb: dwc2: fixes, enhancements and new features" series. > > That patch series was too large, and based on community feedbacks decided to > split that series into

[RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git

Re: [RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 >

Re: [PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

Andy Shevchenko writes: > On Thu, 2018-02-15 at 13:16 +0200, Felipe Balbi wrote: >> ...instead of open coding file operations followed by custom ->open() >> callbacks per each attribute. >> > > Reviewed-by: Andy Shevchenko >

[balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: 65223a0ed97c8c4b18c4899653745058f87d67e3 commit: 4caf1fe8fb537388810a4c8fecfa5324b26f80ea [45/57] usb: dwc2: Make dwc2_force_mode() static config: i386-randconfig-x072-201806 (attached as .config)

Re: [PATCH v1 13/14] USB: typec: Re-use DEFINE_SHOW_ATTRIBUTE() macro

On Wed, Feb 14, 2018 at 06:08:29PM +0200, Andy Shevchenko wrote: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Cc: Heikki Krogerus > Cc: Guenter Roeck > Signed-off-by: Andy

[RFC PATCH v2 0/6] dt-bindings: add bindings for USB physical connector

Hi, Thanks for reviews of previous iterations. This patchset introduces USB physical connector bindings, together with working example. v2: I have addressed comments by Rob and Laurent, thanks v3: Separate binding for Samsung 11-pin connector, added full-blown USB-C example. Changes are

Re: [PATCH/RFC 3/6] usb: gadget: Add NO_DMA dummies for DMA mapping API

Hi, Geert Uytterhoeven writes: > Add dummies for usb_gadget_{,un}map_request{,_by_dev}(), to allow > compile-testing if NO_DMA=y. > > This prevents the following from showing up later: > > ERROR: "usb_gadget_unmap_request_by_dev" >

Re: [PATCH/RFC 6/6] Treewide: Remove depends on HAS_DMA in case of platform dependency

Geert Uytterhoeven writes: > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST". > In most cases this other symbol is an architecture or platform specific > symbol, or PCI. > >

[PATCH] usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

...instead of open coding file operations followed by custom ->open() callbacks per each attribute. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/debugfs.c | 79 -- 1 file changed, 34 insertions(+), 45 deletions(-)

Re: [PATCH v2 02/49] usb: dwc2: Force mode optimizations

Grigor Tovmasyan writes: > From: Vardan Mikayelyan > > If the dr_mode is USB_DR_MODE_OTG, forcing the mode is needed during > driver probe to get the host and device specific HW parameters. Then we > clear the force mode bits so that the core

Re: High CPU load produced by USB (DW2)

On 14 February 2018 at 13:07, Minas Harutyunyan wrote: > On 2/14/2018 12:57 PM, Mirza Krak wrote: >> On 8 February 2018 at 14:53, Minas Harutyunyan >> wrote: < snip > > > I reviewed your interrupt count log again. About 140,000

Re: [balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

Hi, kbuild test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git > testing/next > head: 65223a0ed97c8c4b18c4899653745058f87d67e3 > commit: 4caf1fe8fb537388810a4c8fecfa5324b26f80ea [45/57] usb: dwc2: Make > dwc2_force_mode() static

Re: [PATCH 01/14] usb: dwc2: Rename hibernation to partial_power_down

Hi Balbi On 2/15/2018 17:23, Felipe Balbi wrote: > Grigor Tovmasyan writes: > >> From: Vardan Mikayelyan >> >> No-op change, only rename. >> >> This code was misnamed originally. It was only responsible for partial >> power down and not for

Re: [PATCH v1 03/14] USB: musb: Re-use DEFINE_SHOW_ATTRIBUTE() macro

On Wed, Feb 14, 2018 at 06:08:19PM +0200, Andy Shevchenko wrote: > ...instead of open coding file operations followed by custom ->open() > callbacks per each attribute. > > Cc: Bin Liu > Signed-off-by: Andy Shevchenko Acked-by: Bin Liu

Re: [RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On 15.02.2018 13:14, Krzysztof Kozlowski wrote: > On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda >> --- >>

Re: [balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

Hi Balbi On 2/15/2018 17:34, Felipe Balbi wrote: > > Hi, > > kbuild test robot writes: >> tree: >>

RE: [[INTERNAL] PATCH 0/2] Fix STM32F7 DWC2 OTG HS binding

Forget this one! Sorry for the inconvenience. > -Original Message- > From: Amelie DELAUNAY > Sent: jeudi 15 février 2018 16:47 > To: John Youn ; Felipe Balbi ; > Greg Kroah-Hartman ; Rob Herring > ;

[[INTERNAL] PATCH 0/2] Fix STM32F7 DWC2 OTG HS binding

This patchset fixes STM32F7 DWC2 OTG HS binding. It actually re-applies the v2 former patches adding STM32F7 DWC2 OTG HS support. Amelie Delaunay (2): dt-bindings: usb: fix the STM32F7 DWC2 OTG HS core binding usb: dwc2: fix STM32F7 USB OTG HS compatible

Re: [BUG] SD card reader disappears after suspend

On 14.02.2018 15:06, Samuel Sadok wrote: Thanks for the patches. However no luck yet, the usb device still doesn't reinitialize. Logs: https://gist.github.com/90ccb390c5777b9e2d5dc595f44d50da Can I somehow check if it is at all possible to bring back this particular device after hub power

Re: [PATCH 6/6] usb: dwc2: Force mode optimizations

Hi Balbi, I rebased this commit to your testing/next (see below). Please skip 05/06 patch in this series, it was already applied via "[PATCH v2 00/49] usb: dwc2: fixes, enhancements and new features " patch series. Please ignore "[PATCH v2 00/49] usb: dwc2: fixes, enhancements and new

[PATCH 0/2] Fix STM32F7 DWC2 OTG HS binding

This patchset fixes STM32F7 DWC2 OTG HS binding. It actually re-applies the v2 former patches adding STM32F7 DWC2 OTG HS support. Amelie Delaunay (2): dt-bindings: usb: fix the STM32F7 DWC2 OTG HS core binding usb: dwc2: fix STM32F7 USB OTG HS compatible

[PATCH 1/2] dt-bindings: usb: fix the STM32F7 DWC2 OTG HS core binding

This patch fixes binding documentation for DWC2 controller in HS mode found on STMicroelectronics STM32F7 SoC. The v2 former patch [1] had been acked by Rob Herring, but v1 was merged. [1] https://patchwork.kernel.org/patch/9925575/ Fixes: 000777dadc7e ("dt-bindings: usb: Document the STM32F7xx

[PATCH 2/2] usb: dwc2: fix STM32F7 USB OTG HS compatible

This patch fixes compatible for STM32F7 USB OTG HS and consistently rename dw2_set_params function. The v2 former patch [1] had been acked by Paul Young, but v1 was merged. [1] https://patchwork.kernel.org/patch/9925573/ Fixes: d8fae8b93682 ("usb: dwc2: add support for STM32F7xx USB OTG HS")

Re: [PATCH 5/6] usb: dwc2: eliminate irq parameter from dwc2_gadget_init

On 2/15/2018 17:08, Felipe Balbi wrote: > Grigor Tovmasyan writes: > >> From: Vardan Mikayelyan >> >> The irq is available in hsotg already, so there's no need to pass it as >> separate function parameter. >> >> Signed-off-by: Vardan

Wakeup from USB on i.MX6S

Hello everyone, I am working on an i.MX6S (Solo, not SoloLite or SoloX) attached to a module attached to a carrier board. It's running Yocto 2.2.3. I am trying to wake it up from one of the available standby states (freeze/mem/standby) by plugging in an USB Device. I have already studied

Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

On Sun, Feb 04, 2018 at 04:50:58PM +, JackStocker wrote: > Following on from this patch: https://lkml.org/lkml/2017/11/3/516, > Corsair K70 RGB keyboards also require the DELAY_INIT quirk to > start correctly at boot. > > Device ids found here: > usb 3-3: New USB device found, idVendor=1b1c,

Re: [PATCH v1 1/1] usb: cdc_acm: prevent race at write to acm while system resumes

On Mon, Feb 12, 2018 at 12:15:03PM -0800, sathyanarayan.kuppusw...@linux.intel.com wrote: > From: Dominik Bozek > > ACM driver may accept data to transmit while system is not fully > resumed. In this case ACM driver buffers data and prepare URBs > on usb anchor list. >

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

On 15 February 2018 at 19:29, Marc Zyngier wrote: > [+ Ard, who helped me chasing the initial issue] > > On 15/02/18 06:43, Bockholdt Arne wrote: >> Hi all, >> >> on our Intel Atom C2578 server with a SuperMicro A1SAi board and a >> Renesas uPD720201 USB 3.0 host controller

Re: [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT

On Wed, Jan 31, 2018 at 10:24:45PM +, James Hogan wrote: > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is > conditional upon USB && USB_SUPPORT, so that it can be freely selected > by platform Kconfig symbols in

Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

On 15/02/18 17:35, Greg Kroah-Hartman wrote: On Sun, Feb 04, 2018 at 04:50:58PM +, JackStocker wrote: Following on from this patch: https://lkml.org/lkml/2017/11/3/516, Corsair K70 RGB keyboards also require the DELAY_INIT quirk to start correctly at boot. Device ids found here: usb 3-3:

[BUG] musb: broken isochronous transfer at TI AM335x platform

Hi all, Almost two years ago I faced an issue related to PWC-driven V4L2 webcam attached to BeagleBone Black SBC. [1][2] The issue still persists in 4.16-rc1. However, some research has been carried out since then. I would like to summarize my findings below. I also would like to receive feedback

[PATCH v4] Add delay-init quirk for Corsair K70 RGB keyboards

Following on from this patch: https://lkml.org/lkml/2017/11/3/516, Corsair K70 RGB keyboards also require the DELAY_INIT quirk to start correctly at boot. Device ids found here: usb 3-3: New USB device found, idVendor=1b1c, idProduct=1b13 usb 3-3: New USB device strings: Mfr=1, Product=2,

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

[+ Ard, who helped me chasing the initial issue] On 15/02/18 06:43, Bockholdt Arne wrote: > Hi all, > > on our Intel Atom C2578 server with a SuperMicro A1SAi board and a > Renesas uPD720201 USB 3.0 host controller the controller has stopped > working since kernel 4.13.x. Before that kernel the

Re: [PATCH v3] Add delay-init quirk for Corsair K70 RGB keyboards

On Thu, Feb 15, 2018 at 05:59:34PM +, Jack wrote: > On 15/02/18 17:35, Greg Kroah-Hartman wrote: > > On Sun, Feb 04, 2018 at 04:50:58PM +, JackStocker wrote: > > > Following on from this patch: https://lkml.org/lkml/2017/11/3/516, > > > Corsair K70 RGB keyboards also require the DELAY_INIT

Re: [Regression] xhci: some hard drives cannot be seen using a JMicron JMS56x enclosure

Hi Adding Oliver On 15.02.2018 03:05, Cyril Roelandt wrote: Hi, I use two hard drives in an enclosure connected to my PC using UAS. The enclosure is a JMicron JMS56x (152d:0562); the drives are a Fujitsu MHZ2160BH G2 (2"5, 160GB) and a Western Digital EFRX-68N32N0 (3"5, 4TB). Using a USB2

Re: [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT

On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 31, 2018 at 10:24:45PM +, James Hogan wrote: > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is > > conditional upon USB &&

Re: [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT

On Thu, Feb 15, 2018 at 10:41:42PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 15, 2018 at 09:38:48PM +, James Hogan wrote: > > On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Jan 31, 2018 at 10:24:45PM +, James Hogan wrote: > > > > Move the Kconfig

Re: [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT

On Thu, Feb 15, 2018 at 09:38:48PM +, James Hogan wrote: > On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 31, 2018 at 10:24:45PM +, James Hogan wrote: > > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and > > > USB_UHCI_BIG_ENDIAN_DESC out of

Re: [PATCH v1 1/1] usb: cdc_acm: prevent race at write to acm while system resumes

Hi Greg, On 02/15/2018 09:37 AM, Greg KH wrote: Why hasn't the author of this patch signed off on it? This patch has been initially submitted with Gerrit-ID and some custom tags. During the scrubbing process of this unrelated details, I think the automated script accidentally deleted the

Q: usb_control_msg() parameters

Hello, I am trying to understand article on reverse engineering usb driver, published in http://www.linuxjournal.com/node/7353/print (2004) I have difficulties understanding the input to the function usb_control_msg() especially the 0x12, 0xc8 numbers. I could not find them in the article, then